Commit Graph

79394 Commits

Author SHA1 Message Date
Dario Lombardo 55bcf95d52 gitlab-ci: replace old notation with extends. 2020-12-22 17:42:15 +00:00
Dario Lombardo 33ab986589 gitlab-ci: fix build:ubuntu-dist. 2020-12-22 17:24:27 +00:00
Dario Lombardo 29b331bf0c make-version: use 0 as number of commits if they can't be obtained.
When running on gitlab-ci, the checkout of the project doesn't give
a complete repo. Then git describe fails at giving the number of commits.
In this case just use 0 instead of NULL.
2020-12-22 17:06:28 +00:00
Moshe Kaplan 5227f385b8 Replace g_malloc calls with g_new
Replace calls of `g_malloc(sizeof(foo_t))` with
`g_new(foo_t, 1)`, to improve readability.
2020-12-22 15:48:48 +00:00
Moshe Kaplan e16166a74c Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing
occurrences of `g_malloc()` and `wmem_alloc()` with
`g_new()` and `wmem_new()`, to improve the
readability of Wireshark's code, and
occurrences of
`g_malloc(sizeof(struct myobj) * foo)`
with
`g_new(struct myobj, foo)`
to prevent integer overflows

Also fixes all existing occurrences across
the codebase.
2020-12-22 14:56:38 +00:00
Gerald Combs 7b27b444cb GitLab CI: Set CCACHE_DIR globally. 2020-12-22 02:55:43 +00:00
Gerald Combs fc124f45bb GitLab CI: Use shallow clones for merge requests.
We currently disable shallow clones in our general pipeline settings
because jobs that create packages need a usable `git describe`. None of
our merge request jobs create packages, so clone shallowly in order to
speed things up.
2020-12-21 17:19:04 -08:00
Gerald Combs b468b1fb01 GitLab CI: Don't set our ccache size in ubuntu-dist.
We no longer build anything, so there's nothing to cache.
2020-12-21 23:17:13 +00:00
Dario Lombardo a2bc5b5357 idn: prevent heap buffer overflow.
Check index before using it.
Fix: #17102.
2020-12-21 22:57:26 +00:00
Gerald Combs c971d7f10c GitLab CI: Copy the dist (tarball) build.
Copy it to an S3 bucket if the appropriate environment variables are set
and add it as an artifact.
2020-12-21 14:25:11 -08:00
Martin Mathieson e2593e2022 Call add item and tfs checking scripts in ubuntu pipeline
N.B. Neither of these scripts return an error code if issues are found.
2020-12-21 11:46:29 +00:00
Martin Mathieson b7d93ff0ef Fix some more item lengths. 2020-12-20 22:35:08 +00:00
Guy Harris ca99a821b4 Fix the way we get high-resolution time.
If we're not on Windows, use clock_gettime(CLOCK_REALTIME) *if* we have
it; otherwise, fall back on gettimeofday().

(Note: neither Linux, nor macOS, nor Windows necessarily "have"
particular APIs; particular *versions* of Linux distributions
(kernel+libc) have them, particular *versions* of macOS have them, and
particular *versions* of Windows+MSVC have them.

And Linux, Windows and macOS aren't the only platforms on which we run.)

Fixes #17101.
2020-12-20 13:31:57 -08:00
Gerald Combs 299d2f1ae5 [Automatic update for 2020-12-20]
Update manuf, services enterprise numbers, translations, and other items.
2020-12-20 20:12:13 +00:00
Gerald Combs 2c303c725f CMake: macOS version updates.
Set MIN_MACOS_VERSION to 10.14 if we're building with Qt 6.0 or later.
Print both our deployment target and our base SDK at configure time.
2020-12-20 19:50:25 +00:00
Martin Mathieson eef4ba7ed7 More spelling fixes. 2020-12-20 16:31:18 +00:00
Nardi Ivan bfb889910a GQUIC: add decoding of QLVE tag
Latest GQUIC versions encapsulate their first flight in Q043 packets.
2020-12-20 12:27:58 +00:00
Nardi Ivan 60401ca54e QUIC: improve heurist to avoid false positives
Improve visualization of "Version Negotiation" fields
2020-12-20 10:20:31 +00:00
Vadim Yanitskiy 7332c91a7e A-bis/RSL: fix handling of MS/BS Power IEs in dissct_rsl_ipaccess_msg()
These IEs can optionally be included in ip.access specific MEASurement
PREPROCessing DeFauLT message.  Let's dissect them properly.
2020-12-20 07:21:21 +00:00
Guy Harris f3dc269df6 macos-setup: work around a botch in GLib "make distclean".
[skip ci]
2020-12-19 14:21:15 -08:00
Jaap Keuter 7052994a19 IPv6: SRH setup correct DA for pseudo header
When a Segment Routing Header is present in the IPv6 packet provisions
have to be made to setup the right destination address for the pseudo
header used in checksum calculations. When segments are left in the header
the first address in the list has to replace the destination address.

Closes #17097
2020-12-19 08:20:03 +00:00
Guy Harris 8b0d19c634 macos-setup: explain why we're running autoreconf on minizip.
[skip ci]
2020-12-18 23:53:47 -08:00
Guy Harris 0cdbdcc5a4 macos-setup: fix the name of the -done file for Minizip.
It's minizip-$installed_minizip_version-done, not
zlib-$installed_minizip_version-done; the tarball is
zlib-$installed_minizip_version.tar.gz, because it's a contributed file
in the zlib package, but we don't use zlib in the name of the -done
file.

[skip ci]
2020-12-18 23:45:28 -08:00
Guy Harris 806f524a10 macos-setup: do "make clean", not "make distclean", for zstd.
It has no configure script, so there's no need for "make distclean", and
the Makefile supplied with it has no "make distclean" rule; just do
"make clean".

[skip ci]
2020-12-18 23:19:40 -08:00
Guy Harris 6498bde741 In Wireshark's version info, indicate whether we were built with Minizip.
We can't determine the version number, as there's nothing in the header
to indicate the version with which we were compiled, nor is there an API
to determine the version with which we're running.
2020-12-18 22:16:04 -08:00
Dario Lombardo 024d91a493
cirrus: remove FreeBSD 11.4.
Many packages needed to build Wireshark are missing from pkg in
FreeBSD 11.4. They're only available in ports. That doesn't mean
that Wireshark is not compilable on FreeBSD 11.4, but that it
requires a long build from ports that is unlikely compatible with
Cirrus' CI (and its timeouts).
2020-12-18 23:20:34 +01:00
Teyut efabf1d291 wlan: fix wrong reported length for reassembled payloads
There is no need to remove the FCS at the end of the reassembled payload since FCS bytes have already been removed from the fragments. Also, the way it was removed in the code was wrong: it set the reported length of the reassembled payload to the reported length of the last fragment only.

Revert "ieee802.11: Make sure we do not include the FCS in the next_tvb."

This reverts commit 094297ec77.
2020-12-18 11:40:22 +00:00
Dr. Lars Völker ff23fb9f0c SOME/IP-SD: hidden fields for entries are 16 bytes off (Bugfix)
This patch fixes a bug that lead to 7 hidden fields being off by
16 bytes.

Closes #17091
2020-12-18 10:14:28 +00:00
Gael Langlais b06b760dd2 UI: Fix Firewall ACL rules
Fix the Cisco Extended, IPFilter and IPFirewall inbound rules.

Closes #16446
2020-12-18 07:30:37 +00:00
Alexis La Goutte 4713e04143 Aruba(IAP): Fix and update model list 2020-12-18 06:32:48 +00:00
Guy Harris 1949b6a5ee macos-setup: don't configure p11-kit to use libffi.
See comment for an explanation.
2020-12-17 21:45:14 +00:00
Nardi Ivan 01e64f996b QUIC: update to draft-33
QUIC (final?) constants for v1 are defined in draft-33
2020-12-17 21:19:27 +00:00
Guy Harris 2db0c64034 macos-setup: remove tabs.
Consistenly use spaces for indentation.
2020-12-17 12:43:43 -08:00
Anders Broman 3bf1f18e48 Fix duplicated filters 2020-12-17 17:31:26 +00:00
Gerald Combs 9772fc5be0 GitLab CI: Add a dist (tarball) build.
Add most of the tarball build steps from the master Buildbot config.
2020-12-17 17:01:59 +00:00
Jim Young 2e137f31fa Update comments: From wtap_pkthdr to wtap_rec.
Fixup some overlooked comments to reflect refactoring made back
in 2018 with commit 1f5f63f8ef.
2020-12-17 13:23:14 +00:00
Anders Broman 1694820e84 GTPv2: Update IE 8.12 Indication 2020-12-17 12:35:01 +00:00
Vadim Yanitskiy cf6f049456 GSM A-bis/OML: fix dissect_oml_attrs(): do not dissect empty IEs
Before:

  FOM Attribute ID: SW Description
      FOM Attribute Length: 0
      FOM Attribute Value: <MISSING>
  FOM Attribute ID: File ID
      FOM Attribute Length: 8
      FOM Attribute Value: 3136386435303200

After:

  FOM Attribute ID: SW Description
      FOM Attribute Length: 0
  FOM Attribute ID: File ID
      FOM Attribute Length: 8
      FOM Attribute Value: 3136386435303200
2020-12-17 09:16:13 +00:00
Frédéric Perrin 7010b4236f bfd: add ports for BFD on LAG and seamless BFD 2020-12-17 08:51:19 +00:00
Guy Harris ca13c3ce49 macos-setup: get rid of a debugging "set -x". 2020-12-16 23:23:13 -08:00
Guy Harris 9fbf79c045 macos-setup: various cleanups.
In uninstall_autoconf, when running uninstall subfunctions, pass the
arguments to the subfunctions.

When uninstalling Ninja, remove the "we've finished installing this"
indicator file.

Get rid of a debugging "set +x".
2020-12-16 18:14:30 -08:00
Guy Harris 190442d76e macos-setup: set SDKROOT when running xcrun.
That lets it find the right SDK path if you're not using the default
SDK.
2020-12-16 14:09:22 -08:00
Gerald Combs bf45e8c3f1 macOS: Add a workaround for libsnappy.
Work around an issue with libsnappy similar to what we do with libssh.
2020-12-16 21:31:29 +00:00
Pascal Quantin 6deafe8afa F1AP: upgrade dissector to v16.3.1 2020-12-16 21:58:11 +01:00
Gerald Combs d4b40c0047 Qt: Force layer backing on Big Sur when needed.
Make sure NSView.wantsLayer is true by setting QT_MAC_WANTS_LAYER=1 at
startup if we're running on Big Sur and we were built with a version of
Qt susceptible to QTBUG-87014. Fixes #17075?
2020-12-16 20:28:16 +00:00
Guy Harris f2af1ea66d macos-setup: fix uninstallation of libtasn1.
Fix a copy-and-pasteo.
2020-12-16 11:54:53 -08:00
Đorđije Manojlović 7e8392c784 R-GOOSE dissector: Fix subtree item lengths 2020-12-16 15:28:45 +00:00
Anders Broman adb1b59495 Fix duplicated filter names. 2020-12-16 15:13:31 +01:00
Anders Broman 4735eddfef Fix duplicated filter names 2020-12-16 12:58:38 +00:00
Guy Harris 19ffed19bd fcdns: the Owner Id field is a 3-octet FC address, not a text string.
Make it FT_BYTES with SEP_DOT, like other 3-octet FC addresses.
2020-12-16 12:28:28 +00:00