Check slice lengths as well as offsets. Disallow negative/zero
lengths.
Range on RHS of display filter expression wasn't being checked in
every case.
svn path=/trunk/; revision=11083
Use gint32 instead of guint32 and strtol() instead of strtoul()
for signed integers.
Pathological slice specifications could cause Flex default rule
to be invoked, echoing characters to stdout.
Example: frame[0foo]==1
svn path=/trunk/; revision=11082
- fixed tree display of NFSv4 change_info type;
- add OPEN4_RESULT_LOCKTYPE_POSIX to OPEN result (reply) flags;
- fixed open_delegation4 dissector;
svn path=/trunk/; revision=11080
fails, set "rb_data.pdh" to NULL, so we know it's not open (if
"wtap_dump_close()" fails, the wtap_dumper_t is still closed - and the
file descriptor for it is probably closed, too, as, if "close()" fails,
the FD is probably closed; the Single UNIX Specification Version 3 says
the state of the FD is unspecified, but in practice most OSes probably
still close it).
If we try to close the current file, first check to make sure it's open,
i.e. that "rb_data.pdh" is non-null. (Or perhaps we should avoid trying
to close it if the open *or* the most recent attempt to rotate the
capture files failed.)
Note that if "wtap_dump_close()" fails we might not need to close the
underlying file descriptor (and, even if we do, there's no guarantee
that attempt won't also fail and leave the FD still open - which is why
I suspect that a failed "close()" leaves the FD closed on most OSes).
svn path=/trunk/; revision=11075
Use "tvb_format_stringzpad()" to put a zero-padded string into the
protocol tree and Info column, so that we 1) don't use a fixed-length
buffer that we might overflow and 2) we handle non-printable bytes in
the string.
svn path=/trunk/; revision=11068
file - that keeps the variable from being shared, and also produces
compiler warnings if the variable isn't used by all the files that
include the header in question.
svn path=/trunk/; revision=11067
declaration.
Give the address and port arguments to "add_hostlist_table_data()"
appropriate names and Doxygen comments (they're not a source address and
port, they're just an address and port), and do the same for the address
and port members of a "hostlist_talker_t".
Get rid of extra unnecessary variables in "add_hostlist_table_data()".
Clean up indentation.
svn path=/trunk/; revision=11066
with its descriptive name rather than the raw value string,
much like packet-rtp.c does already.
To avoid duplicate definitions, the existing rtp_payload_type_vals[] definition is moved
from packet-rtp.c and gtk/rtp_stream_dlg.c to rtp_pt.h.
svn path=/trunk/; revision=11060
level configure.in to mirror that change in wiretap. Otherwise people who
have both versions of glib/gtk installed may see crashes.
svn path=/trunk/; revision=11049
registered (not whether there are any tap *filters* registered).
Do dissection in Tethereal iff:
we're printing information about each packet;
we're using a read filter on the packets;
there are any tap listeners registered (even if there are no tap
filters registered - not all taps use filters).
svn path=/trunk/; revision=11040
and not writing to another capture file, for use with "-z" options.
Note that "-z proto" *doesn't* print statistics at the end - it modifies
the packet summary output.
Note that on at least some BSDs the "status" character is set to "off"
by default, so you have to set it explicitly in order to be able to ^T
an application such as Tethereal.
svn path=/trunk/; revision=11038
packet" and "print packet" callbacks into a common routine, so that we
don't count packets twice if we're counting and dissecting.
Print the packet count with ^T iff we're not updating a displayed packet
count as packets arrive, regardless of whether we're printing packet
information, saving packets to a file, or both (tcpdump prints it
regardless of whether it's printing packet information or saving packets
to a file).
svn path=/trunk/; revision=11037
Guy Harris