Commit graph

34801 commits

Author SHA1 Message Date
Martin Mathieson
5344e9f3d9 Take care not to append RLC mode to proto_item twice.
svn path=/trunk/; revision=36429
2011-04-01 13:41:08 +00:00
Bill Meier
18fc4872bc Rename local 'pipe_input' so it doesn't shadow global 'pipe_input';
Use consistent indentation and remove trailing whitespace.

svn path=/trunk/; revision=36428
2011-03-31 20:57:40 +00:00
Ronnie Sahlberg
f4d68c6a08 Memory leak in lemon.c
coverity 1177


svn path=/trunk/; revision=36427
2011-03-31 20:50:13 +00:00
Chris Maynard
6760848315 Fix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067.
svn path=/trunk/; revision=36426
2011-03-31 19:17:06 +00:00
Chris Maynard
9e49109b28 Check return value of file_seek(). Fixes CID 338.
svn path=/trunk/; revision=36425
2011-03-31 18:28:52 +00:00
Chris Maynard
735b61500c Don't dereference a NULL pointer. Fixes CID 426.
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
Chris Maynard
8f429fd919 separator will never be NULL, but sep_len could be 0, so test for that instead.
Fixes CID 620.

svn path=/trunk/; revision=36423
2011-03-31 17:27:48 +00:00
Chris Maynard
b92bf3b06c Use BSWAP16 instead of BSWAP32 for 16-bit values. Fixes CID's 1179 and 1180.
svn path=/trunk/; revision=36422
2011-03-31 16:46:16 +00:00
Chris Maynard
adadb7dd0f Use a common function, higher_priority_status_level() to determine whether or
not messages should be pushed onto the statusbar.  Should fix CID 270.

svn path=/trunk/; revision=36421
2011-03-31 16:23:07 +00:00
Chris Maynard
4d4f0b839b Clear the entire contents of ctx at the end of md5_finish(). Fixes CID 712.
svn path=/trunk/; revision=36420
2011-03-31 15:41:23 +00:00
Chris Maynard
f8737dfbcc From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
"warning: Value stored to 'offset' is never read".  The 'offset' is now used.

svn path=/trunk/; revision=36419
2011-03-31 15:17:49 +00:00
Chris Maynard
0db9556757 Delete unused header fields found by running tools/checkhf.pl.
svn path=/trunk/; revision=36418
2011-03-31 14:35:40 +00:00
Bill Meier
94f2771f41 (Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.
svn path=/trunk/; revision=36417
2011-03-31 14:30:38 +00:00
Chris Maynard
f88037ac41 From Yair via bug 5779: Add option to leave AAL5 in unspecified format.
(... with whitepsace changes by me.)

svn path=/trunk/; revision=36416
2011-03-31 14:23:07 +00:00
Chris Maynard
1e71ccef15 From Andrew Feren via bug 5775: Correct types on several info elements.
svn path=/trunk/; revision=36415
2011-03-31 14:03:23 +00:00
Stig Bjørlykke
8d62b393a4 Register tcp by name.
To be used in User DLT's and Lua scripts.

svn path=/trunk/; revision=36414
2011-03-31 12:18:14 +00:00
Stig Bjørlykke
a54e28e2ec Use correct functions to fetch protocol name for a dissector registered
by register_dissector().

svn path=/trunk/; revision=36413
2011-03-31 12:16:41 +00:00
Stig Bjørlykke
a6476ba91b Added dissector_handle_get_long_name().
svn path=/trunk/; revision=36412
2011-03-31 12:14:59 +00:00
Stig Bjørlykke
0b8be02229 Use correct length for clientaddr4 callback address entry.
svn path=/trunk/; revision=36411
2011-03-31 11:01:06 +00:00
Chris Maynard
a3fe8fbd1a Fix a couple of typos.
svn path=/trunk/; revision=36410
2011-03-30 15:54:28 +00:00
Chris Maynard
dde455a94e From: http://www.wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT.  (This should have been checked in with r36297.)

svn path=/trunk/; revision=36409
2011-03-30 14:53:09 +00:00
Chris Maynard
9e55be72fc Wrap all text lines of help at column 80.
svn path=/trunk/; revision=36408
2011-03-30 14:44:18 +00:00
Ronnie Sahlberg
13f6b77d92 remove two pointless const in casts
coverity 580 and 581

svn path=/trunk/; revision=36407
2011-03-30 04:36:09 +00:00
Ronnie Sahlberg
f3512de0a9 remove some assignments we dont use
svn path=/trunk/; revision=36406
2011-03-30 03:39:58 +00:00
Chris Maynard
a4452f43fa Change TCP_PORT_MANGO to TCP_PORT_MONGO.
svn path=/trunk/; revision=36405
2011-03-29 21:40:54 +00:00
Jeff Morriss
5a2a122942 Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 760-761.

svn path=/trunk/; revision=36404
2011-03-29 21:39:15 +00:00
Anders Broman
645cfe9ef2 Add a missing break.
CID 487

svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
Anders Broman
ce248d9ea9 Add a missing break.
CID 488

svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
Anders Broman
2b81b097e5 Add a missing break.
CID 490

svn path=/trunk/; revision=36401
2011-03-29 21:08:34 +00:00
Anders Broman
bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning.
CID 489

svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Chris Maynard
83dc9446ec From Alexis La Goutte via bug 5790: Add partial bit flag in query.
svn path=/trunk/; revision=36399
2011-03-29 20:58:57 +00:00
Chris Maynard
a8c78f0562 Grab URL from frame info value instead of from tvb. Fixes bug 5780.
svn path=/trunk/; revision=36398
2011-03-29 20:05:33 +00:00
Jeff Morriss
607d944d02 Don't put a 196808 byte variable on the stack: instead, malloc/free it.
Coverity 789-790.

Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.

Also, some white space/indentation cleanup.

svn path=/trunk/; revision=36397
2011-03-29 14:29:45 +00:00
Anders Broman
ba8a739f4c Remove check_col().
svn path=/trunk/; revision=36396
2011-03-29 14:23:21 +00:00
Martin Mathieson
7356320a2a Don't assign proto_item pointers that are not used.
Coverity 1174

svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Jeff Morriss
ce392b5764 Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 791-794.

Also, some white space/indentation cleanup.

svn path=/trunk/; revision=36394
2011-03-29 14:05:28 +00:00
Stig Bjørlykke
9e5a9badda Guard against NULL return from find_protocol_by_id().
svn path=/trunk/; revision=36393
2011-03-29 11:09:59 +00:00
Stig Bjørlykke
f7c84ad094 From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.

svn path=/trunk/; revision=36392
2011-03-29 11:08:15 +00:00
Tomas Kukosa
7c083c0966 RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling 

svn path=/trunk/; revision=36391
2011-03-29 10:56:30 +00:00
Jeff Morriss
892d734975 Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().
svn path=/trunk/; revision=36390
2011-03-29 01:27:20 +00:00
Chris Maynard
d69a7dac79 Cast to guint to avoid a Windows compiler warning.
svn path=/trunk/; revision=36389
2011-03-28 22:22:05 +00:00
Chris Maynard
c91893191d Move -D option into "pre-scan" group as there's no need to start gtk+ for it.
svn path=/trunk/; revision=36388
2011-03-28 22:12:53 +00:00
Chris Maynard
42d40ee494 Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).
svn path=/trunk/; revision=36387
2011-03-28 22:10:41 +00:00
Stephen Fisher
d4649392d8 Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.
svn path=/trunk/; revision=36386
2011-03-28 20:53:20 +00:00
Jeff Morriss
a2393ea239 Use g_ascii_strdown instead of g_strdown
svn path=/trunk/; revision=36385
2011-03-28 19:44:41 +00:00
Guy Harris
173708364c More updates to the wtap_open_offline() comment.
svn path=/trunk/; revision=36384
2011-03-28 17:23:06 +00:00
Chris Maynard
10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Chris Maynard
15503bf4aa Don't use prohibited strncpy(). In this case, use g_strlcat() instead.
svn path=/trunk/; revision=36382
2011-03-28 16:42:25 +00:00
Jeff Morriss
c977007591 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :
Fix a Clang warning, add email address, and add some stuff to COL_INFO.

svn path=/trunk/; revision=36381
2011-03-28 15:28:03 +00:00
Jeff Morriss
c39c25ce9c From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :
Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

svn path=/trunk/; revision=36380
2011-03-28 15:23:27 +00:00