Commit Graph

35049 Commits

Author SHA1 Message Date
Alexis La Goutte 50cf6ca9c3 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36701
2011-04-18 17:44:17 +00:00
Alexis La Goutte 8b61d83f5e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36700
2011-04-18 17:38:08 +00:00
Alexis La Goutte e95efe228e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36699
2011-04-18 17:35:25 +00:00
Stig Bjørlykke 27344a90fe Removed some unneeded assignments.
Found by clang.

svn path=/trunk/; revision=36698
2011-04-18 15:29:25 +00:00
Stig Bjørlykke 9739656c71 Make it build.
svn path=/trunk/; revision=36697
2011-04-18 15:27:27 +00:00
Anders Broman 9f2e70aad5 Start merging from packet-pdcp-lte.c
svn path=/trunk/; revision=36696
2011-04-18 14:38:18 +00:00
Chris Maynard e4c6b7d0c3 Update Motonori Shindo's email address at the author's request. Fixes bug 5840.
svn path=/trunk/; revision=36695
2011-04-18 02:16:36 +00:00
Martin Mathieson a4b6665653 Retire a preference that can be always on now.
svn path=/trunk/; revision=36693
2011-04-17 21:43:20 +00:00
Martin Mathieson 16cb326768 Allow signaling protocol (e.g. RRC) to set number of SN bits
PDCP should use for DRB channels.

Not yet called by RRC.

svn path=/trunk/; revision=36692
2011-04-17 21:34:47 +00:00
Michael Tüxen ad619e3a04 Decode the SI value in DATA messages correclty.
This fixes bug 5834.

svn path=/trunk/; revision=36691
2011-04-17 19:37:46 +00:00
Stig Bjørlykke 4f809a7e67 One more unused argument.
svn path=/trunk/; revision=36690
2011-04-17 19:17:46 +00:00
Stig Bjørlykke 2a2dd7655c Removed unneeded assignments.
Found by clang.

svn path=/trunk/; revision=36689
2011-04-17 19:07:17 +00:00
Stig Bjørlykke d6e7705c96 Mark unused arguments with _U_.
svn path=/trunk/; revision=36688
2011-04-17 19:04:54 +00:00
Stig Bjørlykke 95447e23f8 Removed unneeded assignments to self.
Found by clang.

svn path=/trunk/; revision=36687
2011-04-17 19:01:26 +00:00
Stig Bjørlykke a3391d1a95 Removed an unneeded assignment, they are both always 0.
Found by clang.

svn path=/trunk/; revision=36686
2011-04-17 18:59:17 +00:00
Stig Bjørlykke 3c53c25a0c Corrected equality check in frag_equal().
Found by clang.

svn path=/trunk/; revision=36685
2011-04-17 18:49:58 +00:00
Anders Broman 61041c062d Coverity UNUSED_VALUE
CID 1141

svn path=/trunk/; revision=36684
2011-04-17 18:10:08 +00:00
Anders Broman bd8c36d4a3 Coverity UNUSED_VALUE
CID 1142,1143,1147

svn path=/trunk/; revision=36683
2011-04-17 18:00:14 +00:00
Stig Bjørlykke bf28f7247c Mark err as unused in k12text_dump_open().
svn path=/trunk/; revision=36682
2011-04-17 17:49:02 +00:00
Stig Bjørlykke 722dba0495 Check for valid docsis_handle, and use data_handle if not.
This fixes bug 5839.

svn path=/trunk/; revision=36681
2011-04-17 17:47:39 +00:00
Alexis La Goutte df3293c9d4 Add QoS Capability element (46) and Extended Supported Rates element (50)
Enhance RSN Info (48), Extended Capabilities information element (127)

* Replace proto_tree_add_uint*/boolean/text by proto_tree_add_item
* use ENC_* macro for encoding

svn path=/trunk/; revision=36680
2011-04-17 17:20:58 +00:00
Gerald Combs b05a8ef84e [Automatic manuf, services and enterprise-numbers update for 2011-04-17]
svn path=/trunk/; revision=36677
2011-04-17 15:03:50 +00:00
Martin Mathieson d4e9304fd2 Add a way for configuration protocol (e.g. RRC) to configure MAC-> RLC mappings, and add a preference to use this or the static UAT.
API is not yet called by RRC.

svn path=/trunk/; revision=36676
2011-04-17 11:22:03 +00:00
Anders Broman 67900c23be Fix Unused varaiable warnings.
CID 1163 - 1166

svn path=/trunk/; revision=36675
2011-04-17 09:34:38 +00:00
Alexis La Goutte 5f6a579854 Using the routing subtree (Miss in my last patch)
Fix a typo error (shoubl => should)

svn path=/trunk/; revision=36674
2011-04-17 08:58:15 +00:00
Gerald Combs 2d2109c0c7 Remove another unneeded NULL check. Fixes Coverity CID 605.
svn path=/trunk/; revision=36673
2011-04-16 22:02:14 +00:00
Gerald Combs 43b089db87 Fix Coverity CIDs 603 & 604.
svn path=/trunk/; revision=36672
2011-04-16 21:46:15 +00:00
Gerald Combs ed25109219 Fix the warnings in Coverity CIDs 606-608.
svn path=/trunk/; revision=36671
2011-04-16 21:38:21 +00:00
Gerald Combs 0ea5ded80c Add NULL checks. Fixes Coverity CIDs 509 and 510.
svn path=/trunk/; revision=36670
2011-04-16 21:25:34 +00:00
Anders Broman c63471823d Try to make the OSX buildbot happy.
svn path=/trunk/; revision=36669
2011-04-16 17:32:30 +00:00
Alexis La Goutte 9b5f811b4e Convert ICMPv6 dissector to "new-style" dissector
Fix Dead Store Warning ( warning: Value stored to '*offset*' is never read )


svn path=/trunk/; revision=36668
2011-04-16 17:14:39 +00:00
Gerald Combs 033366bda6 From Edwin Groothuis via bug 5813:
In the explanation of TCP Option 78 (Riverbed Transparency), the labels
are "CSH IP Addr/Port" and "SSH IP Addr/Port". This should be "Src SH IP
Addr/Port" and "Dst SH IP Addr/Port".
The filter keys for these labels are correct.

svn path=/trunk/; revision=36667
2011-04-16 16:45:38 +00:00
Stig Bjørlykke 1bc2077b3e Initialize feedback_data_len to avoid a compiler warning.
svn path=/trunk/; revision=36666
2011-04-16 16:37:53 +00:00
Anders Broman 05172d4476 From Dirk:
The attachted patch cleans up the output of DCE/RPC fragment information in the
dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5772

From me get rid of check_col()

svn path=/trunk/; revision=36665
2011-04-16 16:00:02 +00:00
Gerald Combs 76b26d9a2b Fix compilation errors.
svn path=/trunk/; revision=36664
2011-04-16 15:33:24 +00:00
Anders Broman 6a0cbfbce8 Fix:
packet-rohc.c: In function 'dissect_rohc_ir_rtp_profile_dynamic':
packet-rohc.c:285: warning: 'val_len' may be used uninitialized in this function
packet-rohc.c:186: warning: 'num_bits' may be used uninitialized in this function
packet-rohc.c:186: note: 'num_bits' was declared here

svn path=/trunk/; revision=36663
2011-04-16 12:28:03 +00:00
Anders Broman ffae0f912d From Neil Piercy:
Adds BMC protocol, including adding support for MAC and RLC CTCH channels to carry it.
From me:
Removed hf blurbs = def and removed check_col added tp CMakeList.

svn path=/trunk/; revision=36662
2011-04-16 12:22:16 +00:00
Anders Broman 214b9c3ad0 From Motonori Shindo:
Current NetFlow V9/IPFIX dissector treats IN_BYTES (IE=1) and
IN_PERMANENT_BYTES (IE=85) exactly in the same way. The same applies to IN_PKTS
(IE=2) and IN_PERMANENT_PKTS (IE=86). However, IN_BYTES/IN_PKTS and
IN_PERMANENT_BYTES/IN_PERMANENT_PKTS have different semantics so they should be
distinguishable when they are displayed or specified in a filter. Please find
attached the patch
which does that.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5807

svn path=/trunk/; revision=36661
2011-04-16 12:03:50 +00:00
Anders Broman 8c98248308 Add rohc
svn path=/trunk/; revision=36660
2011-04-16 11:49:51 +00:00
Anders Broman 0a1437bfac Add a basic ROCH dissector.
Limitations:
- Small CID
- RTP profile
- IPv4

svn path=/trunk/; revision=36659
2011-04-16 11:44:05 +00:00
Martin Mathieson 960376a8f3 Show max UEs/TTI in MAC stats window (UL/DL separately).
svn path=/trunk/; revision=36658
2011-04-16 10:56:18 +00:00
Martin Mathieson ae149510e6 Keep track of how many UL/DL UEs in a TTI, and attach this info to each UL-SCH/DL-SCH frame..
svn path=/trunk/; revision=36657
2011-04-15 23:32:44 +00:00
Stephen Fisher 2a028a16ba From Edwin Groothuis via bug #5833: Make number of bits in Frame header
optional


svn path=/trunk/; revision=36652
2011-04-15 17:53:23 +00:00
Martin Mathieson bdf271e79e Remove more unnecessary assignments. Coverity 1022 (again).
svn path=/trunk/; revision=36649
2011-04-15 12:53:20 +00:00
Guy Harris cd1a4b036c Return ENOMEM if we run out of memory. (We're either running on UN*X,
in which case ENOMEM is the right error, or we're running on Windows but
using UN*Xy routines, in which case ENOMEM is the right error; unlike
zlib, we don't have to run on a whole pile of OSes.)

svn path=/trunk/; revision=36648
2011-04-15 07:27:03 +00:00
Chris Maynard 3e6bd6b558 From Andrew Feren via bug 5774: Make V9TEMPLATE_MAX_FIELDS a user preference.
From me: Use lower-case v9template_max_fields instead of upper-case to avoid
any confusion with that variable being a define.  Use STRINGIFY() so we always
keep the default and the displayed default the same.  Fix bug introduced by
Andrew's patch where option_scope_field_count was inadvertently changed to
option_field_count.  Append "Maximum value can be adjusted ..." message to all
relevant expert infos.

svn path=/trunk/; revision=36643
2011-04-14 16:17:09 +00:00
Chris Maynard 75deae992a Revert r24047. Fixes bug 5822.
svn path=/trunk/; revision=36642
2011-04-14 13:58:40 +00:00
Alexis La Goutte 12dae38bb7 Update to last IANA parameters (2011-04-08)
Update to last RPL Draft (19)
Add new ICMPv6 Option: Proxy Signature (PS) draft-ietf-csi-proxy-send-05
Fix 2 Clang Warning (unused variable):
packet-icmpv6.c:2755:9: warning: Value stored to 'oplength' is never read
        oplength = tvb_get_guint8(tvb, rr_offset);
packet-icmpv6.c:2916:5: warning: Value stored to 'nb_mcast_records' is never read
    nb_mcast_records = tvb_get_ntohs(tvb, mldr_offset);

svn path=/trunk/; revision=36641
2011-04-14 09:40:07 +00:00
Tomas Kukosa 5653540de6 Export new file_...() functions from libwiretap.dll
svn path=/trunk/; revision=36640
2011-04-14 09:02:01 +00:00
Guy Harris c0e5dc8489 Zero is zero is zero, as Gertrude Stein didn't say.
svn path=/trunk/; revision=36639
2011-04-14 06:28:25 +00:00