Commit graph

83214 commits

Author SHA1 Message Date
Dr. Lars Völker
4d9f29150e Signal-PDU: Adding support for zero-terminated and UTF strings
This patch adds support for zero-terminated strings as well as UTF-8 and
UTF-16 strings.

This patch also fixes a check for the signal list UAT (scaler, offset).
2022-01-06 03:17:05 +00:00
Michael Tuexen
b3c24758b3 macos-setup.sh: Simplify building nghttp2 2022-01-05 20:58:32 +00:00
Pascal Quantin
adca11dd5c range_string: follow-up of 893290c 2022-01-05 20:34:15 +00:00
Martin Mathieson
f1c31deb61 UDS: make a function static 2022-01-05 20:15:16 +00:00
Dr. Lars Völker
9b43910bc2 PTP: Source Code Cleanup (formatting) 2022-01-05 17:40:32 +00:00
Gerald Combs
e9bc60ace4 macos-setup.sh: Update the PCRE URL.
As noted on https://pcre.org/, ftp.pcre.org has been shut down. Switch
to SourceForge and bump the version to 8.45. Fixes #17834.
2022-01-05 17:01:23 +00:00
John Thacker
4b5d54f5ea packaging: Bump RPM glib2 version to 2.38
We require glib2 version 2.38 now, increase the version requirement
in the RPM spec file to match.
2022-01-05 10:21:23 -05:00
John Thacker
2cb8f34721 packaging: Remove unnecessary Requires
Automatic dependency generation has been around since RPM 4.0 (September
2000). The BuildRequires are sufficient for all of these; the automatic
dependences for the .so files works and are superior as they are versioned.

Red Hat and SUSE both recommend using automatic dependencies and
avoiding unnecessary Requires in spec files:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires
https://en.opensuse.org/openSUSE:Package_dependencies
2022-01-05 09:53:17 -05:00
João Valverde
7afb52c479 ws_assert: refactor assertions 2022-01-05 13:31:53 +00:00
João Valverde
1dfba751e5 wslog: Replace ws_assert() 2022-01-05 13:31:52 +00:00
João Valverde
f7b904f328 wslog: Convert to C99/POSIX types 2022-01-05 13:31:52 +00:00
João Valverde
947c617812 Remove some circular dependencies on wireshark.h 2022-01-05 13:31:52 +00:00
João Valverde
232628322c wslog: Rewrite macros 2022-01-05 13:31:52 +00:00
João Valverde
3f27a830fc wslog: Use a wider type for line 2022-01-05 13:31:52 +00:00
Dr. Lars Völker
0f2cf2b331 Signal-PDU: reformatting for consistency
The code was not formatted consistently. This patch cleans this up.
2022-01-05 13:06:59 +01:00
Alexis La Goutte
a68fd7b09d macos-setup: Update nghttp2 release
there is some CVE and bug fix...
2022-01-05 10:10:38 +00:00
Benedikt Heumüller
893290c603 Extended range_string to 64 bit 2022-01-05 09:14:46 +00:00
Dr. Lars Völker
382fe23aa8 UDS: add subdissector support
Adding subdissector support to UDS and allow Signal PDUs for it.

This patch supports:
- ReadDataByIdentifier (RDBI) Reply
- WriteDataByIdentifier (WDBI) Request
- RoutineControl (RC) Request
- RoutineControl (RC) Reply
2022-01-05 06:06:33 +00:00
Gerald Combs
27ccf26b4b BLF: Fix a coverity warning.
Fix

```
*** CID 1496851:  Resource leaks  (RESOURCE_LEAK)
/builds/wireshark/wireshark/wiretap/blf.c: 1621 in blf_read_apptextmessage()
1615         }
1616
1617         gchar *text = g_try_malloc0((gsize)apptextheader.textLength);
1618
1619         if (!blf_read_bytes(params, data_start + sizeof(apptextheader), text, apptextheader.textLength, err, err_info)) {
1620             ws_debug("not enough bytes for apptext text in file");
>>>     CID 1496851:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "text" going out of scope leaks the storage it points to.
1621             return FALSE;
1622         }
1623
1624         /* returns a NULL terminated array of NULL terminates strings */
1625         gchar **tokens = g_strsplit_set(text, ";", -1);
```
2022-01-05 05:21:25 +00:00
John Thacker
98378d76d0 packaging: ENABLE_RPATH_ORIGIN on Fedora RPM build
Fedora Linux recently turned on some hardcore RPATH hardening
that causes RPM build to fail with a wide variety of prefixes unless
$ORIGIN is enabled.

It builds fine with /usr as the prefix because in that case we disable
the RPATH.

In the long run perhaps we should have the rpm-package target use the
standard prefix of /usr instead of the CMAKE_INSTALL_PREFIX, but even
so we want the spec file to work if /usr/local is set as the prefix.
Fix #17830
2022-01-04 21:48:31 -05:00
John Thacker
007883408f packaging: Fix git-export-release.sh when CI_COMMIT_SHA undefined
Commit 0d820ddc8d added set -u to
the script, so the test for CI_COMMIT_SHA (added in commit
e7296d5208) needs to be changed
so there isn't a fatal error if it is unset.
2022-01-05 01:21:08 +00:00
Guy Harris
ec0aaf1811 ftype-time: check for NULL from gmtime() and localtime().
On Windows, they return NULL for times prior to the Epoch.
2022-01-04 15:35:18 -08:00
Guy Harris
72a4210828 text_import: "localtime()" is an API, "local time" is local time. 2022-01-04 15:17:30 -08:00
Gerald Combs
74a9d3bb67 Docs: Fix release notes markup.
AsciiDoc headings need to start at the beginning of the line. Bump the
next version.
2022-01-04 20:34:13 +00:00
Roman Volkov
0a4f3d62e5 mpeg table: implement Selection Information Table (SIT) 2022-01-04 20:13:09 +02:00
Luca Deri
39df51c46d Added missing nDPI ClassifierId
For more information about classification engine ids see:
https://www.iana.org/assignments/ipfix/ipfix.xhtml#classification-engine-ids
2022-01-04 13:57:14 +00:00
Roman Volkov
4ce03e2be2 mpeg descriptor: add multilingual ones (5B,5C,5D,5E)
Add Multilingual Network Name Descriptor (0x5B),
Multilingual Bouquet Name Descriptor (0x5C),
Multilingual Service Name Descriptor (0x5D),
Multilingual Component Descriptor (0x5E).
2022-01-04 13:26:22 +00:00
Dr. Lars Völker
99056c2d9e Signal-PDU: Fix extraneous parentheses warnings 2022-01-04 13:28:55 +01:00
Roman Volkov
699dc583bd mpeg descriptor: add NorDig Logical Channel Descriptor v1 and v2
Add as a usual DVB descriptors. A specification was taken from
NorDig Unified Requirements 3.1.2.
Formally, private descriptors have to be used after Private Data
Specifier (0x5F) but DVB operators often ignore this rule. So I
didn't limit the descriptors parsing by Nordig private data
specifier (0x00000029).
2022-01-04 11:53:19 +00:00
Martin Mathieson
10ffdcb3c0 Some (trivial) cppcheck fixes. 2022-01-04 10:48:22 +00:00
Dr. Lars Völker
b7ae71a9c2 Signal-PDU: Adding support for float, string, uint_string
This patch adds support to the Signal-PDU dissector for the following
data types:
- float: 32 and 64 bit IEEE floating point numbers
- string: fixed length ASCII strings
- uint_string: dynamic length ASCII strings with leading length
2022-01-04 08:16:18 +00:00
Роман Донченко
3efc8eb073 ldap, ros: restore a missing word in a comment
This was accidentally introduced in 69d54d6f. The corresponding
generated source files don't have this problem, so they don't need to
be fixed.
2022-01-04 07:13:45 +00:00
Jaap Keuter
a4cbf047e4 Validate only real C files, not templates 2022-01-04 07:09:26 +00:00
Gerald Combs
fc2217aa39 WSDG: Add a warning about private forks.
It's not obvious that making a GitLab fork private will disassociate it
from the upstream repository, and it seems to have tripped up a couple
of people. Add a warning to the "Creating Merge Requests" section.
2022-01-04 06:41:05 +00:00
Anders Broman
95e28f7631 GTPv2: Handle thcase where dissect_diameter_3gpp_uli has no data. 2022-01-04 06:24:48 +00:00
John Thacker
04974e3ca9 text2pcap test: Use the -a flag
The text2pcap tests that use a capinfos->tshark->text2pcap->capinfos
cycle need to use the -a flag for identifying when the start of the
ASCII dump looks like hex, since the tshark -x output is a hex+ASCII
format. Adding the flag means that we can remove the override of the
expected data size for the dns_icmp.pcapng.gz file. (It also affects
the file with multiple data sources, but another issue remains there.)
2022-01-03 18:31:12 -05:00
Guy Harris
0e98eb412f nstime: "localtime()" is an API, "local time" is local time. 2022-01-03 23:08:07 +00:00
John Thacker
2aa0664e25 text2pcap: Use -F flag for tests
Use the -F file type flag to have the text2pcap tests produce the
same file type as the input flag, which is a little superior when
the input flag is a nanosecond pcap.

Note that commit 5076aee044 means that
capinfos -M provides a machine-readable filetype that's easier to put
back into text2pcap.
2022-01-03 22:53:49 +00:00
John Thacker
da6cfc4de2 text_import: nanosecond resolution by default
Use nanosecond resolution pcapng files for "Import from Hex Dump"
by default (since we support that level of precision and that's
what text2pcap does).
2022-01-03 22:38:31 +00:00
Gerald Combs
d0408b8b78 epan: Add p_set_proto_data.
Add p_set_proto_data, which either updates our entry if we have a
proto+key match or adds an entry if we don't. Use it with
p_set_proto_depth. Document it and our other proto_data routines.
2022-01-03 22:19:14 +00:00
Dr. Lars Völker
f02d2a4793 Signal-PDU: Adding Check to Remove Compiler Warning
There was a warning that dynamic_hf[i].p_id is not checked for NULL and
that could mean a NULL Pointer dereference.

To make the code more robust and the compiler happy, this patch adds the
check for NULL.
2022-01-03 22:04:14 +00:00
Dr. Lars Völker
196e8e74f3 DLT: Call subdissectors even with empty payload 2022-01-03 21:45:52 +00:00
Martin Mathieson
070cc0a47a Run dissector URLs check - fix up a couple of entries. 2022-01-03 20:01:27 +00:00
Pascal Quantin
d2b5441cec F1AP: upgrade dissector to v16.8.0 2022-01-03 19:22:24 +00:00
Gerald Combs
6d319297ae Qt: Add a common hover color. 2022-01-03 19:03:46 +00:00
Pascal Quantin
ce43234c5a E1AP: upgrade dissector to v16.8.0 2022-01-03 18:48:52 +00:00
Pascal Quantin
c50512abc3 NRPPa: upgrade dissector to v16.6.0 2022-01-03 18:15:52 +00:00
Martin Mathieson
29190ed12e RTPS: Make some functions static 2022-01-03 18:15:11 +00:00
Pascal Quantin
4942262c18 XnAP: upgrade dissector to v16.8.0 2022-01-03 17:37:13 +00:00
Pascal Quantin
345326697c NGAP: upgrade dissector to v16.8.0 2022-01-03 17:21:26 +00:00