offset returned from dissect_nfs_open_claim4, dissect_nfs_openflag4 were different
when we were building tree and where we didn't.
Fix other similar cases.
svn path=/trunk/; revision=43576
Remove refresh button from wireless toolbar
With a "refresh interfaces" menu option and device hotplug
notification in place there is no longer need for a refresh
button in the toolbar.
svn path=/trunk/; revision=43570
Refresh wireless toolbar too
The recently improved refresh interfaces code forgot the wireless
toolbar. Make sure to refresh it too.
svn path=/trunk/; revision=43568
Add checks for calls to proto_tree_add_XXX (where XXX != item and a few other
functions) with an encoding (ENC_*) argument.
Also add a comment to checkAddTextCalls() about why 3 loops are used.
svn path=/trunk/; revision=43563
https://bugs.gentoo.org/show_bug.cgi?id=423743
"The Makefile.am claims including GLIB_LIBS when linking wireshark is
unnecessary, because wireshark links to GTK_LIBS which is a superset.
It is not actually a superset: gmodule is included in GLIB_LIBS but
not in GTK_LIBS (unless accidentally on older glibs/gtks)."
so we must explicitly link with GLIB_LIBS.
Update the comment to reflect that - and to reflect that GTK+ doesn't
necessarily run atop X11 - while we're at it.
Fixes bug 7427.
#BACKPORT
svn path=/trunk/; revision=43561
- Compile the value_string only as part of packet-x11.c
- Create a value_string_ext to ref the value_string;
- packet_vnc.c: Access the value_string using the value_string_ext;
- packet-x11.c: Access the value-string using the value_string_ext
rather then building a temp GTree from the value_string.
svn path=/trunk/; revision=43558
Wireshark > 1.4 does not correctly read Association ID for PS Poll packets
Wireless Frame with subtype 0x1a don't interpret the Association ID (always 0).
Fix :
proto_tree_add_uint() wasn't changed to proto_tree_add_item()
#BACKPORT
svn path=/trunk/; revision=43556
proto_tree_draw() from r43189 is lazy, and it don't fills tree with all item labels.
To fix it, move 'gbl_resolv_flags' hack to proto_tree_model_get_value().
XXX could we pass resolving flags to proto_item_fill_label()?
svn path=/trunk/; revision=43550
PF_SYSTEM sockets on OS X.
Pull iface_mon_nl_init() into iface_mon_start(), to make it a little
easier to figure out what interface monitoring code on other platforms
should do.
Add a bunch of XXX comments about additional things we should perhaps
do.
svn path=/trunk/; revision=43545
packet-dbus.c(354) : error C2220: warning treated as error - no 'object' file generated
packet-dbus.c(354) : warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data
svn path=/trunk/; revision=43543
In MPEG-related dissectors, "adaption" is used instead of "adaptation" several
times. See patch (it also fixes an unrelated typo that happens to be on the
same line).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7421
svn path=/trunk/; revision=43539
platform-dependent work is now done in get_interface_type().
That means we also don't need to protect the handling of IF_DIALUP or
even IF_AIRPCAP in #ifdefs, just in case we add support for those types
in other OSes.
Nothing's uisng the capture_ethernet_16.xpm image here, so don't bother
including it. (Does *anybody* use it? I couldn't find any uses, but
maybe we should use that.)
svn path=/trunk/; revision=43531
geoip_db_lookup_ipv4() and geoip_db_lookup_ipv6().
In both of those routines, "ret" is always set to a non-null value -
it's initially set to the aforementioned string - so always return it.
svn path=/trunk/; revision=43526
does a ws_stat64() to check for the existence of files in /sys.
It's *not* needed in ui/gtk/main.c any more, as that code was moved out
of ui/gtk/main.c.
svn path=/trunk/; revision=43525
Martin Mathieson