If the length is bigger than the captured length, an excpetion will be thrown anyway
Bug: 13554
Change-Id: Icf0f2b049847ec945efdf42815b49c4e6040e19d
Reviewed-on: https://code.wireshark.org/review/20936
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Use macOS when not referring to a particular release; use the
appropriate name when referring to a particular release.
Change-Id: I9293d4db7c91d7c859d7c067c0f0b3c9c482fcc5
Reviewed-on: https://code.wireshark.org/review/20935
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X
10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was
sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS
X" from 10.8 to 10.11.
Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3
Reviewed-on: https://code.wireshark.org/review/20933
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The OS is now called macOS.
In newer versions of macOS, tar can uncompress xz'ed tarballs, but older
versions don't support that.
Change-Id: Ife8ac7fc7da69586ad6b718def4a52588740686b
Reviewed-on: https://code.wireshark.org/review/20931
Reviewed-by: Guy Harris <guy@alum.mit.edu>
xz now hosts older releases on SourceForge and does a 302 redirect
to SourceForge, which cURL without -L won't follow.
The default value of 50 redirects before giving up is left unchanged.
Change-Id: I2d73301f025737ad84438d01a445fe6f257ba9d5
Reviewed-on: https://code.wireshark.org/review/20926
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Don't force display of BASE_DEC
Change-Id: Id6f115c074f0d4b1bd277dcbf6c523ffaa295edb
Reviewed-on: https://code.wireshark.org/review/20918
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
GTK+ supports selecting the first packet (via the "left mouse button")
and the last packet (via the "right mouse button") in an interval, and
Qt supports selecting the last packet of an interval. This patch enables
picking the packet matching the extreme value in Qt.
Bug: 12401
Change-Id: If0b7f2f1bf8c384ea0d68b5f5fae2d1e8b4b0ac2
Reviewed-on: https://code.wireshark.org/review/20769
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Do not assume first graph in the list, pick the first visible graph.
This (1) fixes the tracer which would otherwise show a marker at an
non-obvious position that is not located on the graph and (2) fixes the
GoToPacket action when clicking on the graph.
Bug: 13537
Change-Id: I49d750102ad25c8539aa2e44fe1583cd535dd471
Reviewed-on: https://code.wireshark.org/review/20768
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Initiator is always master. Only Role switch event may change it.
Improve "Accept Connection Request" to avoid users confusion
by using new specification description:
0x00 Become the Master for this connection. The LM will perform the role switch.
0x01 Remain the Slave for this connection. The LM will NOT perform the role switch.
Field "Role" is now splitted from: "bthci_cmd.role"
and it name is "bthci_cmd.acr.role".
Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd
Reviewed-on: https://code.wireshark.org/review/20894
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki@wireshark.org>
Change-Id: Id495f1ca5a7ea2081b6ed35690ad94978c17ec6f
Reviewed-on: https://code.wireshark.org/review/20808
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alignment with IEEE 802.1X-2010
- Addition of Announcement
Alignment with IEEE 802.1X-2010 EAPOL-MKA
- Interpretation of algorithm agility value
- Interpretation of confidentiality offset values
- Interpretation of (wrong) cipher suite ID
- Padding handling for more parameter sets
- Improved robustness malformed frames
- Flexible SAK size handling
- Addition of Announcement parameter set
- Split ICV from ICV indicator
- Handle unknown parameter set
Additions for IEEE 802.1Xbx-2014
- Allow version 2 handling
- Addition of XPN parameter set
Change-Id: If7a36de6bb3b5148bfd1bd890e4490c045fba40d
Reviewed-on: https://code.wireshark.org/review/20899
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Get rid of extra blank lines.
Clean up indentation.
Use the same style for switch statements inside cases for the main
switch statement in dissect_dns_answer() that's used for the main switch
statement.
Change-Id: I77da88a9ffcbf176d27e16222e75c778202c651b
Reviewed-on: https://code.wireshark.org/review/20907
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Change-Id: Idff9c807cbc3714acafd98bea5b15b06bf23f0a9
Reviewed-on: https://code.wireshark.org/review/20906
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Commands:
Enhanced Setup Synchronous Connection
Enhanced Accept Synchronous Connection Request
Truncated Page
Truncated Page Cancel
Set Connectionless Slave Broadcast
Set Connectionless Slave Broadcast Receive
Start Synchronization Train
Receive Synchronization Train
Remote OOB Extended Data Request Reply
Set MWS Channel Parameters
Set External Frame Configuration
Set MWS Signaling
Set MWS Transport Layer
Set MWS Scan Frequency Table
Set MWS Pattern Configuration
Set Reserved LT_ADDR
Delete Reserved LT_ADDR
Set Triggered Clock Capture
AMP Test
Write Secure Connections Test Mode
Fix copy-paste issue:
Implementation for "Get MWS Transport Layer Configuration"
was in: "Set Triggered Clock Capture"
Change-Id: I4a2119278b1f3a7e1a3ec87f499d9aa43e8b8a96
Reviewed-on: https://code.wireshark.org/review/20890
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Explain what it is and where to get it from.
Change-Id: I0a02f1c3c25b76772dddda95d8e6c410b595c036
Reviewed-on: https://code.wireshark.org/review/20886
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: I2757f6442b9f3d37897225a90dd6d848e4a9c373
Reviewed-on: https://code.wireshark.org/review/20889
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It seems that "Parameters" highlight only one byte instead of all
parameters. Fix that before someone requests to fix that.
Change-Id: If056f16ffbfc234e5d6443fb43b34bc107df964f
Reviewed-on: https://code.wireshark.org/review/20898
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Fix missing information about command-event(response) tracking.
Change-Id: I060ae71f8efb774d4d04693e58f750dec442c046
Reviewed-on: https://code.wireshark.org/review/20896
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Application Parameters:
vCard Selector
Data Filter
Both are splitted to two 4-bytes subfield, so there is a need to
move offset for second field.
Change-Id: I66c106f5455bff8789f25c683301276b1e484e65
Reviewed-on: https://code.wireshark.org/review/20892
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It seems to be issue introduced while implementing
features from new specification - add new bits in bitmask field
without correcting expert info condition.
Change-Id: I5a4fb4147971f565cfb5dd1abf4e5616ce9da4c5
Reviewed-on: https://code.wireshark.org/review/20895
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Interval -> Window
Change-Id: Ic40811a87fd301a07e2a9af60b152feeab395ead
Reviewed-on: https://code.wireshark.org/review/20893
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Add ability to display only these HCI commands whose names match specified
filter. Currently only simple filtering is implemented (substring search,
no regex-matching).
Change-Id: I418d3d2d3e7a3b196d5ba05496d31c508e842dec
Reviewed-on: https://code.wireshark.org/review/20880
Reviewed-by: Michal Labedzki <michal.labedzki@wireshark.org>
Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
If the offset is out of bounds, we can simply continue and
proto_tree_add_...() will throw an exception for us.
While at it, wrap some long lines and remove obsolete coments about
g_malloc()ed memory (the dissector has been converted to wmem).
Change-Id: Icd36418f07c0cf33c5fe906a8a2d3160789ee1f2
Reviewed-on: https://code.wireshark.org/review/20856
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>