Commit Graph

4116 Commits

Author SHA1 Message Date
Anders Broman 699c5c66b6 From Florent.Drouin@alcatel.fr:
I did improve the OID management in the tcap dissector.
Now, when a tcap message is reveived, without upper layer, the ACN is saved in the TCAP context, and can be used for the next messages of the dialogue. It is used only when the upper layer session is opened with Tcap only messages.

svn path=/trunk/; revision=19414
2006-10-03 19:24:22 +00:00
Luis Ontanon 8f737d2587 Get it to compile...
svn path=/trunk/; revision=19412
2006-10-03 18:38:04 +00:00
Anders Broman 8774e7e28e From David Richards:
numerous changes, most notably:

1) BACnetStatusFlags is bit string, not enum, in NotificationParameters
2) Fixes many places where enclosing context tags were not handled properly.
3) Simplify tag decoding logic.  Change to explicit decoding in many 
instances rather
    than read tags in a loop and do a switch based on tag number.  Looping
    ignores out-of-order and other types of tagging errors.

svn path=/trunk/; revision=19410
2006-10-03 18:11:55 +00:00
Luis Ontanon 5d40bae072 MSVCC does not like mixing code and variable declarations
svn path=/trunk/; revision=19409
2006-10-03 18:07:31 +00:00
Anders Broman 83971ab494 Add application/media_control+xml
svn path=/trunk/; revision=19408
2006-10-03 18:04:15 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Martin Mathieson 3474ea868c - Add special case for reading strange encoding of ATM CID field
- Indicate direction of DCH Data in info column
- Assume EDCH payload CRC if 2 bytes are left over (previous test was broken)

svn path=/trunk/; revision=19405
2006-10-03 14:21:07 +00:00
Anders Broman 179039652b From Stephen Fisher:
always register 
itself on the port from the preferences (defaults to 0) upon launch.  
This allows the user to right-click and use decode as.

svn path=/trunk/; revision=19403
2006-10-03 05:50:28 +00:00
Anders Broman e65847960f From Stephen Fisher:
Modifie the VNC dissector to desegment 
the "server cut text" message type for cases where the cut text is in 
the next tcp segment from the first part of the message.

svn path=/trunk/; revision=19402
2006-10-03 05:48:47 +00:00
Martin Mathieson 2bfdb780ee Set correct length for extensions root
svn path=/trunk/; revision=19393
2006-10-02 10:49:57 +00:00
Ronnie Sahlberg af410bce95 fix for header digest detection being broken when AHS is used.
we simply forgot to account for the AHS when testing to calculate the crc


svn path=/trunk/; revision=19389
2006-09-30 21:49:11 +00:00
Ronnie Sahlberg 61ac971e2c add dissection of the cdb for service action LIST
(but no decoding of the data in yet)



svn path=/trunk/; revision=19388
2006-09-30 21:08:27 +00:00
Ronnie Sahlberg 71af839c39 the ahs length inside the AHS for an extended cdb includes the reserved byte before the start of cdb data
account for this extra reserved byte in the ahs length so that the reconstructed cdb has the correct length and does not contain one extra byte at the end



svn path=/trunk/; revision=19387
2006-09-30 20:40:04 +00:00
Ulf Lamping ee8abeec9e fix a typo
svn path=/trunk/; revision=19386
2006-09-30 18:30:43 +00:00
Graeme Lunt 23937f82c7 A new field information flag, FI_URL, to indicate a field contains a URL.
This is used to display the field underlined and to allow the user to double-click on it (like FT_FRAMENUM) to open the URL in the configured browser. 
Example usage in the x509ce and logotype certificate extensions. 


svn path=/trunk/; revision=19383
2006-09-30 14:37:09 +00:00
Ulf Lamping 3da46255fe remove compiler warnings
svn path=/trunk/; revision=19382
2006-09-30 13:40:36 +00:00
Ronnie Sahlberg c2b08c79d2 add dissection of SCSI OSD CREATE PARTITION
svn path=/trunk/; revision=19379
2006-09-30 10:24:23 +00:00
Ronnie Sahlberg cadbe48610 finish off the remainder of FORMAT OSD for scsi osd dissector
svn path=/trunk/; revision=19378
2006-09-30 10:08:43 +00:00
Ronnie Sahlberg bedacc2bc2 scsi osd updates
iscsi: when iscsi transfers a cdb that is alrger than 16 bytes,  the first 16 bytes are transferred in the normal place in the header and ther remainder of the cdb is transported inside the AHS.

reassemble these cdb into a proper tvb before passing it to the scsi dissector



svn path=/trunk/; revision=19376
2006-09-30 09:34:58 +00:00
Ulf Lamping 4e79f8f307 remove a warning
svn path=/trunk/; revision=19375
2006-09-30 09:15:15 +00:00
Ronnie Sahlberg 62290c9cc5 add an extra_data pointer to the itlq structure where specific commandsets/cdbs can hang additional data that are unique to that commandset/cdb
make the scsi osd service action and getsetattributetype use this facility

furhter enhancements to scsi osd


svn path=/trunk/; revision=19374
2006-09-30 04:10:28 +00:00
Ronnie Sahlberg deef583ae5 scsi opcode 0x7f is variable length so dont clamp the cdb length to 16 bytes
svn path=/trunk/; revision=19373
2006-09-30 01:01:57 +00:00
Ronnie Sahlberg 0afdb9be78 scsi osd additions
we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly


svn path=/trunk/; revision=19371
2006-09-30 00:31:36 +00:00
Ulf Lamping d6f0ae689c MSVC doesn't like empty array inits
svn path=/trunk/; revision=19368
2006-09-29 21:53:54 +00:00
Anders Broman 55967abbf1 Update Diamater and Radius AVP:s
svn path=/trunk/; revision=19366
2006-09-29 21:26:27 +00:00
Jaap Keuter 8fd898635b Fix for bug 1133:
add a test for (length > 0) in the dissector (dissect_xot_pdu), to avoid to
allocate a new tvb when the XOT decoded length is null. 

svn path=/trunk/; revision=19365
2006-09-29 19:39:40 +00:00
Martin Mathieson 49a3e2a6e5 Dissect Via header
svn path=/trunk/; revision=19364
2006-09-29 17:35:23 +00:00
Jaap Keuter e01fdc5616 From Nicolas DICHTEL:
Please find enclosed a patch about Mobile Network Prefix option in NEMO.
Following RFC3963 Section 4.3, lenght of this option is 18, not 16.

svn path=/trunk/; revision=19363
2006-09-29 16:31:52 +00:00
Ronnie Sahlberg 59d9a1b9c2 add a missing heuristic to acept a NOP_IN packet and correct a broken heuristic that would refuse all NOP_OUT pdus as non-iscsi
it is absolutely amazing that none of the iscsi implementors and users of wireshark had noticed this breakage and reported it.   they apparently do not use wireshark.


svn path=/trunk/; revision=19362
2006-09-29 11:12:18 +00:00
Tomas Kukosa 809d8a1113 From Reinhard Speyerer:
patch fixes a small typo in epan/dissectors/packet-per.c

svn path=/trunk/; revision=19361
2006-09-29 11:09:17 +00:00
Ronnie Sahlberg e2a851e18d add initial scsi osd dissector but only dissect sdbs that are impoerted from SPC
various changes to the existing scsi dissector to start allowing different commandsets to be implemented in their own dissector files to prevent the scsi dissector to become as huge as the parlay dissector




svn path=/trunk/; revision=19360
2006-09-29 10:40:51 +00:00
Ronnie Sahlberg d09cfb2bb8 move the defines for SPC command opcode values to the headerfile
svn path=/trunk/; revision=19359
2006-09-29 09:24:51 +00:00
Anders Broman 2861b22148 Update some value_strings
svn path=/trunk/; revision=19355
2006-09-29 05:51:44 +00:00
Anders Broman f1a97e4ec3 From Martin Peylo:
- dissection of TIPCv2 internal messages now shows
  all fields used according to the protocol spec
- there should be no issues with the current protocol
  spec anymore
- the info column is more concise and gives more
  details
- some code beautifications

svn path=/trunk/; revision=19354
2006-09-29 05:50:41 +00:00
Jaap Keuter b43742894c From Nicolas DICHTEL:
I've two patchs for FMIPv6:
- FBU encapsulated in FNA are not correctly parsed;
- there is an error when parsing LLA Option.

svn path=/trunk/; revision=19351
2006-09-28 16:30:20 +00:00
Ronnie Sahlberg c220a1a89a From stephen fisher:
I have figured out one of the fields in the MAPI
EcRRegisterPushNotification packet.  The field is a UDP port number that
the client wants the Exchange server to send new mail notifications on.
These notifications are on a port > 1023 and are always 8 bytes long.

It looks like I would add the function name to the
dcerpc_mapi_dissectors[] for the register push notification.  What would
my new function need to do besides display the field?


Thanks,

Steve

Here is a patch to add this functionality.  It displays the notification
port and the notification payload (not sure what the payload itself
means yet).  It also dynamically registers each notification port found
with a new dissector (that I called newmail for lack of a better name -
I'm open to suggestions) that displays the notification payload.  This
is all undocumented by Microsoft in their usual fashion.

I also changed the code to always display the mapi.opnum field;
currently, the mapi.opnum is only displayed when the
dcerpc_mapi_dissector is null.


Steve




svn path=/trunk/; revision=19350
2006-09-28 16:29:18 +00:00
Ronnie Sahlberg c20b7c8eda additional scsi sense codes from patrick@abra2.bitwizard.nl
svn path=/trunk/; revision=19349
2006-09-28 15:57:54 +00:00
Ronnie Sahlberg ad305c630b Hi,
This patch fixes the page code selector for the scsi log sense command.

Patrick




svn path=/trunk/; revision=19348
2006-09-28 15:55:13 +00:00
Ronnie Sahlberg 6fee9a41f0 From Alex Burlyga
This patch adds support for dissecting ontap's nfsv4 filehandle,
as well as some updates to nfsv3 filehandle as well in the nfs
dissector.

Alex.


checked in with minor changes


svn path=/trunk/; revision=19345
2006-09-28 07:52:46 +00:00
Ronnie Sahlberg 171a98950c EFS is generated by PIDL now so we dont need the old idl2wrs folder any more
svn path=/trunk/; revision=19343
2006-09-27 20:56:15 +00:00
Ronnie Sahlberg 3fbca8aff5 generate the EFS DCERPC interface dissector using PIDL
svn path=/trunk/; revision=19342
2006-09-27 20:55:13 +00:00
Anders Broman ad9a9a6a9d From Florent Drouin:
Here are some patches and a new module to introduce the notion of Tcap context for a Tcap transaction. For each Tcap transaction, several parameters, like session identifier, start time or OID, will be saved in a hash table, to keep these informations available for the next messages. This context is then given to the upper layer, and can be used, for example, to generate transaction-associated statistics.

Moreover, the Upper protocol, detected in the Begin of the TCAP transaction ( according to the OID ), is saved in the context, and will be reused for the next messages of the transaction. This help the decoding of SS7 messages, without any SSN configuration in the "wireshark preferences".

You will have too, the possibility to apply a filter to see only the messages related to a TCAP transaction. (tcap.srt.session_id=XXX)

To enable the use of the Tcap context, you have 2 new parameters in the preferences,
- SRT, enable search for a Tcap context for any TCAP messages
- persistentSRT, keep the Tcap context, even after the transaction has been closed. This is mandatory with Wireshark, to have a clean display of the stats.

There is 2 new timers  in the preferences for the statistics, to tune the retransmission timeout, and messages lost timeout.

svn path=/trunk/; revision=19341
2006-09-27 20:06:06 +00:00
Anders Broman 9753b85f46 Handle unaligned dissect_per_length_determinant and dissect_per_restricted_character_string_sorted.
svn path=/trunk/; revision=19340
2006-09-27 19:30:22 +00:00
Martin Mathieson 473347e064 Dissect sequence number & method name of CSeq header.
svn path=/trunk/; revision=19336
2006-09-27 12:49:00 +00:00
Ronnie Sahlberg 10091ebdaa add new dcerpc protocol WZCSVC based on samba4 idl
this protocol is not too interesting yet since only the function names of this interface is known  but it is more that no dissection at all



svn path=/trunk/; revision=19333
2006-09-27 08:59:20 +00:00
Martin Mathieson 0852c89fd1 - Mark the multipart type as a generated field.
- Remove the RFC 3261 attribution in the long text version of several headers (some of them I couldn't easily work out where the first non-obsoleted introduction of them is)

svn path=/trunk/; revision=19328
2006-09-26 13:01:27 +00:00
Ronnie Sahlberg e2aea53993 update the idl for wkssvc and generate the dissector by pidl
svn path=/trunk/; revision=19321
2006-09-25 08:50:21 +00:00
Anders Broman 299469d48d Handle Zero length SEQUENCE and SEQUENCE OF.
svn path=/trunk/; revision=19318
2006-09-24 21:04:53 +00:00
Guy Harris 239ba17a50 dissect_ndr_uint16()'s last argument points to a guint16, not a guint.
svn path=/trunk/; revision=19316
2006-09-24 20:31:02 +00:00
Guy Harris 240f452c38 Squelch a compiler warning.
Clean up indentation.

svn path=/trunk/; revision=19315
2006-09-24 20:29:47 +00:00
Ronnie Sahlberg d00cec91ec these dissector functions should not be in svn in pidl they are just temporary files that are copied to the correct location after being manually compiled
svn path=/trunk/; revision=19312
2006-09-24 20:24:39 +00:00
Ronnie Sahlberg aa7834c8ef pidl has been updated to use WERR instead of DOS error tables.
regenerate some dissectors


svn path=/trunk/; revision=19311
2006-09-24 20:23:17 +00:00
Ulf Lamping 8ee212b535 print the connectionless interface name if such is known
svn path=/trunk/; revision=19309
2006-09-24 11:10:31 +00:00
Ulf Lamping cb29acb89a don't replace the COL_PROTO and COL_INFO entries simply with "PNG", but append it only to the COL_INFO just like the GIF dissector is doing
this keeps valuable info in COL_INFO, e.g. the HTTP status code 

svn path=/trunk/; revision=19308
2006-09-24 00:45:31 +00:00
Ronnie Sahlberg 1b3847969e we did not have a proper WERR error table for the windows errors insterad we justkept adding the errors to the DOS error table (this merging does work ok since there is so very little overlap between he values in both ranges)
Add a new WERR error table to packet-windows-common    so that PIDL generated dissectors can use this table instead of the DOS table.


To make this table as complete and accurate as possible and to avoid having to type all the values in by hand    the table is generated from the samba doserr.h file and two small commandlines.
The commends in pakcet-windows-common.h explains how to regenerate the table from doserr.h






svn path=/trunk/; revision=19306
2006-09-23 21:55:40 +00:00
Ronnie Sahlberg 5c2232dc22 replace a rotating buffer in smb with ep allocated memory
dont try dcerpc reassembly of fragments if we dont have the entire pdu

only call the heuristical dissectors once from smb/pipe as per guy(?)s comments about idempotence.
when doing reassembly, the dcerpc dissector is indeed not idempotent any more.



svn path=/trunk/; revision=19304
2006-09-23 13:21:54 +00:00
Graeme Lunt 914d48e098 Fix to show all the internal tokens. when configured, when dissecting an unknown piece of BER.
svn path=/trunk/; revision=19289
2006-09-22 17:39:02 +00:00
Graeme Lunt 3001ad5169 When dissecting LDAP, the assumption was made that the maximum LDAP PDU size will be 65535. Anything bigger than this was considered not to be LDAP. However, LDAP can have PDU sizes bigger than this - a CRL can easily grow to be bigger than this, for example.
This patch makes the the maximum valid LDAP PDU size a preference. The default value for this new preference is 65535 for backwards compatibility.


svn path=/trunk/; revision=19288
2006-09-22 15:19:32 +00:00
Martin Mathieson 03a7d4ac2e Add missing updates to unbreak build...
svn path=/trunk/; revision=19287
2006-09-22 12:41:30 +00:00
Martin Mathieson aa42f96cc5 Add remaining dedicated control message types. This dissector is pretty complete now.
svn path=/trunk/; revision=19286
2006-09-22 12:35:06 +00:00
Martin Mathieson e240c46f6c EDCH new fields + another DCH control message type
svn path=/trunk/; revision=19285
2006-09-22 10:29:19 +00:00
Ronnie Sahlberg 4987fc95bb dfs updates from the s4 idl repository
svn path=/trunk/; revision=19284
2006-09-22 09:27:25 +00:00
Ronnie Sahlberg cb23bfa371 update where the extra strings in the record are being dissected to that the decode follows the packet structure more closely
svn path=/trunk/; revision=19283
2006-09-22 07:56:18 +00:00
Ronnie Sahlberg 4fb91a42f8 update to eventlog record
dissect the informational strings that may be present inside an event



svn path=/trunk/; revision=19282
2006-09-22 07:43:29 +00:00
Ronnie Sahlberg f1aec19c53 add conformance file magic to decode the non-NDR source/computer name strings of the eventlog_Record
svn path=/trunk/; revision=19280
2006-09-22 01:40:23 +00:00
Ronnie Sahlberg e38da93629 updates to eventlog to use the pidl generated dissector and enhance the conformance file to dissect parts of the eventlog Records.
(record dissection is incomplete since this is not really NDR encoded   but better than nothing)



svn path=/trunk/; revision=19279
2006-09-22 00:01:38 +00:00
Ronnie Sahlberg 3991557f68 merge JBMs changes from the handwritten dissector to the idl
svn path=/trunk/; revision=19278
2006-09-21 22:02:08 +00:00
Ronnie Sahlberg 03ff1644f3 add idl file and conformance file for eventlog interface
svn path=/trunk/; revision=19277
2006-09-21 22:01:32 +00:00
Ronnie Sahlberg d1ce720b3c winreg updates resync idl from s4
svn path=/trunk/; revision=19276
2006-09-21 21:14:33 +00:00
Anders Broman c8f1354c14 Fix for bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1106
packet-lapd.c change on 2006-03-02 (17452) by etxrab swaps SRC/DST for the default case
And added a comment to Q.931

svn path=/trunk/; revision=19275
2006-09-21 19:39:42 +00:00
Guy Harris 3b1726527a Add some space after commas.
svn path=/trunk/; revision=19274
2006-09-21 17:42:23 +00:00
Guy Harris 2b56ab8695 Fix the handling of IPv4-address and Boolean suboptions of the Novell
options item.

svn path=/trunk/; revision=19273
2006-09-21 17:41:47 +00:00
Jaap Keuter 18664a7803 From: Marco Strack
The smb dissector displays lock requests in the "Locking AndX Request" as a vector of locks. It opens a tree branch
"Locks" and appends the locks to this branch. Instead of adding "Lock" objects to this branch it added "Unlock"
objects. Everything else is fine.

svn path=/trunk/; revision=19271
2006-09-21 13:08:50 +00:00
Martin Mathieson 4990aec4b9 New fields in R6 RACH
svn path=/trunk/; revision=19270
2006-09-21 10:21:12 +00:00
Ronnie Sahlberg af26289df3 dfs updates
svn path=/trunk/; revision=19269
2006-09-21 09:18:39 +00:00
Martin Mathieson b7bb8c7460 Make the data part of the message filterable
svn path=/trunk/; revision=19265
2006-09-20 12:13:18 +00:00
Martin Mathieson 6de1b28bb8 Add Content-Id and Content-Transfer-Encoding headers, as described in RFC 2045/6
svn path=/trunk/; revision=19264
2006-09-20 12:12:18 +00:00
Anders Broman 06bdcadce0 From David Pelton:
Add  the ieee802a_add_oui function to libwireshark.def, and also adds the OUI that I am using to a couple of internal lists (in epan/oui.h and dissectors/packet-llc.c).

From me:
Resorted the oui  lists, some witespace changes and added Ericsson OUI:s.

svn path=/trunk/; revision=19262
2006-09-20 06:13:02 +00:00
Anders Broman 93ea6fac36 From Graham Addis:
In dissect_geographical_description the longitude is multiplied by 260 
 and should be by 360(degrees).

 Also it would be good to display to 5 decimal places.

svn path=/trunk/; revision=19260
2006-09-19 20:25:57 +00:00
Martin Mathieson 133e459384 Make Content-Length and Max-Forwards fields uints
svn path=/trunk/; revision=19259
2006-09-19 17:40:24 +00:00
Ronnie Sahlberg 6cd45b33ae import DFS.idl from samba and use it to generate a much more complete DFS dissector
svn path=/trunk/; revision=19257
2006-09-19 08:02:19 +00:00
Jaap Keuter 0058816599 From G.F. aka Gena01
I have put together a patch for YMSG packet dissector. This is based on my own code and service lists (this
should match Gaim and Kopete service lists). This new code should bring the code up to par to most of the
known services. Which should cover up to Yahoo 7.x or most of it.

I have also setup a new set of constants which are specific to YMSG packets. These are the types that I've
seen in miranda network logs and they should reveal more information. The other constants are mostly for buddy
statuses and need nor apply to the YMSG header.  I have left them in the code (for now). These constants are
currently used in my own code.

svn path=/trunk/; revision=19255
2006-09-18 14:29:58 +00:00
Jaap Keuter a3821bf4c3 Licepnse -> License
svn path=/trunk/; revision=19254
2006-09-18 13:59:30 +00:00
Martin Mathieson 704f848105 Add old release DSCH FDD fields. Try to squash compiler warnings seen on MACOS buildbot
svn path=/trunk/; revision=19253
2006-09-18 13:39:23 +00:00
Jörg Mayer 8b4aeedaf1 jeff morriss:
Patch for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1102


svn path=/trunk/; revision=19252
2006-09-18 10:14:12 +00:00
Jaap Keuter b9f9757bed From Francesco Fondelli:
You find attached a patch file (against svn 19058) to dissect packets
produced by the Linux kernel packet generator.

svn path=/trunk/; revision=19251
2006-09-18 09:27:47 +00:00
Ronnie Sahlberg fe89548ed9 some more bitmaps for SRVSVC
svn path=/trunk/; revision=19250
2006-09-18 08:42:46 +00:00
Ronnie Sahlberg 690ad14806 add decoding of the SessionInfo userflags
svn path=/trunk/; revision=19249
2006-09-18 08:05:51 +00:00
Anders Broman 168079f703 From Martin Peylo:
Improve Infocolumn output.

svn path=/trunk/; revision=19248
2006-09-17 20:23:23 +00:00
Anders Broman 71628796c4 Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1107
"The decoder has some bugs:
 * RTP redundancy field is decoded incorrectly.
 * Timer TU3920 is displayed as being in seconds, but it is really in units of
100 ms."

svn path=/trunk/; revision=19247
2006-09-17 19:43:13 +00:00
Ronnie Sahlberg b85f1d1b80 generate SRVSVC by pidl
small prettification regression but that will be fixed in the next few days



svn path=/trunk/; revision=19244
2006-09-16 11:57:14 +00:00
Ronnie Sahlberg 7bed417e5e make dissect_nt_sid return ep allocated memory and thus fix a few memory leaks
(this function is often called from dcerpc dissectors)


svn path=/trunk/; revision=19243
2006-09-16 09:20:34 +00:00
Ronnie Sahlberg ff901e2b0e strings we pass up to the caller through private_data are now of ep scope
this closes a few memory leaks


svn path=/trunk/; revision=19242
2006-09-16 09:10:23 +00:00
Ronnie Sahlberg ac85c4717c remove any dependencies that dcv->private_data is persistent
svn path=/trunk/; revision=19241
2006-09-16 08:51:03 +00:00
Ronnie Sahlberg eebad152f7 make SAMR not rely on dcv->private_data being persistent any more and use dcv->se_data
once the private_data -> se_data conversion is complete we can plug quite a large number of memory leaks related to dcerpc



svn path=/trunk/; revision=19240
2006-09-16 05:30:31 +00:00
Martin Mathieson 5f38a25c0b More missing message types
svn path=/trunk/; revision=19235
2006-09-15 15:03:18 +00:00
Anders Broman 20b391debb svn propset.
svn path=/trunk/; revision=19234
2006-09-14 17:21:28 +00:00
Martin Mathieson 2a380ba8bf More fixes and prettifications
svn path=/trunk/; revision=19233
2006-09-14 15:43:43 +00:00
Ronnie Sahlberg 8b236488e2 add OpenSCManagerW
also make the dissector manage that dcv->private_data in the future will be of ep scope



svn path=/trunk/; revision=19232
2006-09-14 12:01:18 +00:00
Jörg Mayer 2a5d217358 Jeff Morriss:
Fix for bug 1036

I looked at this today and found that in fact the PC stuff is pretty
hosed up in the SS7 dissectors.  For example, MTP3 *looks* OK here (DPC is
4-5-6):

    Routing label
        DPC (4-5-6) (394500)

but 394500 == 0x60504 == 6-5-4.  Something's not right.

I made a common PC dissector function for all the SS7 dissectors so as to
concentrate all this code in one place (something I've been wanting to do for a
while anyway) and fixed the reported problem as well as the above problem in
the attached patch.

svn path=/trunk/; revision=19231
2006-09-14 10:51:44 +00:00
Martin Mathieson 1d5165c8e0 Add support for R6 HSDPA data 'new IEs' (the spec seems not be be very clear...).
Try to cast away a warning seen on buildbot logs

svn path=/trunk/; revision=19229
2006-09-13 13:32:31 +00:00
Ronnie Sahlberg f6976864bf the way we pass dcerpc strings from deep down in helpers to high level dissector functions (dcv->private_data) for things such as strings and sids is a mess and very difficult to handle without a lot of memory leakage.
the biggest problem in changing this is the dcv->private_data usage.


add a dcv->se_data which can keep data around from a request to a response and use this to change the LSA/OpenPolicy2 servername passing from request to response as a test pattern of moving all users of dcv->private data over to use dcv->se_data.

once all users are migrated over we can then change the dcv->private data pointer to be of ep scope and thus not need an explicit free (which is quite difficult and it is quite difficult in the old semantics to know WHEN we need to free this pointer)

this will eventually make the usage more clean and at the same time close down quite a few memory leaks.


eventually this will make dissect_ndr_nt_SID return a pointer to ep allocated memory that need not be explicitely freed.



svn path=/trunk/; revision=19226
2006-09-13 08:30:16 +00:00
Guy Harris 2e64b81928 Not all platforms define "u_short", and "tvb_length_remaining()+4" isn't
guaranteed to fit into a "u_short" in any case.  Use "gint" instead.

Squelch some compiler warnings.

svn path=/trunk/; revision=19225
2006-09-13 01:28:07 +00:00
Anders Broman 5dd7a4e7f9 From: Luca Deri via Andrew Feren:
> please find enclosed a patch to the CFlow dissector (packet-netflow.c) 
> that enables it to decode IPFIX packet traces.

svn path=/trunk/; revision=19221
2006-09-12 19:11:45 +00:00
Anders Broman ffbabd4fb8 Set default port to zero.
svn path=/trunk/; revision=19220
2006-09-12 19:02:10 +00:00
Martin Mathieson 46afb89310 More DCH control types
svn path=/trunk/; revision=19212
2006-09-12 17:13:56 +00:00
Jaap Keuter 593efe3509 Fix for bug 1098. Add BPDU dissector to ethertype 0x8181.
svn path=/trunk/; revision=19211
2006-09-12 12:58:16 +00:00
Ronnie Sahlberg 4919409df7 from Taner Kurtulus and Menno Andriesse
Hi folks,
We think we've found a bug in STANAG 5066 SIS layer dissector.

Problem is at S_EXPEDITED_UNIDATA_INDICATION S_Prim's parser
and occurs when we receive a U_PDU via expedited unidata channel.
Dissector tries to parse first 2 bytes of U_PDU as a header size of  type
21 s_prim (S_UNIDATA_INDICATION). But, this is not an wanted  process on
that parser. Maybe, it was forgotten unchanged from
S_UNIDATA_INDICATION dissector while copying it. So it shows
data (U_PDU) 2 bytes short. Moreover, if data is just 1-byte, TCP datagrams
receive TCP checksum error.


Confirmed.

It was indeed a "copy-paste-did not edit correctly" bug.

While going over the code once more, I found:

1 - One bug in the heuristic. (Changed '&&' to '||')
2 - One to-do that was already done. (Removed the /* TODO */)
3 - One to-do that is now done. ;-)



svn path=/trunk/; revision=19210
2006-09-12 12:08:34 +00:00
Ronnie Sahlberg 073483df45 from Florian Lohoff
Hi,
after using the redback dissector again i found some more protocol
types:



svn path=/trunk/; revision=19209
2006-09-12 11:51:48 +00:00
Ronnie Sahlberg b61e42bc3a from bryant eastham
Also, there is still an outstanding issue regarding the default use of
the "media" dissector. The way it is currently coded there is no way to
have a heuristic decoder when a content-type header is specified.


In this way if there is a decoder for a specific content-type then it
will be used, then the heuristic decoders have a chance, and finally the
default of either the media-type decoder of the http_payload decoder.



svn path=/trunk/; revision=19208
2006-09-12 11:39:51 +00:00
Martin Mathieson 3dc82c316d Various small fixes and prettifications
svn path=/trunk/; revision=19207
2006-09-12 11:36:42 +00:00
Ronnie Sahlberg a92d1dc783 put the ah and esp payload as its own top level expansion in the tree instead of as an expansion inside the ah/esp layer.
since source/dest/protocol/info is updated by the content of the payload    it doesnt make sense to hide the actual payload inside esp/ah
it just would look confusing



svn path=/trunk/; revision=19206
2006-09-12 10:04:11 +00:00
Ronnie Sahlberg a67f7da9d7 prettify dissection of ESP
show the IV as a hexadecimal
show the protocol name for the Next header field inside ESP



svn path=/trunk/; revision=19204
2006-09-12 09:53:10 +00:00
Ulf Lamping 04fe34d711 various nmake related build file cleanups
svn path=/trunk/; revision=19198
2006-09-12 00:27:03 +00:00
Anders Broman 96c13a1000 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091
h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames.

svn path=/trunk/; revision=19190
2006-09-11 20:35:24 +00:00
Martin Mathieson 1936461d8d Added E-DCH (HSUPA) channels to FP.
Also show VPI/VCI/CID in ATM protocol label.

svn path=/trunk/; revision=19189
2006-09-11 12:03:29 +00:00
Jaap Keuter f29dbe34d8 VRRPver3 support fixed: Count restored, Auth Type is reserved field.
svn path=/trunk/; revision=19188
2006-09-10 18:48:33 +00:00
Ronnie Sahlberg d517c305b1 fix for bug 1045
windows in SYN and SYN+ACK packets are not scaled so dont apply window scaling to them when displaying them in the tree


svn path=/trunk/; revision=19186
2006-09-10 14:34:57 +00:00
Ronnie Sahlberg 6d3c94a53a implement support to reassemble tcp sessions until the end of the session (FIN)
add required code to the http (and others) code in req_resp_hdrs.c to signal to tcp
when it wants a session to be reassembled to the FIN.

This is currently done for all HTTP packets where we have a Content-type in the header but no content-length.




svn path=/trunk/; revision=19185
2006-09-10 14:03:08 +00:00
Anders Broman 505465d5a4 From Frédéric Roudaut:
as requested  here is a patch  in order to take into account  Encryption 
and Authentication keys for ESP in hexa. 
You only have to write your key with 0x first. In this case if the key 
is not in 8-bit unit, it will be considered as starting with a "0" (4 bits). Excepted this case, the key should be completely written, even if it 
starts with "0x00".

svn path=/trunk/; revision=19181
2006-09-08 07:32:13 +00:00
Anders Broman d0ee14432c Move the code to handle ISO protocols over TCP/TPKT to packet-osi.c where it belongs.
svn path=/trunk/; revision=19180
2006-09-08 06:58:40 +00:00
Ulf Lamping ac76ad1c64 tweak some expert infos so they better work with the composite dialog (e.g. remove some minor details)
svn path=/trunk/; revision=19176
2006-09-07 20:35:26 +00:00
Ulf Lamping a6d4e249a6 add some probable protocol IDs from the DCOM specs
svn path=/trunk/; revision=19175
2006-09-07 20:33:02 +00:00
Ulf Lamping 4a03300106 distinguish between things "ToBeDone" and "NoSpecificationAvailable" as some DCOM things are just unknown and cannot be implemented therefore
svn path=/trunk/; revision=19174
2006-09-07 20:30:48 +00:00
Ronnie Sahlberg 457c3f13c0 pidl now handles empty bitmaps properly so no need for the dummy (dont trigger empty bitmapbug entry)
svn path=/trunk/; revision=19170
2006-09-07 10:53:32 +00:00
Martin Mathieson b7505630c8 Dissect some more common control messages
svn path=/trunk/; revision=19164
2006-09-06 14:08:40 +00:00
Ronnie Sahlberg 9fddfa2777 fix for the typo in bug 1094
svn path=/trunk/; revision=19163
2006-09-06 08:36:13 +00:00
Jörg Mayer 370a162e87 - Make options filterable
- Display options in info column
- Only remember blksize from OACK packets
- Add some rfc numbers
- Move tftp_dissect_options in front of dissect_tftp
  (I forgot to fix the forward decl once too often ;)
- Warning fixes
- Add expert error in case of tftp-error pdu


svn path=/trunk/; revision=19162
2006-09-06 08:24:36 +00:00
Jörg Mayer adc56b8e95 option name "blksize" is case in-sensitive
svn path=/trunk/; revision=19158
2006-09-05 16:09:49 +00:00
Martin Mathieson 26285e4b2f Make smrse & radius dissectors findable by name
svn path=/trunk/; revision=19157
2006-09-05 16:06:41 +00:00
Martin Mathieson 2e1177c328 For DCT2000, show better transport info:
- for FP over AAL2, add CID to AAL tree
- for IPPRIM protocols, show IPV4 addresses in src & dst columns

svn path=/trunk/; revision=19156
2006-09-05 16:05:23 +00:00
Jörg Mayer 56e1dd7780 Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
Actually, this was a feature request:

Store the value of the blksize option in the conversation data
and use that information to compare whether we have reached the
last packet.

Includes the cleanup ideas from Ronnie.

svn path=/trunk/; revision=19155
2006-09-05 15:58:11 +00:00
Ronnie Sahlberg 542380d974 fix for bug 1054
there were instances where the function dissect_nt_sid() would not fill in the return pointer for the sid string
causing callers that rely on that this string will ALWAYS be assigned try to access and g_free() an uninitialized pointer.

dissect_nt_sid() should be changed to use and return ep allocated memory instead of gmalloced memory



svn path=/trunk/; revision=19154
2006-09-05 15:13:39 +00:00
Ronnie Sahlberg 52c827f1d1 fix for bug 1079
verify that stat_info->request_uri is non null before doing string manipulations on it
so that we dont try to dereference a null pointer further down the code


svn path=/trunk/; revision=19153
2006-09-05 14:32:15 +00:00
Jaap Keuter db31d4a72f Fix for bug 1093, as proposed by Atsushi Fukumoto
svn path=/trunk/; revision=19152
2006-09-05 12:22:44 +00:00
Anders Broman 5c682dd6ee From Stephen Fisher:
A patch to bring the VNC dissector almost to completion.

I have not had a chance to finish the server message type "frame buffer 
update," which are the pixel values for screen rectangle updates.  
Everything else is there - tracking the keys the user is pushing, 
ringing a bell on the client, mouse button pushes/pointer movements, 
etc.

svn path=/trunk/; revision=19145
2006-09-05 05:38:11 +00:00
Guy Harris ee7166aff1 Declare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
used.

svn path=/trunk/; revision=19141
2006-09-04 23:20:52 +00:00
Anders Broman c99428334a Fix(?) bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
Does the string need to be freed ad destruction of the hashtable?

Surplus add_text removed.

svn path=/trunk/; revision=19139
2006-09-04 21:07:35 +00:00
Anders Broman 316453598a From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

svn path=/trunk/; revision=19136
2006-09-04 18:10:14 +00:00
Jaap Keuter 6f7f25b8d5 From Donald White:
First, the length of the header of a sub-frame may be miscalculated if
if the PID field is not present, but was present in a previous
sub-frame.  The calculation of the header length will use the value from
the previous sub-frame.

Second, correct the typo "ength" to "length".

Third, the length of the current sub-frame was not passed as the
reported length to a sub-dissector.  When the sub-dissector calls
tvb_reported_length(), the function returns the length of the complete
frame and not the length of the sub-frame to be dissected.

svn path=/trunk/; revision=19132
2006-09-04 14:12:26 +00:00
Martin Mathieson 76192b1c6c Partial implementation of UMTS FP. Currently only works with Catapult DCT2000 format files, as need extra information about packet when decoding. There are a few TODOs (notably E-DCH channels), but the current version gives OK coverage.
svn path=/trunk/; revision=19130
2006-09-04 11:04:14 +00:00
Ronnie Sahlberg 6e040b3a83 krb4 is a new style dissector and is called through a handle from krb5 which is also new style.
use call_dissector_only()  which is new-style aware and not call_dissector() which is not.

this fixes a recent bug found on the heimdal list.



svn path=/trunk/; revision=19129
2006-09-04 08:18:52 +00:00
Ronnie Sahlberg 389e7390e9 make the heuristics for detecting kerberos4 stronger
svn path=/trunk/; revision=19128
2006-09-04 07:44:30 +00:00
Ronnie Sahlberg c91f8d9876 From David Buechi
New protocol: epl v1


Hi,

in addition to the recently submitted dissector for the EPL v2 protocol,
this is the dissector for the first version of the EPL protocol.

Best Regards,
David




svn path=/trunk/; revision=19125
2006-09-02 23:18:38 +00:00
Ronnie Sahlberg e3c9fab51c add primitive reassembly of gssapi
this will allow reassembly of gssapi blobs that span multiple smb/sessionsetup command pdus



svn path=/trunk/; revision=19119
2006-09-02 11:46:15 +00:00
Guy Harris f1706bc27a Add a common routine for adding session IDs. Have it handle session IDs
from 1 to 8 bytes, and not only handle 0-byte session IDs as special,
have it handle session IDs > 8 bytes as special as well.

svn path=/trunk/; revision=19115
2006-09-02 06:38:21 +00:00
Guy Harris d6209d8dbe Add brackets to squelch a compiler warning.
Fix indentation.

svn path=/trunk/; revision=19114
2006-09-02 06:36:42 +00:00
Ronnie Sahlberg 8e830b8ef4 break out the handling of conversation specific data so that we will always have one such struct (and not an value pointer to an oid struct)
so that it is easier to attach other useage to the conversation specific state



svn path=/trunk/; revision=19113
2006-09-02 02:03:26 +00:00
Ronnie Sahlberg 62780fec5a resolve the oid to a variable before we check it in the conditional so that
we can add code to check that it looks sane (for better heuristics) when
we start adding GSS-KRB reassembly.

we need this for some transports such as SMB/SessionSetup that will transport GSS-KRB blobs inside multiple PDUs (multiple different SMB/SessionSetups) so we can reassemble the blobs before decoding them.


this probably only happens for SMB/SessionSetup   but the design of that command is so "nice" that you can not tell whether the blob is fragmented or not or how big it is supposed to be by looking at the SMB layer itself, one needs to know the BER length field for the BER APPLICATION tag. :-(

to make things worse, the only way match multiple such fragments together one will need not just the fragments from the SessionSetup requests  but also the UID that is returned in the response to the initial request.
perverse design.


lets assume that there will almost never be multiple sessionsetups on the same tcp session in real traces    so to make things easier just ignore the UID for now when reassembling. (well reassembly is not added yet but will be)




svn path=/trunk/; revision=19112
2006-09-02 00:43:19 +00:00
Ronnie Sahlberg 000182e09b remove a comment with dead code
remove three pointless volatile declarations


svn path=/trunk/; revision=19111
2006-09-02 00:24:31 +00:00
Ronnie Sahlberg 4c5987ce98 always create a conversation for gssapi
we will need a conversation in more places once we start adding reassembly of gss-krb blobs that span multiple pdus (smb/sessionsetup)



svn path=/trunk/; revision=19110
2006-09-02 00:17:35 +00:00
Anders Broman 8faa5f837c From Florent Drouin:
patch to implement the decoding of the GPRS reference. The specific oid for the CAP-GPRS-ReferenceNumber is attached to a decoding function in the camel module.

svn path=/trunk/; revision=19108
2006-09-01 16:17:48 +00:00
Ulf Lamping a0dbf3d7ac mark the "short segment" message field as generated and add an expert_info to it
svn path=/trunk/; revision=19106
2006-08-31 23:00:44 +00:00
Ulf Lamping 04f35c220a use an expert_info instead of an fprintf to show an undecoded message (fprintf won't work on windows as usually no console available)
svn path=/trunk/; revision=19105
2006-08-31 22:58:22 +00:00
Jörg Mayer b1719dd68f Albert Chin:
Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1078


svn path=/trunk/; revision=19103
2006-08-31 13:14:48 +00:00
Tomas Kukosa c5374442cf flags have only 1 byte
svn path=/trunk/; revision=19086
2006-08-30 10:03:50 +00:00
Tomas Kukosa eb86b80cf4 display Random as a single item with two subitems
svn path=/trunk/; revision=19084
2006-08-30 07:31:36 +00:00
Anders Broman f558e1491e Remove debugcode left by mistake...
svn path=/trunk/; revision=19083
2006-08-30 05:03:16 +00:00
Anders Broman eb8862e1ef Add CLNP over TCP over TPKT dissection. The port number is by default set to 0.
svn path=/trunk/; revision=19082
2006-08-29 22:18:39 +00:00
Jörg Mayer 5b99f21735 Florent DROUIN <florent.drouin@alcatel.fr>:
Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1077

svn path=/trunk/; revision=19074
2006-08-29 16:31:00 +00:00
Greg Morris a9e704bc96 Fixes and updated files:
File NCP2222.py:
1. Added NCP service type 0xffff = All types
2. Added evaluation of task states. (following bits are defined. 0=normal, 1 = TTS explicit transaction in progress, 2= TTS implicit transaction in progress, 4 = Shared file ste lock in progress)
3. Reversed the Volume Request Flags, this was backwards (s/b 0=do not return name with volume number, 1=Return name with volume number)
4. Fixed endianess of Creator ID in NetWare Information Struct.
5. File information structure incorrectly defined Current Block Being Decompressed.
6. Logical Lock Status structure incorrectly identified Task Number as a byte. It should be two bytes "word".
7. Fixed endianess of Modifier ID in NetWare Information Struct.
8. Fixed Name Space Information structure (was defined as Name Space, changed to Creator Name Space Number).
9. Fixed Semaphore Structure (Task Number was incorrectly defined as a byte, should be two bytes "word").
10. Added Task structure (Task Number, Task State)
11. Fixed Volume structure (incorrectly defined Volume Name)
12. Added VolumeWithName structure (This struct contains both volume number and volume name)
13. Added error 0x8901 - "No purgable files available"
14. Added error 0x8977 - "Buffer too small" 
15. Added error 0x899c - "No more trustees found"
16. Added error 0x89d9 - "Queue station is not a server"
17. Added NCP connection status values (0=Ok, 1=Bad service connection, 10=File server is down, 40=Broadcast Message Pending)
18. Fixed error definitions for NCP 22/50.
19. Fixed reply packet for NCP 22/52 to properly display volume information depending on reply struct, Volume or volume with name.
20. Fixed error definitions for NCP 22/52
21. Fixed NCP 23/26 reply packet to properly return internet address and display correctly.
22. Fixed NCP 23/27 Reply packet structure to properly repeat connection numbers array.
23. Fixed error definitions for NCP 23/33
24. Fixed NCP 23/114 Request (improperly defined Charge Information as a long value, s/b word)
25. Fixed NCP 23/120 Reply (Improperly defined Job Number as a long value, s/b word)
26. Fixed error definitions for NCP 23/123
27. Fixed error definitions for NCP 23/124
28. Fixed error definitions for NCP 23/131
29. Fixed error definitions for NCP 23/132
30. Fixed error definitions for NCP 23/135
31. Fixed error definitions for NCP 23/137
32. Fixed error definitions for NCP 23/138
33. Fixed NCP 23/205 Reply (User Login Allowed incorrectly defined as long value, s/b byte value)
34. Fixed NCP 23/234 Reply (Reply structure incorrectly defined based on old NCP documentation. Corrected per new docs)
35. Fixed endianess of NCP 23/237 Reply on value Number of Locks.
36. Fixed endianess of NCP 23/238 Reply on value Number of Locks.
37. Fixed error definitions for NCP 30
38. Fixed error definitions for NCP 36/6
39. Fixed error definitions for NCP 86/2
40. Fixed error definitions for NCP 86/3
41. Fixed error definitions for NCP 86/4
42. Fixed error definitions for NCP 86/5
43. Fixed error definitions for NCP 87/1
44. Fixed error definitions for NCP 87/4
45. Fixed error definitions for NCP 87/5
46. Fixed error definitions for NCP 87/10
47. Fixed error definitions for NCP 87/11
48. Fixed error definitions for NCP 87/12
49. Fixed error definitions for NCP 87/17
50. Fixed error definitions for NCP 87/18
51. Fixed NCP 87/20 Reply to properly decode multiple entries returned. This used to only dissect the first entry.
52. Fixed error definitions for NCP 87/30
53. Fixed NCP 87/33 Reply to properly utilize the request flags to dissect the reply packet NetWare Info Struct
54. Fixed error definitions for NCP 87/33
55. Fixed error definitions for NCP 88/22
56. Fixed error definitions for NCP 89/1
57. Fixed error definitions for NCP 89/10
58. Fixed NCP 89/11 Request packet structure
59. Fixed error definitions for NCP 89/11
60. Fixed NCP 89/20 Reply to properly decode multiple entries returned. This used to only dissect the first entry.
61. Fixed error definitions for NCP 104/5
62. Added undefined NCP 112
63. Fixed NCP 123/11 Reply to properly dissect FileName, Name, and copyright.
64. Fixed NCP 123/17 Reply to properly display NCP Network Address values.
65. Fixed NCP 123/24 Reply to properly display Driver Board Name, Driver Short Name, and Dirver Logical Name.
66. Fixed error definitions for NCP 123/33
67. Fixed NCP 123/60 to properly display Set Command Name and Set Command Value.
68. Fixed error definitions for NCP 123/70
69. Fixed NCP 123/71 Reply to utilize new File Information Struct
70. Fixed error definitions for NCP 123/71
71. Fixed error definitions for NCP 123/72
72. Added NCP 123/249
73. Added NCP 123/251
74. Added NCP 123/252
75. Added NCP 123/253
76. Added NCP 123/254
77. Added NCP 123/255
78. Fixed error definitions for NCP 131/1
79. Fixed error definitions for NCP 131/2
 
File packet-ncp2222.inc
1. Added new NCP preference setting to tell Wireshark to decode the NetWare information structure as new or old style.
2. Set default NCP preference settings of echo connection and echo file to FALSE.
3. Added NDS verb 2 Request Flags (0=retain old object, 1=delete old object)
4. Fixed problem where NDS fragmentation could not be reassembled on reload. (fragment array needed to be re-initialized on reload)
5. Fixed NCP service types 1111, 5555, bbbb, and 1111/LIP to reflect real type number. (Was defined as 0xf1, 0xf2, 0xf3, etc... Now defined as 0x1, 0x5, 0xb, etc)
6. Fixed function build_expert_data to parse subtree memory structures to acquire NCP request value records
7. Fix NDS attribute type Boolean to byte value and properly aligned.
8. Fixed attribute zendmSearchOrder to display properly regardless of number or order of value entries.
9. Added check of length of packet prior to attempting to defragment
10. Added for Request packets logic to abort if NCP type isn't found.
11. Added logic to store packet length and then manually decode NCP function 123 based on length.
12. Added logic to manually dissect NCP 87/20 and 89/20 reply packets.
13. NDS resolve name replies with remote entry as the specifier should not store the EID returned (0x00000000)
14. Added logic to trap and echo to expert tap when connection status flags indicate an error.
15. Added manual dissect of NCP 23/26 replies
16. Added logic to Capture the EID returned form NCP 22/51 "Get vol info".
17. Fixed NDS verb 0x2a
18. Fixed NDS verb 0x2b
 
File packet-ncp.c
1. Fix offset for packet signature. (This used to automatically set the offset to account for packet signature if it could not determine the correct NCP type. But for some failed fragment packets, retransmissions, etc, this would be wrongly identified. So first we check to see if we can read a valid type at the offset before we just automatically assume that packet signature is being used)
2. Register the new NCP preference for old/new NetWareInfoStruct.
 
File packet-ncp-int.h
1. Add extern declaration for ncp_newstyle setting.
2. Add length, req_mask, and req_mast_ext to ncp_req_hash_value structure
 
File packet-ncp-sss.c
1. Fix SecretStore request verb Write App Secrets, Client Put Data, to evaluate packet length.

svn path=/trunk/; revision=19073
2006-08-29 08:45:53 +00:00
Tomas Kukosa 10db04c78b get rid of few warnings
svn path=/trunk/; revision=19072
2006-08-29 08:33:52 +00:00
Gerald Combs 9257393ede Add a missing file.
svn path=/trunk/; revision=19071
2006-08-29 02:19:27 +00:00
Gerald Combs 95e1e5a790 Fix a typo.
svn path=/trunk/; revision=19068
2006-08-28 22:52:26 +00:00
Ulf Lamping 4ad1f977d2 add a new this/that flag value
svn path=/trunk/; revision=19066
2006-08-28 21:14:36 +00:00
Ulf Lamping 18b2bf8992 minor format string change
svn path=/trunk/; revision=19065
2006-08-28 21:13:37 +00:00
Ulf Lamping 72b1b767b3 add some more right-hand-side infos of the tower data
svn path=/trunk/; revision=19064
2006-08-28 21:12:44 +00:00
Jaap Keuter 6be339868d Fix length check for IP packets with options.
svn path=/trunk/; revision=19062
2006-08-28 19:15:08 +00:00
Jörg Mayer 79221e2d94 Donald White <donald_white@qwest.net>
There is a small bug in the function dissect_ppp() which prevents proper
demuxing of packets.  Patch is attached.



svn path=/trunk/; revision=19061
2006-08-28 16:55:03 +00:00
Greg Morris 736793fca9 Fix the decoding of SLP attributes. Open SLP has the ability to pass back multiple attribute types in each reply. Previously the dissector only would dissect address attributes. The change adds parsing of attributes and proper dissection of names and address attributes contained in the same reply payload.
svn path=/trunk/; revision=19060
2006-08-28 12:24:24 +00:00
Tomas Kukosa 539102ca60 - new function ssl_dissector_delete()
- register H.225.0 over TLS (configurable port 1300)
- register SIP over TLS (fixed port 5061)
- new function proto_tree_get_root()

svn path=/trunk/; revision=19059
2006-08-28 07:05:02 +00:00
Anders Broman c2bc366392 More release 6 changes.
svn path=/trunk/; revision=19058
2006-08-28 05:32:16 +00:00
Gerald Combs 8961a58ee1 Don't abort the entire program if we have bad data. Just mark the
packet as malformed and continue on our merry way.  This should fix
bugs 1064 - 1073.

Fix up whitespace.

svn path=/trunk/; revision=19057
2006-08-28 02:06:28 +00:00
Anders Broman 65267d932f Do some more of the relase 6 stuff.
svn path=/trunk/; revision=19056
2006-08-27 20:30:01 +00:00
Ulf Lamping 36d80b8c8b squelch some compiler warnings
svn path=/trunk/; revision=19052
2006-08-27 11:27:47 +00:00
Graeme Lunt 8618db09eb An octet string form of the ASO-qualifier used by some systems from the days when it was an ANY.
Really just an elaboration of the "...".


svn path=/trunk/; revision=19050
2006-08-27 09:03:21 +00:00
Graeme Lunt e05d92d07c Register tpkt as a dissector so subdissectors can register tpkt on ports other than 102.
svn path=/trunk/; revision=19049
2006-08-27 08:31:29 +00:00
Graeme Lunt 7428612ae0 Support for X.500 strong authentication - used by DAP, DISP, DSP and DOP.
svn path=/trunk/; revision=19048
2006-08-27 08:19:55 +00:00
Ronnie Sahlberg a5f6c6cdbf two more chunks
svn path=/trunk/; revision=19045
2006-08-26 12:26:19 +00:00
Ronnie Sahlberg 318b5d8e99 fix wrong constant in a valuestring
add two more chunks to be dissected


svn path=/trunk/; revision=19044
2006-08-26 11:57:28 +00:00
Ronnie Sahlberg 39d99904f8 initial PNG dissector (Portable Network Graphics)
svn path=/trunk/; revision=19042
2006-08-26 09:16:38 +00:00
Guy Harris 86c158a4db Don't define the Aironet/Cisco Wireless OUI ourselves; get it from
<epan/oui.h>.

Fix indentation.

svn path=/trunk/; revision=19038
2006-08-26 00:06:40 +00:00
Guy Harris 90a3563fa5 Fix some compiler warnings (some by getting rid of variables unused if
you don't have GNU TLS).

svn path=/trunk/; revision=19037
2006-08-26 00:05:26 +00:00
Guy Harris c0540294d7 Don't use %ld for guint64 - use PRIu64. (Also, don't use %d for guint32
- use %u.)

svn path=/trunk/; revision=19036
2006-08-26 00:03:59 +00:00
Ronnie Sahlberg 0899de4bd5 remove the code that conditionally dissects LG only if IG is set
svn path=/trunk/; revision=19034
2006-08-25 21:53:37 +00:00
Ronnie Sahlberg 19f3809cc6 from Stephen F
ethernet IG/LG bit changes   with minor modifications

(only dissect LG if it is a unicast address
 put a hint what locally administered means in the dissect tree
)
 


svn path=/trunk/; revision=19033
2006-08-25 21:33:23 +00:00
Tomas Kukosa 200da0f7e4 commit forgotten file
svn path=/trunk/; revision=19028
2006-08-25 11:28:00 +00:00
Guy Harris 3f7a918917 If the length of a GSS token is zero, it's a null token, and the opaque
data shouldn't be dissected.

svn path=/trunk/; revision=19027
2006-08-25 08:10:35 +00:00
Tomas Kukosa ce4e15b76d new ssl_dissector_add() function which can be called from another dissectors (similar to dissector_add())
svn path=/trunk/; revision=19026
2006-08-25 08:07:26 +00:00
Anders Broman 2976f89507 From Erwin Rol:
this patch adds support for MPEG2 transport stream packets in RTP (type 
MP2T). It currently dissects the headers of the MPEG2 packets

svn path=/trunk/; revision=19023
2006-08-25 05:49:37 +00:00
Gerald Combs 07f798ed37 Make sure a string pointer exists before we try to use it. Fixes bug 1050.
svn path=/trunk/; revision=19022
2006-08-24 22:05:26 +00:00
Anders Broman 0bcced5d2e BSSGP: Wrong length on IE and preparation to export IE dissection.
GSM_a: Add an if_def
GTP: Update comments

svn path=/trunk/; revision=19019
2006-08-24 21:19:49 +00:00
Anders Broman f265fad2bb From Jeff Morriss:
however there's a bug in the ANSI MAP dissector 
SSN preference code - it's deleting an ANSI SSN and adding an ITU one

svn path=/trunk/; revision=19018
2006-08-24 21:15:15 +00:00
Anders Broman 989fcb7656 Dissect 'User Location Information' IE and MS Time Zone' IE.
svn path=/trunk/; revision=19016
2006-08-24 17:27:45 +00:00
Jaap Keuter cfa1bda00b From Toralf Foerster (in bug 1044):
Add new primary sources, fix typo. 

svn path=/trunk/; revision=19007
2006-08-23 15:51:15 +00:00
Ronnie Sahlberg 8fe329094f testdrive the request/response README and implement request/response matching for DNS
svn path=/trunk/; revision=19003
2006-08-23 09:48:16 +00:00
Ronnie Sahlberg a3eedad0d1 Counter64 should be a FT_UINT64 and not a FT_UINT32
fixes bug 1047


svn path=/trunk/; revision=19002
2006-08-23 08:05:28 +00:00
Ronnie Sahlberg 70a01d80bf move the include for emem.h so that size_t is defined before emem.h is invoked
svn path=/trunk/; revision=19001
2006-08-23 07:41:43 +00:00
Anders Broman 51b64927e4 From David Buechi:
Add support for the ETHERNET Powerlink protocol

svn path=/trunk/; revision=18998
2006-08-22 19:55:31 +00:00
Gerald Combs 6ceaff43af From Florent Drouin:
I found a loop in the q2931 dissector, whereas I was dissecting Ranap
  Traces with a bad wireshark configuration.
  Wireshark did crash, after eating all the memory.

Make other loop checks more paranoid.

svn path=/trunk/; revision=18992
2006-08-22 14:46:51 +00:00
Martin Mathieson 875f1ce05e Fix iuup.delta FT_ type mismatch
svn path=/trunk/; revision=18991
2006-08-22 14:00:18 +00:00
Guy Harris a9469ccb31 Squelch a compiler warning.
svn path=/trunk/; revision=18988
2006-08-21 23:23:22 +00:00
Anders Broman 4e72c1ca2f From Florent Drouin:
This patch introduce the decoding of the RP-Cause element in the Release SMS message for Camel.

svn path=/trunk/; revision=18986
2006-08-21 21:58:30 +00:00
Anders Broman ba6eb01246 From Florent Drouin:
This patch provide a correction for the element "Channel Needed" in the Paging message. and some improvements for the display of AUTH,SRES,RAND etc..

With some further changes to APDU and LSA Identifier dissection.

svn path=/trunk/; revision=18985
2006-08-21 21:24:42 +00:00
Anders Broman abc11f9604 From Florent Drouin:
This patch allow to change the value of the SSN associated to the bssap dissector.

svn path=/trunk/; revision=18984
2006-08-21 21:19:48 +00:00
Ronnie Sahlberg 93c3a4026b prettify the MMS dissector by at least putting the pdu name in the info column
svn path=/trunk/; revision=18975
2006-08-21 13:44:37 +00:00
Ronnie Sahlberg ce1ae65e12 from Angel de Juan
make mms bitstrings easier to read


--
Hi, this is my new mms with some changes in order to display some data in
binary instead of hex.

Excuse me because is not a diff from the repository, but I don't know how to
create a diff.

I also have the compiled packet-mms.c and packet-mms.h if you want it only
mail me.



svn path=/trunk/; revision=18974
2006-08-21 13:32:07 +00:00
Ronnie Sahlberg 834647384c get rid of a rotating buffer
svn path=/trunk/; revision=18973
2006-08-21 13:05:18 +00:00
Ronnie Sahlberg 27924a4603 move a few arrays off the stack
svn path=/trunk/; revision=18972
2006-08-21 13:00:55 +00:00
Ronnie Sahlberg 3d5a81b7e9 remove two hashtables and replace with binary trees
svn path=/trunk/; revision=18971
2006-08-21 12:41:59 +00:00
Martin Mathieson bd6931e2d3 Use FT_UINT_STRING for TBCP DENY reason-phrase
svn path=/trunk/; revision=18968
2006-08-21 11:41:32 +00:00
Anders Broman 43d1b4c099 Dissect some more H.245 messages in MEGACO
svn path=/trunk/; revision=18966
2006-08-20 21:18:43 +00:00
Ronnie Sahlberg cf6d4692aa in LDAP over TCP
use tcp_dissect_pdus() which works    insterad of trying to do the pdu tracking and signalling for reassembly manually.
This makes ldap pdu tracking and reassembly work properly for cases when hosts are streaming lpad over tcp and there is little or none alignlemt of pdus to the start of a segment



svn path=/trunk/; revision=18965
2006-08-20 06:00:16 +00:00
Ronnie Sahlberg 0adb40dbc0 we have to search for multisegments starting PRIOR to the start of the current semgent or elsae it will break for the case when one multisegment ends in this segment there are a few smaller ones completely within this segment and then another segment starts that spans across future segments.
svn path=/trunk/; revision=18964
2006-08-20 05:18:10 +00:00
Ronnie Sahlberg c0e5ca30ad add some well known rids from s4 security.idl and code to show the name of this rid
when dissecting a security descriptor


svn path=/trunk/; revision=18959
2006-08-19 09:22:20 +00:00
Guy Harris f4457669d3 Fix some g_warning() calls.
svn path=/trunk/; revision=18958
2006-08-19 03:01:53 +00:00
Guy Harris 7cb6f60b18 Fix some format strings and format string arguments.
svn path=/trunk/; revision=18957
2006-08-19 03:01:15 +00:00
Guy Harris 8a3af12c87 Define "char_def_alphabet_ext_decode()" with a return type - and define
it as static as it's not used outside this file.

svn path=/trunk/; revision=18955
2006-08-19 02:58:48 +00:00
Guy Harris 338f7ede99 Squelch a compiler warning.
svn path=/trunk/; revision=18954
2006-08-19 02:56:16 +00:00
Gerald Combs 7bded1f0ee Fix CID 209 (possible NULL dereference).
svn path=/trunk/; revision=18950
2006-08-18 20:18:38 +00:00
Gerald Combs f95cb7af5c Add an attribution.
svn path=/trunk/; revision=18948
2006-08-18 15:46:43 +00:00
Ronnie Sahlberg b588469ccf guids are not olnly used in dcerpc interfaces and they often occur in many other protocols such as ldap and smb/smb2
move the initialization of the guid mapping table from the dcerpc dissector to a more neutral place


svn path=/trunk/; revision=18947
2006-08-18 09:32:19 +00:00
Ronnie Sahlberg d6ba4c112c from stephen f
new protocol: veritas low latency transport

---
Attached is a patch file that adds a new dissector for the LLT protocol
(Veritas Low Level Transport, used for server clustering).  They use
ethertype 0xCAFE even though it isn't assigned to them :(.  There are
other fields and possibly other message types directly between servers
it does not yet dissect as no one outside of Veritas knows what they
are.  This dissector understands the one people will run across most -
multiple servers broadcasting these heartbeats all over the place.  I
figured out these fields through many Internet searches.

I will add the protocol to the Wiki after it is committed.


Thanks,
  Steve




svn path=/trunk/; revision=18944
2006-08-18 08:46:31 +00:00
Gerald Combs 0e5e0c4453 Fix two remaining off-by-one errors. Remove a static buffer.
svn path=/trunk/; revision=18943
2006-08-18 00:22:48 +00:00
Anders Broman a870534df9 From Stephen Fisher:
the attached patch removes the 
redundant "Cisco Discovery Protocol" from the info column:

Before:

  Cisco Discovery Protocol  Device ID: myswitch.domain.com  Port ID: GigabitEthernet3/17

After:

  Device ID: myswitch.domain.com  Port ID: GigabitEthernet3/17

svn path=/trunk/; revision=18941
2006-08-17 20:32:06 +00:00
Anders Broman d221d6f2fc From Hannes Gredler:
A patch that adds support for dissection of
libpcap DLT_JUNIPER_VP frames. In addition i have fixed
also the indent for DLT_JUNIPER_GGSN.

svn path=/trunk/; revision=18940
2006-08-17 20:24:05 +00:00
Ulf Lamping 7d04019388 some further work on the GUID/UUID resolvings
most of the relevant code moved to guid_utils
lot of corresponding code cleanup in packet-dcerpc.c
still using GHashTable
still not using a manuf like file

svn path=/trunk/; revision=18939
2006-08-17 19:09:41 +00:00
Jörg Mayer 162d87a516 Muthu Krishnan V <muthukrishnanv@gmail.com>
As per RFC 4090, In the FAST_REROUTE Object, Include-any starts
at the 12th byte and Exclude-any starts at the 16th byte.

Ethereal has inter-changed these two fields in its display.

*Ethereal* bug 1043.

svn path=/trunk/; revision=18938
2006-08-17 11:56:35 +00:00
Ronnie Sahlberg c7250199a7 add missing _WIN32 encapsulation so braces match and compilation under non-win32 works
svn path=/trunk/; revision=18936
2006-08-17 07:35:58 +00:00
Ulf Lamping de0594b9a5 various UUID/GUID based changes.
I think I've changed all corresponding appearances from FT_STRING to FT_GUID, so assert the FT_ type as it should only be a FT_GUID now.

Add a generic implementation in guid_utils.h to have a way to store data about GUID to name resolving (something like value_string for e.g. int). It might be better to have a single registry for all GUID's of all dissectors and implement the GUID name resolving into the proto_tree_add... functions.

svn path=/trunk/; revision=18935
2006-08-16 23:13:26 +00:00
Ulf Lamping eb7c653073 FT_STRING -> FT_GUID
svn path=/trunk/; revision=18934
2006-08-16 22:59:55 +00:00
Ulf Lamping 2ed79a23f1 lower the expert info levels WARN -> NOTE for missing references
fix an iteration bug in cba_connection_disconnectme()

svn path=/trunk/; revision=18933
2006-08-16 22:56:55 +00:00
Ulf Lamping f17222a893 FT_STRING -> FT_GUID
svn path=/trunk/; revision=18931
2006-08-16 20:55:21 +00:00
Ulf Lamping 3ec210b0d1 Don't mark a TCP packet as a "Duplicate ACK" if the flags don't have the ACK flag set (IMHO it's not an ACK in that case). This happens sometimes between FIN and RST packets.
Ronnie, could you check if this change is ok?

svn path=/trunk/; revision=18930
2006-08-16 20:52:51 +00:00
Ronnie Sahlberg 58396f47da add tracking of fid type to objects opened by NT CREATE so that we can dissect aces properly also for these fids
svn path=/trunk/; revision=18929
2006-08-16 19:38:39 +00:00
Gerald Combs f9661850d1 Add support for AirPcap, an upcoming wireless product from CACE. Support
is disabled by default, and can be enabled by setting AIRPCAP_CONFIG
in config.nmake.  The code is currently limited to Windows, but should
be adaptable to other platforms.

The official announcement won't come until next week, so you'll have to
read the source for details.  :)

svn path=/trunk/; revision=18928
2006-08-16 18:01:25 +00:00
Ronnie Sahlberg b02d08fa76 use the same structure to pass the fid type information from nt transaction parameter to nt transaction data dissector for both ssd and qsd instead of two different ones
svn path=/trunk/; revision=18927
2006-08-16 10:35:04 +00:00
Ronnie Sahlberg d08c190fe0 track fid types between NT TRans QUERY_SECURITY_DESCRIPTOR and dissect the ACEs properly
svn path=/trunk/; revision=18926
2006-08-16 09:22:36 +00:00
Ronnie Sahlberg 80e1ff0ee8 add dissection of DIRECTORY specific bits of the accessmask for SET_SECURITY_DESCRIPTOR
svn path=/trunk/; revision=18925
2006-08-16 09:02:15 +00:00
Ronnie Sahlberg 3c6d1fcef8 add code to dissect FILE specific bits for the accessmask inside a security descriptor and have SET_SECURITY_DESCRIPTOR use it so that security descriptors for files held inside SET_SECURITY_DESCRIPTOR are decoded properly
svn path=/trunk/; revision=18924
2006-08-16 08:48:00 +00:00
Tomas Kukosa 5ff34d332b - add value_ptr into struct _asn1_ctx_t
- small changes in h225.cnf
- H.225 regenerated

svn path=/trunk/; revision=18923
2006-08-16 08:07:30 +00:00
Ronnie Sahlberg 0902016b42 add a type field for the fid tracking structure and initialize it to UNKNOWN
when files are opened using NTCreateAndX  and if we recognize the type   set the type field to either FILE, DIR or PIPE

This is useful to know when dissecting things like security descriptors since it tells us how to dissect the specific bits of the access mask.


Only do this for NTCreateAndX for now.   It is trivial to add similar tracking to some of the older   obsolete   calls used to open fids    but no clients ever use those old calls any more.





svn path=/trunk/; revision=18922
2006-08-16 08:00:46 +00:00
Tomas Kukosa 5cd8c719e6 ASN.1 dissectors regenerated with new asn2wrs to get updated field blurb
svn path=/trunk/; revision=18921
2006-08-16 05:58:39 +00:00
Jörg Mayer c5bf44c6ad Always print length as well as type in Option line.
Count amount of padding.


svn path=/trunk/; revision=18920
2006-08-16 00:12:02 +00:00
Jörg Mayer d9f56b9080 Steve Karg <skarg@users.sourceforge.net>
I made a small change in packet-bacapp.c to fix the following:
1. Corrected Signed value decoding for a one octet value.
2. Corrected Priority values to decode as Unsigned values.


svn path=/trunk/; revision=18918
2006-08-15 20:46:13 +00:00
Jörg Mayer 591167281e Complete: Make dhcp options filterable
svn path=/trunk/; revision=18916
2006-08-15 20:32:08 +00:00
Gerald Combs a0f21609b8 Fix CIDs 204 - 208.
svn path=/trunk/; revision=18915
2006-08-15 19:28:07 +00:00
Jörg Mayer b58714b375 Eric Fung <efung@certicom.com>
A very tiny patch that corrects decoding of the Next Payload field in
the IKEv2 header. RFC 4306, Sec 3.2 says that a payload type of 0
means "No Next Payload" and not RESERVED. The patch just uses the
same string the dissector uses for IKEv1, namely, "NONE".


svn path=/trunk/; revision=18914
2006-08-15 18:16:56 +00:00
Jörg Mayer 24f77cfbf5 Mike Duigou <wireshark@duigou.org>
The enclosed patch updates the set of mime types for line oriented text
data per RFC 2046.

Me:

Remove application/postscript, as it may be binary.

svn path=/trunk/; revision=18913
2006-08-15 18:13:35 +00:00
Jörg Mayer 9c53d1894b Start making dhcp options filterable (special cases still missing)
svn path=/trunk/; revision=18912
2006-08-15 13:24:02 +00:00