Commit Graph

4116 Commits

Author SHA1 Message Date
Michael Tüxen fe5f26af7b Register the dissector.
svn path=/trunk/; revision=19609
2006-10-19 17:25:13 +00:00
Guy Harris 1fbb567ebe Fix a compiler warning (about a real problem).
svn path=/trunk/; revision=19605
2006-10-19 09:14:27 +00:00
Guy Harris ed8b50ba3f Fix some compiler warnings (about real problems).
svn path=/trunk/; revision=19604
2006-10-19 09:12:28 +00:00
Jaap Keuter 7ded21f336 Squelch compiler warnings
svn path=/trunk/; revision=19597
2006-10-18 19:42:10 +00:00
Jaap Keuter a3f017648f From Shaun Jackman
The RDM protocol has been accepted as ANSI standard E1.20-2006. The following patch updates the decoder to that spec. 
At the same time it is promoted to a build-in dissector.

svn path=/trunk/; revision=19596
2006-10-18 19:29:05 +00:00
Gerald Combs fc62f98e74 In the 802.11 dissector, mark the "wep_keys" preference as obsolete,
and replace it with an "enable_decryption" preference.

Instead of forcing the user to specify how many WEP keys we have,
figure it out for ourselves by parsing the key list.  When decrypting,
don't worry about the key index specified in the header (which resulted
in trying to decrypt using the same key twice); simply try each key in
order (which we were doing anyway).

In hex_str_to_bytes(), handle a null hex string.

Update the release notes.

svn path=/trunk/; revision=19592
2006-10-18 17:55:29 +00:00
Ronnie Sahlberg b3301320c1 add dissection of DATA IN/OUT and SCSI RESPONSE to the usb mass storage dissector
svn path=/trunk/; revision=19590
2006-10-18 12:00:38 +00:00
Ronnie Sahlberg 232e884ca1 new dissector : usb mass storage
this is a wrapper protocol to store SCSI frames inside usb bulk data transfers

the dissector is far from complete but does
track ITL and ITLQ structures and will also call the SCSI dissector to 
dissect the SCSI CDB.


what is still missing is handling of data in/out and scsi responses


at least it will now display the SCSI CDB and dissect it. woohoo



svn path=/trunk/; revision=19589
2006-10-18 11:24:03 +00:00
Ronnie Sahlberg 6a75fbab65 create a dissector table for the bulk input/output packet types
svn path=/trunk/; revision=19588
2006-10-18 09:30:28 +00:00
Ronnie Sahlberg df75f29284 move some defines to packet-usb.h so that they can be shared with other dissectors
svn path=/trunk/; revision=19587
2006-10-18 09:10:14 +00:00
Anders Broman 5243edd737 Add part of E.5 Basic DTMF Generator Package
svn path=/trunk/; revision=19586
2006-10-18 05:45:52 +00:00
Ulf Lamping 195144a85e llc_add_oui() wants a pointer, not a pointer pointer
svn path=/trunk/; revision=19585
2006-10-18 00:22:23 +00:00
Ronnie Sahlberg 638f9eced7 now when we do dissect the descriptors:
add tracking so that when we find an interface descriptor which tells us the device class we also create a conversation for each and every endpoint for that interface and also let all conversations (one for each endpoint) share the same usb conversation info structure.


store the device type inside this conv_info structure


add the required code to manage BULK data pdus and have it for now only display what kind of bulk data is contained (interface class as snooped from the descriptors)



we now only need a class dissector table we can fork off into from the bulk dissector in usb    and then an external usb_masstorage dissector that registers itself as a mass storage device and we should be all set to dissect the scsi layer being transported atop usb





svn path=/trunk/; revision=19575
2006-10-17 13:40:26 +00:00
Tomas Kukosa cd92272ac9 debug trace at beginning of each packet
do not call subdissector for empty application data

svn path=/trunk/; revision=19574
2006-10-17 13:29:44 +00:00
Ronnie Sahlberg 5bbcf2e2ca add a define for the "no endpoint" constant used to represent unknown or host side endpoint used for conversations
ansp provide the desired port/endpoints in the call to get/create a conversation   so that we later when we see the a descriptor that says   Endpoint X is using class Y
we need tis to register that certain endpoints are used for mass storage
(or other applications)


svn path=/trunk/; revision=19573
2006-10-17 09:14:16 +00:00
Jörg Mayer ccca31102b Stephen Fisher:
Please apply the attached patch to improve the WLCCP dissector.  I have
also finished merging in packet-cisco-wireless.c, so it can be deleted.


svn path=/trunk/; revision=19572
2006-10-17 08:59:01 +00:00
Tomas Kukosa e1e18ea393 update Timestamps Option labels in accordance with RFC1323
svn path=/trunk/; revision=19570
2006-10-17 06:01:54 +00:00
Anders Broman d5cee1152d Add A.8 Basic call progress tones generator with directionality
svn path=/trunk/; revision=19569
2006-10-17 05:40:58 +00:00
Ulf Lamping 0c23562511 fix #1135: another "off by one" bug, zero termination was done twice, second time writing behind the end of the available buffer
svn path=/trunk/; revision=19566
2006-10-16 23:13:21 +00:00
Gerald Combs 2e28e9fd13 Make sure a value is non-null before we feed it to strcmp(). Fixes bug
1134.

svn path=/trunk/; revision=19560
2006-10-16 18:44:43 +00:00
Ronnie Sahlberg 40ee68e3d4 correct the little / big endian comment
svn path=/trunk/; revision=19558
2006-10-16 14:54:20 +00:00
Ronnie Sahlberg 2cb017d84f dissect a lot more of the descriptors so that we can finally see which endpoints are used for what purpose
svn path=/trunk/; revision=19557
2006-10-16 14:43:35 +00:00
Jörg Mayer a32f396008 Display the skipped 4 bytes from the header as setup (see
struct usb_header). Just display it as a big endian number
(I don't have a spec at hand).


svn path=/trunk/; revision=19556
2006-10-16 14:24:24 +00:00
Ronnie Sahlberg ff7e652235 break finding/creating a conversation out into its own helper (which makes it easier later when we find an endpoint description that tells us some other endpoint is used for massstorage)
implement some more descriptors


svn path=/trunk/; revision=19555
2006-10-16 13:42:59 +00:00
Ronnie Sahlberg af000bdaa6 Finish dissection of GET DESCRIPTOR for the devicetype: DEVICE.
This dissector should be extended to dissect all other descriptors for all other device types as well.





svn path=/trunk/; revision=19554
2006-10-16 10:33:46 +00:00
Ronnie Sahlberg c5480555fd add some variables to the task structure so that we can pass TYPE/INDEX from the GET DESCRIPTOR request to the response dissector
(we need this in order to know how to dissect the response?)



svn path=/trunk/; revision=19553
2006-10-16 08:47:48 +00:00
Anders Broman dc10ba22e6 Fix Event dissection which was broken when going to V3.
and add a few parameters.

svn path=/trunk/; revision=19544
2006-10-15 22:11:26 +00:00
Anders Broman 6c0254b1cb Upadte to H.248 V3 and add some annex E parameters.
svn path=/trunk/; revision=19543
2006-10-15 16:06:02 +00:00
Jörg Mayer b9582da89f - gcc dies on "default: }", add a ;
- proto_register usb instead of eth.

svn path=/trunk/; revision=19542
2006-10-15 12:27:51 +00:00
Ronnie Sahlberg d0bea0954e populate the info column with the request type and whetehr it is a request or a response
svn path=/trunk/; revision=19541
2006-10-15 08:21:56 +00:00
Ronnie Sahlberg a78a49b057 add tracking of request/responses for CONTROL INPUT so we can start passing parameters from request to response and dissect response data
svn path=/trunk/; revision=19540
2006-10-15 08:12:41 +00:00
Ronnie Sahlberg 714ce64b12 add a new port type for usb endpoints
start introducing conversations to the usb dissector so that we can start tracking requests/responses
which we need to in order to dissect for example the data returned by a device to a GET DESCRIPTORS call



svn path=/trunk/; revision=19539
2006-10-15 06:10:59 +00:00
Ronnie Sahlberg 077e03a549 start dissecting the setup headers
dissect GET DESCRIPTOR as an example on how to add such dissectors


svn path=/trunk/; revision=19538
2006-10-15 03:49:27 +00:00
Ronnie Sahlberg c56d0ab3af more serviceactions
svn path=/trunk/; revision=19537
2006-10-15 02:54:08 +00:00
Ronnie Sahlberg ba6507c460 some more service actions
svn path=/trunk/; revision=19536
2006-10-14 22:45:07 +00:00
Ronnie Sahlberg 187454bf8a dissect some more osd service actions
svn path=/trunk/; revision=19535
2006-10-14 22:31:27 +00:00
Ronnie Sahlberg 26e2395f1d if reassembly did not give us a new tvb, then dont call any scsi payload subdissector
svn path=/trunk/; revision=19534
2006-10-14 22:05:57 +00:00
Guy Harris aa60f5a539 Fix a compiler warning by doing what I suspect was intended.
svn path=/trunk/; revision=19533
2006-10-14 20:18:10 +00:00
Guy Harris 196bb24bdd Do the suboption processing in dissect_netware_ip_suboption() a bit more
like the way it's done in other suboption dissectors.

Fix a typo.

svn path=/trunk/; revision=19532
2006-10-14 20:17:14 +00:00
Ronnie Sahlberg 3d0788951a add dissection of FLUSH and FLUSH COLLECTION
svn path=/trunk/; revision=19529
2006-10-14 11:25:38 +00:00
Ronnie Sahlberg ebfc131d81 implement WRITE and CREATE COLLECTION
svn path=/trunk/; revision=19528
2006-10-14 10:52:50 +00:00
Ronnie Sahlberg cfaf149ae8 rename some fields in the setup blob to use the same names as in the standard
add dissection of the bmRequestType bitmap



svn path=/trunk/; revision=19527
2006-10-14 10:09:32 +00:00
Ronnie Sahlberg f1f76a1817 put the packet type in the summary line
svn path=/trunk/; revision=19526
2006-10-14 09:43:17 +00:00
Ronnie Sahlberg 2b13206239 set both read/write flags in ndmp scsi and also always set the expected length to whatever length is transported inside the ndmp pdu
this fixes a regression caused by the recent scsi data in/out reassembly code which made the scsi dissector fail to dissect data in/out over ndmp correctly if scsi reassembly was enabled



svn path=/trunk/; revision=19525
2006-10-14 09:18:24 +00:00
Ronnie Sahlberg 24ef4fcef0 create a new address type AT_USB and start populating the packet list
with nice data




svn path=/trunk/; revision=19524
2006-10-14 05:02:40 +00:00
Ronnie Sahlberg 057c7a0555 let SCSI reassembly default to FALSE
put "reassembled in" in the summary line

put the fragment list at the top of the tree instead of down inside the SCSI expansion



svn path=/trunk/; revision=19523
2006-10-14 01:44:29 +00:00
Ronnie Sahlberg 91ff6ddaf4 add scsi data reassembly
svn path=/trunk/; revision=19519
2006-10-13 22:25:35 +00:00
Ronnie Sahlberg 02ea9c5608 check the estinated data transfer length for the current transfer and start adding checks for scsi data reassembly
svn path=/trunk/; revision=19518
2006-10-13 21:26:03 +00:00
Ronnie Sahlberg 9768637878 dont call the scsi data in/out dissectors unless data offset is 0 i.e. the beginning of data in/out
svn path=/trunk/; revision=19517
2006-10-13 21:07:07 +00:00
Anders Broman c1bc224c9e Set properties.
svn path=/trunk/; revision=19515
2006-10-13 17:04:16 +00:00
Gerald Combs e000e1c8ec Make the "WEP key count" option match the number of WEP key slots. Add
a note about improving the WEP key interface.

svn path=/trunk/; revision=19514
2006-10-13 15:53:20 +00:00
Ronnie Sahlberg 8826c144f7 pass the relative data offset of data in/out pdu's to the scsi data in/out dissector (dissect_scsi_payload) so that we can later add reassembly of data pdu's
and also (if reassembly is disabled) only dissect the initial (offset==0) data pdu.

dissect_scsi_payload() does not yet use this parameter.


now that we have both data offset and expected data length/bidir expected data length and also the read/write flags availabe we have what we need to reassemble data in/out pdus    (modulo overflow/underflow  but those are so rare we can worry about them later).


ndmp:   ndmp conceptually always has a data in and a data out phase and never fragment the data into smaller pdu's os that dissector always report offset as 0.





svn path=/trunk/; revision=19511
2006-10-13 09:16:45 +00:00
Ronnie Sahlberg d516bcbb78 if FC type is FPC/SCSI and the relative offset bit is set in f_ctl then the parameter field is 4 bytes and contain the relative offset of the data for data in/out
decode this field as relative offset   and also store it in the fc_hdr structure so that FCP can pick it up and pass if to the SCSI payload data in/out dissector later




svn path=/trunk/; revision=19510
2006-10-13 08:42:33 +00:00
Jaap Keuter 643c6f1bfd Add 802.1QinQ Ethertype preference.
svn path=/trunk/; revision=19508
2006-10-12 21:31:00 +00:00
Gerald Combs 44318bc1f1 Check to see if we've passed a null strval to ndps_string().
Should fix the recent fuzz bugs.

svn path=/trunk/; revision=19506
2006-10-12 15:00:07 +00:00
Ronnie Sahlberg 15d3176063 wireshark does not yet consume enough memory for me to be happy
pass conversation form the transports up to the scsi layer

add tracking of conversation specific info to scsi osd
add tracking of conversation+lun specific info to scsi osd

for scsi osd   add tracking of PARTITIONS and display in which frame they were created/removed



svn path=/trunk/; revision=19505
2006-10-12 10:54:36 +00:00
Jaap Keuter 804bed87e6 From Paolo Abeni:
The attached patch fix parsing of the setup header in the usb dissector.
Currently the size of the field specified into proto_tree_add_item call
was wrong.

svn path=/trunk/; revision=19503
2006-10-12 08:04:11 +00:00
Jaap Keuter 8f44a5ef69 Adding initial version of UDLD dissector
svn path=/trunk/; revision=19501
2006-10-12 06:01:51 +00:00
Ronnie Sahlberg 2f6fb1fe7f From Patrick vd Lageweg
Hi,

This patch makes several bit fields in the LOG SELECT command being displayed as bits instead of as numbers.



svn path=/trunk/; revision=19497
2006-10-11 20:05:27 +00:00
Ronnie Sahlberg 10893e51d7 From Patrick vd Lageweg
Hi,

This patch fixes the page number user for the "write error couner page".






svn path=/trunk/; revision=19496
2006-10-11 20:03:44 +00:00
Ronnie Sahlberg d8a8ec9b36 From Patrick vd Lageweg
Hi,

This patch impelments a dissect for the SCSI SSC Medium Partition Page.


Patrick


svn path=/trunk/; revision=19495
2006-10-11 20:00:43 +00:00
Guy Harris 69ab0c473b Use a different heuristic to determine whether an NDPS string is ASCII
or Unicode, and use tvb_get_ephemeral_faked_unicode() to get Unicode
strings; this fixes problems I've seen in captures, where the string
isn't being processed correctly.

svn path=/trunk/; revision=19494
2006-10-11 17:01:51 +00:00
Ronnie Sahlberg 145d7a0577 add a task_flags bitmap and two lengths (data and bidirectional data)
so that the two scsi transports   FCP and ISCSI can provide the expected data transfer lengths to SCSI  to allow SCSI reassembly.

NDMP does not really need these hints since for NDMP (and also iscsi-lite) there is conceptually always both data in and data out phases and there is never any fragmentation.



svn path=/trunk/; revision=19493
2006-10-11 11:32:56 +00:00
Ronnie Sahlberg 494e873eb0 move the ITL and the ITLQ structure to packet-scsi.h where it belongs
svn path=/trunk/; revision=19492
2006-10-11 10:38:59 +00:00
Ronnie Sahlberg 72817cf7bd from Paolo A
update the usb dissector to reflect the recent change in the pcap format


svn path=/trunk/; revision=19491
2006-10-11 09:47:27 +00:00
Ronnie Sahlberg daa7210867 fix for 1148
pretty horrible hack to store an ntlmssp blob inside an ldap string

the info column is not entirely pretty but   the payload is at least decoded


svn path=/trunk/; revision=19490
2006-10-11 08:18:14 +00:00
Ulf Lamping d099129659 fix #1154: although g_vsnprintf() is called, it don't like a NULL pointer for a %s format string. The following proto_tree_add_text was already fixed.
svn path=/trunk/; revision=19489
2006-10-11 07:31:01 +00:00
Anders Broman c16a3fa90a From Donald White:
An enhancement to the PPP multiplexing protocol 
dissector in protocol-ppp.c.  There are two changes:

     The protocol id field of the multiplexed sub-frame is added
     to the protocol tree using a header field.  This allows
     filters to select the protocol as is the case when it is not
     multiplexed.  I think this fixes a small bug as the ability to
     filter for a protocol should not depend on the lower level
     protocol.

     When the protocol id of the subframe is not present, the
     appropriate default protocol is displayed with the standard
     indication that Wireshark generated the value.

svn path=/trunk/; revision=19488
2006-10-11 06:11:54 +00:00
Gerald Combs b07b29f711 Simplify the preference string allocation code. Shorten the comments,
which (as Ulf pointed out) reduces the size of the prefs file
significantly.

svn path=/trunk/; revision=19486
2006-10-10 22:46:58 +00:00
Anders Broman d307493eb5 Fix a typo.
svn path=/trunk/; revision=19485
2006-10-10 21:56:10 +00:00
Anders Broman 9d005246c1 Add H.248 packet BCP dissecton.
svn path=/trunk/; revision=19484
2006-10-10 21:52:52 +00:00
Anders Broman c1d78e08ed Remove no longer used files.
svn path=/trunk/; revision=19483
2006-10-10 21:50:19 +00:00
Anders Broman cec6d51774 u_int32_t gives error on Windows assuming guint32 will do.
svn path=/trunk/; revision=19482
2006-10-10 21:46:44 +00:00
Ronnie Sahlberg 26f642778f From Paolo Abeni
USB dissector


svn path=/trunk/; revision=19480
2006-10-10 21:00:35 +00:00
Guy Harris e9a7c32e2d Squelch a compiler warning.
svn path=/trunk/; revision=19474
2006-10-10 08:12:04 +00:00
Guy Harris 51a426a4ca Clean up some compiler warnings.
svn path=/trunk/; revision=19473
2006-10-10 08:10:42 +00:00
Guy Harris badda625ae Get rid of an unused variable.
svn path=/trunk/; revision=19472
2006-10-10 08:09:11 +00:00
Guy Harris 9890b823f4 Get rid of CR's at the ends of lines, set svn:keywords and svn:eol-style
appropriately.

svn path=/trunk/; revision=19469
2006-10-10 07:35:47 +00:00
Gerald Combs 4e1d2cd8a9 Remove a leftover printf.
svn path=/trunk/; revision=19468
2006-10-10 00:30:49 +00:00
Gerald Combs 993305a75f First step in integrating the AirPcap WEP preferences with those
from the 802.11 dissector.  Use a #define for the maximum number of
WEP keys.  Use AirPcap's if we have it (64).  Rename find_module()
prefs_find_module() and make it public.

svn path=/trunk/; revision=19467
2006-10-10 00:28:53 +00:00
Ronnie Sahlberg 01b065893e From Joe Breher
dissect the permission bits in the capability blob



svn path=/trunk/; revision=19462
2006-10-09 19:35:36 +00:00
Ronnie Sahlberg dfc0a65002 from Joe Breher
This patch fixes a transposition of the orders of
Set Attribute Number
Set Attribute Length
In the page oriented get and set attributes CDB parameters format
Ref SCSI-OSD T10/1355-D Revision 10 section 5.2.2.2





svn path=/trunk/; revision=19460
2006-10-09 08:31:04 +00:00
Anders Broman ed0cf1e0bb H248:
Lost a line in last commit.

ISUP Export a value string.

svn path=/trunk/; revision=19454
2006-10-08 20:57:20 +00:00
Ronnie Sahlberg daed1f10cd add some more SCSI OSD command dissectors
REMOVE
REMOVE PARTITION
REMOVE COLELCTION
SET KEY


svn path=/trunk/; revision=19453
2006-10-08 19:54:01 +00:00
Ronnie Sahlberg 0eb3023c5f dissect attribute get/set data in data in/out blobs and display them for now as a blob.
svn path=/trunk/; revision=19452
2006-10-08 19:11:39 +00:00
Jaap Keuter f9e196db54 Fix for bug 1153, typos in debug output
svn path=/trunk/; revision=19451
2006-10-08 07:54:06 +00:00
Ronnie Sahlberg 08421ffc74 scsi osd
collapse attripute parameters, capability and security parameters into subtrees to make the display easier to read


svn path=/trunk/; revision=19450
2006-10-08 04:48:24 +00:00
Ronnie Sahlberg 4d6a65270b scsi: unusual scsi protocols can request multiple AHS fields for iscsi so decode the AHS properly instead of assuming at most one field is present
scsi-osd   add dissection of  LIST data pdus  and  CREATE cdb


svn path=/trunk/; revision=19449
2006-10-08 04:13:18 +00:00
Jörg Mayer 7cf6ac9327 Stephen Fisher:
packet-cisco-wireless.c is actually trying to dissect WLCCP:

I have attached a dissector I wrote from scratch for the
frames that I'm seeing.  It has #defines for the field offsets and
lengths so it should be easier to merge.  I also attached a sample
capture with one of the frames that I'm seeing.  There are more fields
in the frame I haven't yet figured out, hopefully your dissector has
those that I'm missing.

Me: - Commented in wlccp over udp as well, it works most of the time.
    - Leave the file packet-cisco-wireless.c in for the time being to
      copy over knowledge until no usable info is left in the file.

svn path=/trunk/; revision=19447
2006-10-07 14:48:04 +00:00
Anders Broman 1785428d4c Add a few packages and fix dissecton of a_codecs and handle the case when
hf_param = -1.

svn path=/trunk/; revision=19445
2006-10-06 19:48:00 +00:00
Jaap Keuter 004cb06d90 From Aaron Campbell:
The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always
evaluate to 1.  As well, neither of these constants are defined as flag
values, so a bitwise op was probably not intended either.

svn path=/trunk/; revision=19444
2006-10-06 19:18:55 +00:00
Martin Mathieson 60193f0ae7 Make IPPrim based addresses filterable (mirroring ip/udp/tcp filter names).
Add some if (tree) tests to try to avoid doing extra work (large FP captures can be very slow to load).

svn path=/trunk/; revision=19439
2006-10-05 14:10:10 +00:00
Jaap Keuter 52499b3dd4 Patch in bug 1149, adds DCE-style flag for gss-api
svn path=/trunk/; revision=19438
2006-10-05 11:35:41 +00:00
Anders Broman 1677b21838 Added the possibillity of Statistic pkg as well.
svn path=/trunk/; revision=19436
2006-10-04 22:43:38 +00:00
Jaap Keuter 662d1c90fa Make provisional ETHERTYPE dependant on registered ETHERTYPE
Remove preferences stuff
Use stringz for variable length names
Media address size independant
Removed generated item
Set actual length of packet
Make info column work without coloring rules or filters

svn path=/trunk/; revision=19435
2006-10-04 22:01:58 +00:00
Anders Broman 7817c0a610 Put back the bugfixes froim Revision 19190/19356
Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091

"h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames."

svn path=/trunk/; revision=19434
2006-10-04 21:52:35 +00:00
Anders Broman d701298da8 From Martin Peylo:
dissector for Enea's LINX protocol?

A protocol spec is available at <http://www.enea.com/templates/Extension____8947.aspx>. The source of the kernel module could be obtained from Enea by sending a request to "linx at enea dot com".

Currently they use ethertype 0x9999 which is not registered at IEEE.

svn path=/trunk/; revision=19430
2006-10-04 18:00:32 +00:00
Anders Broman 1775368e0a From Nicolas DICHTEL:
M flag isn't for MCOA, but for HMIP (RFC4140 Section 4.1).

svn path=/trunk/; revision=19429
2006-10-04 17:43:52 +00:00
Anders Broman 12819c3b19 Finally got it to complie.
svn path=/trunk/; revision=19427
2006-10-04 16:02:59 +00:00
Luis Ontanon c284a7f9ab more cleanup... almost there...
svn path=/trunk/; revision=19426
2006-10-04 15:31:31 +00:00
Anders Broman 699c5c66b6 From Florent.Drouin@alcatel.fr:
I did improve the OID management in the tcap dissector.
Now, when a tcap message is reveived, without upper layer, the ACN is saved in the TCAP context, and can be used for the next messages of the dialogue. It is used only when the upper layer session is opened with Tcap only messages.

svn path=/trunk/; revision=19414
2006-10-03 19:24:22 +00:00
Luis Ontanon 8f737d2587 Get it to compile...
svn path=/trunk/; revision=19412
2006-10-03 18:38:04 +00:00
Anders Broman 8774e7e28e From David Richards:
numerous changes, most notably:

1) BACnetStatusFlags is bit string, not enum, in NotificationParameters
2) Fixes many places where enclosing context tags were not handled properly.
3) Simplify tag decoding logic.  Change to explicit decoding in many 
instances rather
    than read tags in a loop and do a switch based on tag number.  Looping
    ignores out-of-order and other types of tagging errors.

svn path=/trunk/; revision=19410
2006-10-03 18:11:55 +00:00
Luis Ontanon 5d40bae072 MSVCC does not like mixing code and variable declarations
svn path=/trunk/; revision=19409
2006-10-03 18:07:31 +00:00
Anders Broman 83971ab494 Add application/media_control+xml
svn path=/trunk/; revision=19408
2006-10-03 18:04:15 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Martin Mathieson 3474ea868c - Add special case for reading strange encoding of ATM CID field
- Indicate direction of DCH Data in info column
- Assume EDCH payload CRC if 2 bytes are left over (previous test was broken)

svn path=/trunk/; revision=19405
2006-10-03 14:21:07 +00:00
Anders Broman 179039652b From Stephen Fisher:
always register 
itself on the port from the preferences (defaults to 0) upon launch.  
This allows the user to right-click and use decode as.

svn path=/trunk/; revision=19403
2006-10-03 05:50:28 +00:00
Anders Broman e65847960f From Stephen Fisher:
Modifie the VNC dissector to desegment 
the "server cut text" message type for cases where the cut text is in 
the next tcp segment from the first part of the message.

svn path=/trunk/; revision=19402
2006-10-03 05:48:47 +00:00
Martin Mathieson 2bfdb780ee Set correct length for extensions root
svn path=/trunk/; revision=19393
2006-10-02 10:49:57 +00:00
Ronnie Sahlberg af410bce95 fix for header digest detection being broken when AHS is used.
we simply forgot to account for the AHS when testing to calculate the crc


svn path=/trunk/; revision=19389
2006-09-30 21:49:11 +00:00
Ronnie Sahlberg 61ac971e2c add dissection of the cdb for service action LIST
(but no decoding of the data in yet)



svn path=/trunk/; revision=19388
2006-09-30 21:08:27 +00:00
Ronnie Sahlberg 71af839c39 the ahs length inside the AHS for an extended cdb includes the reserved byte before the start of cdb data
account for this extra reserved byte in the ahs length so that the reconstructed cdb has the correct length and does not contain one extra byte at the end



svn path=/trunk/; revision=19387
2006-09-30 20:40:04 +00:00
Ulf Lamping ee8abeec9e fix a typo
svn path=/trunk/; revision=19386
2006-09-30 18:30:43 +00:00
Graeme Lunt 23937f82c7 A new field information flag, FI_URL, to indicate a field contains a URL.
This is used to display the field underlined and to allow the user to double-click on it (like FT_FRAMENUM) to open the URL in the configured browser. 
Example usage in the x509ce and logotype certificate extensions. 


svn path=/trunk/; revision=19383
2006-09-30 14:37:09 +00:00
Ulf Lamping 3da46255fe remove compiler warnings
svn path=/trunk/; revision=19382
2006-09-30 13:40:36 +00:00
Ronnie Sahlberg c2b08c79d2 add dissection of SCSI OSD CREATE PARTITION
svn path=/trunk/; revision=19379
2006-09-30 10:24:23 +00:00
Ronnie Sahlberg cadbe48610 finish off the remainder of FORMAT OSD for scsi osd dissector
svn path=/trunk/; revision=19378
2006-09-30 10:08:43 +00:00
Ronnie Sahlberg bedacc2bc2 scsi osd updates
iscsi: when iscsi transfers a cdb that is alrger than 16 bytes,  the first 16 bytes are transferred in the normal place in the header and ther remainder of the cdb is transported inside the AHS.

reassemble these cdb into a proper tvb before passing it to the scsi dissector



svn path=/trunk/; revision=19376
2006-09-30 09:34:58 +00:00
Ulf Lamping 4e79f8f307 remove a warning
svn path=/trunk/; revision=19375
2006-09-30 09:15:15 +00:00
Ronnie Sahlberg 62290c9cc5 add an extra_data pointer to the itlq structure where specific commandsets/cdbs can hang additional data that are unique to that commandset/cdb
make the scsi osd service action and getsetattributetype use this facility

furhter enhancements to scsi osd


svn path=/trunk/; revision=19374
2006-09-30 04:10:28 +00:00
Ronnie Sahlberg deef583ae5 scsi opcode 0x7f is variable length so dont clamp the cdb length to 16 bytes
svn path=/trunk/; revision=19373
2006-09-30 01:01:57 +00:00
Ronnie Sahlberg 0afdb9be78 scsi osd additions
we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly


svn path=/trunk/; revision=19371
2006-09-30 00:31:36 +00:00
Ulf Lamping d6f0ae689c MSVC doesn't like empty array inits
svn path=/trunk/; revision=19368
2006-09-29 21:53:54 +00:00
Anders Broman 55967abbf1 Update Diamater and Radius AVP:s
svn path=/trunk/; revision=19366
2006-09-29 21:26:27 +00:00
Jaap Keuter 8fd898635b Fix for bug 1133:
add a test for (length > 0) in the dissector (dissect_xot_pdu), to avoid to
allocate a new tvb when the XOT decoded length is null. 

svn path=/trunk/; revision=19365
2006-09-29 19:39:40 +00:00
Martin Mathieson 49a3e2a6e5 Dissect Via header
svn path=/trunk/; revision=19364
2006-09-29 17:35:23 +00:00
Jaap Keuter e01fdc5616 From Nicolas DICHTEL:
Please find enclosed a patch about Mobile Network Prefix option in NEMO.
Following RFC3963 Section 4.3, lenght of this option is 18, not 16.

svn path=/trunk/; revision=19363
2006-09-29 16:31:52 +00:00
Ronnie Sahlberg 59d9a1b9c2 add a missing heuristic to acept a NOP_IN packet and correct a broken heuristic that would refuse all NOP_OUT pdus as non-iscsi
it is absolutely amazing that none of the iscsi implementors and users of wireshark had noticed this breakage and reported it.   they apparently do not use wireshark.


svn path=/trunk/; revision=19362
2006-09-29 11:12:18 +00:00
Tomas Kukosa 809d8a1113 From Reinhard Speyerer:
patch fixes a small typo in epan/dissectors/packet-per.c

svn path=/trunk/; revision=19361
2006-09-29 11:09:17 +00:00
Ronnie Sahlberg e2a851e18d add initial scsi osd dissector but only dissect sdbs that are impoerted from SPC
various changes to the existing scsi dissector to start allowing different commandsets to be implemented in their own dissector files to prevent the scsi dissector to become as huge as the parlay dissector




svn path=/trunk/; revision=19360
2006-09-29 10:40:51 +00:00
Ronnie Sahlberg d09cfb2bb8 move the defines for SPC command opcode values to the headerfile
svn path=/trunk/; revision=19359
2006-09-29 09:24:51 +00:00
Anders Broman 2861b22148 Update some value_strings
svn path=/trunk/; revision=19355
2006-09-29 05:51:44 +00:00
Anders Broman f1a97e4ec3 From Martin Peylo:
- dissection of TIPCv2 internal messages now shows
  all fields used according to the protocol spec
- there should be no issues with the current protocol
  spec anymore
- the info column is more concise and gives more
  details
- some code beautifications

svn path=/trunk/; revision=19354
2006-09-29 05:50:41 +00:00
Jaap Keuter b43742894c From Nicolas DICHTEL:
I've two patchs for FMIPv6:
- FBU encapsulated in FNA are not correctly parsed;
- there is an error when parsing LLA Option.

svn path=/trunk/; revision=19351
2006-09-28 16:30:20 +00:00
Ronnie Sahlberg c220a1a89a From stephen fisher:
I have figured out one of the fields in the MAPI
EcRRegisterPushNotification packet.  The field is a UDP port number that
the client wants the Exchange server to send new mail notifications on.
These notifications are on a port > 1023 and are always 8 bytes long.

It looks like I would add the function name to the
dcerpc_mapi_dissectors[] for the register push notification.  What would
my new function need to do besides display the field?


Thanks,

Steve

Here is a patch to add this functionality.  It displays the notification
port and the notification payload (not sure what the payload itself
means yet).  It also dynamically registers each notification port found
with a new dissector (that I called newmail for lack of a better name -
I'm open to suggestions) that displays the notification payload.  This
is all undocumented by Microsoft in their usual fashion.

I also changed the code to always display the mapi.opnum field;
currently, the mapi.opnum is only displayed when the
dcerpc_mapi_dissector is null.


Steve




svn path=/trunk/; revision=19350
2006-09-28 16:29:18 +00:00
Ronnie Sahlberg c20b7c8eda additional scsi sense codes from patrick@abra2.bitwizard.nl
svn path=/trunk/; revision=19349
2006-09-28 15:57:54 +00:00
Ronnie Sahlberg ad305c630b Hi,
This patch fixes the page code selector for the scsi log sense command.

Patrick




svn path=/trunk/; revision=19348
2006-09-28 15:55:13 +00:00
Ronnie Sahlberg 6fee9a41f0 From Alex Burlyga
This patch adds support for dissecting ontap's nfsv4 filehandle,
as well as some updates to nfsv3 filehandle as well in the nfs
dissector.

Alex.


checked in with minor changes


svn path=/trunk/; revision=19345
2006-09-28 07:52:46 +00:00
Ronnie Sahlberg 171a98950c EFS is generated by PIDL now so we dont need the old idl2wrs folder any more
svn path=/trunk/; revision=19343
2006-09-27 20:56:15 +00:00
Ronnie Sahlberg 3fbca8aff5 generate the EFS DCERPC interface dissector using PIDL
svn path=/trunk/; revision=19342
2006-09-27 20:55:13 +00:00
Anders Broman ad9a9a6a9d From Florent Drouin:
Here are some patches and a new module to introduce the notion of Tcap context for a Tcap transaction. For each Tcap transaction, several parameters, like session identifier, start time or OID, will be saved in a hash table, to keep these informations available for the next messages. This context is then given to the upper layer, and can be used, for example, to generate transaction-associated statistics.

Moreover, the Upper protocol, detected in the Begin of the TCAP transaction ( according to the OID ), is saved in the context, and will be reused for the next messages of the transaction. This help the decoding of SS7 messages, without any SSN configuration in the "wireshark preferences".

You will have too, the possibility to apply a filter to see only the messages related to a TCAP transaction. (tcap.srt.session_id=XXX)

To enable the use of the Tcap context, you have 2 new parameters in the preferences,
- SRT, enable search for a Tcap context for any TCAP messages
- persistentSRT, keep the Tcap context, even after the transaction has been closed. This is mandatory with Wireshark, to have a clean display of the stats.

There is 2 new timers  in the preferences for the statistics, to tune the retransmission timeout, and messages lost timeout.

svn path=/trunk/; revision=19341
2006-09-27 20:06:06 +00:00
Anders Broman 9753b85f46 Handle unaligned dissect_per_length_determinant and dissect_per_restricted_character_string_sorted.
svn path=/trunk/; revision=19340
2006-09-27 19:30:22 +00:00
Martin Mathieson 473347e064 Dissect sequence number & method name of CSeq header.
svn path=/trunk/; revision=19336
2006-09-27 12:49:00 +00:00
Ronnie Sahlberg 10091ebdaa add new dcerpc protocol WZCSVC based on samba4 idl
this protocol is not too interesting yet since only the function names of this interface is known  but it is more that no dissection at all



svn path=/trunk/; revision=19333
2006-09-27 08:59:20 +00:00
Martin Mathieson 0852c89fd1 - Mark the multipart type as a generated field.
- Remove the RFC 3261 attribution in the long text version of several headers (some of them I couldn't easily work out where the first non-obsoleted introduction of them is)

svn path=/trunk/; revision=19328
2006-09-26 13:01:27 +00:00
Ronnie Sahlberg e2aea53993 update the idl for wkssvc and generate the dissector by pidl
svn path=/trunk/; revision=19321
2006-09-25 08:50:21 +00:00
Anders Broman 299469d48d Handle Zero length SEQUENCE and SEQUENCE OF.
svn path=/trunk/; revision=19318
2006-09-24 21:04:53 +00:00
Guy Harris 239ba17a50 dissect_ndr_uint16()'s last argument points to a guint16, not a guint.
svn path=/trunk/; revision=19316
2006-09-24 20:31:02 +00:00
Guy Harris 240f452c38 Squelch a compiler warning.
Clean up indentation.

svn path=/trunk/; revision=19315
2006-09-24 20:29:47 +00:00