Commit Graph

5174 Commits

Author SHA1 Message Date
Jeff Morriss e61fd0979b From Gisle Vanem: text_import_scanner_lex.h is no longer used.
svn path=/trunk/; revision=36507
2011-04-07 20:04:01 +00:00
Chris Maynard 43803a3457 More console tweaks. But how to prevent prompt from being displayed before
command finishes without requiring, "start /wait <command>"?

svn path=/trunk/; revision=36463
2011-04-04 19:15:31 +00:00
Gerald Combs 031164aa9f More console tweaks.
svn path=/trunk/; revision=36458
2011-04-04 18:03:24 +00:00
Gerald Combs e7435f2d3f Only call destroy_console() when we create a console (pointed out by
Chris Maynard).

svn path=/trunk/; revision=36455
2011-04-04 17:48:07 +00:00
Gerald Combs 82a145ceb5 On Windows, try to use an existing console for our messages. Create one if
it doesn't exist.

svn path=/trunk/; revision=36452
2011-04-04 17:11:56 +00:00
Chris Maynard 2db46ad8d4 Remove const type qualifier from cast. Resolves CID's 582-585.
svn path=/trunk/; revision=36430
2011-04-01 16:30:59 +00:00
Chris Maynard adadb7dd0f Use a common function, higher_priority_status_level() to determine whether or
not messages should be pushed onto the statusbar.  Should fix CID 270.

svn path=/trunk/; revision=36421
2011-03-31 16:23:07 +00:00
Chris Maynard 9e55be72fc Wrap all text lines of help at column 80.
svn path=/trunk/; revision=36408
2011-03-30 14:44:18 +00:00
Chris Maynard a8c78f0562 Grab URL from frame info value instead of from tvb. Fixes bug 5780.
svn path=/trunk/; revision=36398
2011-03-29 20:05:33 +00:00
Chris Maynard c91893191d Move -D option into "pre-scan" group as there's no need to start gtk+ for it.
svn path=/trunk/; revision=36388
2011-03-28 22:12:53 +00:00
Stig Bjørlykke cfd583a6be Added sanity checks for preferences.
Coverity 551 & 553.

svn path=/trunk/; revision=36352
2011-03-26 15:53:55 +00:00
Stig Bjørlykke 4c7f1096db Added a missing break in graph_select_segment.
Coverity 482.

svn path=/trunk/; revision=36349
2011-03-26 15:20:37 +00:00
Stig Bjørlykke 43cba80324 Added a missing break in hostlist_get_filter_name.
Coverity 481.

svn path=/trunk/; revision=36348
2011-03-26 15:16:40 +00:00
Stephen Fisher 321149bcd7 Fix Coverity 331, 332, 333: Wrap the three remaining
gtk_tree_selection_get_selected() calls with if(!..) return;
like the rest of them.  These functions shouldn't be called
unless a packet was selected, so this call should always return
TRUE for success.


svn path=/trunk/; revision=36339
2011-03-25 22:35:29 +00:00
Bill Meier 6817d03a66 Recode a loop slightly ....
svn path=/trunk/; revision=36294
2011-03-23 18:10:34 +00:00
Stig Bjørlykke e8e4bff8ee Removed "comparing an array to null", with no effect.
Coverity 534.

svn path=/trunk/; revision=36281
2011-03-23 07:31:17 +00:00
Stig Bjørlykke 0ae643e27d Removed "comparing an array to null", with no effect.
Coverity 533.

svn path=/trunk/; revision=36280
2011-03-23 07:29:19 +00:00
Ronnie Sahlberg c317244ff8 Print the time units in the CSV output for io_stat using correct extension, i.e. always in seconds.
coverity 419

svn path=/trunk/; revision=36275
2011-03-23 05:11:06 +00:00
Jeff Morriss 263a3b3d10 Don't compile expert_dlg.c (that dialog is being removed)
svn path=/trunk/; revision=36271
2011-03-22 21:15:36 +00:00
Stig Bjørlykke f775562f33 Added a sanity check for finfo->hfinfo.
Coverity 425.

svn path=/trunk/; revision=36268
2011-03-22 19:48:55 +00:00
Stig Bjørlykke abb51ebe9b Allocate correct size of int, not size of a pointer to int.
Coverity 717.

svn path=/trunk/; revision=36261
2011-03-22 18:53:37 +00:00
Stig Bjørlykke b03c1345d2 Initialize geom in window_get_geometry.
Coverity 804.

svn path=/trunk/; revision=36259
2011-03-22 18:28:08 +00:00
Jeff Morriss 20c8fe0f7a Copy expert_tapdata_t here so that expert_dlg.h is no longer needed.
svn path=/trunk/; revision=36251
2011-03-22 16:05:12 +00:00
Guy Harris 3a39cb2ed6 Make expert_tapdata_t opaque to its clients; define the structure only
in gtk/expert_comp_dlg.c.

Don't declare now-static functions in gtk/expert_dlg.h.

svn path=/trunk/; revision=36236
2011-03-22 07:24:14 +00:00
Anders Broman 694a48cdc8 Remove the Exper info dialogue.
(Leave the fies for a while).

svn path=/trunk/; revision=36235
2011-03-22 06:17:20 +00:00
Bill Meier 3905d7715c Re-arrange code slightly to remove a false positive Coverity Prevent "Forward Null" defect report.
svn path=/trunk/; revision=36229
2011-03-21 18:54:10 +00:00
Jeff Morriss 4863594e6a #if out another unused routine.
svn path=/trunk/; revision=36224
2011-03-21 14:52:54 +00:00
Guy Harris 3a8b4900a2 #if 0-out an unused routine.
svn path=/trunk/; revision=36222
2011-03-21 08:21:51 +00:00
Anders Broman d78a104c99 expert_dlg.c:603: warning: 'expert_dlg_cb' defined but not used
svn path=/trunk/; revision=36220
2011-03-20 22:36:57 +00:00
Anders Broman 670bd1514f Don't register the Exper info dialogue as a first step of removal.
Should the common routines be moved into expet_comp_dlg.[ch]?

svn path=/trunk/; revision=36219
2011-03-20 19:33:07 +00:00
Stig Bjørlykke 27954b8c9d From James Deucker via bug 5766:
Mark some unused arguments.

svn path=/trunk/; revision=36212
2011-03-19 11:09:03 +00:00
Bill Meier a37493fe16 Fix bug #5189: Wireshark crashes when cancelling a large sort operation.
Essentially: Don't try to sort if the pre-requisite "columnization" step is stopped
             via the progressbar dialog window before the step completes.
Also: Fix a (very) minor bug wherein the sort-indicator not always cleared on the
      "previous column" when "No Sorting" was selected from a column context menu.
Also: Do minor code, comments & whitespace cleanup.

svn path=/trunk/; revision=36180
2011-03-12 19:02:24 +00:00
Chris Maynard ac6ae6dbd3 Allow <variance> to be successfully sscanf'd no matter the locale for the
decimal symbol.  Same change and reason as for revision 36160.

svn path=/trunk/; revision=36166
2011-03-08 14:57:38 +00:00
Sake Blok 307c0d70fb Removal of the old packet-list in favor of the new packet list.
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)


svn path=/trunk/; revision=36161
2011-03-08 01:52:25 +00:00
Stig Bjørlykke d188988e83 Added functionality for handling global profiles.
Global profiles can be installed in a "profiles" directory in the
Global configuration directory, and a global profile will be copied
to the users profiles on first time usage.

svn path=/trunk/; revision=36077
2011-02-26 17:23:24 +00:00
Stig Bjørlykke c6abce41f8 Ensure we write the current recent file before copying.
svn path=/trunk/; revision=36067
2011-02-25 15:06:37 +00:00
Gerald Combs a6bbdaa849 Fix some dead code and zero division issues found by Clang scan-build.
In convert_string_case() use g_utf8_strup() instead of converting each
character by hand. Hopefully this won't cause any unexpected changes in
behavior.

svn path=/trunk/; revision=36006
2011-02-18 22:43:48 +00:00
Gerald Combs 3e13ddbadc Fix a few errors found by Clang scan-build.
svn path=/trunk/; revision=36002
2011-02-18 19:46:05 +00:00
Gerald Combs 7b254f46fb Fix some Visual C++ static analyzer complaints.
svn path=/trunk/; revision=35971
2011-02-17 01:11:05 +00:00
Gerald Combs 9bdecea98c Fix compilation on Windows.
svn path=/trunk/; revision=35967
2011-02-16 19:26:08 +00:00
Stephen Fisher 82c78778ae More cleanup toward being able to compile with GTK+ 3.0. Mostly replacing
deprecated GtkToolTips with new functions.


svn path=/trunk/; revision=35966
2011-02-16 18:27:00 +00:00
Stephen Fisher a29a04f112 Traditional GtkTooltips deprecated at GTK+ 2.14 (and removed in 3.0), so
use the new functions when available. 


svn path=/trunk/; revision=35926
2011-02-12 00:27:47 +00:00
Stephen Fisher 1b2f2426e0 Remove #ifndef GSEAL_ENABLE hack to work-around the lack of an accessor
for a GSEALed variable since GTK 3.0 is out, which has the accessor.


svn path=/trunk/; revision=35917
2011-02-11 18:28:55 +00:00
Guy Harris e2bdef175d Add the rest of the changes from the patch in bug 5924. Squelches some
compiler warnings.

svn path=/trunk/; revision=35901
2011-02-10 20:27:35 +00:00
Gerald Combs ceb650ecee #ifdef → #ifndef.
svn path=/trunk/; revision=35900
2011-02-10 20:15:31 +00:00
Gerald Combs 66281f8744 Mark a parameter unused if needed.
svn path=/trunk/; revision=35899
2011-02-10 19:50:05 +00:00
Gerald Combs fb3055d41a Remove a bunch of prototypes in airpcap_dlg.h for functions which are
now static. Make another function static.

svn path=/trunk/; revision=35897
2011-02-10 17:09:36 +00:00
Stephen Fisher cf5aeb0c4c Fix compilation problem for GTK+ < 2.18
graph_analysis.c(1450): error C2039: 'allocation' : is not a member of
'_GtkStyle'


svn path=/trunk/; revision=35877
2011-02-08 04:12:09 +00:00
Guy Harris 7e6b4ad3a3 Build with pre-2.18 GTK+es.
svn path=/trunk/; revision=35874
2011-02-08 01:48:07 +00:00
Stephen Fisher e53853bea0 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0...
svn path=/trunk/; revision=35872
2011-02-08 01:01:50 +00:00