09c49ac78c
More -DGSEAL_ENABLE cleanup (hopefully without breaking anything)...
...
svn path=/trunk/; revision=35870
2011-02-08 00:56:22 +00:00
104d4d80a2
Fix parameters to gtk_widget_get_allocation() call.
...
svn path=/trunk/; revision=35865
2011-02-07 22:11:14 +00:00
c257693621
Switch from GtkCList (which is deprecated) to GtkTreeView+GtkListStore.
...
Make a bunch of functions static. Get rid of a no-longer-necessary
struct. Clean up other parts of the code.
svn path=/trunk/; revision=35862
2011-02-07 20:24:42 +00:00
4efa18be22
Similar corrections here.
...
svn path=/trunk/; revision=35861
2011-02-07 19:43:18 +00:00
c66802f606
Fix typo.
...
svn path=/trunk/; revision=35856
2011-02-07 19:39:05 +00:00
e895aa9ddf
"XXX takes a foo * as an argument" != "pass a variable of type foo * to
...
XXX"; in the case of gtk_widget_get_allocation(), you have to pass it a
pointer to a variable of type foo, where foo = GtkAllocation.
The same applies to the pre-GTK-2.18 code.
svn path=/trunk/; revision=35854
2011-02-07 19:37:51 +00:00
3ef2acd516
More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3
...
svn path=/trunk/; revision=35853
2011-02-07 19:24:26 +00:00
95f99b60e4
More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3
...
svn path=/trunk/; revision=35852
2011-02-07 19:21:45 +00:00
75333216ee
Fix crash introduced in r35849
...
svn path=/trunk/; revision=35851
2011-02-07 19:18:19 +00:00
9d3586b4f5
And even more -DGSEAL_ENABLE cleanup for GTK+ 3.0 preparation...
...
svn path=/trunk/; revision=35849
2011-02-07 18:41:38 +00:00
88ea7649d5
More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0
...
svn path=/trunk/; revision=35848
2011-02-07 18:38:33 +00:00
2b049e573d
Some -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0
...
svn path=/trunk/; revision=35847
2011-02-07 18:37:11 +00:00
7d6e4633e3
Disable error substring controls when show errors checkbox is disabled.
...
svn path=/trunk/; revision=35784
2011-02-03 17:41:45 +00:00
d3efa3ed9f
A bit of Windows makefiles rework and cleanup:
...
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
(This allows disabling "Warnings as Errors" by just changing config.nmake)
c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
-DWIN32 and -DNULL=0 do not appear to be needed (any more);
-D_MT and _D_DLL are not needed since /MP causes these definitions.
d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...
svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
6adf502aa7
Replace a couple of deprecated functions # ifdef:ed with the GTK version they are deprecated in.
...
svn path=/trunk/; revision=35740
2011-02-01 07:15:14 +00:00
51bae2f9f8
Use {'0', ...} type initializer for fixed length character arrays.
...
svn path=/trunk/; revision=35735
2011-01-31 21:45:16 +00:00
ed78f0a33e
Fix two cases of 'if (x = y)' which should be 'if (x == y)'.
...
Found by reviewing msvc level 4 warnings "assignment within conditional expression".
(Unfortunately most of the warnings are false positives so this warning can't be enabled)
svn path=/trunk/; revision=35726
2011-01-31 18:58:38 +00:00
1d9fe2c424
Only define view_menu_auto_scroll_live_cb if HAVE_LIBPCAP
...
svn path=/trunk/; revision=35720
2011-01-31 13:58:36 +00:00
c9b96a9bfb
Try to fix previous commit.
...
- menu.h commited by mistake
- new_packet_list.c missing
svn path=/trunk/; revision=35719
2011-01-31 13:52:32 +00:00
b7527dd063
From Cal Turney:
...
Bug 5621 - With String in Packet details searches, highlight row in tree
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5621
svn path=/trunk/; revision=35718
2011-01-31 12:19:15 +00:00
502ddd6cdb
Added filter autocomplete to "Edit Column Details".
...
svn path=/trunk/; revision=35717
2011-01-31 07:42:13 +00:00
7f0107220d
Fix various instances of "unreachable code".
...
svn path=/trunk/; revision=35713
2011-01-30 23:27:57 +00:00
043e0e0bbf
Don't compile non-used (unreachable) code on Windows.
...
svn path=/trunk/; revision=35712
2011-01-30 23:24:23 +00:00
b0d7bf821c
Don't compile unused non-Windows code when on Windows.
...
(Found by msvc level 4 warning "unreachable code").
Also:
- suppress an invalid msvc level 4 warning by initializing a variable.
- Use #ifdef _WIN32 iso #if _WIN32
svn path=/trunk/; revision=35708
2011-01-30 22:23:45 +00:00
d6e70aa723
Improve r35695/35696 by repeating the whole function call in each
...
block of the #if / #else / #endif for clarity.
svn path=/trunk/; revision=35697
2011-01-29 07:47:03 +00:00
b96434a014
Fix Windows compile error(s);
...
{Compiles OK on Windows but not tested).
svn path=/trunk/; revision=35696
2011-01-29 04:41:03 +00:00
bf8ce5c383
If we're compiling with GTK+ 2.14 or higher, use accessor function
...
gtk_color_selection_dialog_get_color_selection() instead of accessing
the struct member directly.
svn path=/trunk/; revision=35695
2011-01-29 00:30:42 +00:00
cf46488ec4
From Irene Ruengeler: Double check that the interface specified in the
...
preferences still exists. If not, don't use it.
svn path=/trunk/; revision=35659
2011-01-26 15:15:20 +00:00
df985b7140
Fix crash when doing File ! Export ! Objects ! SMB.
...
[Essentially: simplify the code used to test for duplicate packets].
Fixes Bug #5337 : http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337
Also:
- Fix "divide by 0" which caused garbage for display of a percent value;
- Remove some unneeded #includes;
svn path=/trunk/; revision=35638
2011-01-24 18:59:26 +00:00
becab16f36
Fix a crash which can occur if a user hits "Capture:Options" immediately followed by "Capture:Start"
...
Fixes Bug #4645 : https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645
Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
to use not yet initialized "Capture Options" state.
svn path=/trunk/; revision=35633
2011-01-23 20:59:12 +00:00
ce1313cc15
Reword some text about the accuracy of the dislayed values.
...
svn path=/trunk/; revision=35629
2011-01-23 17:29:06 +00:00
73100c482b
Resolve bug #2520 by moving the follow stream direction combo box above the
...
buttons to make more room for hostnames.
svn path=/trunk/; revision=35625
2011-01-22 17:42:40 +00:00
09d5dd80c7
Set active combo_box entry before connecting the changed signal
...
to avoid a crash when opening the Import window.
svn path=/trunk/; revision=35620
2011-01-22 14:02:38 +00:00
fb4d2c059c
Close dir opened by ws_dir_open().
...
svn path=/trunk/; revision=35618
2011-01-22 13:43:54 +00:00
58fc79bb04
Add buttons to allow filtering only UL or DL on selected UE.
...
svn path=/trunk/; revision=35616
2011-01-22 03:49:23 +00:00
2c4bf4d8fa
Re-arrange help menu a bit to group website and wiki links.
...
svn path=/trunk/; revision=35613
2011-01-21 23:24:08 +00:00
fb645f7e28
Cast the returned value from strlen() to an int to make the Windows 64-bit
...
buildbot happy.
svn path=/trunk/; revision=35585
2011-01-19 19:42:00 +00:00
347d0a77bf
From Cal Turney via enhancement bug #5587 : In hex or string searches of the
...
packet data highlight the target rather than the entire field.
svn path=/trunk/; revision=35584
2011-01-19 18:21:21 +00:00
30b047223a
From Cal Turney via bug #5585 : When searching in packet bytes, the field and
...
bytes are not immediately shown.
svn path=/trunk/; revision=35583
2011-01-19 17:58:53 +00:00
bc80cd8155
Fix the broken Edit Menu when UImanager is used.
...
(UnmarkAllDisplayedPackets)
svn path=/trunk/; revision=35582
2011-01-19 14:55:15 +00:00
180bb0c13f
Remove redundant test for a non-null pointer;
...
svn path=/trunk/; revision=35570
2011-01-17 16:36:52 +00:00
fc38e13bcf
Move MAC and RLC stats menu items into a common LTE subtree.
...
svn path=/trunk/; revision=35532
2011-01-14 11:32:58 +00:00
13d20c309a
From H.sivank:
...
-A patch to allow drag and drop on wireshark icon doc.
It does not require old(Carbon) ScriptExec.
svn path=/trunk/; revision=35428
2011-01-08 18:44:21 +00:00
3bc1fc3802
On Windows, convert all of our command-line arguments from UTF-16 to
...
UTF-8 where we don't already do so. In Wireshark use g_utf16_to_utf8
instead of utf_16to8. This should fix bug 5520.
svn path=/trunk/; revision=35411
2011-01-06 23:28:58 +00:00
656e914296
Rearrange the Intenals and Help menu somewhat.
...
svn path=/trunk/; revision=35392
2011-01-05 23:12:51 +00:00
90a2ad31dd
Clean up the white space.
...
svn path=/trunk/; revision=35372
2011-01-05 07:31:46 +00:00
a6caff484f
Fix Windows build, which complained about possible loss of data converting
...
from a double to a time_t. I removed nstime_to_secs() and grab the
seconds portion of the nstime (which is a time_t), since that's all the
precision needed in the code right now anyway.
svn path=/trunk/; revision=35293
2010-12-29 00:29:05 +00:00
fb897e8883
Implement first part of request in bug #5527 - allow the user to change
...
the timestamp display in the RTP Player to time of day with a checkbox
similar to in the IO Stats graph.
svn path=/trunk/; revision=35288
2010-12-28 18:22:59 +00:00
737c5f3863
Add support for showing errors matching substrings (like LTE RLC stats supports). TODO: fix the loayout/spacing....
...
svn path=/trunk/; revision=35281
2010-12-28 01:06:51 +00:00
9dec1a9cb0
Add a tooltip.
...
svn path=/trunk/; revision=35280
2010-12-28 01:05:45 +00:00
9148bb6c53
Clarify some comments
...
svn path=/trunk/; revision=35279
2010-12-27 22:24:07 +00:00
808d632345
The RTP Player shows the number of seconds since the beginning of that
...
call's packet flow along the x-axis. Add " s" to the end of each number
to give the user an idea those numbers are seconds.
svn path=/trunk/; revision=35278
2010-12-27 21:44:34 +00:00
3c9cfef565
Fix for bug 5513:
...
Prepare filter must take Fwd and Rev part in combined filter.
svn path=/trunk/; revision=35247
2010-12-22 20:24:51 +00:00
516bfe3363
Fix marking functionality (bug 5279)
...
svn path=/trunk/; revision=35244
2010-12-22 17:25:06 +00:00
dfb9193526
Set default graph file format to more appropriate Portable Network Graphics.
...
svn path=/trunk/; revision=35236
2010-12-21 08:08:28 +00:00
015cd4a18d
From Marc Giertzsch:
...
Dialog RTP Graph analysis is not showing forward and reverse delta.
svn path=/trunk/; revision=35235
2010-12-21 08:07:24 +00:00
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
5ae824fc8f
From k barnard:
...
Flag when a packet has been dropped by the jitter buffer in the audio player,
by showing:
D dropped packet
W wrong timestamp
S silence added by wireshark
To show when audio 'glitches' may have come from the processing the received
packets through the jitter buffer.
svn path=/trunk/; revision=35192
2010-12-15 18:38:17 +00:00
2118fd723c
Always provide wslua_plugin_list, even if we don't have Lua configured.
...
svn path=/trunk/; revision=35163
2010-12-09 15:20:14 +00:00
fc47a70c65
Change includes for getenv_utf8()
...
svn path=/trunk/; revision=35150
2010-12-07 21:20:39 +00:00
740dfb5a4d
Change the accelerator keys for "goto previous/next packet in conversation" from "<ctrl>+[" and "<ctrl>+]" to "<ctrl>+," and "<ctrl>+." as the bracket keys cause problems on many keyboards where they are "hidden" behind AltGr (I was tipped by a user with a German keyboard that has that "problem"). The new keys should cause no problems on most keyboards according to http://en.wikipedia.org/wiki/Keyboard_layout .
...
svn path=/trunk/; revision=35143
2010-12-07 11:42:32 +00:00
36deb61faa
Revert r35132 so that a better fix can be implemented that doesn't break
...
non-printable non-UTF8 ASCII characters such as in binary streams.
svn path=/trunk/; revision=35136
2010-12-06 21:33:19 +00:00
a27983a413
Remove unnecessary #include "../isprint.h"
...
svn path=/trunk/; revision=35135
2010-12-06 21:24:25 +00:00
8525fe0037
Change isprint() calls in follow_stream.c (shared code that supports Follow
...
TCP, UDP and SSL streams) to g_unichar_isprint() so that UTF-8 characters
are displayed properly.
svn path=/trunk/; revision=35132
2010-12-06 18:34:26 +00:00
03b57df5a0
Fix various typos and spelling errors.
...
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
5a7b4defa3
After applying GUI preferences, reset the welcome screen's header message
...
in case the show version in welcome screen option was toggled.
svn path=/trunk/; revision=35114
2010-12-03 22:19:58 +00:00
a3d313a967
Don't include epan/emem.h twice.
...
svn path=/trunk/; revision=35109
2010-12-03 18:47:10 +00:00
f4b4c45af1
Change the Wireshark stock icon description from "Auto Scroll in Live Capture"
...
to "Auto Scroll" to save space in the main toolbar. Leave the rest of the
references (such as in the view menu) as they were.
svn path=/trunk/; revision=35108
2010-12-03 17:31:58 +00:00
ad2730d302
Convert the .c file names to .obj before putting them in WIRESHARK_GTK_OBJECTS.
...
svn path=/trunk/; revision=35081
2010-11-30 21:32:04 +00:00
b8cb5e53ff
Move the port audio source into a separate variable which is not run through checkapi.
...
svn path=/trunk/; revision=35080
2010-11-30 20:57:43 +00:00
c755b2fd54
Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target). Revert 35073 and 35069.
...
svn path=/trunk/; revision=35075
2010-11-30 02:04:55 +00:00
a857d6d69b
Fix "colorize with filter" functionality that got broken with the new_packet_list.
...
svn path=/trunk/; revision=35074
2010-11-29 22:50:21 +00:00
5f3ff94816
Move the checkapi targes to Makefile.common. Rename Makefile.nmake's WIRESHARK_GTK_SRC to WIRESHARK_GTK_ALL_SRC to avoid reusing the variable of the same name from Makefile.common; Put DIRTY_GENERATED_C_FILES back in that variable since checkapi is no longer run on it.
...
svn path=/trunk/; revision=35069
2010-11-29 20:53:22 +00:00
6dc182c9d9
Remove DIRTY_GENERATED_C_FILES from WIRESHARK_GTK_SRC so we don't run checkapi on it. Also remove capture_if_details_dlg_win32.c from the checkapi list since it's in WIRESHARK_GTK_SRC (which is in the list of files checkapi is run against).
...
svn path=/trunk/; revision=35067
2010-11-29 20:37:24 +00:00
564e85b8fe
Remove file_dlg_win32.c and print_win32.c from the checkapi target.
...
svn path=/trunk/; revision=35066
2010-11-29 20:09:09 +00:00
9f8a83e19c
Add DIRTY_GENERATED_C_FILES to GENERATED_FILES (so they get cleaned up by distclean).
...
svn path=/trunk/; revision=35065
2010-11-29 20:07:43 +00:00
4f5e11eaca
Allow DCT error strings containing given subsets to be filtered upon.
...
svn path=/trunk/; revision=35059
2010-11-29 12:09:18 +00:00
4ee8c642d6
u3.c has moved.
...
svn path=/trunk/; revision=35057
2010-11-28 21:44:06 +00:00
9ff6526256
Partially clean up white space.
...
svn path=/trunk/; revision=35049
2010-11-28 00:53:23 +00:00
49ddccb45b
Clean up white space.
...
svn path=/trunk/; revision=35048
2010-11-28 00:41:47 +00:00
eda0f472c9
Move u3 code to top-level directory since it's not GTK specific
...
svn path=/trunk/; revision=35046
2010-11-28 00:15:21 +00:00
46356d715c
Don't report an error twice.
...
svn path=/trunk/; revision=35045
2010-11-28 00:13:38 +00:00
186ce16c52
Add GCC-style printf annotation to the routines that now take a format
...
string and format arguments, and fix issues warned about by that.
svn path=/trunk/; revision=35044
2010-11-28 00:02:39 +00:00
1a4a8ff9c3
Clean up white space.
...
svn path=/trunk/; revision=35043
2010-11-28 00:00:58 +00:00
002a1b75fa
Make some other statusbar routines take a format string and format args,
...
and get rid of an unnecessary string pointer.
Make the argument to welcome_header_push_msg() a const pointer.
svn path=/trunk/; revision=35042
2010-11-27 23:06:14 +00:00
a4cc25f84d
Move main_statusbar.h to the top-level directory; none of its routines
...
use GTK+ data types, so, at least in theory, it could be implemented
atop another toolkit.
Make statusbar_push_temporary_msg() take a format string and format
arguments. Use it instead of simple_status(), and change one call to
just take a format string and arguments rather than to take the result
of using that format string and arguments with g_strdup_printf() and
passing the result to statusbar_push_temporary_msg().
svn path=/trunk/; revision=35041
2010-11-27 21:50:49 +00:00
049e9e39e8
Fix the rest of the include paths after the move of native win32 code to win32 and out of the gtk directory in r35032
...
svn path=/trunk/; revision=35034
2010-11-26 20:57:46 +00:00
587bd2724f
Move native Win32 code to its own directory and out of gtk directory (hopefully without breaking any builds)
...
svn path=/trunk/; revision=35032
2010-11-26 19:16:06 +00:00
d65eab20bc
Update comments to point to the previous commit to enhance traceabillity.
...
svn path=/trunk/; revision=35028
2010-11-25 15:21:24 +00:00
9e277ae615
Remove threading of tap update.
...
See http://www.wireshark.org/lists/wireshark-dev/200611/msg00199.html
svn path=/trunk/; revision=35027
2010-11-25 13:56:29 +00:00
bc3b5e96a9
Create proper Help reference.
...
svn path=/trunk/; revision=35026
2010-11-25 07:01:39 +00:00
cd7c2e0241
Try to fix dummy header settings alignment.
...
svn path=/trunk/; revision=35019
2010-11-24 08:41:22 +00:00
613efa359b
Remove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c
...
svn path=/trunk/; revision=35008
2010-11-22 19:45:03 +00:00
98fba4de6f
From Jakub Zawadzki via Alexander Koeppe.
...
Improvement of checking available length highlighting byteview data.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5383
svn path=/trunk/; revision=34989
2010-11-21 10:41:01 +00:00
831f5777b6
Repair copy (summary and as filter) functionality in the packet-list context menu. It got broken in the bulk of work required to move to the UImanager.
...
svn path=/trunk/; revision=34984
2010-11-20 14:55:02 +00:00
2f0ee70e27
Remove comments used when editing.
...
svn path=/trunk/; revision=34975
2010-11-19 16:34:51 +00:00
023fb81cbc
[UImanager]Add missing GO to frame, and copy paste errors.
...
svn path=/trunk/; revision=34945
2010-11-18 15:57:12 +00:00
1e2ae5a88a
Quote all fields when exporting to CSV. Fixes bug 2811.
...
svn path=/trunk/; revision=34920
2010-11-17 03:29:12 +00:00
d63f2559da
Split libui into libui and libui_dirty. The latter contains (only)
...
text_import_scanner.c (which is generated and not by us so we can't guarantee
that it's clean).
svn path=/trunk/; revision=34912
2010-11-16 20:13:26 +00:00
4323fa647d
Try to clean up the makefile a bit.
...
svn path=/trunk/; revision=34898
2010-11-16 09:15:15 +00:00
Stephen Fisher