perhaps some versions of Digital/Tru64 UNIX) drags in <wait.h>, which
drags in <sys/procset.h>, which defines P_SID in ways that cause this
not to compile. Use P_MY_SID instead.
svn path=/trunk/; revision=8931
"aliasAddress", in an EndPoint sequence, is a sequence of
aliasAddresses.
Don't update the Info or Protocol columns in a pdu_item.
svn path=/trunk/; revision=8930
1. Add dissection of inquiry type (rpc_c_ep_all_elts /
rpc_c_ep_match_by_if / rpc_c_ep_match_by_obj /
rpc_c_ep_match_by_both).
2. The version field seems incorrect to me - I believe it is usually
should be version 2.0, not 0.2.
I suspect that the insertion of version information to the hash
table is also wrong, (and the get for the version should have
used _letohl() ) - but I did not change it.
3. Clean up some white space.
svn path=/trunk/; revision=8929
(such as at least one older version of the HP C compiler) can't cope
with constant expressions that involve the "?" operator, it appears;
they think it's not a constant expression.
Also, as Albert notes, there's no reason for "ett" to be static here.
svn path=/trunk/; revision=8928
This was problematic and caused crashes since this variable is used as an index into an array where we grab a
pointer (which is later dereferenced).
Dereferencing that pointer will have surprising effects. Usually crashes.
Update Q.931 to verify sanity of the codeset variable everytime it gets set.
svn path=/trunk/; revision=8927
If the ByteCount field in the SMB PDU spanned beyond the end of the
packet because the packet was short or because the BC field was corrupted and contained
garbade data then the tree item for the command (the subtree just after the SMBHeader subtree) would describe data continuing beyond the end of the
packet.
If we selected one such tree in the dissect pane and used Prepare/Match Selected this would cause the filter build thing to try to access data beyod the end
of the packet and ethereal would dump core.
Change the END_OF_SMB macro so that it shrinks bc so that bc never describes
data beyond the end of the packet.
svn path=/trunk/; revision=8926
If we failed to dissect the GSS-SPNEGO blob it probably means that the segment
is somewhere in the middle of an LDAP PDU.
Just bail out and stop dissecting the PDU instead of aborting ethereal completely
using g_assert() since this is not really a pathological error, its just something that can and will happen normally.
svn path=/trunk/; revision=8925
the parameter name so that the user doesn't have to open the parameter
subtree to see the most important data.
Use "%u", not "%d", to print unsigned quantities.
Get rid of includes of <gmodule.h> (we're not loading any code at
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those).
svn path=/trunk/; revision=8922
formats.
Use "%u", not "%d", to print unsigned quantities.
Get rid of includes of <gmodule.h> (we're not loading any code at
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those).
svn path=/trunk/; revision=8921
Fix some incorrect bit shifts.
Get rid of non-portable "%N$" constructs in printf formats.
Use "%u", not "%d", to print unsigned quantities.
svn path=/trunk/; revision=8919
typedef enum _foo foo;
enum _foo {
...
};
You have to define the enum before using it in a typedef. (If I had my
ANSI C89 standard handy, I could say whether that was legal ANSI C or
not.)
svn path=/trunk/; revision=8918
and have it return TRUE if we succeeded, FALSE otherwise - and have an
internal "process_tcp_payload()" routine handle the (TCP-specific) PDU
tracking and sequence number analysis, with an argument to indicate
whether it should do that or not (i.e., whether it's being handed a TCP
segment or reassembled data).
svn path=/trunk/; revision=8914
correct and enhance support for RSVP FAST_REROUTE and DETOUR
objects (source: draft-ietf-mpls-rsvp-lsp-fastreroute-03.txt);
support an RSVP SESSION_OBJECT object with ctype = 1. This
object contains resource affinities (source: RFC 3209).
svn path=/trunk/; revision=8913
packets/sessions, e.g. MSProxy and SOCKS. It should not cause any of
the TCP-specific stuff such as sequence number analysis or PDU tracking
to be done. (Actually, MSProxy and SOCKS should offer desegmentation
services *themselves* and do their *own* PDU tracking, rather than just
passing stuff on to "decode_tcp_ports()", but that's another matter.)
Make "tcp_tree" once again be a local variable to "dissect_tcp()", and
pass it as an argument to those functions that use it.
svn path=/trunk/; revision=8912
- Added support for displaying support for Multicast/Broadcast supported
bits in *LOGI common service params
- Removed restriction for "Random Relative Offset" & its alternate to be in
PLOGI or PDISC only. Some HBAs set it even in FLOGI.
svn path=/trunk/; revision=8907
- Added support for decoding related to Security in *LOGI service params
- Added support for new LS_RJT code for authentication failure
- Brought packet-fcsp.c up-to-date with FC-SP rev 1.2
svn path=/trunk/; revision=8906
KPasswd is partially dissected for UDP.
It would be very useful if someone added dissection of the asn.1 encoded
AP_REQ and the KRB-PRIV blobs. I dont think I will add those.
svn path=/trunk/; revision=8905
session where GSS-SPNEGO is used.
If we havent seen the BIND call ethereal would assume it is
vanilla non-GSS-SPNEGO LDAP and would fail to decode the packet.
Add heuristics to the LDAP dissector so that
IF the first 4 bytes of the LDAP PDU looks like ity could be a length field
and IF the fifth byte has the value 0x60
then assume what we have is GSS-SPNEGO and assume this and all further commands on this session is GSS-SPNEGO as well.
svn path=/trunk/; revision=8904
value so it can be handled specially (with a string dissector table so
that subdissectors can register for particular content types).
svn path=/trunk/; revision=8903
open.
The toolbar equivalent should *not* be available if we have an "Update
list of packets in real time" capture running.
The toolbar "Save" button should not be available if we don't have an
unsaved capture file.
svn path=/trunk/; revision=8902
Note that you have to modify plugins/Makefile.nmake.
Fix "plugin/" to "plugins/".
Update the sample Makefile.am and Makefile.nmake to match the current
state of affairs.
svn path=/trunk/; revision=8899
LDAP messages that span multiple segments will throw an exception unless we have reassembly enabled.
Update TCP so that IF an exception was thrown that we still pick up any hints
provided by the subdissector about where the next PDU starts.
Update LDAP so that it will rpovide hints to TCP about where the next LDAP PDU starts in the sequence number space.
Thus now ethereal can find and dissect LDAP PDUs that starts somewhere in the middle of a TCP segment.
svn path=/trunk/; revision=8895
(string) values to be put into the protocol tree as fields and allowing
some headers to get special treatment, and use it for Authorization,
Proxy-Authorization, WWW-Authenticate, and Proxy-Authenticate.
svn path=/trunk/; revision=8892
If we have short or malformed PDUs in protocols above TCP this will generate
an exception and thus some of the stateful things such as keeping track of
and printing the tcp analysis data will be shourcutted and not called.
Add a wrapper around the call to the subdissectors above TCP so that
if an exception is generated we will still catch it and explicitely
call tcp_print_sequence_number_analysis() so that also short packets are
handled well.
svn path=/trunk/; revision=8891
Sometimes if we cant decrypt a DCERPC packet decrypted_tvb is NULL.
do not pass a NULL pointer to show_stub_data() since this will dump
core.
svn path=/trunk/; revision=8890
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those, and they might be responsible for
dragging in <sys/procset.h> on Digital UNIX - that header defines P_SID
in a way that conflicts with our definition).
svn path=/trunk/; revision=8889
Guy Harris