Commit Graph

81754 Commits

Author SHA1 Message Date
Gerald Combs 3fbf6fa022 GitLab CI: Fix a path.
Copy the correct .dmg path to s3.
2021-08-25 21:42:48 +00:00
Joerg Mayer 280085838b packet-extreme.c EDP Link TLV: Decode some flags
Fix a signed vs. unsigned warning while at it.

Whitespace fixes
2021-08-25 21:04:11 +00:00
Gerald Combs 28c4c947c0 GitLab CI: Enable macOS Arm notarization.
Enable code signing & notarization in the macOS Arm Package job. Add
"needs: []". Verify the .dmg after notarizing it.
2021-08-25 20:40:29 +00:00
Alexis La Goutte f7755972c9 LDP: Display Generic label with DEC
Fix #17539
2021-08-25 20:12:28 +00:00
Nardi Ivan 1f28ac3ef5 DoQ: update to latest draft (-03)
See https://www.ietf.org/archive/id/draft-ietf-dprive-dnsoquic-03.txt
2021-08-25 19:23:20 +00:00
Gerald Combs f6e2cdcc54 HTTP3: Define dissect_http3_settings only if needed.
Define dissect_http3_settings only if HAVE_LIBGCRYPT_AEAD is defined.
This should hopefully fix

```
epan/dissectors/packet-http3.c: In function 'dissect_http3_settings':
epan/dissectors/packet-http3.c:212:9: error: implicit declaration of function 'http3_is_reserved_code' [-Werror=implicit-function-declaration]
         if (http3_is_reserved_code(settingsid)) {
         ^
epan/dissectors/packet-http3.c: At top level:
epan/dissectors/packet-http3.c:200:1: warning: 'dissect_http3_settings' defined but not used [-Wunused-function]
 dissect_http3_settings(tvbuff_t* tvb, packet_info* pinfo _U_, proto_tree* http3_tree, guint offset)
 ^
cc1: some warnings being treated as errors
```

on the CentOS 7 builds.
2021-08-25 17:54:47 +00:00
Taisuke Sasaki 95f3f58e0d ISIS: Fix Flexible Algorithm issues
- Fix "Priority" field name in FAD TLV (draft-ietf-lsr-flex-algo-16)
- Fix SABM/UDABM length in ASLA TLV (rfc8919)
2021-08-25 17:35:26 +00:00
Alexis La Goutte 72eb858741 gitlab-ci: Fix daily API ref
mkdir / cd build is already on ubuntu step
2021-08-25 17:18:28 +00:00
Alexis La Goutte ebb1d7ffaf gitlab-ci: Fix daily Clang Analysis
mkdir / cd build is already on ubuntu step
2021-08-25 17:18:28 +00:00
Gerald Combs 0d27b63747 FAQ: Add items about forms and contracts.
We occasionally get requests to fill in compliance forms and to sign
contracts. Add items for those.

Move the name change question to a historical intrest section.
2021-08-25 17:01:21 +00:00
Tomas Kukosa 522414a091 ITS: use custom value format for DSRC element DeltaTime 2021-08-25 16:29:23 +00:00
Maxime Meignan 09a993da39 NTLMSSP: Remove unnecessary condition in decryption
If a "NT Password" value is provided by the user, the NTLMSSP decryption
should take place, whether or not Kerberos decryption option is enabled
 (disabled by default).
2021-08-25 16:11:11 +00:00
Maxime Meignan 1e697fb7ff NTLMSSP: Allow empty NT passwords for decryption
NT Accounts may have empty passwords; this allows the dissector to try
decrypting the NTLMSSP session using an empty password (when "NT
Password" preference is left blank).
2021-08-25 15:53:55 +00:00
David Perry 697f28c1d3 RTPS: use proto_data instead of private_table
Rewrite storage and retrieval of `endpoint_guid`s to use private proto
data instead of `pinfo->private_table` which was meant solely for Lua
use.

Closes #17156
2021-08-25 15:37:03 +00:00
Arkady Gilinsky cbada6faf4 oampdu: Improve Queue object parsing
Signed-off-by: Arkady Gilinsky <8351139-ark-g@users.noreply.gitlab.com>
2021-08-25 15:20:29 +00:00
Evan Huus 9311982664 plugins: convert to pinfo->pool
Convert all plugin dissectors from wmem_packet_scope to pinfo->pool.
2021-08-25 14:30:47 +00:00
Alexis La Goutte 2ee06d3fef Qt: Add Turkey translation
Thanks to Serkan ÖNDER
2021-08-25 14:06:50 +00:00
Dr. Lars Völker 8e2cd4f652 UI: Import profiles from ZIP supporting bigger files (Bugfix)
This patch allows the profile importer to recover from a file too large
to import as well as adjusts the maximum allowed config file size.

Closes: #17504
2021-08-25 13:40:12 +00:00
Anders Broman d884af52e9 F1AP: Make it possible to exort F1AP PDUs 2021-08-25 10:19:37 +00:00
Guy Harris a70c120a04 gryphon: get rid of unused variables.
Found by cppcheck.
2021-08-25 08:57:47 +00:00
Gtker 75881ac914 WOWW: Add maps enum and strings
The "unused versions" are not unused in Wireshark, they're just
literally called `unused` for some reason.

DBC file:
https://wowdev.wiki/DB/Map#1.12.1.5875

SMSG_CHAR_ENUM:
https://wowdev.wiki/SMSG_CHAR_ENUM
2021-08-25 08:41:17 +00:00
Gtker 07da0d01ef WOWW: Rename _zone to _area and add strings
`Zone` is not entirely correct, since the value can also be used for
areas within a zone.

AreaTable:
https://wowdev.wiki/DB/AreaTable#1.12.1.5875

SMSG_CHAR_ENUM:
https://wowdev.wiki/SMSG_CHAR_ENUM
2021-08-25 08:41:17 +00:00
Gtker cf28565d4d WOWW: Fix class enum
Original values were incorrect.

Mangos link:
e45aa74e0f/src/game/Server/SharedDefines.h (L75)
2021-08-25 08:41:17 +00:00
Gtker 41eeb05bd1 WOWW: Add case for messages without bodies
This will allow distinguishing messages that have been handle, but have
no body, and unhandled messages (default case).
2021-08-25 08:41:17 +00:00
Gtker a9831231e7 WOWW: Add movement messages 2021-08-25 08:41:17 +00:00
Gtker bc440490c5 WOWW: Refactor parse_SMSG_CHAR_ENUM to take ptvcursor_t 2021-08-25 08:41:17 +00:00
Guy Harris d42ac7b4b5 check_tfs: we want os.path.commonprefix, not os.path.commonpath. 2021-08-25 01:24:31 -07:00
Alexis La Goutte fbabba338c HTTP3: Add define value for HTTP3 Frame Type
use switch for support dissect of other H3 frame_type
2021-08-25 07:48:48 +00:00
Alexis La Goutte f0fa2b333a HTTP3(Settings): Append settings with value 2021-08-25 07:48:48 +00:00
Alexis La Goutte b0bd1c4c2a HTTP3(Settings): Support of GREASE frame 2021-08-25 07:48:48 +00:00
Alexis La Goutte d8618462f5 HTTP3: Add Settings from QPACK (draft-ietf-quic-qpack-21) 2021-08-25 07:48:48 +00:00
Alexis La Goutte b70fa0d4ad HTTP3: Add Settings dissection 2021-08-25 07:48:48 +00:00
Guy Harris 9941c00a0f check_tfs: don't require plugins to use tfs.c true_false_strings.
To quote the comment in plugins/epan/gryphon/packet-gryphon.c, "Note:
using external tfs strings doesn't work in a plugin", so, for plugins,
don't check to make sure that the file doesn't define a
true_false_string that's the same as one defined by tfs.c.
2021-08-25 07:31:56 +00:00
Adam Mitz 1089bd47f8 RTPS: fixed expected size of fragment number set
The size of this submessage is 8 + the number of 32-bit ints
needed for the value of the num_bits field to be represented
in the bitmap.
2021-08-25 07:15:28 +00:00
John Thacker 7bd16e0dd9 MP2T: Fix packet length for short packets
Small payload packets that fit into a single TSP without
fragmentation are dissected without ever being placed in
the reassembly table, so fragment_get_reassembled_id returns
NULL even on the second pass and later. Handle them (and
distinguish that case from packets not reassembled because they
were at the end of a capture.)

Add a few comments to clarify what's going on.
2021-08-25 06:57:41 +00:00
Guy Harris e490f93072 wmem: don't check whether sizeof(type) is <= 0.
This should fix the cppcheck warning "The unsigned expression
'sizeof(struct _PKT_INFO)' will never be negative so it is either
pointless or an error to check if it is."

wmem_safe_mult() was only used to do an overflow-safe multiplication of
a type size and a count of elements of that type; replace it with
wmem_safe_mult_type_size(), which takes the type as the first argument,
and checks only whether the count of elements is <= 0.
2021-08-24 20:58:00 -07:00
Gerald Combs d2979e1976 GitLab CI: Initial macOS Arm build.
Add a "macOS Arm Package" job to .gitlab-ci.yml. Fixup a check in
osx-dmg.sh.
2021-08-24 21:22:41 +00:00
Gerald Combs c52c50b944 CMake: Switch GLib back to PUBLIC.
379352ef7f / !3603 removed GLib from the INTERFACE_LINK_LIBRARIES and
INTERFACE_INCLUDE_DIRECTORIES properties for the epan target. This broke
external plugin development as discussed in !3891, so switch it back.
2021-08-24 20:33:16 +00:00
Michael Tuexen 3d7729c6b3 tools: use glib version 2.68.4 on MacOS 2021-08-24 19:23:49 +00:00
Lin Sun 5e59ffd12d [build] fix warnings for unused variables 2021-08-24 18:47:15 +00:00
ismaelrti ed2d004181 RTPS: Fixed UDPv4 WAN locator port encoding and always dissecting of all fields
Always dissecting the UUID IP and port of UDPv4 WAN no matter the
locator flags set. Also fixing the port encoding.
2021-08-24 16:54:22 +00:00
Evan Huus 678541878c h248: convert to pinfo->pool
This one was non-trivial in places and involved converting a few methods
to use strbufs to simplify.
2021-08-24 12:43:52 +00:00
Evan Huus e8f967f162 asn1: convert more dissectors to pinfo->pool
Just h248 left of the asn1 templates, and it's gonna be tricky.
2021-08-24 12:16:15 +00:00
Joakim Karlsson 28ab4bed8e PFCP: added missing PFCP Session Change Info IE 2021-08-24 11:05:35 +00:00
Joakim Karlsson 51327a330b JSON: adding more 3GPP EPS IEs 2021-08-24 12:00:07 +02:00
Guy Harris f7d05a0d0f pdcp-lte: stub out calculate_digest() if we don't support any crypto.
In the non-stub routine, all parameters are used, so remove the _U_.

In the stub routine, mark all unused parameters with _U_.
2021-08-24 01:14:18 -07:00
Guy Harris e3d93143c8 btmesh: don't provide stub custom field formatting routines.
Use the non-stub versions even if we don't have libgcrypt 1.6.0 or
newer; yes, it's code that won't ever be used, but if you want to
eliminate waste, remove all the fields that aren't used if we don't have
libgcrypt 1.6.0 or later.

This avoids the need to create stub routines, making the code a bit less
confusing (and avoiding the risk of using those fields with
non-functional formatting routines).

It also eliminates "function argument unused" warnings when building
with an older version of libgcrypt, and does so more cleanly than adding
a bunch of _U_s to the stub functions.
2021-08-24 00:40:50 -07:00
Gerald Combs 405db40992 [Automatic update for 2021-08-22]
Update manuf, services enterprise numbers, translations, and other items.
2021-08-23 23:26:01 +00:00
Dr. Lars Völker 0091a83e31 BLF: adding Interface blocks (bugfix)
This patch adds code to add the interface blocks, so that the packets
read by blf can be written again (e.g., to pcapng).
2021-08-23 21:19:29 +02:00
Dr. Lars Völker 5de353f324 BLF: WTAP_BLOCK_PACKET should have been MULTIPLE_BLOCKS_SUPPORTED 2021-08-23 20:30:12 +02:00