Commit Graph

39469 Commits

Author SHA1 Message Date
Guy Harris 3af7f28931 capture_opts_add_iface_opt() is not used outside capture_opts.c; make it
static.

svn path=/trunk/; revision=41494
2012-03-12 02:53:21 +00:00
Martin Mathieson 5a84afd814 Within a status report, check that NACK_SNs are not 'ahead' of ACK_SN.
svn path=/trunk/; revision=41493
2012-03-11 23:44:03 +00:00
Anders Broman c00ca87104 From Steve Magnani: knock URB Setup out from under USB URB https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6934
svn path=/trunk/; revision=41492
2012-03-11 22:31:18 +00:00
Guy Harris 681c29c5d5 Don't close the currently loaded capture file in capture_start(), do so
in its callers; when starting a capture with "wireshark -k", there's no
capture file to close, and closing it might be provoking some UI actions
that cause crashes on Windows.

Don't copy the list of selected interfaces to the list of capture
interfaces in capture_start(), either, do that in the callers; we were
already doing that in one place and, in one of the remaining cases,
namely "wireshark -k", we should do so only if no capture interfaces
were supplied on the command line.  (I.e., the set of interfaces on
which we want to capture depends on where in the UI the capture is being
started.)

svn path=/trunk/; revision=41491
2012-03-11 20:08:54 +00:00
Guy Harris 6f3ee54d62 Add a comment to indicate what collect_ifaces() does.
svn path=/trunk/; revision=41490
2012-03-11 20:01:11 +00:00
Guy Harris 7f6caeb730 If the length is bogus in a message received from the sync pipe, dump
out all 4 bytes we read, to provide more information about the message
that was sent so it's easier to see if something was spewing extra
output to the standard output or error in the child.

svn path=/trunk/; revision=41489
2012-03-11 20:00:39 +00:00
Guy Harris 6486942282 Fix function name in debugging message.
svn path=/trunk/; revision=41488
2012-03-11 19:59:08 +00:00
Anders Broman b8fd91e8c1 Add a comments LED
svn path=/trunk/; revision=41487
2012-03-11 19:31:10 +00:00
Alexis La Goutte 55ca59ffb9 From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6787
Move Y.1711 out of MPLS dissector

ITU-T Y.1711 code was "embedded" into the MPLS dissector in 2006. 
This patch moves it into its own dissector.

From me :
Fix a Clang warning

svn path=/trunk/; revision=41486
2012-03-11 19:05:32 +00:00
Gerald Combs 69b533085b [Automatic manuf, services and enterprise-numbers update for 2012-03-11]
svn path=/trunk/; revision=41483
2012-03-11 14:03:34 +00:00
Stig Bjørlykke b71ce5d268 Do not assign a value to itself.
svn path=/trunk/; revision=41482
2012-03-11 14:03:13 +00:00
Stig Bjørlykke b049f8a976 Return a valid offset from process_app0_segment().
The return value is not used, but this removes a warning.

svn path=/trunk/; revision=41481
2012-03-11 14:02:59 +00:00
Stig Bjørlykke 3d8a2927a7 Remove extraneous parentheses around some comparisons to silence a warning.
svn path=/trunk/; revision=41480
2012-03-11 12:00:27 +00:00
Stig Bjørlykke 6a724c8d83 Free name string only when used.
svn path=/trunk/; revision=41479
2012-03-11 12:00:13 +00:00
Stig Bjørlykke 1301b98e25 Use _U_ for unused arguments.
svn path=/trunk/; revision=41478
2012-03-11 12:00:00 +00:00
Guy Harris 42df48aab0 capture_opts_add_opt() does just fine at adding an interface to the
capture options, so don't special-case the -i option.

svn path=/trunk/; revision=41477
2012-03-11 07:10:48 +00:00
Guy Harris 7676b02551 Reflect the rename of the Xylan RADIUS dictionary.
svn path=/trunk/; revision=41476
2012-03-10 19:05:46 +00:00
Alexis La Goutte d14a0dad80 Fix QtShark build after the move of alert_box.c in ui folder
svn path=/trunk/; revision=41475
2012-03-10 19:00:34 +00:00
Alexis La Goutte d23c469785 Rename the Xylan dictionnary to Alcatel-Lucent Xylan dictionnary
Alcatel (now Alcatel-Lucent) buy Xylan in 1999...
And now Attributs RADIUS is used in Alcatel-Lucent Omniswitch Product.

svn path=/trunk/; revision=41474
2012-03-10 18:30:20 +00:00
Alexis La Goutte 4c64d32a03 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41473
2012-03-10 17:51:47 +00:00
Alexis La Goutte 515612450e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41472
2012-03-10 17:51:32 +00:00
Alexis La Goutte b60c478326 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41471
2012-03-10 17:51:18 +00:00
Alexis La Goutte bce5a791fc Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41470
2012-03-10 17:50:28 +00:00
Alexis La Goutte 1dee4d224e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41469
2012-03-10 17:49:33 +00:00
Alexis La Goutte 63b9d7324e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41468
2012-03-10 17:49:17 +00:00
Alexis La Goutte 27f56dd47f Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41467
2012-03-10 17:49:00 +00:00
Alexis La Goutte 342c647ed4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41466
2012-03-10 17:48:33 +00:00
Alexis La Goutte 2561aad178 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41465
2012-03-10 17:48:17 +00:00
Alexis La Goutte bdbe07fe0a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41464
2012-03-10 17:47:28 +00:00
Alexis La Goutte 6ee4ab9692 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41463
2012-03-10 17:47:07 +00:00
Alexis La Goutte 5634cf10fd Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41462
2012-03-10 17:46:18 +00:00
Alexis La Goutte ba19f72aab Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41461
2012-03-10 17:45:17 +00:00
Anders Broman edbdf1b6de Don't register the payload type unless it's in the dynamic range
svn path=/trunk/; revision=41460
2012-03-10 17:00:30 +00:00
Anders Broman 970272235d From martijn: subdissectors for URB_INTERRUPT. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6929
svn path=/trunk/; revision=41459
2012-03-10 16:16:07 +00:00
Anders Broman f030f799bd From Steve Magnani: USB: centralize some common dissection code for class reuse. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6930
svn path=/trunk/; revision=41458
2012-03-10 16:09:28 +00:00
Guy Harris 5dc7d02ed8 Replace 4-space tabs (and one 8-space tab, the only remaining tab in the
file after replacing the 4-space tabs) with spaces.

svn path=/trunk/; revision=41457
2012-03-10 09:08:03 +00:00
Guy Harris 541dab39eb Replace inconsistent tabs with spaces.
svn path=/trunk/; revision=41456
2012-03-10 09:01:48 +00:00
Gerald Combs 7a8df2f485 In pcapng.c use the units per second value from the interface instead of
the default.

Add support for reading nseclibpcap files to dumpcap.

svn path=/trunk/; revision=41455
2012-03-10 00:24:42 +00:00
Anders Broman bb71a9c96a Forward interface_opts.descr (currently empty) when writing IDB:s
svn path=/trunk/; revision=41454
2012-03-09 15:29:35 +00:00
Jeff Morriss da33d2ef5a Fix up indentation (get rid of 4-space tabs).
svn path=/trunk/; revision=41453
2012-03-09 14:25:30 +00:00
Anders Broman d862ce97e3 Mark an unused parameter as such.
svn path=/trunk/; revision=41452
2012-03-09 14:20:53 +00:00
Anders Broman f6919f2b50 Make packet comments editable from the expert info tab.
svn path=/trunk/; revision=41451
2012-03-09 13:36:29 +00:00
Anders Broman 183289786d From Sylvain Munaut:
packet-gmr1_dtap: Add dissector for GMR1 DTAP messages (Step 4(4)).
Added to Cmalelists.txt and #if 0 zero lenght hf array which windows 
build did not like.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41450
2012-03-09 12:45:19 +00:00
Anders Broman 2bc1d9f874 From Sylvain Munaut:
packet-gsmtap: Call the GMR-1 CCCH dissector when appropriate  (Step 3).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41449
2012-03-09 12:33:16 +00:00
Anders Broman 017351556b From Sylvain Munaut:
packet-gmr1_rr: Add dissector for GMR-1 RR elements and CCCH messages (Step 2).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41448
2012-03-09 12:15:08 +00:00
Anders Broman abbdb721dd From Jose Pedro Oliveira:
pcapio.c: write IDB options in numeric order and corrects the IDB block_total_length.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718

svn path=/trunk/; revision=41447
2012-03-09 11:47:55 +00:00
Anders Broman a908ffac57 From Sylvain Munaut:
GMR-1: Add dissections for various GMR 04.08 elements (Step1).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41446
2012-03-09 09:38:21 +00:00
Anders Broman d50dcb37e9 From Sylvain Munaut: gsm_a_common: ELEM_MAND_VV_SHORT doesn't support IEs of different types. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6924
svn path=/trunk/; revision=41445
2012-03-09 05:08:30 +00:00
Anders Broman 9d03324d91 From Jose Pedro Oliveira: Make dumpcap write the if_tsresol option (using the default value) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718
svn path=/trunk/; revision=41444
2012-03-09 05:02:27 +00:00
Anders Broman e15692be8a From Jose Pedro Oliveira: Corrects several 'wdh->bytes_dumped += ...' lines. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6718
svn path=/trunk/; revision=41443
2012-03-09 04:50:43 +00:00