Commit Graph

41546 Commits

Author SHA1 Message Date
Anders Broman 39747fc669 Shoul be gtk_box_pack_start(GTK_BOX (vbox), message_type_fr, TRUE, TRUE, 0);
svn path=/trunk/; revision=43827
2012-07-19 13:36:26 +00:00
Anders Broman 42cb0dd606 Remove unused variable.
svn path=/trunk/; revision=43826
2012-07-19 13:10:17 +00:00
Anders Broman d3ecc1431f gtk_container_add() -> gtk_box_pack_start().
svn path=/trunk/; revision=43825
2012-07-19 13:06:04 +00:00
Jakub Zawadzki 58d106382a Use define instead of string constant.
svn path=/trunk/; revision=43824
2012-07-19 12:49:42 +00:00
Jakub Zawadzki 3c80b32e54 BytesView: use GtkStyleContext for gtk-3 (bug #7502)
svn path=/trunk/; revision=43823
2012-07-19 12:41:44 +00:00
Jakub Zawadzki 3fd00ae4e7 Fix bug #7377 for 'Protocol Hierarchy' and 'Endpoints'
svn path=/trunk/; revision=43822
2012-07-19 11:47:00 +00:00
Jakub Zawadzki dce9b3baec BytesView: Support for gtk3 scrollbar.
svn path=/trunk/; revision=43821
2012-07-19 11:03:54 +00:00
Anders Broman e6c5c00453 gtk_container_add() -> gtk_box_pack_start().
svn path=/trunk/; revision=43820
2012-07-19 10:36:56 +00:00
Anders Broman 78527f225d Make it possible to add custom/private MIBs to the Windows installer.
svn path=/trunk/; revision=43819
2012-07-19 08:02:50 +00:00
Guy Harris 41be8e4344 Add a local errorCount variable to functions that use it, have them
return it, and use the return value.

svn path=/trunk/; revision=43818
2012-07-19 07:02:00 +00:00
Guy Harris 66ed910844 Yup, that did it. Make use of ENC_ values in non-item proto_tree_add
calls an error.

Fix one case where we weren't counting an error (unregistered ett
variables).

svn path=/trunk/; revision=43817
2012-07-19 04:16:15 +00:00
Guy Harris defeb589d6 Rename ENC_HDRLEN to BSD_ENC_HDRLEN, to see if that squelches the false
positive in the "you're passing an ENC_ value as a field value" check in
checkAPI.pl.

svn path=/trunk/; revision=43816
2012-07-19 03:28:39 +00:00
Michael Mann 7184dac548 Addresses https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3895. Note that this doesn't write a Nokia file type properly, it just doesn't corrupt an existing one (read in by Wireshark) if resaved.
svn path=/trunk/; revision=43815
2012-07-19 01:00:49 +00:00
Michael Mann 757361f4d4 Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5469. Added more comments to make the function of vnc_is_client_or_server_version_message() very clear.
Also includes some minor cleanup of proto_tree_add_text -> proto_tree_add_item

svn path=/trunk/; revision=43814
2012-07-19 00:29:11 +00:00
Guy Harris 7b1be4c91e Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43812
2012-07-18 23:44:15 +00:00
Guy Harris d91978600c Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43810
2012-07-18 23:37:59 +00:00
Guy Harris 4c3fd1012a Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43808
2012-07-18 23:34:59 +00:00
Guy Harris bdf148e3ea Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43806
2012-07-18 23:30:45 +00:00
Guy Harris 9667a4703b Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43804
2012-07-18 23:27:37 +00:00
Guy Harris 682d1f34b6 Fix non-proto_tree_add_item() calls passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43802
2012-07-18 23:18:01 +00:00
Guy Harris 4f84db81e2 Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43800
2012-07-18 23:06:20 +00:00
Guy Harris 754711b757 Fix a non-proto_tree_add_item() passing an ENC_ value as the last
argument.

svn path=/trunk/; revision=43798
2012-07-18 22:59:54 +00:00
Guy Harris 87ad190d49 exit() must not be used in dissectors. Use REPORT_DISSECTOR_BUG() and
just return NULL instead.

svn path=/trunk/; revision=43797
2012-07-18 22:57:04 +00:00
Guy Harris b459c468a3 Set the 802.11 "already decrypted" flag to FALSE for file formats other
than Network Instruments Observer files, as we don't know whether they
are already decrypted.

svn path=/trunk/; revision=43796
2012-07-18 22:48:18 +00:00
Guy Harris b40db9cf4c Add to the 802.11 pseudo-header a "this is already decrypted" flag, set
it as appropriate in the code to read Network Instruments Observer
captures (rather than tweaking the "protected" flag in the packet data),
and use that flag in the 802.11 dissector.

Fix indentation while we're at it (tabs are not *ipso facto* 4 spaces).

svn path=/trunk/; revision=43795
2012-07-18 22:10:34 +00:00
Guy Harris 1e7c2d7d51 Eliminate some gsize's I missed in the previous checkin.
svn path=/trunk/; revision=43794
2012-07-18 21:43:39 +00:00
Guy Harris d0df3d4c5a Nobody uses the return value of dissect_sender_array(), so don't have it
return anything.

Don't use gsize for offsets in packets; the type used in Wireshark is
int.

svn path=/trunk/; revision=43793
2012-07-18 21:22:10 +00:00
Guy Harris b695d863aa Set svn:keywords and svn:eol-style, and fix the EOL style (I'm on UN*X,
so with svn:eol-style native, there should be no CRs).

svn path=/trunk/; revision=43792
2012-07-18 20:56:24 +00:00
Michael Mann b16b7e951e Adds CliqueRM protocol (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2076)
svn path=/trunk/; revision=43791
2012-07-18 20:11:32 +00:00
Anders Broman 3be9409ae8 From Jakub Zawadzki use gtk_box_pack_start isof gtk_container_add fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377
svn path=/trunk/; revision=43790
2012-07-18 19:44:54 +00:00
Michael Mann e298722f5b svn path=/trunk/; revision=43789 2012-07-18 19:40:56 +00:00
Guy Harris bbe3a78d3a That comment might have confused the API checker into thinking we were
calling abort(); try changing it.

svn path=/trunk/; revision=43788
2012-07-18 18:50:29 +00:00
Jörg Mayer ebccbb0829 Get rid of the problems described in bug7377
Bissecting shows, that the problem was introduced by commit

r43009 | etxrab | 2012-06-03 01:53:04 +0200 (So, 03 Jun 2012) | 1 line

From Evan Huus Convert a bunch more GTK-2 calls to their cross-version ws_ equivalent

To get the problems back, compile with -DBREAK_GTK3


svn path=/trunk/; revision=43787
2012-07-18 17:38:19 +00:00
Gerald Combs 2643a5b02d Update qtshark to match the recent file dialog changes.
svn path=/trunk/; revision=43786
2012-07-18 16:40:34 +00:00
Gerald Combs e1bf3c011e Fill in our display filter after we open a file.
svn path=/trunk/; revision=43785
2012-07-18 15:29:13 +00:00
Balint Reczey 1f37a8cf14 Fix crash in PPP dissector
Make sure that there is enough space allocated for PPP encapsulated CRTP
packet's header.
The bug can be triggered on an x86_64 system using the cpature file attached to
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680056

svn path=/trunk/; revision=43784
2012-07-18 15:14:45 +00:00
Pascal Quantin 2350d1aecf Put back r43768 that got removed by error in r43781
svn path=/trunk/; revision=43783
2012-07-18 08:37:46 +00:00
Anders Broman 0649041b1c Merge the rest of Jacob Nordgren and Rishie Sharmas work on
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43782
2012-07-18 07:47:05 +00:00
Anders Broman fccbea6702 Merge the rest of Jacob Nordgren and Rishie Sharmas work on
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43781
2012-07-18 07:45:19 +00:00
Guy Harris 9d470cceb9 Clean up indentation.
svn path=/trunk/; revision=43780
2012-07-18 04:45:41 +00:00
Evan Huus a234b68ff0 Fix some system header files that were #included with "" instead of <>.
They made cppcheck unhappy.

svn path=/trunk/; revision=43779
2012-07-18 02:47:56 +00:00
Evan Huus 6e8258be9a Add basic CppCheck configuration and runner.
Probably subject to change as it gets integrated into the build-bot.

svn path=/trunk/; revision=43778
2012-07-18 02:30:35 +00:00
Martin Mathieson c0a913afda Match R9 versions of some more LTE protocols to registered dissector names.
svn path=/trunk/; revision=43777
2012-07-18 01:19:48 +00:00
Guy Harris 3074044f77 Set the folder to the containing directory of the file name in question,
not to the file itself (the file itself will be a plain file, so that
will fail).

svn path=/trunk/; revision=43776
2012-07-17 21:44:41 +00:00
Pascal Quantin c0a5bc9aa8 Fix copy/paste error
svn path=/trunk/; revision=43775
2012-07-17 21:36:34 +00:00
Jörg Mayer c8579ac82c - Make dns srv elemnts filterable (were: text only)
- Don't suppress first character in srv service and protocol
  as some services don't use _ as first character

svn path=/trunk/; revision=43774
2012-07-17 21:10:02 +00:00
Jakub Zawadzki b4ec6ba914 Fix comments, from r43729 we don't load bold font.
svn path=/trunk/; revision=43773
2012-07-17 20:52:16 +00:00
Pascal Quantin 574f57d5ba From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7491 :
DNP3 protocol dissector does not fully decode application layer object 50 variation 3

svn path=/trunk/; revision=43772
2012-07-17 19:54:35 +00:00
Pascal Quantin e9de91f53e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7470 :
Add support for OID 1.3.6.1.5.2.2

svn path=/trunk/; revision=43771
2012-07-17 19:43:17 +00:00
Chris Maynard ae8d9d4461 Fix Coverity CID 709722: Logically dead code.
svn path=/trunk/; revision=43770
2012-07-17 19:43:08 +00:00