osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
46,918 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

2677 Commits

Author SHA1 Message Date
Martin Kaiser 38a73a32f3 include the wsutil/wsgcrypt.h instead of including gcrypt.h directly 
svn path=/trunk/; revision=47802
 2013-02-21 18:23:29 +00:00
Guy Harris c5f0b68669 And one more case where tvb_new_subset_remaining() is appropriate. 
svn path=/trunk/; revision=47760
 2013-02-20 01:38:58 +00:00
Guy Harris 021069a56b Clean up white space - get rid of 4-space tabs. 
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).

svn path=/trunk/; revision=47759
 2013-02-20 01:37:08 +00:00
Guy Harris 29715ccc8f How can I get a new tvbuff that starts at an offset within a given 
tvbuff and runs to the end of the tvbuff?  Let me count the ways....

Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().

svn path=/trunk/; revision=47751
 2013-02-19 23:17:07 +00:00
Anders Broman 9736ff7cb5 Remove experiment with global code 
svn path=/trunk/; revision=47747
 2013-02-19 18:53:47 +00:00
Anders Broman fc2b80ac0b Add the remaining asn1 files "CODE global" not handled yet. 
svn path=/trunk/; revision=47746
 2013-02-19 18:44:06 +00:00
Anders Broman b38062ff8f Dissect more supplementarry services 
svn path=/trunk/; revision=47738
 2013-02-18 19:34:04 +00:00
Anders Broman 399f019522 Add more ASN1 files. 
svn path=/trunk/; revision=47730
 2013-02-18 06:26:09 +00:00
Michael Mann fd44f9a339 Remove C++ incompatibilities in c1222 dissector. 
Also addresses an implicit cast in the epan/uat.h file

Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)

svn path=/trunk/; revision=47721
 2013-02-17 22:15:16 +00:00
Guy Harris 61f7b3e031 Squelch some more warnings. 
svn path=/trunk/; revision=47717
 2013-02-17 20:00:53 +00:00
Guy Harris 947da615c4 Squelch some warnings. 
svn path=/trunk/; revision=47716
 2013-02-17 19:58:56 +00:00
Anders Broman ad636a9492 Try to fix merge problem. 
svn path=/trunk/; revision=47714
 2013-02-17 19:35:17 +00:00
Anders Broman 9341c04a12 Add a preferense to the Q.932 dissector wether facility messages should be dissected as QSIG or ETSI. 
Add the ISUP Supplementary services dissector.

svn path=/trunk/; revision=47713
 2013-02-17 19:28:59 +00:00
Guy Harris 1e389e91c1 Give it an RCS ID. 
svn path=/trunk/; revision=47710
 2013-02-17 19:08:12 +00:00
Guy Harris 4e16c03bd1 Get rid of trailing CRs, set the usual svn properties to expand $Id$ and 
use native line endings.

svn path=/trunk/; revision=47709
 2013-02-17 19:07:27 +00:00
Anders Broman f942b5e12a Add isdn-sup to the asn1 makefiles. 
svn path=/trunk/; revision=47707
 2013-02-17 18:32:35 +00:00
Anders Broman 7a60d0d9eb Add the files for an initial ISDN Supplimentary Services(ETSI) dissector. 
svn path=/trunk/; revision=47706
 2013-02-17 18:27:04 +00:00
Pascal Quantin 9dc510fc8e Fix typo error 
svn path=/trunk/; revision=47693
 2013-02-16 13:55:10 +00:00
Michael Mann 46dbc91896 Add decryption algorithm preference to SNMP dissector. 
Bug 8328 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8328)

svn path=/trunk/; revision=47690
 2013-02-16 02:10:50 +00:00
Pascal Quantin 203e7e0301 Factorize FGI dissection 
svn path=/trunk/; revision=47654
 2013-02-14 10:09:46 +00:00
Anders Broman e5556e29ce Export TBCD-STRING. 
svn path=/trunk/; revision=47496
 2013-02-05 15:12:13 +00:00
Bill Meier 8ef31f222e Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start of comment' within a text string. 
svn path=/trunk/; revision=47446
 2013-02-02 14:20:15 +00:00
Pascal Quantin 98c1748e12 Add SIB type to info column 
svn path=/trunk/; revision=47394
 2013-01-31 20:08:38 +00:00
Anders Broman 4a8f124c43 Add an OID translation. 
svn path=/trunk/; revision=47386
 2013-01-31 16:59:39 +00:00
Michael Mann 8ad4ccb850 Allow SNMP user table entry to be re-editted even if engineID/Username remains the same. 
Bug 2426 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426)

svn path=/trunk/; revision=47328
 2013-01-28 21:08:14 +00:00
Pascal Quantin df466c5940 Remove duplicate include file 
svn path=/trunk/; revision=47275
 2013-01-25 18:37:00 +00:00
Pascal Quantin fd659d2b4a Fix dissection of ETWS/CMAS messages 
svn path=/trunk/; revision=47274
 2013-01-25 18:33:07 +00:00
Pascal Quantin eaf731ccad Remove non ASCII character 
svn path=/trunk/; revision=47273
 2013-01-25 16:50:05 +00:00
Anders Broman ce6025b059 Dissect Broadcast-Message-Content correctly. 
svn path=/trunk/; revision=47272
 2013-01-25 15:29:19 +00:00
Tomas Kukosa 5d3ff466da Fix H.460.9 numbers of parameters 
svn path=/trunk/; revision=47256
 2013-01-24 11:54:18 +00:00
Tomas Kukosa d19cde439e Fix H.460.x calling from H.225 - content decoding 
svn path=/trunk/; revision=47253
 2013-01-24 10:11:02 +00:00
Anders Broman 5bd9f6aa9d Add sGSNPLMNIDChange 
svn path=/trunk/; revision=47250
 2013-01-24 09:53:57 +00:00
Jeff Morriss ce5adea80a Try making dataCodingScheme a guint32 to quiet the MacOS buildbots. 
svn path=/trunk/; revision=47244
 2013-01-24 02:28:12 +00:00
Pascal Quantin 9cf7642d19 Allow dissection of several segmented warning messages in parallel 
svn path=/trunk/; revision=47236
 2013-01-23 21:55:07 +00:00
Anders Broman b7548f11bd Update to 3GPP TS 25.419 V11.0.0 (2012-09) no change in asn1. 
svn path=/trunk/; revision=47192
 2013-01-21 07:09:13 +00:00
Pascal Quantin 1a182e2a79 Dissect ETWS and CMAS notifications 
svn path=/trunk/; revision=47177
 2013-01-20 17:14:24 +00:00
Graham Bloice cf4fcaa8b6 snmp dissector did not correctly set length of pdu's of more than 127 bytes. The dissector assumed the ber identifier and length fields were always 2 bytes long, so a pdu length of more than 127 bytes, which requires more than 1 length octet, was incorrectly dissected. 
svn path=/trunk/; revision=47173
 2013-01-20 10:01:34 +00:00
Evan Huus 518eee193b Use epan-scoped memory to clean up another 1Kb+ of valgrind 
sorta-false-positive leaks.

svn path=/trunk/; revision=47170
 2013-01-19 20:14:42 +00:00
Jaap Keuter f177deead0 Fix for CID 280252. 
We can be sure we've at least 0 bytes remaining in the TVB.

svn path=/trunk/; revision=47162
 2013-01-19 13:06:26 +00:00
Jeff Morriss 1a93ee3345 Based on http://ask.wireshark.org/questions/17661/tcap-decoding-bug : 
Register the Camel dissector for SSN 146 instead of (GSM MAP's) SSN 6-9.
Looks like the 6-9 list was a carryover from when this dissector was created
based on the GSM MAP dissector.

svn path=/trunk/; revision=47097
 2013-01-15 16:44:02 +00:00
Pascal Quantin d3e4d6c972 Upgrade RRC dissector to v11.4.0 
svn path=/trunk/; revision=47041
 2013-01-11 23:25:30 +00:00
Pascal Quantin 1ca9d5c2b3 Upgrade LPP dissector to v11.1.0 and modify extract_asn1_from_spec.pl to automatically get ASN.1 from spec 
svn path=/trunk/; revision=47034
 2013-01-11 19:31:15 +00:00
Anders Broman 614441f9e5 #if 0 out unused code 
svn path=/trunk/; revision=47017
 2013-01-10 12:42:07 +00:00
Anders Broman 84a8c1d83a From an.huang: 
(1) support for optional attribute in Sample Value:
    datSet    (0x81), 
    refrTm    (0x84), 
    smpRate   (0x86),
    smpMod    (0x88). New attribute in 9-2 Ed2
(2) Data (0x87) decoded as PhsMeas in 9-2 LE(Lite Edition) recommemdation is removed, now the data is decoded as simply OctString, just as 9-2, further details should refer to the data set definition and Table 14 in Ed1 / Table 15 in Ed2  Encoding for the basic data types;

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5696

svn path=/trunk/; revision=47016
 2013-01-10 12:13:16 +00:00
Pascal Quantin c872b1258c Dissect CDMA2000 system time 
svn path=/trunk/; revision=47001
 2013-01-08 22:29:38 +00:00
Pascal Quantin ca189246fe Upgrade LTE RRC dissector to v11.2.0 
svn path=/trunk/; revision=46959
 2013-01-06 09:56:24 +00:00
Guy Harris 1cd57ad3c5 bytestring_to_str() now returns a const char *; assign its result to a 
const char *, not a char *.

svn path=/trunk/; revision=46769
 2012-12-26 10:54:03 +00:00
Guy Harris 8ed7a73e22 Fix a bunch of warnings. 
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
 2012-12-26 05:57:06 +00:00
Guy Harris 954b90418a Squelch a qualifier-discard warning. 
svn path=/trunk/; revision=46664
 2012-12-21 11:04:10 +00:00
Guy Harris 69270d1bea Get rid of unused routines for UDC-type. 
svn path=/trunk/; revision=46662
 2012-12-21 10:52:29 +00:00
Jeff Morriss 09221f45e4 When copying addresses, also copy the (new) hf field. 
Use SET_ADDRESS in some dissectors that weren't using it (so that the hf field
is correctly initialized).

Introduce a COPY_ADDRESS_SHALLOW (which copies an address without copying the
contents of the data field).

svn path=/trunk/; revision=46602
 2012-12-18 23:28:38 +00:00
Pascal Quantin e5fc8a400e Fix what seems to be a typo error 
svn path=/trunk/; revision=46528
 2012-12-13 17:57:37 +00:00
Pascal Quantin 53edadd49b From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 : 
H.248 MEGACO PkgName property is poorly formatted

svn path=/trunk/; revision=46526
 2012-12-13 14:24:44 +00:00
Stig Bjørlykke f6f46de2ca Moved users table lookup to find_oid_by_pres_ctx_id() so other 
dissectors (acse, ros, rtse) can benefit from the configured settings.

svn path=/trunk/; revision=46520
 2012-12-12 15:17:36 +00:00
Anders Broman 5c1bc94608 "Fill" a couple of value_string(ext) 
svn path=/trunk/; revision=46518
 2012-12-12 12:48:12 +00:00
Stig Bjørlykke 38aeb0e1e3 Added deltaRevocationList. 
svn path=/trunk/; revision=46438
 2012-12-07 11:40:29 +00:00
Bill Meier 52e47754f1 Fix [-Wshadow] warnings. 
svn path=/trunk/; revision=46357
 2012-12-03 22:27:46 +00:00
Pascal Quantin 91576e1f70 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8023 : 
Fix typo in LPPa protocol name

svn path=/trunk/; revision=46300
 2012-11-30 08:34:50 +00:00
Jeff Morriss 0266cceef3 Make all enum_val_t's const. 
svn path=/trunk/; revision=46292
 2012-11-29 20:15:37 +00:00
Pascal Quantin 17781b66bf Add missing OPTIONAL keyword in RRCConnectionRequest message 
svn path=/trunk/; revision=46202
 2012-11-26 13:21:18 +00:00
Guy Harris e5c2f19eab You can't return from inside a TRY/CATCH/ENDTRY block (see 
epan/exceptions.h; it crashes).

Try BER first, including both the test dissection and the check of the
results.  If that fails due to an exception being thrown, or due to the
results not indicating that it's a BER-encoded T.125 packet, try PER, so
that if the BER dissection doesn't work we don't just give up.

Get rid of some _U_s attached to parameters that are, in fact, used.

svn path=/trunk/; revision=46066
 2012-11-18 01:39:32 +00:00
Guy Harris 2254dcaa00 In the heuristic T.124 dissector, catch BoundsError and 
ReportedBoundsError exceptions when attempting to dissect the first bit
of the packet and, if either is thrown, assume the packet isn't a packet
for what we were trying to dissect, rather than just completely failing.

Return TRUE if the heuristic T.124 dissector recognizes the packet.

Get rid of some _U_s attached to parameters that are, in fact, used.

svn path=/trunk/; revision=46064
 2012-11-18 01:32:31 +00:00
Stig Bjørlykke d93bf350b5 Added a try-catch in the heuristics to avoid a false malformed packet 
error when having no data (occurs in COTP CR and CC).

svn path=/trunk/; revision=46038
 2012-11-16 10:20:36 +00:00
Anders Broman be29436715 If we have an com_context_id entry reuse that. 
svn path=/trunk/; revision=46036
 2012-11-16 09:41:26 +00:00
Anders Broman ab3111f465 Add and prettify debug info - will regenerate dissector later 
svn path=/trunk/; revision=46034
 2012-11-15 06:32:35 +00:00
Anders Broman 02287c05d6 Dissable code causing a crash. Add debug printouts and add a few more visited checks. 
svn path=/trunk/; revision=46029
 2012-11-14 16:46:57 +00:00
Pascal Quantin 8acaffff82 Pacify OSX-10.5 buildbots 
svn path=/trunk/; revision=46017
 2012-11-13 07:40:23 +00:00
Stig Bjørlykke f267dda0d5 Added attributes from RFC 2798. 
svn path=/trunk/; revision=46013
 2012-11-12 22:00:53 +00:00
Pascal Quantin 4e96e6c475 Fix detection of H-RNTI when it is given after the DL-TransportChannelType configuration (typically in case of handoverToUTRANCommand) 
svn path=/trunk/; revision=46012
 2012-11-12 21:39:14 +00:00
Stig Bjørlykke 6a64309b02 Fixed some typos 
svn path=/trunk/; revision=46009
 2012-11-12 14:09:51 +00:00
Stig Bjørlykke d728699115 Update ACP133 to edition D. 
svn path=/trunk/; revision=46008
 2012-11-12 13:45:24 +00:00
Pascal Quantin bf4ea56713 Use a subtree for message containers 
svn path=/trunk/; revision=45986
 2012-11-09 22:04:14 +00:00
Stig Bjørlykke f4ade83844 Only append oid name to parent item once when having RDN as a attribute. 
svn path=/trunk/; revision=45965
 2012-11-08 08:42:45 +00:00
Pascal Quantin 6d044f3281 Avoid accessing a no more valid tvbuff 
svn path=/trunk/; revision=45957
 2012-11-07 00:00:57 +00:00
Pascal Quantin d7d1840e67 Fix dissection of NAS security parameters to/from E-UTRA 
svn path=/trunk/; revision=45950
 2012-11-06 19:33:27 +00:00
Anders Broman 9bdaeafabf Dissect lat. long and Uncertainty-Code. 
svn path=/trunk/; revision=45946
 2012-11-06 09:22:29 +00:00
Anders Broman 4ceb76265a Dissect the positioning data. 
svn path=/trunk/; revision=45932
 2012-11-05 16:28:53 +00:00
Anders Broman f88ffd78f3 Use little endian MNC encoding. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7952

svn path=/trunk/; revision=45931
 2012-11-05 15:15:54 +00:00
Anders Broman fb46fccec4 From LI Hai: 
According to Table 161 in ETSI 392-2 standard, the Class of MS field in
U-LOCATION UPDATE DEMAND in tetra.asn is incorrect. the type of Class of MS
field should be Type 2, not Type 1, and the length should be 24 bits, not
32bits.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7946

svn path=/trunk/; revision=45857
 2012-11-01 09:11:06 +00:00
Chris Maynard 6a4eed57f2 To indicate that all bytes in the tvb were consumed, just return tvb_reported_length(). 
svn path=/trunk/; revision=45775
 2012-10-24 19:13:54 +00:00
Anders Broman 8d178187e3 AddressString can have a size of 1, fixes Bug 7882 -GSM_MAP show malformed Packets when two IMSI https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7882 
svn path=/trunk/; revision=45687
 2012-10-21 15:01:23 +00:00
Anders Broman eb618abad9 From Bill Parker: 
Explicitly declare/cast 'unsigned <variable>' as 'unsigned int <variable>'

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7810

svn path=/trunk/; revision=45418
 2012-10-09 08:40:02 +00:00
Pascal Quantin 1b3fd6e7e1 Upgrade LTE RRC dissector to v11.1.0 
svn path=/trunk/; revision=45215
 2012-09-30 08:06:50 +00:00
Pascal Quantin da4b39e720 Revert r21471: previous decoding of APN was matching 3GPP 23.003 chapter 9.1 and the pcap file attached to bug 1543 is not valid 
svn path=/trunk/; revision=45194
 2012-09-28 16:31:08 +00:00
Pascal Quantin 559a26361a Upgrade LTE Positioning Protocol to V11.0.0 
svn path=/trunk/; revision=45193
 2012-09-28 15:40:14 +00:00
Pascal Quantin 7dd916459e Let's be consistent and display lte_rrc root for all LTE RRC messages 
svn path=/trunk/; revision=45080
 2012-09-23 21:01:05 +00:00
Jeff Morriss 3551a86c36 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45015
 2012-09-20 01:29:52 +00:00
Pascal Quantin 0543f20a15 From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7736 : 
Fix dissection error of D-RELEASE and D-CONNECT in TETRA dissector

svn path=/trunk/; revision=45004
 2012-09-19 11:02:19 +00:00
Pascal Quantin 1bdf9a8912 Upgrade LTE RRC dissector to v11.0.0 
svn path=/trunk/; revision=44875
 2012-09-11 10:08:41 +00:00
Jakub Zawadzki a406bb1a50 Add data parameter to dissector_try_uint_new 
svn path=/trunk/; revision=44874
 2012-09-11 09:06:48 +00:00
Jakub Zawadzki 9f92dc93c5 Add data parameter to call_dissector_only. 
svn path=/trunk/; revision=44872
 2012-09-11 08:28:07 +00:00
Jakub Zawadzki dee4443809 Add data parameter to dissector_try_heuristic 
svn path=/trunk/; revision=44871
 2012-09-11 08:26:48 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Jakub Zawadzki 0176a135db Propage changes done in generated dissectors to asn1/ 
svn path=/trunk/; revision=44845
 2012-09-10 15:24:00 +00:00
Jakub Zawadzki 5ad3e5331e MT: move global frame_end_routines to packet_info. 
svn path=/trunk/; revision=44748
 2012-09-03 12:00:40 +00:00
Michael Mann 6f8f3fdd42 match display filter prefix for all filters 
svn path=/trunk/; revision=44653
 2012-08-24 02:48:36 +00:00
Anders Broman 2b905a1b6a Add French National parameter https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7656 
svn path=/trunk/; revision=44612
 2012-08-22 13:35:20 +00:00
Pascal Quantin f2fbb79c49 Add dissection of locationInformation IE in Ericsson proprietary extension 
svn path=/trunk/; revision=44605
 2012-08-21 15:14:50 +00:00
Pascal Quantin 9f3c1253f7 Fix filter names for Ericsson proprietary extensions 
svn path=/trunk/; revision=44604
 2012-08-21 10:40:04 +00:00
Pascal Quantin 91a531739f Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7648 : 
Add support for Ericsson proprietary extensions to GSM MAP dissector

svn path=/trunk/; revision=44603
 2012-08-21 09:32:04 +00:00
Pascal Quantin dfc983d9ce Remove unused hf_gsm_map_imsi_digits entry and fix filter name for hf_gsm_map_TBCD_digits (which is also used for IMEI, ASCI call reference, MS Group ID and MS Long Group ID on top of IMSI) 
svn path=/trunk/; revision=44596
 2012-08-20 12:47:47 +00:00
Pascal Quantin 45a25dbf9e Avoid defining 2 entries with incompatible types (FT_BYTES vs FT_NONE) and same filter 
svn path=/trunk/; revision=44595
 2012-08-20 09:28:01 +00:00
Michael Mann 6c0e747f61 use session allocated memory for rtp_add_address/srtp_add_address hash tables 
svn path=/trunk/; revision=44571
 2012-08-19 00:21:26 +00:00
Michael Mann 296871713f make hash key session scoped 
cleanup g_snprintf

svn path=/trunk/; revision=44565
 2012-08-18 19:22:22 +00:00
Guy Harris ff6a33fdb4 Mark a parameter as unused. 
Clean up indentation and get rid of trailing white space.

svn path=/trunk/; revision=44562
 2012-08-18 06:53:39 +00:00
Guy Harris 549d81fe37 epan/dissectors/packet-ansi_map.c shouldn't be edited - it's generated 
from the files in asn1/ansi_map.  Update packet-ansi_map-template.c to
reflect the use of session-scope-allocated data for the saved invoke
data, and regenerate the dissector - which means that
TransactionId_table_cleanup() still exists, and is still used, it just
frees only the hash table key, which is g_strdup()ed, not the value,
which is automatically freed when the session-scope-allocated data is
all freed.

svn path=/trunk/; revision=44561
 2012-08-18 06:33:08 +00:00
Guy Harris c3caa3ba4f epan/dissectors/packet-ansi_tcap.c shouldn't be edited - it's generated 
from the files in asn1/ansi_tcap.  Update packet-ansi_tcap-template.c to
reflect the use of session-scope-allocated data for the saved invoke
data, and regenerate the dissector - which means that
TransactionId_table_cleanup() still exists, and is still used, it just
frees only the hash table key, which is g_strdup()ed, not the value,
which is automatically freed when the session-scope-allocated data is
all freed.

svn path=/trunk/; revision=44560
 2012-08-18 06:20:32 +00:00
Pascal Quantin 983d7a543f Remove non ASCCI characters 
svn path=/trunk/; revision=44534
 2012-08-15 20:50:26 +00:00
Pascal Quantin e5b7968030 Fix some headers fields that were wrongly marked as 64 bits instead of 32 bits 
svn path=/trunk/; revision=44533
 2012-08-15 20:43:00 +00:00
Pascal Quantin 870b536e6c Fix field type for some 64 bits header fields 
svn path=/trunk/; revision=44513
 2012-08-15 13:42:46 +00:00
Pascal Quantin f464eb4b58 Fix missing dissection of HSDSCH-Paging-System-InformationFDD (bug introduced in r44037) and HSDSCH-MACdPDUSizeFormat (bug introduced in r44423). 
While we are at it, fix a few typo errors.

svn path=/trunk/; revision=44434
 2012-08-10 18:41:40 +00:00
Anders Broman 3cf2df1ef5 Try to make the buildbot happy. 
svn path=/trunk/; revision=44425
 2012-08-10 15:59:35 +00:00
Anders Broman 0e68cac192 From Jacob Nordgren and Rishie Sharma: 
RLC: changed so reassembly fail flag is set per channel instead of globally.
RLC: added reset channel function
Added support for reconfigurin HSDSCH flows, and E-DCH flows (just needs to figure out when it should become active for 'overloaded' ports), also changed slightly how ehs headers are configured in nbap.
Removed extra (debugging)  port in nbap

This is the last patch set for a while.

svn path=/trunk/; revision=44423
 2012-08-10 15:22:50 +00:00
Anders Broman 12d6721d86 Fix a comment. 
svn path=/trunk/; revision=44386
 2012-08-09 17:11:53 +00:00
Anders Broman 508e1c3027 From Jacob Nordgren and Rishie Sharma: 
FP: fixed exotic bug where fakes counter was sometimes not reset, RRC: fixed bug where num_chans_per_flow was not properly cleared

svn path=/trunk/; revision=44375
 2012-08-09 10:06:01 +00:00
Pascal Quantin 25523bd0bf Various small changes: 
- add a missing test on null pointer
- always initialize rrc_nas_sys_info_gsm_map_type with a value from its associated enum
- fix some typo errors
- remove some useless directives from conformance file
- detabify files (ASN.1 generated dissectors are indented with spaces)

svn path=/trunk/; revision=44358
 2012-08-08 20:43:48 +00:00
Anders Broman a1218c94c9 From Jacob Nordgren and Rishie Sharma: 
- FP: added header CRC validation, added crc11.c and crc11.h in wsutil/ for EDCH 11 bit CRC, fixed bug in RRC,
And also smaller bugfixes in umts_fp and rrc.

svn path=/trunk/; revision=44349
 2012-08-08 17:24:14 +00:00
Anders Broman 704e2f524e From Jacob Nordgren and Rishie Sharma: 
NBAP: fixed segfault, FP: aesthetic fix, RLC: added channel info to GUI, MAC-is: fixed case with reassembly when a middle segment arrives 

 MAC, RLC, added preferences for LI-size and TSN-size

svn path=/trunk/; revision=44205
 2012-08-02 14:03:17 +00:00
Pascal Quantin 025200992d Follow-up of r44162: gsm_a_gm dissector is used for both GPRS Mobility Management and Session Management protocols. Update filter names accordingly. 
svn path=/trunk/; revision=44183
 2012-08-01 09:44:57 +00:00
Chris Maynard c38a247faa Fix Coverity CID 280019 (formerly 19): "Logically dead code" that abroman previously commited a fix for in r17532, but forgot to also commit a change to asn1/snmp/packet-snmp-template.c as well, so the change was apparently inadvertently reverted the next time that packet-snmp.c was regenerated. 
svn path=/trunk/; revision=44179
 2012-08-01 02:08:29 +00:00
Anders Broman 796bbde5d3 - Put back not used constants to fill value_strings_ext. 
- Don't dissect RRC container, it seems to only cause grief.

svn path=/trunk/; revision=44156
 2012-07-31 13:49:39 +00:00
Jakub Zawadzki b503d9d659 Restore includes from r44107 to fix abi check. 
Reverted (by mistake?) in r44129

svn path=/trunk/; revision=44154
 2012-07-31 08:40:22 +00:00
Anders Broman ad95fa259b From Jacob Nordgren and Rishie Sharma: 
NBAP: added preferences to change logical channel id to mac content type mapping.

svn path=/trunk/; revision=44151
 2012-07-31 06:56:13 +00:00
Chris Maynard 4efded1f50 Fix Coverity CID 712343: Wrong sizeof argument. 
svn path=/trunk/; revision=44136
 2012-07-30 13:38:51 +00:00
Anders Broman ee071c887a From Jacob Nordgren and Rishie Sharma: 
-MAC-is update

svn path=/trunk/; revision=44129
 2012-07-30 08:37:00 +00:00
Jakub Zawadzki e66f10b125 Try to fix ABI check. 
svn path=/trunk/; revision=44107
 2012-07-29 16:12:17 +00:00
Anders Broman ad7c4a4bba From Jacob Nordgren and Rishie Sharma: 
- Added basic support for tracking flows over reconfigured transport channels + mindor bugfixes 

- small fix in rrc, and some small cleanups

svn path=/trunk/; revision=44062
 2012-07-27 08:10:31 +00:00
Michael Tüxen 69ee8e5a72 Changes corresping to 
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44040

svn path=/trunk/; revision=44041
 2012-07-26 12:51:30 +00:00
Anders Broman 180f7aa1e0 From Jacob Nordgren and Rishie Sharma: 
-  FP and RLC fixed spelling 
- Fixed variable declaration in RRC 
- removed extra ppi in nbap

svn path=/trunk/; revision=44035
 2012-07-26 09:42:07 +00:00
Anders Broman aed65b0c7b From Jacob Nordgren and Rishie Sharma: 
- RRC now configures logical channels in HS-DSCH hs, and some HSDSCH common support added 
- RLC: modifed memory management, MAC: dch would set the incorrect logical channel for RLC

svn path=/trunk/; revision=44027
 2012-07-26 08:15:20 +00:00
Pascal Quantin 996e2f58b8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7508 : 
Display snmp.contextName as FT_STRING

svn path=/trunk/; revision=43883
 2012-07-21 08:50:32 +00:00
Pascal Quantin 2350d1aecf Put back r43768 that got removed by error in r43781 
svn path=/trunk/; revision=43783
 2012-07-18 08:37:46 +00:00
Anders Broman fccbea6702 Merge the rest of Jacob Nordgren and Rishie Sharmas work on 
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43781
 2012-07-18 07:45:19 +00:00
Pascal Quantin e9de91f53e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7470 : 
Add support for OID 1.3.6.1.5.2.2

svn path=/trunk/; revision=43771
 2012-07-17 19:43:17 +00:00
Pascal Quantin c2883b7be2 Fix 'dereferencing type-punned pointer will break strict-aliasing rules' warning when compiling with gcc 4.1.3 
svn path=/trunk/; revision=43768
 2012-07-17 14:55:27 +00:00
Pascal Quantin 3a682212f5 Remove extra space after message name 
svn path=/trunk/; revision=43760
 2012-07-17 10:13:22 +00:00
Pascal Quantin a76f4990b8 Comment a few unused variables / functions 
svn path=/trunk/; revision=43754
 2012-07-16 15:54:53 +00:00
Anders Broman fe630ec1df From Jacob Nordgren and Rishie Sharma: 
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43749
 2012-07-16 13:11:20 +00:00
Anders Broman ac335fc5f4 From Jacob Nordgren and Rishie Sharma: 
Handle RRC_MESSAGE_TYPE_BCCH_FACH.

svn path=/trunk/; revision=43741
 2012-07-16 07:02:29 +00:00
Chris Maynard a592bd657c tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID 281367: Improper use of negative value. 
svn path=/trunk/; revision=43698
 2012-07-13 21:03:54 +00:00
Chris Maynard 4d180fbe32 tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID's 280233 and 280234. 
svn path=/trunk/; revision=43697
 2012-07-13 20:47:08 +00:00
Anders Broman 6dfa10bc57 Revert part of revision 43107 which broke sub dissection of 
Signal and events as a new tvb wasn't created. 
|BASE_EXT_STRING also removed.

svn path=/trunk/; revision=43661
 2012-07-11 14:40:35 +00:00
Pascal Quantin 1410207421 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7438 : 
Do not call tvb_ensure_length_remaining on an empty tvb

svn path=/trunk/; revision=43648
 2012-07-10 15:43:03 +00:00
Anders Broman 8ecd85f1ad Introduce a preference setting for application context version. 
svn path=/trunk/; revision=43641
 2012-07-10 11:39:06 +00:00
Pascal Quantin 4705839f11 Update comments 
svn path=/trunk/; revision=43629
 2012-07-09 21:04:50 +00:00
Pascal Quantin 309e6646f7 Add LTE Positioning Protocol Extensions dissector 
Upgrade LTE Positioning Protocol to V10.5.0

svn path=/trunk/; revision=43628
 2012-07-09 20:55:09 +00:00
Anders Broman eedc186e94 Dissect Release 8 CDR:s 
svn path=/trunk/; revision=43624
 2012-07-09 14:09:59 +00:00
Guy Harris 659cf0527a UATs could be put into "categories". The categories were defined only 
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).

The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not.  It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.

Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist".  Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.

Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.

svn path=/trunk/; revision=43603
 2012-07-08 01:00:46 +00:00
Pascal Quantin a7fef5b3bf Upgrade LTE RRC dissector to v10.6.0 
svn path=/trunk/; revision=43571
 2012-07-05 08:44:30 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00