Commit Graph

390 Commits

Author SHA1 Message Date
Ulf Lamping 3a0c285065 fix return types, hopefully this will make the osx buildbot happy
svn path=/trunk/; revision=22531
2007-08-16 22:45:36 +00:00
Ulf Lamping 4b215597ae experimental feature: dissector filters
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI


svn path=/trunk/; revision=22530
2007-08-16 22:03:10 +00:00
Ulf Lamping 2d11b0813e mark some parameters as unused
svn path=/trunk/; revision=22445
2007-08-03 20:07:06 +00:00
Ulf Lamping 12aed7290c - add PDInterfaceFSUDataAdjust block
- start to implement an AR conversation handler

svn path=/trunk/; revision=22444
2007-08-03 19:29:34 +00:00
Ulf Lamping f4cabf95a1 update PTCP dissection to latest specification draft
svn path=/trunk/; revision=22432
2007-07-31 19:01:15 +00:00
Ulf Lamping 6970aff017 add helper function dissect_pn_int32()
svn path=/trunk/; revision=22431
2007-07-31 18:57:51 +00:00
Ulf Lamping 85e09ecdd5 fix unused parameter warning by adding _U_
svn path=/trunk/; revision=22400
2007-07-25 08:38:31 +00:00
Ulf Lamping 9f2478f46c from HPfrommer@hilscher.com:
I’ve fixed a bug in the Profinet-Dissector 
(plugins/profinet/packet-dcerpc-pn-io.c).

In PROFINET IO DCE RPC write-requests, only the first IR frame dataset 
in PDIRFrameData was dissected.

I’ve fixed the problem, now all IR frame datasets are dissected into 
individual sub-trees.

svn path=/trunk/; revision=22398
2007-07-24 21:15:34 +00:00
Ulf Lamping a5ba21acf8 remove ProvCRID from expert info output, so the composite view is more compact
svn path=/trunk/; revision=22386
2007-07-23 20:08:53 +00:00
Ulf Lamping 94b3dbf3f6 add dissection of blocks:
{ 0x021E, "CheckSyncDifference"},
	{ 0x021F, "CheckMAUTypeDifference"},

svn path=/trunk/; revision=22385
2007-07-23 20:07:51 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris a7c42e75e0 Use $(PLUGIN_LDFLAGS) for LDFLAGS.
svn path=/trunk/; revision=21963
2007-05-27 18:56:39 +00:00
Guy Harris d99b6c0a8b Clean up white space.
svn path=/trunk/; revision=21959
2007-05-27 18:30:03 +00:00
Ulf Lamping 2fd09672de add dissection of PortTime
svn path=/trunk/; revision=21360
2007-04-10 02:26:39 +00:00
Gerald Combs 5620d4fa15 Add the make-dissector-reg scripts to the dependency list for each copy
of plugin.c.

svn path=/trunk/; revision=21342
2007-04-05 23:23:06 +00:00
Ulf Lamping 0104002d2e Add PN-IO FSHelloBlock and PN-DCP Device/AliasName
svn path=/trunk/; revision=21298
2007-04-02 05:18:31 +00:00
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher 8973617e4b From Sebastien Tandel:
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.


svn path=/trunk/; revision=21155
2007-03-23 18:16:53 +00:00
Stephen Fisher 62f88a4a04 From Sebastien Tandel:
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)

   Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)


svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
Stephen Fisher cdf47e536b Add -Werror when using GCC only to the Makefile.am of the base
directory and most of the plugins to match the same command 
put in the Makefile.nmake files for Windows compliations.  Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD.  Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition. 


svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
Ulf Lamping af9ae7eebb set CFLAGS to block new warnings for all plugins (except for giop and h223, which has remaining issues - for now)
svn path=/trunk/; revision=21102
2007-03-21 23:59:41 +00:00
Ulf Lamping c3bf838051 as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Ulf Lamping e30640be45 PROFINET RT frames can also be transported over UDP Port 0x8892 - to be routable
svn path=/trunk/; revision=20985
2007-03-06 21:54:53 +00:00
Ulf Lamping 00335ac48e fix read handling of index 0x8051 and 0xe00c
svn path=/trunk/; revision=20963
2007-03-03 09:33:02 +00:00
Jaap Keuter cf13f56dc8 -Add the compiler version to the plugin resource
-Remove the SPECIAL_BUILD tag
-Set to OS type to NT_WINDOWS32

svn path=/trunk/; revision=20934
2007-02-26 20:39:38 +00:00
Ulf Lamping cd08e6448f fix the padding in the read/write headers, some other minor changes
svn path=/trunk/; revision=20927
2007-02-25 15:50:40 +00:00
Ulf Lamping 7887d478cc add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Jaap Keuter a8fb7d24d0 Properly introduce packet-pn.c as a helper
svn path=/trunk/; revision=20903
2007-02-23 19:37:01 +00:00
Guy Harris c127df0bc8 Include <string.h> to declare memcpy().
svn path=/trunk/; revision=20842
2007-02-19 00:56:22 +00:00
Ulf Lamping 822bb2e489 fix an error added lately
svn path=/trunk/; revision=20832
2007-02-17 11:13:24 +00:00
Ulf Lamping 2172e293d6 some more compiler warnings removed
svn path=/trunk/; revision=20829
2007-02-17 09:42:38 +00:00
Ulf Lamping 16aa7c17db squelch some compiler warnings
svn path=/trunk/; revision=20828
2007-02-17 08:08:40 +00:00
Ulf Lamping d6e22b2d9a major code cleanup:
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code

svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
Ulf Lamping aad5a4e6b1 add remaining TLV blocks (complete now?)
add a lot of missing index values
fix some minor bugs

svn path=/trunk/; revision=20795
2007-02-12 19:01:20 +00:00
Ulf Lamping 44ee701ba6 remove some warnings
svn path=/trunk/; revision=20785
2007-02-11 04:12:07 +00:00
Ulf Lamping 59a86ae3e9 remove a g_warning left over from debugging
svn path=/trunk/; revision=20784
2007-02-11 03:45:21 +00:00
Ulf Lamping b04c53a23c add a lot more TLV block decodes, some code cleanup, ...
svn path=/trunk/; revision=20763
2007-02-10 08:03:47 +00:00
Ulf Lamping 98f2412a6f various major enhancements to the PROFINET-IO dissector (including some new TLV blocks)
svn path=/trunk/; revision=20751
2007-02-08 18:29:47 +00:00
Ulf Lamping 8559a25d23 - add dissection for "I&M0" block
- enhance dissection or ErrorDecode2 (ErrorCode1 rta_err_cls_protocol specific) - a lot more of ErrorCode1/ErrorCode2 combinations still to go ...

svn path=/trunk/; revision=20724
2007-02-06 01:37:32 +00:00
Ulf Lamping 39956903b5 PropagationDelayFactor -> LineDelay
svn path=/trunk/; revision=20348
2007-01-08 22:11:56 +00:00
Ulf Lamping d53f947b16 clean should also remove generated plugin.c and manifest files
svn path=/trunk/; revision=20291
2007-01-03 06:06:53 +00:00
Jaap Keuter 5800f59d15 Bump micro version number, like in moduleinfo.h
svn path=/trunk/; revision=20178
2006-12-20 10:07:20 +00:00
Ulf Lamping cc7ffdcb07 raise plugin version, as I've done some small but important changes
svn path=/trunk/; revision=20177
2006-12-19 22:44:35 +00:00
Jaap Keuter f46bd5f3b8 Add Windows version info resource.
svn path=/trunk/; revision=20169
2006-12-19 22:27:15 +00:00
Ulf Lamping 9cddaf7c84 add MaintenanceItem block dissection, fix issues with heuristic of RT classes
svn path=/trunk/; revision=20128
2006-12-12 23:50:59 +00:00
Ulf Lamping aacf309f42 add IRDataUUID to the blocks subitem
svn path=/trunk/; revision=20078
2006-12-09 09:28:29 +00:00
Ulf Lamping 1ce7261136 add dissection of the "IsochronousModeData" block
svn path=/trunk/; revision=20045
2006-12-05 08:09:01 +00:00
Ulf Lamping 647533a5ef put every python script name into "" so the call won't fail on Win32 native python.
The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

svn path=/trunk/; revision=19730
2006-10-29 17:19:52 +00:00
Ulf Lamping 161d7695eb (slightly) further dissection of the Option (Organizationally specific) block
svn path=/trunk/; revision=18997
2006-08-22 19:43:38 +00:00
Ulf Lamping c91dd2c6c2 fix TLB block alignment to be compatible with the current MRP draft. Would be nice if included in the 0.99.3
svn path=/trunk/; revision=18996
2006-08-22 19:42:04 +00:00
Ulf Lamping bd807d4b69 several minor fixes and enhancements to the dissection
svn path=/trunk/; revision=18854
2006-08-08 21:28:14 +00:00
Ulf Lamping 2981e4022a remove some warnings (2nd try)
svn path=/trunk/; revision=18635
2006-07-01 15:14:19 +00:00
Ulf Lamping 66318ef7e1 remove some "signedness" warnings
svn path=/trunk/; revision=18633
2006-07-01 12:15:37 +00:00
Ulf Lamping 95279cb92c remove a "differ in signedness" warnings
svn path=/trunk/; revision=18607
2006-06-29 08:16:57 +00:00
Ulf Lamping b41b729b2f remove some "unused parameter" warnings
svn path=/trunk/; revision=18606
2006-06-29 08:15:07 +00:00
Ulf Lamping 1896e7021d squelch some compiler warnings
svn path=/trunk/; revision=18560
2006-06-23 18:03:40 +00:00
Ulf Lamping a016d9ee45 fix a (correct) compiler warning
svn path=/trunk/; revision=18548
2006-06-22 19:17:43 +00:00
Ulf Lamping d2b72027b0 add various new dissections, enhancements to the existing dissections and update things to current spec, ...
Still incomplete, but a lot better than before :-)

svn path=/trunk/; revision=18536
2006-06-21 20:10:38 +00:00
Ulf Lamping 1d51934de2 add an expert info if a capture file contains some (yet) undecoded portions
svn path=/trunk/; revision=18534
2006-06-21 18:35:39 +00:00
Ulf Lamping 4f83154239 detect the PROFINET OUI correct if the multicast bit is set
svn path=/trunk/; revision=18528
2006-06-21 07:28:56 +00:00
Ronnie Sahlberg 62e32390b5 ethereal to wireshark changes
svn path=/trunk/; revision=18500
2006-06-17 12:07:49 +00:00
Guy Harris 1af7caeeb1 Squelch a (valid) compiler warning.
Clean up indentation a bit.

svn path=/trunk/; revision=18481
2006-06-16 07:15:03 +00:00
Ulf Lamping f1f0e294b4 (on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
add Media Redundancy and Media Redundancy Realtime Protocol dissectors (PN-MRP and PN-MRRT)

svn path=/trunk/; revision=18454
2006-06-13 18:26:49 +00:00
Ulf Lamping 7da210b418 use FT_GUID instead of FT_STRING at appropriate fields
svn path=/trunk/; revision=18439
2006-06-12 19:36:58 +00:00
Jörg Mayer 299ac5e8bc remove plugin.c in distlclean
svn path=/trunk/; revision=18312
2006-06-02 06:53:30 +00:00
Gerald Combs b15974d094 libethereal -> libwireshark. idl2eth -> idl2wrs. There are a _lot_ of
changes here.  It compiles OK on OS X, but hasn't been tested anywhere else.

svn path=/trunk/; revision=18260
2006-05-31 00:23:01 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Ulf Lamping 4b4eba7993 minor enhancements
svn path=/trunk/; revision=18009
2006-04-26 20:13:33 +00:00
Guy Harris 5e49264181 Resolve conflicts.
svn path=/trunk/; revision=17965
2006-04-23 08:23:49 +00:00
Guy Harris 5199671441 Convert most other plugin dissectors to use the make-dissector-reg
scripts.

svn path=/trunk/; revision=17961
2006-04-22 20:26:16 +00:00
Ulf Lamping a70e3c548c (on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
add Precision Time Control Protocol dissector (PTCP)

svn path=/trunk/; revision=17930
2006-04-20 19:49:12 +00:00
Ulf Lamping 22dca0c988 ... and don't forget to include emem.h!
svn path=/trunk/; revision=17577
2006-03-11 09:09:55 +00:00
Ulf Lamping 2e2c970da9 replace g_malloc and alike by their corresponding ep_ functions
svn path=/trunk/; revision=17576
2006-03-11 09:08:18 +00:00
Ulf Lamping 60869fe1cc various code cleanup (e.g. remove unrequired length parameter), should also fix coverity id 126
svn path=/trunk/; revision=17569
2006-03-10 21:34:56 +00:00
Ronnie Sahlberg 3a92bf963c fix coverity bug 122
svn path=/trunk/; revision=17527
2006-03-08 10:59:05 +00:00
Ulf Lamping eefbb60770 minor enhancements
svn path=/trunk/; revision=16485
2005-11-12 09:39:24 +00:00
Ulf Lamping e90ebfad09 minor enhancement (raised plugin version to 0.1.2):
PN-DCP: dissection of "DHCP/DHCP client identifier" suboption was added

svn path=/trunk/; revision=16377
2005-11-02 19:33:46 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Jörg Mayer 4f693dfae2 Some warning fixes for "no previous declaration"
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id


svn path=/trunk/; revision=15179
2005-08-02 05:39:45 +00:00
Jörg Mayer 30a8557868 More 'char*' -> 'const char*' changes to fix warnings.
svn path=/trunk/; revision=15015
2005-07-23 11:41:25 +00:00
Jörg Mayer 5b442f2279 After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.


svn path=/trunk/; revision=14891
2005-07-10 08:04:27 +00:00
Gerald Combs 3a6c9ab134 Fix a format string vulneratility in the AFP dissector identified
by iDEFENSE.  Add constant format strings to proto_item_append_text()
in a bunch of other dissectors.  Copy a comment from proto.c to proto.h.

svn path=/trunk/; revision=14713
2005-06-20 19:35:58 +00:00
Ulf Lamping 3ad08cb0ee raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release
svn path=/trunk/; revision=14603
2005-06-09 20:08:39 +00:00
Ulf Lamping b087ed4b6e add another tvb_ensure_bytes_exist() call
replace dissect_ndr_uuid_t by dissect_dcerpc_uuid_t, as this is the correct function to use and will prevent a problem with access to non existing private_data in dissect_ndr_uuid_t

svn path=/trunk/; revision=14506
2005-05-31 18:27:20 +00:00
Guy Harris 0c8fb767d1 Fix a call to dereference a pointer (found by a compiler warning).
svn path=/trunk/; revision=14318
2005-05-05 11:08:20 +00:00
Ulf Lamping 1a9152727b add a *lot* more dissections of the various PN-IO blocks
svn path=/trunk/; revision=14301
2005-05-03 19:58:05 +00:00
Ulf Lamping 4e3c0cde68 move the pn-dcp dissector into the profinet plugin
svn path=/trunk/; revision=14285
2005-05-03 01:39:00 +00:00
Ulf Lamping a46d7d2d59 set subversion attributes
svn path=/trunk/; revision=14249
2005-04-30 20:55:21 +00:00
Ulf Lamping 48aee19b1a move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-)
svn path=/trunk/; revision=14248
2005-04-30 20:52:20 +00:00