eaecea41a3
Get rid of non-ASCII characters.
...
Clean up white space.
Clean up capitalization a bit.
svn path=/trunk/; revision=38253
2011-07-29 10:28:29 +00:00
c6b79979c2
Get it compiling.
...
svn path=/trunk/; revision=38250
2011-07-29 07:24:15 +00:00
bbf4437af0
From Wido Kelling:
...
Add Dissection of newly released PNIO IEC 61158 Version 2.3.
From me use ENC_BIG_ENDIAN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6154
svn path=/trunk/; revision=38249
2011-07-29 05:36:57 +00:00
c34b796445
Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
...
representation. Use it rather than a raw 0x10.
Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".
Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.
Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().
Clean up white space.
svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
3826755b0a
From Roland Knall:
...
implement a named dissector for the PN/IO sub-protocol for
Profinet, as well as a heuristic dissector ("pn_io"), other protocols can
attach too.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6062
svn path=/trunk/; revision=37882
2011-07-03 19:25:34 +00:00
b223e99e5a
get_host_ipaddr() was returning numeric addresses in host byte order
...
and hostnames in network byte order. Have it return everything in
network byte order.
svn path=/trunk/; revision=36873
2011-04-26 17:13:37 +00:00
ed3a223400
From http://www.wireshark.org/lists/wireshark-dev/201104/msg00231.html
...
Always use the returned tree value of proto_tree_add_subtree (and not the item!)
svn path=/trunk/; revision=36801
2011-04-22 13:07:11 +00:00
83aea790d4
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=36772
2011-04-21 16:01:03 +00:00
ab38454697
Fix Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36754
2011-04-21 13:32:11 +00:00
4b87a3d770
CID 1161: Not really used variable
...
svn path=/trunk/; revision=36725
2011-04-19 21:20:15 +00:00
8efd127f31
CID 1162: Not really used variable
...
svn path=/trunk/; revision=36724
2011-04-19 21:15:58 +00:00
888880eb25
Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.
...
Coverity 535.
svn path=/trunk/; revision=36282
2011-03-23 07:34:00 +00:00
d3efa3ed9f
A bit of Windows makefiles rework and cleanup:
...
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
(This allows disabling "Warnings as Errors" by just changing config.nmake)
c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
-DWIN32 and -DNULL=0 do not appear to be needed (any more);
-D_MT and _D_DLL are not needed since /MP causes these definitions.
d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...
svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
f53744b59d
There's no need to pass the result of tvb_get_ptr() as the 'value' in
...
proto_tree_add_*(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().
svn path=/trunk/; revision=35603
2011-01-21 03:00:31 +00:00
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
333ef8b5b7
Removed unused hf_pn_dcp and hf_pn_ptcp.
...
svn path=/trunk/; revision=34544
2010-10-17 16:49:10 +00:00
7502bd4a8f
From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5300 :
...
In the profinet plugin, the decoding of the MRP LinkUp and MRP LinkDown
messages is missing the MRP_SA field which garbles the decode of the rest of
the packet.
This fix adds the decoding of the MRP_SA field to the MRP LinkUp and MRP
LinkDown dissectors.
svn path=/trunk/; revision=34524
2010-10-15 17:17:04 +00:00
2d9d0900c5
From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5299 :
...
In profinet plugin, there is a dissection based on whether the read data
returned is expected to contain a single or multiple blocks. Currently, the
I&M0FilterData case assumes only a single block is returned. Profinet specifies
two optional additional blocks.
This change moves I&M0FilterData to expect multiple blocks to correct decode
the optional information.
svn path=/trunk/; revision=34523
2010-10-15 17:10:29 +00:00
5984fb4888
From Yu Zhang:
...
MRP packet is not correctly parsed in PROFINET multiple write record request.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5267
svn path=/trunk/; revision=34358
2010-10-04 06:16:45 +00:00
ac3ac6c476
Plugins are not shared libraries, so:
...
1) don't set thei SOVERSION - run-time-loaded modules don't have
an SOVERSION;
2) build them with link mode MODULE, not SHARED, on all
platforms.
(Fixing 1) also fixes the problem with building them as MODULE on OS X.)
svn path=/trunk/; revision=34243
2010-09-24 20:41:34 +00:00
de68ad3066
H. Sivank <hsivank@gmail.com>
...
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.
svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
54082c6ed0
Add Cmake stuff to the source distribution so more people can try it out.
...
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
e611923124
Get rid of check_col().
...
svn path=/trunk/; revision=32428
2010-04-08 15:51:44 +00:00
5ccee6196a
Remove some uneeded #includes
...
svn path=/trunk/; revision=32419
2010-04-07 18:24:18 +00:00
846eed1d9e
Get rid of check_col
...
svn path=/trunk/; revision=32401
2010-04-06 16:13:09 +00:00
7cfa27b04b
Get rid of a bunch of check_col().
...
svn path=/trunk/; revision=32388
2010-04-05 20:04:52 +00:00
96779de920
cmake changes:
...
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
This will make it easier to find matching plugin versions if
files get just copied over.
svn path=/trunk/; revision=32231
2010-03-18 10:27:17 +00:00
67072286bf
- Remove the lib prefix for plugin names.
...
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
plugin's file name.
svn path=/trunk/; revision=31995
2010-02-24 22:32:10 +00:00
25dcd066b6
From Hannes Diethelm via bug 4525:
...
Corrected values for IdentInfo (which was obviously wrong)
svn path=/trunk/; revision=31978
2010-02-24 08:22:33 +00:00
c033a08313
Fix some gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31724
2010-01-28 23:53:27 +00:00
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
d2cc318f4f
Beginnings of enabling static builds. Still to do:
...
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua
svn path=/trunk/; revision=30987
2009-11-17 11:58:36 +00:00
9ee31d1d0e
cmake will now honor -Werror if configured (default: on)
...
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
06e6441c9e
add "reserved for profiles" comments
...
svn path=/trunk/; revision=30811
2009-11-04 00:07:54 +00:00
03c3b66945
From Benjamin Meyer:
...
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195
svn path=/trunk/; revision=30808
2009-11-03 20:11:19 +00:00
ecbe3c28f3
From Matthias FRANK:
...
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193
svn path=/trunk/; revision=30804
2009-11-03 12:30:59 +00:00
d0a15b4473
From Matthias FRANK:
...
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();
svn path=/trunk/; revision=30801
2009-11-02 18:09:46 +00:00
8248955d7d
Renamed tvb_new -> new_tvb to avoid name collision.
...
svn path=/trunk/; revision=30617
2009-10-19 14:36:26 +00:00
d7ca2a6444
Initialize variables which may be used uninitialized.
...
svn path=/trunk/; revision=30535
2009-10-12 14:13:01 +00:00
8b8399b711
Use register_dissector_files in the plugins dissectors
...
svn path=/trunk/; revision=30435
2009-10-09 16:39:34 +00:00
cf85342eec
Build plugins with cmake on OSX.
...
svn path=/trunk/; revision=30373
2009-10-06 18:58:09 +00:00
b95ab896f7
From Benjamin Meyer:
...
Profinet PDIRFrameData field FrameDetails not decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4091
svn path=/trunk/; revision=30321
2009-10-04 19:34:48 +00:00
7bff8c664b
From Benjamin Meyer:
...
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090
svn path=/trunk/; revision=30320
2009-10-04 19:31:02 +00:00
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
124faf721c
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
633bb05380
Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
...
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
ebfcf3c387
Build more plugins with cmake.
...
svn path=/trunk/; revision=30084
2009-09-23 04:41:14 +00:00
c28bafe341
Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30082
2009-09-22 21:18:11 +00:00
4661aad9a4
Run checkapi on the dissector header files
...
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
2547ce21bf
We no longer support the old plugin API so remove it completely from the build system
...
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
9bc8469d96
Remove a couple of unused variables.
...
svn path=/trunk/; revision=29286
2009-08-03 23:50:55 +00:00
617077e94a
From Benjamin Meyer:
...
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753
svn path=/trunk/; revision=29150
2009-07-21 06:08:45 +00:00
7881d1ccd7
From Kovarththanan Rajaratnam:
...
More FT_XXX cleanup.
svn path=/trunk/; revision=28970
2009-07-07 09:00:33 +00:00
9518d53ab4
Make the compiler on Mac OS X happy...
...
svn path=/trunk/; revision=28934
2009-07-03 10:29:45 +00:00
d180d37c8d
update to the latest PROFINET drafts
...
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)
svn path=/trunk/; revision=28932
2009-07-03 09:12:43 +00:00
2bba6be84f
From Kovarththanan Rajaratnam via bug 3548:
...
Cleanup header_field_info in plugins.
svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
b7dc0a3e51
From Reinhard Speyerer:
...
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.
svn path=/trunk/; revision=28204
2009-05-01 06:58:28 +00:00
321506c076
(Trivial) Fix some spelling & etc in comments
...
svn path=/trunk/; revision=27996
2009-04-08 13:41:30 +00:00
f681477e33
remove GPLv2 CRC code, the new epan CRC stuff is working well
...
svn path=/trunk/; revision=27803
2009-03-20 10:44:42 +00:00
dd903ca9c8
Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch],
...
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
svn path=/trunk/; revision=27790
2009-03-18 21:59:30 +00:00
870e139576
fix type
...
svn path=/trunk/; revision=27749
2009-03-16 22:36:34 +00:00
dcdda03610
update to the latest PROTINET changes:
...
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4
crc16 algorithm copied from Linux sources (GPL V2 only!)
svn path=/trunk/; revision=27748
2009-03-16 21:40:00 +00:00
07e5df616e
Disable manifest building for our DLLs. This attempts to fix bug 3272.
...
svn path=/trunk/; revision=27579
2009-03-02 18:57:35 +00:00
043532d63e
add missing mt.exe calls, to include manifest files into exe / dll files
...
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
2ba37de400
Fix uninitialized variable.
...
More indentation cleanups.
svn path=/trunk/; revision=27306
2009-01-26 23:48:10 +00:00
248db0a42a
Non-constant strings should not be used as format items; the format
...
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.
Clean up indentation.
svn path=/trunk/; revision=27304
2009-01-26 22:58:47 +00:00
f9e110d4cd
fix a minor comment bug
...
svn path=/trunk/; revision=27299
2009-01-26 19:53:22 +00:00
269cec3108
add some expert infos
...
svn path=/trunk/; revision=27298
2009-01-26 19:52:19 +00:00
9a3563e807
Fix some typos and spelling (mostly in text strings)
...
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
e4e7334be0
From Jim Young (bug 3105):
...
Trivial patch to change two C++ style comments to standard C style comments.
svn path=/trunk/; revision=26944
2008-12-09 13:42:00 +00:00
4f46066fa0
add missing version check for new block
...
svn path=/trunk/; revision=26917
2008-12-04 21:26:35 +00:00
6e0a9d6df0
add block dissections:
...
- PDIRBeginEndData
- PDIRData V1.1
svn path=/trunk/; revision=26916
2008-12-04 20:52:11 +00:00
94e9e2b1ec
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
05c1929f1d
proto_register/proto_reg_handoff; Various small cleanup and bug-fixing
...
remove unnecessary #include prefs.f and emem.h in a few cases...
svn path=/trunk/; revision=26554
2008-10-25 20:24:31 +00:00
b4d2c37635
Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
...
Also use $(top_builddir) instead of ../../ in a couple of other spots.
svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
a04774395f
Add Makefile.common files for epan/dfilter and epan/ftypes.
...
Add checkapi rules to Makefile.am files.
svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
b6e20d89be
Put printf into a separate "termoutput" API group. For most files,
...
check for it - but not for TShark plugins, as they are expected to
print to the standard output.
svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
83aacf0a09
Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
...
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
bd8528644e
fix BlockError strings
...
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
a5cee04fad
Move the file utility functions from wiretap to libwsutil so that
...
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.
While doing that, rename the eth_* functions to ws_*.
svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
023a81709a
Make it possible to run checkapi on all plugins trough makefile.nmake
...
Note: Commented out in the plugins giving errors for now.
svn path=/trunk/; revision=25231
2008-05-05 16:55:19 +00:00
b704bdcbc5
Remove the pre-release flag from FILEFLAGS in the resource file.
...
svn path=/trunk/; revision=24757
2008-03-29 23:04:33 +00:00
fcf8509f69
Create proper dependancies for plugin.c
...
svn path=/trunk/; revision=24520
2008-03-01 12:31:01 +00:00
fc5527ef6c
Quote argument to test in plugins Makefiles, as proposed by Greg A. Woods.
...
svn path=/trunk/; revision=24488
2008-02-27 16:18:30 +00:00
7abeb02747
If we have an SVN revision number, use it as the build number under Windows
...
instead of "0".
svn path=/trunk/; revision=24376
2008-02-18 18:08:14 +00:00
adccc10596
add some parentheses as suggested by the OS X buildbot
...
svn path=/trunk/; revision=24122
2008-01-17 19:30:35 +00:00
6cfbb485bf
better conformance to the released DCP protocol spec:
...
- redesign/refactoring the code to support BlockQualifier
- fix handling of BlockInfo
- rename some display strings for better spec conformance
- remove LLDP suboption
svn path=/trunk/; revision=24120
2008-01-17 18:29:51 +00:00
309f7503e5
Get rid of C++/C99 style comments--not all compilers support them
...
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
5c901658e7
add FSParameterBlock and ARFSUDataAdjust blocks
...
svn path=/trunk/; revision=23140
2007-10-10 18:33:21 +00:00
37d9fc37da
- add DomainName fields for PDInterfaceMrpDataAdjust and PDInterfaceMrpDataReal
...
- lower expert info level if AR wasn't found
svn path=/trunk/; revision=23106
2007-10-09 05:39:48 +00:00
87cffefe2f
Added parentheses to make the buildbot happy.
...
svn path=/trunk/; revision=23065
2007-10-03 19:35:32 +00:00
2a8f9b4c99
check version of each block and don't try to dissect a block if the version is not as expected (to avoid "miss-dissections")
...
svn path=/trunk/; revision=23064
2007-10-03 18:02:27 +00:00
c3131594a8
update to latest IEC draft
...
svn path=/trunk/; revision=23041
2007-10-02 05:04:35 +00:00
33f27f437f
slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header
...
svn path=/trunk/; revision=22970
2007-09-25 21:56:43 +00:00
b57c83f6eb
fix length calculation for 802.11 packets - the 802.11 dissector will strip off the 4 byte FCS at the end of a packet (while the Ethernet dissector does not).
...
svn path=/trunk/; revision=22759
2007-08-30 19:50:56 +00:00
b0f5c26ebf
update to latest draft:
...
- add PDSyncData block with Version 1.2
- add IOXBlockReq/s ids 0x116, 0x117, 0x8116 and 0x8117
svn path=/trunk/; revision=22734
2007-08-30 02:14:36 +00:00
516ca59b99
Add .c.obj:: inference rule (to cause "batch compile")
...
svn path=/trunk/; revision=22696
2007-08-27 22:56:27 +00:00
3a0c285065
fix return types, hopefully this will make the osx buildbot happy
...
svn path=/trunk/; revision=22531
2007-08-16 22:45:36 +00:00
4b215597ae
experimental feature: dissector filters
...
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI
svn path=/trunk/; revision=22530
2007-08-16 22:03:10 +00:00
2d11b0813e
mark some parameters as unused
...
svn path=/trunk/; revision=22445
2007-08-03 20:07:06 +00:00
12aed7290c
- add PDInterfaceFSUDataAdjust block
...
- start to implement an AR conversation handler
svn path=/trunk/; revision=22444
2007-08-03 19:29:34 +00:00
f4cabf95a1
update PTCP dissection to latest specification draft
...
svn path=/trunk/; revision=22432
2007-07-31 19:01:15 +00:00
6970aff017
add helper function dissect_pn_int32()
...
svn path=/trunk/; revision=22431
2007-07-31 18:57:51 +00:00
85e09ecdd5
fix unused parameter warning by adding _U_
...
svn path=/trunk/; revision=22400
2007-07-25 08:38:31 +00:00
9f2478f46c
from HPfrommer@hilscher.com:
...
I’ve fixed a bug in the Profinet-Dissector
(plugins/profinet/packet-dcerpc-pn-io.c).
In PROFINET IO DCE RPC write-requests, only the first IR frame dataset
in PDIRFrameData was dissected.
I’ve fixed the problem, now all IR frame datasets are dissected into
individual sub-trees.
svn path=/trunk/; revision=22398
2007-07-24 21:15:34 +00:00
a5ba21acf8
remove ProvCRID from expert info output, so the composite view is more compact
...
svn path=/trunk/; revision=22386
2007-07-23 20:08:53 +00:00
94b3dbf3f6
add dissection of blocks:
...
{ 0x021E, "CheckSyncDifference"},
{ 0x021F, "CheckMAUTypeDifference"},
svn path=/trunk/; revision=22385
2007-07-23 20:07:51 +00:00
5a43799a17
Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
...
routines and routines using those routines. GLib might use different
modifiers for 64-bit quantities than the platform's C library does.
svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
a7c42e75e0
Use $(PLUGIN_LDFLAGS) for LDFLAGS.
...
svn path=/trunk/; revision=21963
2007-05-27 18:56:39 +00:00
d99b6c0a8b
Clean up white space.
...
svn path=/trunk/; revision=21959
2007-05-27 18:30:03 +00:00
2fd09672de
add dissection of PortTime
...
svn path=/trunk/; revision=21360
2007-04-10 02:26:39 +00:00
5620d4fa15
Add the make-dissector-reg scripts to the dependency list for each copy
...
of plugin.c.
svn path=/trunk/; revision=21342
2007-04-05 23:23:06 +00:00
0104002d2e
Add PN-IO FSHelloBlock and PN-DCP Device/AliasName
...
svn path=/trunk/; revision=21298
2007-04-02 05:18:31 +00:00
2896811274
Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
...
Comment out -Werror in plugins/asn1/ until warnings can be fixed.
svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
8973617e4b
From Sebastien Tandel:
...
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.
svn path=/trunk/; revision=21155
2007-03-23 18:16:53 +00:00
62f88a4a04
From Sebastien Tandel:
...
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)
Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)
svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
cdf47e536b
Add -Werror when using GCC only to the Makefile.am of the base
...
directory and most of the plugins to match the same command
put in the Makefile.nmake files for Windows compliations. Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD. Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition.
svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
af9ae7eebb
set CFLAGS to block new warnings for all plugins (except for giop and h223, which has remaining issues - for now)
...
svn path=/trunk/; revision=21102
2007-03-21 23:59:41 +00:00
c3bf838051
as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
...
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
62596bffb3
Fix bug 552:
...
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552
by enforcing that header fields have names of length > 0. This should fix
the display of those fields and also make them filterable (which was the
subject of the bug). Abbreviations are (still) optional: if they are empty
then the field is not filterable.
Update README.developer with this information.
Add header field names in several dissectors where they were missing.
In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.
Also remove trailing white space from all the files checked in.
svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
e30640be45
PROFINET RT frames can also be transported over UDP Port 0x8892 - to be routable
...
svn path=/trunk/; revision=20985
2007-03-06 21:54:53 +00:00
00335ac48e
fix read handling of index 0x8051 and 0xe00c
...
svn path=/trunk/; revision=20963
2007-03-03 09:33:02 +00:00
cf13f56dc8
-Add the compiler version to the plugin resource
...
-Remove the SPECIAL_BUILD tag
-Set to OS type to NT_WINDOWS32
svn path=/trunk/; revision=20934
2007-02-26 20:39:38 +00:00
cd08e6448f
fix the padding in the read/write headers, some other minor changes
...
svn path=/trunk/; revision=20927
2007-02-25 15:50:40 +00:00
7887d478cc
add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
...
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
a8fb7d24d0
Properly introduce packet-pn.c as a helper
...
svn path=/trunk/; revision=20903
2007-02-23 19:37:01 +00:00
c127df0bc8
Include <string.h> to declare memcpy().
...
svn path=/trunk/; revision=20842
2007-02-19 00:56:22 +00:00
822bb2e489
fix an error added lately
...
svn path=/trunk/; revision=20832
2007-02-17 11:13:24 +00:00
2172e293d6
some more compiler warnings removed
...
svn path=/trunk/; revision=20829
2007-02-17 09:42:38 +00:00
16aa7c17db
squelch some compiler warnings
...
svn path=/trunk/; revision=20828
2007-02-17 08:08:40 +00:00
d6e22b2d9a
major code cleanup:
...
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code
svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
aad5a4e6b1
add remaining TLV blocks (complete now?)
...
add a lot of missing index values
fix some minor bugs
svn path=/trunk/; revision=20795
2007-02-12 19:01:20 +00:00
44ee701ba6
remove some warnings
...
svn path=/trunk/; revision=20785
2007-02-11 04:12:07 +00:00
59a86ae3e9
remove a g_warning left over from debugging
...
svn path=/trunk/; revision=20784
2007-02-11 03:45:21 +00:00
b04c53a23c
add a lot more TLV block decodes, some code cleanup, ...
...
svn path=/trunk/; revision=20763
2007-02-10 08:03:47 +00:00
98f2412a6f
various major enhancements to the PROFINET-IO dissector (including some new TLV blocks)
...
svn path=/trunk/; revision=20751
2007-02-08 18:29:47 +00:00
8559a25d23
- add dissection for "I&M0" block
...
- enhance dissection or ErrorDecode2 (ErrorCode1 rta_err_cls_protocol specific) - a lot more of ErrorCode1/ErrorCode2 combinations still to go ...
svn path=/trunk/; revision=20724
2007-02-06 01:37:32 +00:00
39956903b5
PropagationDelayFactor -> LineDelay
...
svn path=/trunk/; revision=20348
2007-01-08 22:11:56 +00:00
d53f947b16
clean should also remove generated plugin.c and manifest files
...
svn path=/trunk/; revision=20291
2007-01-03 06:06:53 +00:00
5800f59d15
Bump micro version number, like in moduleinfo.h
...
svn path=/trunk/; revision=20178
2006-12-20 10:07:20 +00:00
cc7ffdcb07
raise plugin version, as I've done some small but important changes
...
svn path=/trunk/; revision=20177
2006-12-19 22:44:35 +00:00
f46bd5f3b8
Add Windows version info resource.
...
svn path=/trunk/; revision=20169
2006-12-19 22:27:15 +00:00
9cddaf7c84
add MaintenanceItem block dissection, fix issues with heuristic of RT classes
...
svn path=/trunk/; revision=20128
2006-12-12 23:50:59 +00:00
aacf309f42
add IRDataUUID to the blocks subitem
...
svn path=/trunk/; revision=20078
2006-12-09 09:28:29 +00:00
1ce7261136
add dissection of the "IsochronousModeData" block
...
svn path=/trunk/; revision=20045
2006-12-05 08:09:01 +00:00
647533a5ef
put every python script name into "" so the call won't fail on Win32 native python.
...
The problem is the slash in e.g.:
@$(PYTHON) ../../tools/make-dissector-reg.py
is interpreted as an option instead of being part of the path.
I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.
svn path=/trunk/; revision=19730
2006-10-29 17:19:52 +00:00
161d7695eb
(slightly) further dissection of the Option (Organizationally specific) block
...
svn path=/trunk/; revision=18997
2006-08-22 19:43:38 +00:00
c91dd2c6c2
fix TLB block alignment to be compatible with the current MRP draft. Would be nice if included in the 0.99.3
...
svn path=/trunk/; revision=18996
2006-08-22 19:42:04 +00:00
bd807d4b69
several minor fixes and enhancements to the dissection
...
svn path=/trunk/; revision=18854
2006-08-08 21:28:14 +00:00
2981e4022a
remove some warnings (2nd try)
...
svn path=/trunk/; revision=18635
2006-07-01 15:14:19 +00:00
66318ef7e1
remove some "signedness" warnings
...
svn path=/trunk/; revision=18633
2006-07-01 12:15:37 +00:00
95279cb92c
remove a "differ in signedness" warnings
...
svn path=/trunk/; revision=18607
2006-06-29 08:16:57 +00:00
b41b729b2f
remove some "unused parameter" warnings
...
svn path=/trunk/; revision=18606
2006-06-29 08:15:07 +00:00
1896e7021d
squelch some compiler warnings
...
svn path=/trunk/; revision=18560
2006-06-23 18:03:40 +00:00
a016d9ee45
fix a (correct) compiler warning
...
svn path=/trunk/; revision=18548
2006-06-22 19:17:43 +00:00
d2b72027b0
add various new dissections, enhancements to the existing dissections and update things to current spec, ...
...
Still incomplete, but a lot better than before :-)
svn path=/trunk/; revision=18536
2006-06-21 20:10:38 +00:00
1d51934de2
add an expert info if a capture file contains some (yet) undecoded portions
...
svn path=/trunk/; revision=18534
2006-06-21 18:35:39 +00:00
4f83154239
detect the PROFINET OUI correct if the multicast bit is set
...
svn path=/trunk/; revision=18528
2006-06-21 07:28:56 +00:00
62e32390b5
ethereal to wireshark changes
...
svn path=/trunk/; revision=18500
2006-06-17 12:07:49 +00:00
1af7caeeb1
Squelch a (valid) compiler warning.
...
Clean up indentation a bit.
svn path=/trunk/; revision=18481
2006-06-16 07:15:03 +00:00
f1f0e294b4
(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
...
add Media Redundancy and Media Redundancy Realtime Protocol dissectors (PN-MRP and PN-MRRT)
svn path=/trunk/; revision=18454
2006-06-13 18:26:49 +00:00
7da210b418
use FT_GUID instead of FT_STRING at appropriate fields
...
svn path=/trunk/; revision=18439
2006-06-12 19:36:58 +00:00
299ac5e8bc
remove plugin.c in distlclean
...
svn path=/trunk/; revision=18312
2006-06-02 06:53:30 +00:00
b15974d094
libethereal -> libwireshark. idl2eth -> idl2wrs. There are a _lot_ of
...
changes here. It compiles OK on OS X, but hasn't been tested anywhere else.
svn path=/trunk/; revision=18260
2006-05-31 00:23:01 +00:00
89f022b12b
name change
...
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
4b4eba7993
minor enhancements
...
svn path=/trunk/; revision=18009
2006-04-26 20:13:33 +00:00
5e49264181
Resolve conflicts.
...
svn path=/trunk/; revision=17965
2006-04-23 08:23:49 +00:00
5199671441
Convert most other plugin dissectors to use the make-dissector-reg
...
scripts.
svn path=/trunk/; revision=17961
2006-04-22 20:26:16 +00:00
a70e3c548c
(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
...
add Precision Time Control Protocol dissector (PTCP)
svn path=/trunk/; revision=17930
2006-04-20 19:49:12 +00:00
22dca0c988
... and don't forget to include emem.h!
...
svn path=/trunk/; revision=17577
2006-03-11 09:09:55 +00:00
2e2c970da9
replace g_malloc and alike by their corresponding ep_ functions
...
svn path=/trunk/; revision=17576
2006-03-11 09:08:18 +00:00
60869fe1cc
various code cleanup (e.g. remove unrequired length parameter), should also fix coverity id 126
...
svn path=/trunk/; revision=17569
2006-03-10 21:34:56 +00:00
3a92bf963c
fix coverity bug 122
...
svn path=/trunk/; revision=17527
2006-03-08 10:59:05 +00:00
eefbb60770
minor enhancements
...
svn path=/trunk/; revision=16485
2005-11-12 09:39:24 +00:00
e90ebfad09
minor enhancement (raised plugin version to 0.1.2):
...
PN-DCP: dissection of "DHCP/DHCP client identifier" suboption was added
svn path=/trunk/; revision=16377
2005-11-02 19:33:46 +00:00
25c4bc9379
Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
...
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.
Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).
svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
4f693dfae2
Some warning fixes for "no previous declaration"
...
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id
svn path=/trunk/; revision=15179
2005-08-02 05:39:45 +00:00
30a8557868
More 'char*' -> 'const char*' changes to fix warnings.
...
svn path=/trunk/; revision=15015
2005-07-23 11:41:25 +00:00
5b442f2279
After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
...
returned quite a list of files. Add them to MAINTAINERCLEANFILES.
Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.
svn path=/trunk/; revision=14891
2005-07-10 08:04:27 +00:00
3a6c9ab134
Fix a format string vulneratility in the AFP dissector identified
...
by iDEFENSE. Add constant format strings to proto_item_append_text()
in a bunch of other dissectors. Copy a comment from proto.c to proto.h.
svn path=/trunk/; revision=14713
2005-06-20 19:35:58 +00:00
3ad08cb0ee
raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release
...
svn path=/trunk/; revision=14603
2005-06-09 20:08:39 +00:00
b087ed4b6e
add another tvb_ensure_bytes_exist() call
...
replace dissect_ndr_uuid_t by dissect_dcerpc_uuid_t, as this is the correct function to use and will prevent a problem with access to non existing private_data in dissect_ndr_uuid_t
svn path=/trunk/; revision=14506
2005-05-31 18:27:20 +00:00
0c8fb767d1
Fix a call to dereference a pointer (found by a compiler warning).
...
svn path=/trunk/; revision=14318
2005-05-05 11:08:20 +00:00
1a9152727b
add a *lot* more dissections of the various PN-IO blocks
...
svn path=/trunk/; revision=14301
2005-05-03 19:58:05 +00:00
4e3c0cde68
move the pn-dcp dissector into the profinet plugin
...
svn path=/trunk/; revision=14285
2005-05-03 01:39:00 +00:00
a46d7d2d59
set subversion attributes
...
svn path=/trunk/; revision=14249
2005-04-30 20:55:21 +00:00
48aee19b1a
move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-)
...
svn path=/trunk/; revision=14248
2005-04-30 20:52:20 +00:00
Guy Harris