Commit Graph

36204 Commits

Author SHA1 Message Date
Anders Broman 347c71d9a8 GTK_CHECK_VERSION cleanup.
svn path=/trunk/; revision=37972
2011-07-11 18:54:49 +00:00
Gerald Combs 5ad2293f40 More GLIB_CHECK_VERSION and GTK_CHECK_VERSION cleanup.
svn path=/trunk/; revision=37971
2011-07-11 18:35:36 +00:00
Gerald Combs 2c469e3714 More GLIB_CHECK_VERSION, GTK_CHECK_VERSION, and related whitespace
cleanup.

svn path=/trunk/; revision=37970
2011-07-11 18:18:35 +00:00
Gerald Combs f6d7f90c72 Remove a lot of instances of GTK_CHECK_VERSION. Clean up whitespace in a
couple of places.

svn path=/trunk/; revision=37969
2011-07-11 18:08:08 +00:00
Gerald Combs cf161b7735 Make the minimum GLib version 2.14 and the minimum GTK+ version 2.12.
svn path=/trunk/; revision=37967
2011-07-11 17:49:59 +00:00
Anders Broman 0604267b6d Change encoding type from FALSE to ENC_BIG_ENDIAN.
svn path=/trunk/; revision=37963
2011-07-11 13:44:29 +00:00
Anders Broman c5fab10bf1 From qgj:
when dissect the capwap control header,the sequence's value is decoded
improperly,it tooks the wrong offset value,so the control messages' sequence is
showed improperly.
Changed to uset proto_add_item and encoding type changed from FALSE to ENC_BIG_ENDIAN.

svn path=/trunk/; revision=37962
2011-07-11 13:43:12 +00:00
Anders Broman 7b0ca24a90 Change encoding type from FALSE to ENC_BIG_ENDIAN.
svn path=/trunk/; revision=37961
2011-07-11 13:41:19 +00:00
Anders Broman 1f0ca1440c From Ludovic Haessler:
Add 3GPP TS44.060 RLC/MAC control blocks management in GSMTAP dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6103

svn path=/trunk/; revision=37960
2011-07-11 13:32:04 +00:00
Anders Broman 66e3012f0f Make sure consumed is set.
svn path=/trunk/; revision=37959
2011-07-11 10:42:16 +00:00
Anders Broman 25d82cf3e3 From Michael Mann:
Added filters for BOOTP options of "basic" types (modeled after packet-wssap.c)

"bootp.option.length" only used when specific option filter can't be found.
"bootp.option.value" expanded to support multiple types

Converted "custom options string" to UAT

replacing many proto_tree_add_text() calls with
proto_tree_add_item(), so the BOOTP dissector is considerably more filterable

svn path=/trunk/; revision=37958
2011-07-11 10:12:40 +00:00
Chris Maynard c23afc424e As noted by Jaap Keuter on -dev, be sure to use message_size instead of
header->message_size for a correct host endianness comparison.


svn path=/trunk/; revision=37957
2011-07-11 00:17:08 +00:00
Guy Harris 4c4b8f8891 Move the definitions of LANalyzer records to lanalyzer.c.
Use LA_RecordHeaderSize rather than sizeof, to squelch some compiler
complaints.

svn path=/trunk/; revision=37956
2011-07-10 22:57:59 +00:00
Anders Broman 94bf8a52be From Jaap:
Limit the search to the line.

svn path=/trunk/; revision=37955
2011-07-10 22:13:03 +00:00
Guy Harris 5e5b778a67 Define a structure for the record header, and read into that, and then
extract values from it.

svn path=/trunk/; revision=37954
2011-07-10 22:10:07 +00:00
Guy Harris 41d53a1635 At that point in the code, bytes_read isn't the total number of record
header bytes read, as we're reading the two header fields separately and
checking the byte count for each read.  We *do*, however, know that the
record header is 4 bytes long, so we can just seek back 4 bytes.

svn path=/trunk/; revision=37953
2011-07-10 21:05:19 +00:00
Guy Harris a3ae744636 Add port 2710 for the XBT BitTorrent tracker (and note why it's added;
the other unusual ports should be mentioned as well).

svn path=/trunk/; revision=37952
2011-07-10 18:34:15 +00:00
Guy Harris b02af4355c Make sure the SID string attached to a dcerpc_call_value has session
duration, just as the dcerpc_call_value itself does.

svn path=/trunk/; revision=37951
2011-07-10 17:57:39 +00:00
Gerald Combs 4e8b5eac2d [Automatic manuf, services and enterprise-numbers update for 2011-07-10]
svn path=/trunk/; revision=37948
2011-07-10 15:03:37 +00:00
Guy Harris 9988c54700 Put Modbus/UDP support back.
svn path=/trunk/; revision=37947
2011-07-09 19:58:19 +00:00
Guy Harris a53bf09cc1 If the reply length is < 32, that's an overflow, not a bug in the
dissector (unless you consider the calculation not being done in 64 bits
as a bug).  For now, toss a ReportedBoundsError.

svn path=/trunk/; revision=37946
2011-07-09 18:56:21 +00:00
Chris Maynard f93d3aeeb1 Per README.developer, we must call subdissectors regardless of whether "tree"
is NULL or not.  With this change, GRE-encapsulated packets (such as IP)
should now appear in then endpoint and conversation lists.  This was
essentially the request made at Sharkfest '11.  The actual request was for a
"GRE" tab to be added, but that doesn't really make much sense to me.  I
believe this change should fulfill that request.


svn path=/trunk/; revision=37945
2011-07-09 02:04:48 +00:00
Guy Harris 030ec99939 Point to the right place.
svn path=/trunk/; revision=37944
2011-07-09 01:41:09 +00:00
Balint Reczey a2c55f0c17 Show a hint to read http://wiki.wireshark.org/CaptureSetup/CapturePrivileges
when showing the warning about running Wireshark as root
Thanks to Evan Huus for the suggestion.

svn path=/trunk/; revision=37943
2011-07-09 00:20:13 +00:00
Michael Tüxen 8e93cf895f Use a pixbuf for widgets used for icons.
svn path=/trunk/; revision=37942
2011-07-08 18:29:02 +00:00
Martin Mathieson 33a21986f1 Trivial: add a couple of newlines.
svn path=/trunk/; revision=37941
2011-07-08 16:10:25 +00:00
Martin Mathieson ece553d8d0 Change the way we scan past characters before the direction indicator.
svn path=/trunk/; revision=37940
2011-07-08 16:08:32 +00:00
Michael Tüxen 0472f42af7 If no interface is specified on the command line, use the default
capture interface if given.

This patch is provided by Irene Ruengeler.


svn path=/trunk/; revision=37939
2011-07-08 13:47:16 +00:00
Michael Tüxen b2ab9d134a You can't select/deselct interfaces in the capture/interfaces
dialog while you are capturing.
This patch is provided by Irene Ruengeler.

svn path=/trunk/; revision=37938
2011-07-08 13:40:00 +00:00
Michael Tüxen d56de3d638 Try to make non-libpcap builds compiling.
svn path=/trunk/; revision=37937
2011-07-08 09:26:34 +00:00
Michael Tüxen 15bf360095 Use the interfaces from the last capturing process as a starting point
for the next one.

Obtained from Irene Ruengeler.

svn path=/trunk/; revision=37936
2011-07-08 08:49:06 +00:00
Jaap Keuter 7890ac3667 Avoid 'variable set but no used' error from compiler.
svn path=/trunk/; revision=37935
2011-07-08 07:52:31 +00:00
Guy Harris da461f18ad Alas, the libpcap API didn't use "void *" where it should have; squelch
some warnings from Clang.

svn path=/trunk/; revision=37934
2011-07-08 02:02:37 +00:00
Guy Harris eedafe0a92 %u suffices, as varargs are widened. (It aslso doesn't cause Clang to
complain.)

svn path=/trunk/; revision=37933
2011-07-08 01:58:30 +00:00
Michael Tüxen 746ca92b46 The argument of capture_get_if_icon() is used.
svn path=/trunk/; revision=37932
2011-07-07 21:16:03 +00:00
Michael Tüxen 8fac080296 Try to unbreak the Mac OS X 10.5 buildbots.
svn path=/trunk/; revision=37931
2011-07-07 20:20:55 +00:00
Chris Maynard 0dcd4ac28c In elem_cell_id_aux(), in the case of an unknown/invalid disc, be sure to
increment the curr_offset by the correct number of bytes; otherwise we can run
into an infinite loop condition such as was the case for bug 6044.

Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6044


svn path=/trunk/; revision=37930
2011-07-07 16:37:33 +00:00
Michael Tüxen 3500412973 Bring back interface icons.
Obtained from Irene Ruengeler.

svn path=/trunk/; revision=37929
2011-07-07 13:57:08 +00:00
Michael Tüxen 20ded72bac Use the interface descriptions again.
This patch is from Irene Ruengeler.

svn path=/trunk/; revision=37928
2011-07-07 13:34:40 +00:00
Alexis La Goutte 0e2d677887 From Ali Bahar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6093
802.11 Association Response Packet's "Status Code" field is imprecisely decoded/described.

From me :
* Display Reason code in decimal (not Hexa)
* Check list from last standard (802.11-2007, 802.11r-2008, 802.11n-2009, 802.11w-2009 & 802.11z-2011)
* Add link to 802.11z-2010 documentation

svn path=/trunk/; revision=37927
2011-07-07 10:19:02 +00:00
Anders Broman 2a6c45c5a2 From Ludovic Haessler:
CSN Ack/Nack Description wrongly handled in gsm_rlcmac_dl dissector (3GPP TS 44.060)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6101

svn path=/trunk/; revision=37926
2011-07-07 07:44:25 +00:00
Michael Tüxen 6542687a78 Fix a crash when using hidden interfaces.
svn path=/trunk/; revision=37925
2011-07-06 17:27:42 +00:00
Chris Maynard 91f30ab64f From Jakub Zawadzki via bug 6002: Don't set state to STATE_EXPECT_DATA if there's no data to read.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6002


svn path=/trunk/; revision=37924
2011-07-06 16:22:11 +00:00
Chris Maynard f16b234b84 Fix memory leak, using ep_alloc() instead of g_malloc().
svn path=/trunk/; revision=37923
2011-07-06 16:03:43 +00:00
Anders Broman 0c812dbe61 From György Szaniszló:
Introduced a new tcp state variable: maxseqtobeacked, this is the
maximum seq number that can be acked by the rev party in normal case.
This new state variable only serves the proper detection of
tcp.analysis.ack_lost_segment indicator, and decouples it from the detection of
tcp.analysis.lost_segment indicator.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6081

svn path=/trunk/; revision=37922
2011-07-06 15:45:56 +00:00
Anders Broman 8e4aa22fa0 From Kluchnikov Ivan:
Decoding Phy Synchronization Field in wimax DL-MAP and Compressed DL-MAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6068

svn path=/trunk/; revision=37921
2011-07-06 15:39:25 +00:00
Martin Mathieson c4dd3e5e5c Add
#if defined(_WIN32) || defined(HAVE_PCAP_CREATE)
around access to interface_options.buffer_size

svn path=/trunk/; revision=37920
2011-07-06 14:56:42 +00:00
Anders Broman 51b2410345 From Ludovic Haessler:
Wrong decoding of RLC/MAC EGPRS Packet Downlink Ack/Nack (3GPP TS 44.060)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6098

svn path=/trunk/; revision=37919
2011-07-06 12:53:04 +00:00
Anders Broman 6fdf0eed8f From HAESSLER:
Abis interface not correctly handled in gsmtap dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6097

svn path=/trunk/; revision=37918
2011-07-06 12:47:21 +00:00
Michael Tüxen 8180111144 Use g_object_set() instead of gtk_object_set().
svn path=/trunk/; revision=37917
2011-07-06 11:35:52 +00:00