Commit Graph

45859 Commits

Author SHA1 Message Date
Guy Harris 2deedfb1e1 Add a setTitlebarForCaptureInProgress() method to MainWindow, and use it
to set the title when we have a capture in progress.

svn path=/trunk/; revision=48688
2013-04-01 17:57:47 +00:00
Guy Harris d49404236c Get rid of main_capture_set_main_window_title(), as it just wraps
set_titlebar_for_capture_in_progress(); make the call directly, to make
it a bit clearer when it needs to be called (which helps us do the
equivalent in the Qt version).

svn path=/trunk/; revision=48687
2013-04-01 17:57:20 +00:00
Jaap Keuter a62cc81d4b Now only if I can get the case right :)
svn path=/trunk/; revision=48686
2013-04-01 15:33:42 +00:00
Jaap Keuter 97136126bc Typo's. That is all.
svn path=/trunk/; revision=48685
2013-04-01 15:29:49 +00:00
Jaap Keuter dfc87f20df Fix for bug 8548:
Allow the IRC command and response dissection functions to be called with
subsets of the original (full) message line. Therefore we need to calculate
with real lengths and offsets, not mixed with lengths of the subset itself.

svn path=/trunk/; revision=48684
2013-04-01 14:09:44 +00:00
Guy Harris a94307adcf Move the knowledge about what the window title should be to
ui/gtk/main_titlebar.c, with set_titlebar_for_capture_file() for either
no capture file or an opened capture file and
set_titlebar_for_capture_in_progress() for an in-progress capture.

svn path=/trunk/; revision=48683
2013-04-01 00:21:44 +00:00
Guy Harris 6c5c65b486 Add a setTitlebarForCaptureFile() and have it set the titlebar and the
"modified" indicator.  For some reason, it's not getting called in all
the right places.

svn path=/trunk/; revision=48682
2013-03-31 22:59:56 +00:00
Anders Broman 2328de7bf8 Unused parameter.
svn path=/trunk/; revision=48681
2013-03-31 22:27:58 +00:00
Guy Harris 78ab71cc9d Rename set_display_filename() to set_titlebar_for_capture_file(), as
it affects more than just the file name, it also affects whatever "you
have unsaved changes" indicator the UI provides.

Put a comment in the Qt code as a reminder of how to set the "you have
unsaved changes" indicator.

svn path=/trunk/; revision=48680
2013-03-31 22:17:43 +00:00
Anders Broman 1f74d7a1b2 Initial decoding of 3GPP2_OBJECT.
svn path=/trunk/; revision=48679
2013-03-31 22:08:00 +00:00
Martin Kaiser 5ae86d3b2f coverity 281315 logically dead code
svn path=/trunk/; revision=48676
2013-03-31 18:10:45 +00:00
Martin Kaiser 61cad5a8e2 coverity 990813 dereference after null check
(hope I got it right this time)

svn path=/trunk/; revision=48673
2013-03-31 16:19:53 +00:00
Jakub Zawadzki cbbf2b01e7 [NPL] Pushing changes to wireshark repo
- parser no longer use abort() after failing
- initial support for attributes
- symbol hashing to avoid strcasecmp()
- misc other fixes

svn path=/trunk/; revision=48672
2013-03-31 15:03:46 +00:00
Gerald Combs 84134c9e9c [Automatic manuf, services and enterprise-numbers update for 2013-03-31]
svn path=/trunk/; revision=48671
2013-03-31 14:03:28 +00:00
Martin Kaiser 421cd9eaac remove empty else-branches
svn path=/trunk/; revision=48670
2013-03-31 12:16:41 +00:00
Martin Kaiser 4f55532d59 TABs -> spaces
add editor modelines

svn path=/trunk/; revision=48669
2013-03-31 12:12:03 +00:00
Guy Harris a808b622ac Add missing </endlist>.
svn path=/trunk/; revision=48668
2013-03-31 06:17:41 +00:00
Guy Harris b5a890d276 Don't bundle "Open" and "Import" together; again, clarify that "Import"
is a somewhat limited function.

svn path=/trunk/; revision=48667
2013-03-31 05:12:50 +00:00
Guy Harris 7b32fc6873 Reflect the new menu item for the dialog box for importing a hex dump
file (and note in more detail what it does).

svn path=/trunk/; revision=48666
2013-03-31 04:28:39 +00:00
Guy Harris e2eabbc883 Make the menu item for importing a hex dump text file be "Import from
Hex Dump", to clarify that it's not some sort of "generic" import
function, just one that can read a hex dump file.  ("Import from Hex
Dump Text" is another possibility.)  Use that string in the dialog title
as well.

svn path=/trunk/; revision=48665
2013-03-31 04:17:47 +00:00
Jaap Keuter d2efac96b3 From Hauke Mehrtens:
Wireshark misses some new TLS and DTLS cipher suite names which are assigned by IANA.

svn path=/trunk/; revision=48664
2013-03-30 22:52:13 +00:00
Evan Huus 42ec0d8f0d Hopefully fix a false-positive warning in the Mac buildbot.
It complains that service_info may be used uninitialized, but my manual analysis
agrees with GCC 4.7 that it can't, so just defaulting it to NULL will be fine.

svn path=/trunk/; revision=48663
2013-03-30 22:00:43 +00:00
Evan Huus ff9c205f94 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
Add basic support for Bluetooth GNSS profile. It uses NMEA-0183, but that is not
free, so all we can do is add filtering and displaying for ASCII content.

Also add colors for DUN, GNSS to show them in contrast to RFCOMM.

svn path=/trunk/; revision=48662
2013-03-30 21:54:42 +00:00
Evan Huus 6976653023 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
Unify bluetooth direction handling (sent vs rcvd).

svn path=/trunk/; revision=48661
2013-03-30 21:47:27 +00:00
Evan Huus 6d17f1153a From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
Round 3 of Bluetooth SDP updates. Update the list of company IDs and fix
service recognition.

svn path=/trunk/; revision=48660
2013-03-30 21:43:18 +00:00
Martin Kaiser 77c9d43ce4 coverity 993742: potential division by zero
svn path=/trunk/; revision=48659
2013-03-30 19:16:51 +00:00
Martin Kaiser 94ea9af46c fix indentation in one place
svn path=/trunk/; revision=48658
2013-03-30 19:15:29 +00:00
Martin Kaiser 3467c98afc coverity 280417: logically dead code
svn path=/trunk/; revision=48657
2013-03-30 18:57:44 +00:00
Jaap Keuter 4e09bed012 From Tyson Key:
The attached patch adds support for dissection of SAMConfiguration request packets, 
and updates the opcode table to identify their corresponding (null/empty) responses.

svn path=/trunk/; revision=48656
2013-03-30 17:09:26 +00:00
Evan Huus 02dff20783 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
Round 2 of Bluetooth SDP updates:
- replace a lot of proto_tree_add_text with named fields
- dissect more of the protocol
- misc fixes

svn path=/trunk/; revision=48655
2013-03-30 15:53:04 +00:00
Evan Huus 2fba8c0f9d Update -2, -R and -Y to behave consistently as per the concensus reached on
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8223

Mention the new -Y flag and associated changes in the release notes.

svn path=/trunk/; revision=48654
2013-03-30 15:38:03 +00:00
Evan Huus 6fa584b0db Move wireshark's display filter flag to -Y for consistency with tshark.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8223

svn path=/trunk/; revision=48653
2013-03-30 12:15:42 +00:00
Jaap Keuter 037bb3e614 Have 'Capture file' and 'Stop after' extries left aligned in GTK+ 3 as well.
svn path=/trunk/; revision=48652
2013-03-30 11:57:33 +00:00
Martin Kaiser 9ca8ee6c06 dissect CI+ Protection Descriptor
svn path=/trunk/; revision=48651
2013-03-30 10:59:30 +00:00
Martin Kaiser b3bad40c60 use proto_mpeg_descriptor_loop_dissect() in the SDT descriptor loop
this takes private descriptors into account

svn path=/trunk/; revision=48650
2013-03-30 10:41:37 +00:00
Martin Kaiser 2528164448 list the new file format in the release notes
svn path=/trunk/; revision=48649
2013-03-30 10:30:22 +00:00
Martin Kaiser 62075c88fb list the new file format on the manpage
svn path=/trunk/; revision=48648
2013-03-30 10:21:19 +00:00
Martin Kaiser 7a2bdedff6 wiretap support for the CAM Inspector file format
svn path=/trunk/; revision=48647
2013-03-30 09:56:57 +00:00
Evan Huus 178fc8852a Note to self: stop using 'index' as a variable name, it triggers -Wshadow on
some platforms. You'd think I'd have learned by now.

svn path=/trunk/; revision=48646
2013-03-30 00:11:00 +00:00
Evan Huus d155b0da19 Implement str_to_val, opposite of val_to_str for value_strings.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48645
2013-03-29 23:23:28 +00:00
Evan Huus e964ab4164 Bump two guint16 to guint32 to prevent overflow when reassembling a large
number of fragments, and add an extra bounds check.

Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8540
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8541

svn path=/trunk/; revision=48644
2013-03-29 22:20:04 +00:00
Gerald Combs 1606bec857 Add items for Bluetooth and GTK3.
svn path=/trunk/; revision=48643
2013-03-29 18:16:45 +00:00
Gerald Combs 6488d8cc53 Convert png → xpm using a higher alpha threshold.
svn path=/trunk/; revision=48642
2013-03-29 18:12:29 +00:00
Evan Huus 016f8e8d8c Add some missing #includes to hopefully fix check-abi buildbot.
svn path=/trunk/; revision=48641
2013-03-29 17:43:14 +00:00
Evan Huus ea6d7d8a34 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
First round of fixes for Bluetooth SDP.

From me:
- rename one call of match_strval to try_val_to_str instead
- remove a few hf entries that really belong with the second patch (they
  weren't used in this one)

svn path=/trunk/; revision=48640
2013-03-29 17:25:23 +00:00
Gerald Combs ce7c8bc9d7 Resurrect wsicon32.xpm using 'svn cp' then update it based on
wsicon32.png. This should hopefully preserve its history in SVN. Revert
r48565 in debian/.

svn path=/trunk/; revision=48639
2013-03-29 15:44:14 +00:00
Pascal Quantin 5c46fcea6a From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8506 :
Fix incompatible display filters using the same name

svn path=/trunk/; revision=48638
2013-03-29 13:22:53 +00:00
Michael Tüxen 7b7680f3ff Add support for new version of the ID which has been adopted as a WG item.
The now version will be supported by Firefox soon.

svn path=/trunk/; revision=48637
2013-03-29 13:01:52 +00:00
Evan Huus 03b48f94c2 Fix two instances of col_set_str being used with ephemeral memory returned
from val_to_str. Use col_add_str instead.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8537

svn path=/trunk/; revision=48636
2013-03-29 02:46:06 +00:00
Evan Huus a0d107beec Remove decode_enumerated_bitfield and decode_enumerated_bitfield_shifted.
Effectively inline the only remain call (and replace a static buffer with ep
memory). Much of the NFS dissector needs to be converted to use named fields
at which point this code can go away, but that's a much bigger job.

Also, add modelines to packet-nfs.c and mark some internal value_string
functions as WS_DLL_LOCAL.

svn path=/trunk/; revision=48635
2013-03-29 02:34:23 +00:00