osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
44934 commits 23 branches 0 tags 1.3 GiB
Commit graph

44934 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bill Meier
2c269c2864 Fix a set of obscure bugs found by checkhf. 
svn path=/trunk/; revision=47666
 2013-02-15 01:31:27 +00:00
Guy Harris
9ad02809f2 Put in a comment explaining what the signal strength value probably 
means here.

svn path=/trunk/; revision=47665
 2013-02-15 00:43:04 +00:00
Guy Harris
39a742107e Put in a comment explaining what the signal strength value means here. 
svn path=/trunk/; revision=47664
 2013-02-15 00:34:05 +00:00
Guy Harris
58a2320b89 Show the signal strength as a percentage in the RSSI column, as that's 
what it is.

svn path=/trunk/; revision=47663
 2013-02-14 22:38:50 +00:00
Guy Harris
b8179ab57b Show the signal strength as dBm, as that's what it is in the PPI header. 
svn path=/trunk/; revision=47662
 2013-02-14 22:38:12 +00:00
Guy Harris
bf4e129f5f Get rid of unused string to squelch warning. 
svn path=/trunk/; revision=47661
 2013-02-14 22:27:04 +00:00
Pascal Quantin
f244067727 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8333 : 
Corrections to Recent DNP3 Control Code Changes in Bug ID 7865

svn path=/trunk/; revision=47660
 2013-02-14 21:57:30 +00:00
Guy Harris
6532f50bd9 main_window_slots.cpp includes ui_main_window.h, so make sure we build 
ui_main_window.h before doing anything with main_window_slots.cpp.

svn path=/trunk/; revision=47659
 2013-02-14 19:56:21 +00:00
Michael Mann
19eb91cb27 Fix potential buffer overflow in RTPS and RTPS2 dissectors by allocating enough memory to fit the "indentation space". 
Bug 8332 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8332)

svn path=/trunk/; revision=47658
 2013-02-14 19:42:58 +00:00
Evan Huus
cb679f279b If the requested wmem allocator is NULL, take that to mean manually-managed 
memory. This permits using manually-scoped versions of certain wmem structures.

svn path=/trunk/; revision=47657
 2013-02-14 16:23:22 +00:00
Evan Huus
5071e8b627 Add an option for bypassing the wmem slab similar to the one for 
bypassing the emem slab, to aid in debugging with valgrind.

svn path=/trunk/; revision=47656
 2013-02-14 16:07:25 +00:00
Chris Maynard
c3c6ebe6c0 From Michael Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304: Fix potential inconsistency with interfaces introduced with r47651. 
svn path=/trunk/; revision=47655
 2013-02-14 15:29:25 +00:00
Pascal Quantin
203e7e0301 Factorize FGI dissection 
svn path=/trunk/; revision=47654
 2013-02-14 10:09:46 +00:00
Evan Huus
1019582c47 Move version field outside of the switch, since it exists for all subtypes. 
This fixes the TSPEC case, which didn't include it before.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8330

svn path=/trunk/; revision=47653
 2013-02-14 03:35:35 +00:00
Michael Mann
ad92b749e8 Fix crash with SDP setup mechanism, bug 8323 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8323) 
The issue was that hash tables were being accessed after they were freed from a "rejected answer".  

The code was also too generous in considering many SIP status codes as "rejected answers", so now less SIP status codes are treated as "rejected answers" and are ignored by the transport API.


svn path=/trunk/; revision=47652
 2013-02-14 03:30:32 +00:00
Chris Maynard
7410bf54a1 Fix Coverity CID 981007: Dereference before null check. Bug introduced with r47632. 
svn path=/trunk/; revision=47651
 2013-02-13 16:39:31 +00:00
Chris Maynard
5e2c5c7cbd Fix Coverity CID's 981004-981006: Out-of-bounds read. Bugs introduced with r47632. (Backport does not apply.) 
svn path=/trunk/; revision=47650
 2013-02-13 16:01:42 +00:00
Jaap Keuter
d2dcf56c94 From Sascha Herrmann: 
Patch registering ieee802154 dissector to Linux SLL frames.

svn path=/trunk/; revision=47649
 2013-02-13 07:16:14 +00:00
Michael Mann
222a190373 Fix Coverity 980630, negative array index read. 
svn path=/trunk/; revision=47648
 2013-02-13 01:49:06 +00:00
Bill Meier
3a37624a7b Cleanup: 
- Fix various message handler message dissection bugs;
- Change all loops with a potentially large loop count
   to be done only when 'tree' is non-null;
- Simplify code somewhat;
- Do some whitespace and formatting style changes.

svn path=/trunk/; revision=47647
 2013-02-13 00:46:15 +00:00
Evan Huus
d4dbbe0965 From Chaitanya via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8320 
Fix typo in case value that led to misdissection of TSPEC IEs.

svn path=/trunk/; revision=47646
 2013-02-13 00:01:38 +00:00
Michael Mann
1c0ef12021 Fix typos in display filters caught by checkfiltername.pl 
svn path=/trunk/; revision=47645
 2013-02-12 21:26:47 +00:00
Martin Kaiser
dbe4e9c07b remove _U_ for parameter that is used 
svn path=/trunk/; revision=47644
 2013-02-12 19:00:39 +00:00
Gilbert Ramirez
486c6d5445 Fix the grammar.h/grammar.c/grammar.lemon dependency so that 
grammar.h is not always out of date. Use the same pattern as in the
Makefile.nmake files

svn path=/trunk/; revision=47643
 2013-02-12 17:25:28 +00:00
Evan Huus
a99e6fe842 From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8318 
Support for processing UTF-16 surrogate pairs in JSON packets.

svn path=/trunk/; revision=47642
 2013-02-12 16:20:24 +00:00
Evan Huus
090d5e7eda From metatech via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8322 
MQSeries V7 protocol support.

svn path=/trunk/; revision=47641
 2013-02-12 16:13:25 +00:00
Anders Broman
fe266892a7 Even when adding a value with proto_tree_add_uint() the mask is applied to the value which may not be the optimal behavioure. 
Remove the mask to get the correct value displayed.

svn path=/trunk/; revision=47640
 2013-02-12 16:12:03 +00:00
Anders Broman
c45252a75f SDP in 183 session progress is also SDP_EXCHANGE_ANSWER_ACCEPT. 
Without this patch I get a crash on Linux and lots of
STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows.

svn path=/trunk/; revision=47639
 2013-02-12 14:58:02 +00:00
Anders Broman
ed5045605a SDP in 180 ringing is also SDP_EXCHANGE_ANSWER_ACCEPT. 
Without this patch I get a crash on Linux and lots of
STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows.

svn path=/trunk/; revision=47638
 2013-02-12 14:27:06 +00:00
Anders Broman
a3ef2a7293 Fix bit_offset. 
svn path=/trunk/; revision=47637
 2013-02-11 17:39:52 +00:00
Anders Broman
3139b2acf2 Add application ID:s 
svn path=/trunk/; revision=47636
 2013-02-11 17:38:16 +00:00
Anders Broman
755ccf4162 {..., NULL} is required as the last XXX_string array entry: value_string q763_generic_notification_indicator_vals[] 
svn path=/trunk/; revision=47635
 2013-02-11 15:56:02 +00:00
Anders Broman
76557a21f9 From: Michal Labedzki: 
[PATCH 5/6] Bluetooth: BNEP: Remove unneeded code and do some style
 changes

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=47634
 2013-02-11 15:23:51 +00:00
Anders Broman
4056b11883 From: Michal Labedzki: 
Subject: [PATCH 3/6] Bluetooth: Add modeline to hci_usb
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=47633
 2013-02-11 15:18:26 +00:00
Anders Broman
4dc754f454 From: Michal Labedzki: 
Bluetooth: Improve support of MAP, PBAP, BPP and BIP in OBEX

Add support for recognize profiles using OBEX (by "Target"), then add
all Application Parameters specific for MAP, PBAP, BPP, BIP.
Also fix one FIXME, so now dissecting by OBEX does not cause malformed
frames while jumping over dissected packets.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=47632
 2013-02-11 15:04:53 +00:00
Bill Meier
07d2692cad Fixes/Updates: 
- Call conversation_set_dissector();
- Fix encoding args related to use of FT_ABSOLUTE_TIME;
- Remove unneeded #include;
- Cleanup some whitespace.

svn path=/trunk/; revision=47631
 2013-02-11 14:59:03 +00:00
Anders Broman
8f96a14263 Dissection of Q.763 ISUP Generic Notification. 
based on bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8311

svn path=/trunk/; revision=47630
 2013-02-11 14:50:50 +00:00
Evan Huus
8fd4797a08 Add an if (tree) check to prevent a very-long-but-not-infinite loop, 
since without a tree the proto_tree_add_item calls won't throw an exception
when we run past the end of our TVB which means we could end up doing MAX_INT64
iterations.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8312

svn path=/trunk/; revision=47629
 2013-02-11 13:23:05 +00:00
Guy Harris
569aebade2 strlen() returns a size_t, so assign its return value to a size_t. 
gtk_selection_data_set() takes an int, rather than a size_t, as its last
argument, so cast away that bit of "ZOMG ARENT SIZE_T AND INT THE SAME
SIZE!!!!!!!111ONE!!!!!"

svn path=/trunk/; revision=47628
 2013-02-11 06:57:58 +00:00
Guy Harris
8f93b07ff9 Set line endings to "native". 
svn path=/trunk/; revision=47627
 2013-02-11 02:42:41 +00:00
Bill Meier
1e6e56c631 Fix two bugs in the example code that I revised. 
svn path=/trunk/; revision=47626
 2013-02-11 01:31:49 +00:00
Bill Meier
1cb08ae444 Remove a _U_ which I should not have used. 
svn path=/trunk/; revision=47625
 2013-02-11 01:27:04 +00:00
Chris Maynard
eac3307abd Nope. Try again with explicit keywords. 
svn path=/trunk/; revision=47624
 2013-02-11 01:06:00 +00:00
Chris Maynard
8b65d2759e Well, that didn't work (keyword substitution, that is). Try now. 
svn path=/trunk/; revision=47623
 2013-02-11 01:02:38 +00:00
Chris Maynard
b13e7f2000 Fix a couple of typos. Set svn properties. 
svn path=/trunk/; revision=47622
 2013-02-11 00:50:05 +00:00
Bill Meier
32834b7881 Update: Primarily to suggest calling conversation_set_dissector() 
once a packet has been identified as being part of
        a particular protocol.

svn path=/trunk/; revision=47621
 2013-02-11 00:12:59 +00:00
Evan Huus
2f156d0edc From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8309 
Restore an else clause that appears to have been accidentally removed in r44542
which was causing TCP reassembly for SMB2 messages to fail.

svn path=/trunk/; revision=47620
 2013-02-10 22:28:15 +00:00
Gerald Combs
f8002de6a4 If we're using git, try pulling the SVN revision out of the commit body. 
svn path=/trunk/; revision=47619
 2013-02-10 22:20:31 +00:00
Guy Harris
eb769ce13e Clean up some warnings (including warnings that ultimately come from 
trying to modify string constants, which isn't necessarily guaranteed to
work).

svn path=/trunk/; revision=47618
 2013-02-10 22:09:21 +00:00
Bill Meier
f784806968 Comment out numerous unused hf_.... instances found by checkhf. 
svn path=/trunk/; revision=47617
 2013-02-10 20:52:21 +00:00