osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30602 commits 23 branches 0 tags 1.3 GiB
Commit graph

9376 commits

Author SHA1 Message Date
Guy Harris
92a3647ac4 Get rid of a dead link, use IETF links for what appear to be the last 
I-Ds for PIMv1 (the next version of the dense-mode draft didn't run on
IGMP).

svn path=/trunk/; revision=31568
 2010-01-19 18:53:41 +00:00
Gerald Combs
2799a0216f Remove an unused variable. Fixup whitespace. 
svn path=/trunk/; revision=31567
 2010-01-19 17:40:52 +00:00
Anders Broman
3e1c4ca38a Remove an include. 
svn path=/trunk/; revision=31566
 2010-01-19 17:21:19 +00:00
Anders Broman
2dfd8a1e8c If user data is xml display it. 
svn path=/trunk/; revision=31565
 2010-01-19 17:20:17 +00:00
Stig Bjørlykke
174de72350 Moved expert info for bitstring size constraints below bit values. 
Enabled bitstring minimum length size check.

svn path=/trunk/; revision=31564
 2010-01-19 08:54:13 +00:00
Stig Bjørlykke
6ff81c8f6a Change group for "Unknown bit(s)" expert info to Undecoded. 
svn path=/trunk/; revision=31563
 2010-01-19 08:11:23 +00:00
Guy Harris
4579732494 Even better - don't use a global variable in the first place, as its 
value isn't used outside dissect_sss_request().

Get rid of some unused value_strings while we're at it; they duplicate
value_strings in packet-ncp-nmas.c, and if they're really needed here,
there should probably be only one instance, in, for example, the NCP
dissector.

Get rid of some unused variables, use -1 for "to the end of the tvbuff",
don't use "subverb" unless we've actually fetched its value.

svn path=/trunk/; revision=31562
 2010-01-19 01:16:02 +00:00
Bill Meier
9b568ea691 Fix gcc -Wshadow warnings 
svn path=/trunk/; revision=31561
 2010-01-19 00:37:39 +00:00
Bill Meier
c5614625ee Fix some gcc -Wshadow warnings .... 
svn path=/trunk/; revision=31559
 2010-01-18 23:16:10 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings 
svn path=/trunk/; revision=31557
 2010-01-18 21:49:47 +00:00
Bill Meier
55669f7127 Fix gcc -Wshadow warnings. 
[And therefore fixing a benign bug where memory was allocated for sizeof(*p) rather than sizeof(p)].

svn path=/trunk/; revision=31556
 2010-01-18 21:37:34 +00:00
Bill Meier
b3685a583a Use true_false_strings from tfs.c when possible; 
#include stdio, stdlib & string not req'd;
Fix a gcc -Wshadow warnng

svn path=/trunk/; revision=31555
 2010-01-18 20:51:13 +00:00
Stig Bjørlykke
10466c4bbe Add expert info to unknown bitstring bits when having a named_bits table. 
svn path=/trunk/; revision=31554
 2010-01-18 20:08:56 +00:00
Bill Meier
1c11b9571e Use consistent indentation; Reformat a few hf[] array entries. 
svn path=/trunk/; revision=31553
 2010-01-18 18:00:23 +00:00
Anders Broman
9a030dda05 Get rid of check_col(); 
svn path=/trunk/; revision=31552
 2010-01-17 18:16:06 +00:00
Bill Meier
05eae470b9 Dissector for HP encapsulated remote mirroring. 
svn path=/trunk/; revision=31547
 2010-01-17 14:07:03 +00:00
Anders Broman
a255c08b66 Get rid of check_col(); 
svn path=/trunk/; revision=31546
 2010-01-17 12:46:00 +00:00
Anders Broman
ba8d7bd919 Get rid of check_col(); 
svn path=/trunk/; revision=31544
 2010-01-17 12:19:02 +00:00
Anders Broman
0d3840e704 Update to version 9.1.0 
svn path=/trunk/; revision=31543
 2010-01-17 09:43:31 +00:00
Stephen Fisher
5531c24c67 Update URL in comments. 
svn path=/trunk/; revision=31542
 2010-01-16 03:34:07 +00:00
Guy Harris
268345f515 Use G_GSIZE_MODIFIER rather than casting to "gulong" and printing with 
"%lu".

svn path=/trunk/; revision=31541
 2010-01-16 02:57:42 +00:00
Guy Harris
969b98fa35 tvb_get_ntohl() doesn't return a long on any platform (it returns a 
guint32, and on no platform supported by GLib, and thus on no platform
supported by Wireshark, does a guint32 have to be an unsigned long), so
there's no need to cast it to long and print it with %lld.

svn path=/trunk/; revision=31540
 2010-01-16 02:39:25 +00:00
Jeff Morriss
508fd83368 Show spare bits in decimal, not as booleans. 
svn path=/trunk/; revision=31537
 2010-01-15 19:28:28 +00:00
Stig Bjørlykke
5c4ee8a291 Change col_set_str() call to col_add_str() since the string being passed 
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31536
 2010-01-15 14:05:06 +00:00
Stig Bjørlykke
9d918146ff Changed val_to_str() to val_to_str_const() when used with col_set_str(). 
svn path=/trunk/; revision=31535
 2010-01-15 13:51:47 +00:00
Stig Bjørlykke
8255893114 Change col_set_str() call to col_add_str() since the string being passed 
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31534
 2010-01-15 13:40:14 +00:00
Anders Broman
4a38ad658c Get rid of check_col(); 
svn path=/trunk/; revision=31533
 2010-01-15 07:32:04 +00:00
Anders Broman
90bf722451 From Chris Costa: 
tcp.analysis.acks_frame and tcp.analysis.ack_rtt is not reliable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3311

svn path=/trunk/; revision=31532
 2010-01-15 07:20:25 +00:00
Anders Broman
a230916b8e From Didier Gautheron: 
Don't use packet without data in sequence analysis.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2054

svn path=/trunk/; revision=31531
 2010-01-15 07:07:28 +00:00
Gerasimos Dimitriadis
fe1e9d6296 Fix for Bug 3747: 
use FT_FLOAT for the radiotap data rate because of .5 Mbps granularity

svn path=/trunk/; revision=31526
 2010-01-14 18:21:09 +00:00
Gerald Combs
0e3ba74734 Fix several buffer overflows found by babi babi. Replace a lot of manual 
fetching and displaying with proto_tree_add_item().

Use get_dns_name() instead of lwres_get_dns_name(), which fixes a separate
issue.

svn path=/trunk/; revision=31524
 2010-01-14 01:22:00 +00:00
Anders Broman
69b7a06578 Remove redundant calls to check_col() in the .cnf files and regenerate. 
svn path=/trunk/; revision=31523
 2010-01-13 21:41:28 +00:00
Michael Tüxen
c273169cbd Display correct chunk type for unknown chunks. 
svn path=/trunk/; revision=31522
 2010-01-13 21:31:24 +00:00
Anders Broman
04d526a914 check_col.diff 
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31521
 2010-01-13 21:27:44 +00:00
Anders Broman
526891f1b4 From Didier Gautheron: 
fix a memory leak by using se_strdup rather for g_strdup for column text.
replace col_clear() follow by col_add_str() with the faster col_set_str()
remove redundant check_col() call

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31520
 2010-01-13 21:16:46 +00:00
Anders Broman
440c3f9261 From Didier Gautheron: 
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
 2010-01-13 20:32:01 +00:00
Anders Broman
6343ffb68e Try to fix indentation sligtly. 
svn path=/trunk/; revision=31518
 2010-01-13 20:26:17 +00:00
Anders Broman
c4dd31cd87 From Didier Gautheron: 
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
 2010-01-13 20:25:10 +00:00
Anders Broman
253ce6255d Try to fix a memory leak. 
svn path=/trunk/; revision=31514
 2010-01-13 16:35:50 +00:00
Anders Broman
0a5a3c1158 From Didier Gautheron: 
Fix a memory leak.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31511
 2010-01-13 07:42:42 +00:00
Stig Bjørlykke
86a6a0c2a4 Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci, 
to try fixing a buildbot run-randpkt failure.

svn path=/trunk/; revision=31509
 2010-01-12 21:25:35 +00:00
Anders Broman
8dea26e52c From Gonzalo Casas: 
MMS TimeOfDay display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4387

svn path=/trunk/; revision=31508
 2010-01-12 20:15:24 +00:00
Anders Broman
1f6a39eae9 Use g_snprintf() 
svn path=/trunk/; revision=31507
 2010-01-12 20:08:30 +00:00
Martin Mathieson
d5c96e34e7 Use snprintf() to pass checkAPI 
svn path=/trunk/; revision=31506
 2010-01-12 18:43:18 +00:00
Martin Mathieson
23c5730798 Append to the SDU field only once (instead of for each byte!). 
svn path=/trunk/; revision=31503
 2010-01-12 16:12:27 +00:00
Stig Bjørlykke
3d32eed0b5 Update to RFC5035. 
svn path=/trunk/; revision=31502
 2010-01-12 14:31:08 +00:00
Stig Bjørlykke
d215938257 Update to RFC5652. 
svn path=/trunk/; revision=31501
 2010-01-12 14:29:53 +00:00
Stig Bjørlykke
89980e1672 Update to RFC3369. 
svn path=/trunk/; revision=31500
 2010-01-12 11:49:17 +00:00
Anders Broman
324af9e6fa Fix part of Bug 3917 "tvb_new_real_data is prone to memory leak" 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31499
 2010-01-11 16:14:26 +00:00
Bill Meier
11ef8a5e0f Fix Bug 4183: "Wireshark can't decrypt WPA(2)-PSK when passphrase is 63 bytes". 
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4183

svn path=/trunk/; revision=31498
 2010-01-11 15:26:39 +00:00
Jaap Keuter
b8ef5efede From Benoit Sibaud: 
New option to allow retransmission detection with different source ports.

svn path=/trunk/; revision=31496
 2010-01-11 14:28:51 +00:00
Stig Bjørlykke
c66911dd59 Small cleanup in conformation file. 
svn path=/trunk/; revision=31495
 2010-01-11 13:39:09 +00:00
Stig Bjørlykke
7b9b38018f Update to X.511:08/2005. 
svn path=/trunk/; revision=31494
 2010-01-11 13:37:36 +00:00
Stig Bjørlykke
df508b7b96 Update to X.518:08/2005 to add DitBridgeKnowledge. 
Export Exclusions.

svn path=/trunk/; revision=31493
 2010-01-11 13:36:30 +00:00
Stig Bjørlykke
3a79a59517 Add some missing DSEType's. 
svn path=/trunk/; revision=31492
 2010-01-11 13:34:05 +00:00
Stig Bjørlykke
672faadc76 Add missing DEFAULT for UpdateMode. 
svn path=/trunk/; revision=31491
 2010-01-11 13:32:55 +00:00
Anders Broman
dd9d463bcf From Hitoshi Irino: 
Failed to decode NetFlow v9 packets including a 0 length scope field.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4381

svn path=/trunk/; revision=31488
 2010-01-11 08:05:09 +00:00
Anders Broman
0d26e8ad2d From Gonzalo Casas: 
Corrected utc-time display in goose dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4378

svn path=/trunk/; revision=31484
 2010-01-11 07:52:17 +00:00
Stig Bjørlykke
4867f84826 From rmkml via wireshark-dev: 
Redirect secure SMTP traffic on non-standard port 465 to the ssl dissector.

svn path=/trunk/; revision=31482
 2010-01-10 19:39:35 +00:00
Stig Bjørlykke
30a2bbe872 Return correct offset from function handling ExtensionField/value, 
because this changed from mandatory to optional in revision 28593.

Regenerated with some BIT STRING SIZE constraints checking.

svn path=/trunk/; revision=31480
 2010-01-10 16:14:35 +00:00
Gerasimos Dimitriadis
20e77097eb Fix for Bug 4369: 
Use the correct function for adding an FT_STRING field and make some
checks regarding the length of parameters in cmd_manageuser().

svn path=/trunk/; revision=31476
 2010-01-10 14:29:49 +00:00
Gerasimos Dimitriadis
e53c76e9af Partial fix for Bug 4369: 
Remove the possibility of infinite loop when counting items of length 0.

svn path=/trunk/; revision=31475
 2010-01-10 14:00:49 +00:00
Stig Bjørlykke
d94b155f74 Update ASN.1 files. 
Added decoding of ADatP3Data, CorrectionsData, ForwardedEncryptedData, ACP127Data and ACP127NotificationResponse.

svn path=/trunk/; revision=31474
 2010-01-09 20:52:47 +00:00
Stig Bjørlykke
fc3f69f9c5 Export ReceiptTimeField. 
svn path=/trunk/; revision=31473
 2010-01-09 20:33:48 +00:00
Stephen Fisher
279fa465aa Change col_set_str() call to col_add_str() since the string being passed 
to it is freed right afterwards.  This fixes an issue reported to
wireshark-users by Ershov Pavel on Jan 9, 2010 (in the U.S.).


svn path=/trunk/; revision=31472
 2010-01-09 20:15:02 +00:00
Bill Meier
e49599c588 Fix Bug #4177: Analyze ! Expert... doesn't show IP "Bad Checksum" errors. 
svn path=/trunk/; revision=31471
 2010-01-08 23:53:46 +00:00
Bill Meier
1afe329456 Changes to use consistent indentation. 
svn path=/trunk/; revision=31470
 2010-01-08 21:07:51 +00:00
Martin Mathieson
88447bd5cb Add needed offset to 'radio-type' attached to MAC frame. 
svn path=/trunk/; revision=31469
 2010-01-08 16:08:22 +00:00
Martin Mathieson
26c0a94dea Don't crash by calling null RRC dissector because TM appeared on 'impossible' channel type. 
svn path=/trunk/; revision=31468
 2010-01-08 16:07:14 +00:00
Tomas Kukosa
f6e00fa93a fix Linux build error 
svn path=/trunk/; revision=31467
 2010-01-08 13:49:43 +00:00
Tomas Kukosa
e18c3065fb display RTSP in VoIP calls (first simple attempt) 
svn path=/trunk/; revision=31466
 2010-01-08 13:04:49 +00:00
Bill Meier
c7a7cf0771 Remove unneeded #includes. 
svn path=/trunk/; revision=31465
 2010-01-08 00:24:45 +00:00
Bill Meier
ca9fd88be4 From Yaniv Kaul: VNC dissector cleanups and minor changes. 
From me: Several fixes to the patch and some additional cleanup.

svn path=/trunk/; revision=31464
 2010-01-07 23:34:39 +00:00
Gerasimos Dimitriadis
e1af738d14 Partial fix for Bug 4369: 
Remove the possibility of infinite loop when command length is 0.

svn path=/trunk/; revision=31463
 2010-01-07 22:03:29 +00:00
Anders Broman
4d0c391d5d From Michael Lum: 
Fixes for E911 mobile positioning capability and Handoff Back2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4373

svn path=/trunk/; revision=31462
 2010-01-07 20:27:38 +00:00
Guy Harris
9038fc7098 We do proto_item_append_string() all over the place; make the tree 
visible at the top level.

svn path=/trunk/; revision=31460
 2010-01-07 02:51:57 +00:00
Martin Mathieson
bd55fda74c From Pascal Quantin: some typo fixes 
svn path=/trunk/; revision=31455
 2010-01-06 17:07:37 +00:00
Anders Broman
03929b6237 From Pascal Quantin: 
[RRC] Update SIB PDU decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4371
I also removed dummy code.

svn path=/trunk/; revision=31451
 2010-01-05 20:05:12 +00:00
Stig Bjørlykke
d298ea10e7 Terminate value_string user_vals. 
svn path=/trunk/; revision=31448
 2010-01-05 14:46:53 +00:00
Stig Bjørlykke
6a433058f9 Added check for SIZE constraints in bit-string. 
svn path=/trunk/; revision=31447
 2010-01-05 11:38:33 +00:00
Stephen Fisher
bf2aae7784 More updates to the ISL dissector: 
1) Rollback r14139 in two parts:

    a) Change user priority back to what Cisco's ISL documentation states that
       the values mean instead of the 802.1Q CoS values (see also note below).
    b) Change the destination address back to type FT_ETHER since the
       ISL-Frame values were added to manuf/wka.tmpl in r16741 with a /40
       mask.

2) Add 03-00-0C-00-00/40 to manuf/wka.tmpl for ISL over Token Ring.

3) Move the type and user fields to a tree elow the destination address since
   that is where the values come from. 

NOTE: Regarding change 1a, I noticed in the Wiki's isl-2-dot1q.cap sample
      capture file that bit #2 is being set to 1 when bits 0 and 1 are set to
      1.  When bits 0 and 1 are both set to 0, bit 2 is not set.  I cannot
      find a reference to this bit being used in Cisco's documentation. 


svn path=/trunk/; revision=31446
 2010-01-05 10:15:11 +00:00
Stig Bjørlykke
9b3a53b8d1 Split in two asn files. 
svn path=/trunk/; revision=31445
 2010-01-05 08:50:15 +00:00
Stephen Fisher
eb3313be94 Minor updates to ISL dissector: 
- Bring URLs at top of file up to date.
- Replace redundant true false string (bpdu_tfs) with built-in one (tfs_yes_no)
- Change VLAN ID representations from hex to decimal 
- Change description (but not filter name) for BPDU indicator to indicate that,
  per Cisco documentation, it is set when it is not only a BPDU frame but also
  set for CDP and VTP frames.
- Add "(Color)" to VLAN ID field descriptions for nostalgic reasons :)


svn path=/trunk/; revision=31444
 2010-01-05 08:17:09 +00:00
Guy Harris
853cb23801 Get rid of unused variables. 
svn path=/trunk/; revision=31443
 2010-01-05 02:11:24 +00:00
Anders Broman
e8042d8eec From gonzalocas: 
GSSE message dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4370

svn path=/trunk/; revision=31442
 2010-01-04 23:17:37 +00:00
Anders Broman
38b0b13b23 As requested by Pascal Quantin: 
Add the ability to call the UE EUTRA Capability dissector directly.

svn path=/trunk/; revision=31441
 2010-01-04 15:36:51 +00:00
Martin Mathieson
7897e78d02 Added casts wanted by win64 compiler. 
svn path=/trunk/; revision=31440
 2010-01-04 15:24:33 +00:00
Martin Mathieson
b8596e6ad6 Start to supply data for an RLC tap. 
svn path=/trunk/; revision=31439
 2010-01-04 14:07:24 +00:00
Stig Bjørlykke
05ec983b05 Corrected abbrev for message-id ack. 
svn path=/trunk/; revision=31434
 2010-01-03 15:42:53 +00:00
Stig Bjørlykke
31201a01cb Use different abbrev for IPv4 and IPv6 address. 
svn path=/trunk/; revision=31433
 2010-01-03 15:41:29 +00:00
Stig Bjørlykke
a6d17fca9f Corrected abbrev for Client IP. 
svn path=/trunk/; revision=31432
 2010-01-03 15:40:14 +00:00
Stig Bjørlykke
0929d61df2 Changed abbrev for amqp_field. 
svn path=/trunk/; revision=31431
 2010-01-03 15:09:26 +00:00
Stig Bjørlykke
aff9e3efe9 Use different abbrev for IPv4 and IPv6 address. 
svn path=/trunk/; revision=31430
 2010-01-03 15:08:50 +00:00
Stig Bjørlykke
31b77bac8a Use different abbrev for unknown data and unknown field. 
svn path=/trunk/; revision=31429
 2010-01-03 15:08:18 +00:00
Stig Bjørlykke
9995a69512 Changed abbrev for XML Body. 
svn path=/trunk/; revision=31428
 2010-01-03 15:07:16 +00:00
Stig Bjørlykke
1bf289e338 Fixed abbrev for entry_mask elements. 
svn path=/trunk/; revision=31427
 2010-01-03 15:06:35 +00:00
Stig Bjørlykke
4f4e8eed0b Changed abbrev for spare bytes. 
svn path=/trunk/; revision=31426
 2010-01-03 15:05:51 +00:00
Stig Bjørlykke
46e6206ecd Fixed abbrev for Padding and Flags. 
Fixed some indent.

svn path=/trunk/; revision=31425
 2010-01-03 15:01:32 +00:00
Stig Bjørlykke
35cdf7d240 Use proto_ntlmssp for protocol tree item. 
svn path=/trunk/; revision=31424
 2010-01-03 14:59:38 +00:00
Stig Bjørlykke
309989afb7 Fixed abbrev for attribute date. 
svn path=/trunk/; revision=31423
 2010-01-03 14:58:42 +00:00