osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30602 commits 23 branches 0 tags 1.3 GiB
Commit graph

9376 commits

Author SHA1 Message Date
Martin Mathieson
3b0a092b18 Fix crash bug by allocating correct size of struct (used with SR tracking). 
svn path=/trunk/; revision=31307
 2009-12-18 12:32:14 +00:00
Anders Broman
1661212158 Dissect NumberPortabilityRequest return result. 
svn path=/trunk/; revision=31306
 2009-12-18 06:26:20 +00:00
Stephen Fisher
9317528c96 Introduce a value_string to provide descriptions for some SMTP response 
codes.


svn path=/trunk/; revision=31305
 2009-12-18 04:04:15 +00:00
Gerasimos Dimitriadis
309d920eb8 Fix/enhacement of Quality of Service IE 
svn path=/trunk/; revision=31295
 2009-12-17 16:56:56 +00:00
Martin Mathieson
d7f78d0627 Remove stray #if 1 
svn path=/trunk/; revision=31292
 2009-12-17 13:33:00 +00:00
Martin Mathieson
5574e77571 Adding FT_NONE item with proto_tree_add_item() causes crashes later, so use 
proto_tree_add_none_format() instead.

svn path=/trunk/; revision=31291
 2009-12-17 13:15:29 +00:00
Stig Bjørlykke
47be3577a7 Introduce "Ignore Packet" in the packet list. 
This will remove the package from the dissection functions without
removing it from the capture file.

svn path=/trunk/; revision=31287
 2009-12-17 01:18:14 +00:00
Anders Broman
faec4bde00 From Pascal Quantin: 
Add dissection of UE Capability Information PDU.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4335

svn path=/trunk/; revision=31286
 2009-12-16 21:34:03 +00:00
Gerasimos Dimitriadis
8c1b66f33a Expert info warning when Keypad Facility IE contains character that is 
not a DTMF digit

svn path=/trunk/; revision=31284
 2009-12-16 20:46:47 +00:00
Gerasimos Dimitriadis
021f402e5f Update CC Capabilities IE to decode ENICM and MCAT 
svn path=/trunk/; revision=31283
 2009-12-16 19:16:15 +00:00
Gerasimos Dimitriadis
acd70335d1 More NULL entries in dtap_msg_sm_fcn[] to avoid out of bounds access 
svn path=/trunk/; revision=31279
 2009-12-15 22:09:32 +00:00
Gerasimos Dimitriadis
af4c9216ce Fix/update for PDP Address IE 
svn path=/trunk/; revision=31278
 2009-12-15 21:48:05 +00:00
Stephen Fisher
ae2b555a96 Fix a number of copy & paste errors introduced over various checkins and 
change duplicated filter names used for different purposes by inserting
another word to differentiate between them.


svn path=/trunk/; revision=31274
 2009-12-15 08:05:14 +00:00
Jaap Keuter
1e90e0e29a From Yaniv Kaul: 
Attached patch fixes the dissection of the Set Colormap Entries server message. 
It was at least off-by-one to start with, and the dissection went a bit wrong from there on.

svn path=/trunk/; revision=31273
 2009-12-15 07:45:14 +00:00
Anders Broman
393a236663 From Vasil Velichkov: 
Bug 4330 - Add dissection of HighLayerCompatibility parameter in CAMEL/INAP InitialDP operation.

svn path=/trunk/; revision=31272
 2009-12-15 06:31:18 +00:00
Guy Harris
07f9348849 Use the right field for the extension length. Should fix 
http://buildbot.wireshark.org/trunk/builders/Ubuntu-7.10-x86-64/builds/311/steps/run-randpkt/logs/stdio

svn path=/trunk/; revision=31270
 2009-12-14 23:55:50 +00:00
Jeff Morriss
6d11b171d6 Add support for LUDT/LUDTS in ANSI (ANSI added them in 2000/2001). 
svn path=/trunk/; revision=31268
 2009-12-14 20:08:11 +00:00
Martin Mathieson
d0260a142b Add a cast to try to keep the win64 compiler happy 
svn path=/trunk/; revision=31267
 2009-12-14 16:50:42 +00:00
Anders Broman
7a4ae2c3b5 Add ETSI Applications. 
svn path=/trunk/; revision=31266
 2009-12-14 16:49:35 +00:00
Martin Mathieson
52163da600 Show the time between SR and failure or grant. 
svn path=/trunk/; revision=31265
 2009-12-14 16:04:14 +00:00
Martin Mathieson
469884ab44 Catch unexpected Scheduling Request state transitions as expert info. 
svn path=/trunk/; revision=31261
 2009-12-14 11:23:24 +00:00
Jaap Keuter
1c8d287094 From Thomas Dreibholz: 
Add the missing message type "SSP Not Ready" to the SSP protocol
dissector.

In addition to that:
- make it a proper new style dissector, reporting dissected length,
- fix Keep Alive Ack, taking into account the indicated length.

svn path=/trunk/; revision=31260
 2009-12-14 10:59:15 +00:00
Sake Blok
1580d332f4 Fix for bug 3955 and 4288. When doing Follow TCP stream, there was no 
check whether a packet belonged to the correct tcp stream (when there 
are multiple streams in the tracefile with the samen ip addresses and 
tcp ports.


svn path=/trunk/; revision=31252
 2009-12-13 01:10:55 +00:00
Jaap Keuter
e1ec979363 From Mathieu Parent: 
As defined in rfc4511 [Lightweight Directory Access Protocol (LDAP): The Protocol],
see the attached patch that dissects IntermediateMessage.

svn path=/trunk/; revision=31251
 2009-12-12 09:30:49 +00:00
Jaap Keuter
98aaf48d95 From Yaniv Kaul: 
VNC dissector fails to dissect properly the authentication used by the older
VNC protocol. Specifically, the part about version 3.3 in section 6.2 of the 
protocol was ignored / not properly implemented.

svn path=/trunk/; revision=31250
 2009-12-12 08:39:38 +00:00
Jaap Keuter
3cb9c84da1 From Martin Willi: 
The attached patch fixes the check for types with the long extension format and re-enables it.

svn path=/trunk/; revision=31244
 2009-12-11 17:18:00 +00:00
Martin Mathieson
63fc401318 From Pascal Quantin: add PDCP framing method over UDP. 
svn path=/trunk/; revision=31243
 2009-12-11 14:31:40 +00:00
Guy Harris
ac73800bfa Just use abs_time_secs_to_str() to display UTC times, now that it has a 
flag to tell it to format the time in UTC.

svn path=/trunk/; revision=31239
 2009-12-11 08:45:45 +00:00
Jaap Keuter
1e9498cf25 From Clif Bratcher: 
Add a tap hook to the IPv6 dissector.

svn path=/trunk/; revision=31230
 2009-12-10 23:15:12 +00:00
Stephen Fisher
b665a515a8 Generated fields should not highlight any bytes in the packet bytes pane. 
This is especially true in this case because the indication that an arp
packet is gratuitous is determined with the following code, which checks
multiple fields:

  if (((ar_op == ARPOP_REQUEST) || (ar_op == ARPOP_REPLY)) && (memcmp(spa_val, tpa_val, ar_pln) == 0))
    is_gratuitous = TRUE;
  else
    is_gratuitous = FALSE;


svn path=/trunk/; revision=31229
 2009-12-10 22:35:09 +00:00
Guy Harris
ab0a5a3e15 Show absolute times as UTC, as was done before. 
svn path=/trunk/; revision=31228
 2009-12-10 22:20:18 +00:00
Guy Harris
4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str() 
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
 2009-12-10 22:19:29 +00:00
Guy Harris
e1a76d5e2b Well, not quite - proto_tree_add_item() doesn't work on FT_ABSOLUTE_TIME 
fields, as there are several different possible time formats, and
there's not yet any way to specify the particular format.  However, we
don't need to format the time stamp - let the Wireshark core code do that.

svn path=/trunk/; revision=31226
 2009-12-10 22:15:59 +00:00
Guy Harris
28ccd651bf Just use proto_tree_add_item(), don't use a fancy sequence of code that 
yields the same result.

svn path=/trunk/; revision=31225
 2009-12-10 21:59:35 +00:00
Guy Harris
9a4bdbf9ea Use existing code to format relative and absolute times. 
svn path=/trunk/; revision=31224
 2009-12-10 20:48:31 +00:00
Bill Meier
4bc9b95d69 Fix Bug #4319: IPMI dissector crash (on Windows) displaying date/time; 
Using strftime(..., "%F %T", ...) crashes on Windows (VC9) (!!);
Use "%Y-%m-%d %H:%M:%S" instead.....

svn path=/trunk/; revision=31223
 2009-12-10 20:26:39 +00:00
Stephen Fisher
2e94d6c37a Add a simple description to the PID field. 
svn path=/trunk/; revision=31222
 2009-12-10 19:15:37 +00:00
Bill Meier
f3c1957f7c Fix Bug 4316: Crash when using custom RADIUS dictionary. 
(The bug was caused by a variable not being initialized).
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4316

svn path=/trunk/; revision=31221
 2009-12-10 18:13:38 +00:00
Gerasimos Dimitriadis
224298d17c Fix for Bug 4311: 
Update context in case of Get Body Chunk; recognize empty body packets

svn path=/trunk/; revision=31220
 2009-12-09 23:14:31 +00:00
Gerasimos Dimitriadis
2e138172a2 Constrained SEQ OF in PER encoding associated with wrong length; 
also take into account cases of length 0.

svn path=/trunk/; revision=31219
 2009-12-09 21:18:04 +00:00
Gerasimos Dimitriadis
142b31816c From Mathieu Parent: 
Dissector for LDAP Content Synchronization Operation
(Modified in order to remove the unneeded oid_add_from_string's)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4309

svn path=/trunk/; revision=31218
 2009-12-09 20:59:20 +00:00
Jaap Keuter
0960a7221b Add the Id tag. 
svn path=/trunk/; revision=31209
 2009-12-08 22:21:51 +00:00
Stig Bjørlykke
7885ac7b92 Added defines for protocol identifier. 
Added hf_addr_ext_form_orig for Originator.
Rewrote strings for addr_form.
Indicate national protocol.
Added expert info for unknown compression.
Some code cleanup.

svn path=/trunk/; revision=31203
 2009-12-08 10:14:22 +00:00
Martin Mathieson
f1977c1eb7 Add a link to protocol wiki page, where link to example program for UDP framing may be found. 
svn path=/trunk/; revision=31202
 2009-12-08 10:07:27 +00:00
Anders Broman
62c3372576 From Jakub Zawadzki: 
ctime() is not thread safe and it's obsolete.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4302

svn path=/trunk/; revision=31200
 2009-12-08 07:41:43 +00:00
Stephen Fisher
09a4f2af2f From Felix Obenhuber via bug #4299: SocketCAN dissector patch 
From me: Remove changes related to the ARP protocol because it doesn't
appear to be necessary for SocketCAN.  Will add later if Felix says it is
needed.


svn path=/trunk/; revision=31196
 2009-12-08 07:21:33 +00:00
Stig Bjørlykke
7aa873dae6 A fix for bug 4301: 
Check sip->extra_info for SMB_EI_NTI before usage.

svn path=/trunk/; revision=31187
 2009-12-07 15:07:38 +00:00
Stig Bjørlykke
82e8cfe421 Build correct oraddress for several Teletex values. 
Corrected label format for GenerationQualifier: GQ -> Q.

svn path=/trunk/; revision=31186
 2009-12-07 12:17:13 +00:00
Martin Mathieson
68546e930e From Pascal Quantin. Add support a UDP framing format for LTE RLC. 
svn path=/trunk/; revision=31185
 2009-12-07 10:23:35 +00:00
Gerasimos Dimitriadis
eff8b8dd39 From Bug 4298: 
Add additional LDAP OIDs for LDAP Content Synchronization Operation
(Slightly modified in order to add code in packet-ldap-template.c)

svn path=/trunk/; revision=31179
 2009-12-04 23:09:37 +00:00
Martin Mathieson
9a0c5d29c6 Fix length in loop (from Pascal Quantin). 
svn path=/trunk/; revision=31178
 2009-12-04 22:27:29 +00:00
Gerasimos Dimitriadis
809477b66e Fix for Bug 4197: 
Neighbour Cell Description 2 decode error

svn path=/trunk/; revision=31177
 2009-12-04 20:27:16 +00:00
Martin Mathieson
2267dcdd0e From Pascal Quantin via bug 4296. 
- make framing format work when there are no optional parameters present
- when showing raw SDU, show formatted info as well as data itself.  This is done in a horrible way, but I can't find a nice way.

svn path=/trunk/; revision=31174
 2009-12-04 17:39:39 +00:00
Bill Meier
cc43ff3835 From: Ravi Kondamuru: 
"... a patch to make the netscaler wiretap code independent of the
 host system endian-ness. 
 I have taken care of (1) reading and writing nstrace files (netscaler.c) and
 (2) reading in dissector code (packet-nstrace.c) also."

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3540#c26

svn path=/trunk/; revision=31171
 2009-12-04 15:21:48 +00:00
Martin Mathieson
0015dc63be Show whether NACK is full or partial in expert info. 
svn path=/trunk/; revision=31170
 2009-12-04 11:22:33 +00:00
Martin Mathieson
27169c915c Provide frame links between grant or failure ind back to SR. 
svn path=/trunk/; revision=31169
 2009-12-04 11:13:20 +00:00
Stephen Fisher
5ee8a92d01 Fix a problem where the Info column's contents was changing erratically 
because the Info column was being filled in with a string that didn't
stay around long enough.  Changed a col_set_str() to col_add_str() call. 


svn path=/trunk/; revision=31168
 2009-12-04 02:41:23 +00:00
Anders Broman
571e210c76 From Pascal Quantin: 
[NAS EPS] various small fixes for message decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4290

svn path=/trunk/; revision=31166
 2009-12-03 20:12:13 +00:00
Stephen Fisher
c5fdb8edae From Chris Maynard via bug #4287: Display IP protocol number in decimal 
instead of hexadecimal.


svn path=/trunk/; revision=31165
 2009-12-03 19:10:43 +00:00
Stig Bjørlykke
44f8b813ee Decode family and hook type. 
svn path=/trunk/; revision=31164
 2009-12-03 17:31:26 +00:00
Bill Meier
7663aff6fc #include <string.h> not needed. 
svn path=/trunk/; revision=31162
 2009-12-03 16:40:35 +00:00
Stig Bjørlykke
e592902393 From Petr Sumbera via bug 4284: 
Added support for Solaris IPNET layer

From me:
Some code cleanup in packet-ipnet.c
Added packet-ipnet.c to CMakeFiles.txt
Added WTAP_ENCAP_IPNET to encap_table_base[]

svn path=/trunk/; revision=31159
 2009-12-03 15:27:39 +00:00
Gerald Combs
a4538a17a8 Back out r30376, which introduced a buffer overrun. Fixes bug 4285. 
svn path=/trunk/; revision=31157
 2009-12-02 22:29:06 +00:00
Anders Broman
a7255dd3ba Make it possible to match transaction Id:s for Conversation where 
both Originatingand Responding TID is present.

svn path=/trunk/; revision=31156
 2009-12-02 20:16:21 +00:00
Martin Mathieson
b3a836bc23 The beginnings of a state machine to track a UE's SR state and provide links between relevant frames. 
svn path=/trunk/; revision=31153
 2009-12-02 17:46:27 +00:00
Jaap Keuter
6be946c4bb From Samu Varjonen: 
svn diff of the changes after draft-ietf-hip-nat-traversal-09 was approved to
become an RFC.

svn path=/trunk/; revision=31148
 2009-12-02 07:34:55 +00:00
Gerasimos Dimitriadis
060ac76f82 Show spare bits under the IEs they belong 
svn path=/trunk/; revision=31144
 2009-12-01 20:19:01 +00:00
Gerald Combs
2ebdf97ca3 Add an item length check to the DTN dissector. Fixes bugs 4277 
and 4278.  Add a couple of expert items.

svn path=/trunk/; revision=31133
 2009-11-30 18:10:46 +00:00
Gerald Combs
9417a7c86f From Jakub Zawadzki via bug 4274: 
Switch back to checking size instead of asize in emem_alloc_chunk. Make
sure we don't try to cross the streams by allocating a negative amount
of memory in the LTP dissector.

svn path=/trunk/; revision=31132
 2009-11-30 17:31:13 +00:00
Stig Bjørlykke
b5f2728811 Default enable DSP. 
svn path=/trunk/; revision=31129
 2009-11-30 13:11:14 +00:00
Stig Bjørlykke
b9524c35d1 SearchArgumentData filter and EntryInformationSelection attributes are 
OPTIONAL as they are defined with a DEFAULT.

svn path=/trunk/; revision=31128
 2009-11-30 12:54:47 +00:00
Gerasimos Dimitriadis
5de2fed9aa PS LCS Capability IE updated according to 24.008 V8.6.0; 
Change printing of values according to standard style.

svn path=/trunk/; revision=31127
 2009-11-29 23:23:27 +00:00
Jaap Keuter
6cdc6d4968 Try to get the Win64 compile going as well. 
svn path=/trunk/; revision=31124
 2009-11-29 22:47:03 +00:00
Martin Mathieson
8713027d83 Obselete a couple of preferences that can always be on. 
svn path=/trunk/; revision=31123
 2009-11-29 22:45:06 +00:00
Stig Bjørlykke
1d845b1d80 Small fix for "Flag C" filter. 
svn path=/trunk/; revision=31121
 2009-11-29 19:55:02 +00:00
Jaap Keuter
c795dd1af5 From Mithun Roy: 
This is a patch for a new dissector that decodes LTP (Licklider Transmission
Protocol) data according to RFC 5326.

svn path=/trunk/; revision=31120
 2009-11-29 19:11:55 +00:00
Bill Meier
e9fd4a430e Add emacs 'editor modelines'. 
svn path=/trunk/; revision=31119
 2009-11-29 17:58:17 +00:00
Jaap Keuter
b2e0568450 Fix EAP method type 25, 26 interpretation. 
svn path=/trunk/; revision=31115
 2009-11-29 13:55:34 +00:00
Jaap Keuter
cf9260ec0d From Alexis La Goutte: 
Based from a Cisco Sample (Thanks Tanmay)
Changelog :
* Fix a error about value of wbid 
* Support of CAPWAP fragmentation
* Add proper handling of the alignment stuff from the RFC for Radio MAC and Wireless specific information
* Add more support of Messages Element Type
* Add a option to dissector Cisco Sample (Cisco Controler use a old draft)

svn path=/trunk/; revision=31114
 2009-11-29 13:33:05 +00:00
Anders Broman
4888a8de8a From Tobias Witek: 
Add support for UMTS FP over UDP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4218

svn path=/trunk/; revision=31113
 2009-11-29 12:05:23 +00:00
Anders Broman
a5d39ef850 From Harald Welte: 
Correctly parse SYSTEM INFORMATION messages in RSL BCCH FILLING.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4268

svn path=/trunk/; revision=31112
 2009-11-29 09:33:22 +00:00
Anders Broman
135c24f2ba From Herbert Lischka: 
Patch to resolve Error in decoding BACnet NotificationParameters,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4250

svn path=/trunk/; revision=31111
 2009-11-29 09:28:14 +00:00
Stephen Fisher
c241b33233 From enhancement bug #4272: Patch to add new filterable field - 
frame.time_epoch


svn path=/trunk/; revision=31110
 2009-11-29 09:26:01 +00:00
Kovarththanan Rajaratnam
3720bf815c Don't do check_col() 
svn path=/trunk/; revision=31109
 2009-11-29 02:33:31 +00:00
Anders Broman
8b78665a6a - Update ASN1 files to 3GPP TS 36.331 V8.7.0 (2009-09) 
- Make it possible to use "decode as" on DL-CCCH messages sent over UDP.

svn path=/trunk/; revision=31107
 2009-11-28 16:21:19 +00:00
Bill Meier
5cae51417c proto_reg_handoff...: if (!initialized) not req'd; 
Remove unneeded #includes;
Use true_false_string definitions from tfs.c when possible. 

svn path=/trunk/; revision=31106
 2009-11-28 14:47:12 +00:00
Jaap Keuter
698b6e37a0 From J.C. Wren: 
This patch adds protocol dissection support for the Assa Abloy R3 protocol. 
R3 is an electronic lock management protocol for configuring operational
parameters, adding/removing/altering users, dumping log files, etc.

svn path=/trunk/; revision=31105
 2009-11-28 01:16:52 +00:00
Gerasimos Dimitriadis
8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area 
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
 2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis
b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits 
svn path=/trunk/; revision=31102
 2009-11-27 22:57:50 +00:00
Bill Meier
adb2890b02 col_clear() not req'd before col_add_fstr(); 
Remove unneeded forward reference;
Fix typo in a comment.

svn path=/trunk/; revision=31101
 2009-11-27 20:52:21 +00:00
Stig Bjørlykke
72d1cd92de Corrected OID for organizationalUnit. 
svn path=/trunk/; revision=31096
 2009-11-27 14:58:43 +00:00
Stig Bjørlykke
4bcde1958f Add PDU Delay for first data packet. 
svn path=/trunk/; revision=31095
 2009-11-27 14:29:38 +00:00
Gerasimos Dimitriadis
b77caf13a9 More uniform printing of field values: Interpretation first, actual 
value second.

svn path=/trunk/; revision=31092
 2009-11-26 22:37:43 +00:00
Anders Broman
6412e5801f Dissect RRC-container in RelocationResourceAllocation successful outcome. 
svn path=/trunk/; revision=31082
 2009-11-26 07:33:08 +00:00
Martin Mathieson
57d5b991b5 Include ue id in expert info for retx. 
svn path=/trunk/; revision=31080
 2009-11-25 23:18:28 +00:00
Martin Mathieson
33d4186696 Set extent of AM header root properly when there are extensions. 
Give more descriptive expert text when we there is no data for non-extension segment.

svn path=/trunk/; revision=31079
 2009-11-25 23:17:23 +00:00
Guy Harris
1d95b0d4bf Squelch a compiler warning. 
svn path=/trunk/; revision=31078
 2009-11-25 22:30:41 +00:00
Jaap Keuter
1fcf44886e From Michael Speck: 
This patch enhances dissection of NTP protocol's Control messages 
as described in RFC1119 and RFC1305.

svn path=/trunk/; revision=31077
 2009-11-25 21:47:28 +00:00
Anders Broman
6966220a7c Dissect more containers etc. 
svn path=/trunk/; revision=31076
 2009-11-25 21:31:55 +00:00
Jaap Keuter
e1afd4d4f7 From Beth Tridium: 
When a 6lowpan message has a compressed UDP length (i.e. the length must be
calculated, not read from the headers), the 6lowpan dissector correctly reports
that the UDP length is compressed, but it may try to read the length from the
headers anyway.

svn path=/trunk/; revision=31075
 2009-11-25 19:46:08 +00:00
Gerald Combs
4c6f3e96de Show the number of bits captured and on the wire. Use unsigned ints. 
svn path=/trunk/; revision=31074
 2009-11-25 19:18:41 +00:00
Anders Broman
9ca6c5518c If SourceRNC-ToTargetRNC-TransparentContainer is called trough dissect_ranap_SourceRNC_ToTargetRNC_TransparentContainer_PDU ProtocolIE_ID may be unset 
svn path=/trunk/; revision=31073
 2009-11-25 17:15:10 +00:00
Martin Mathieson
bd3a966861 Track UL HARQ retx, look for original tx frame. 
svn path=/trunk/; revision=31072
 2009-11-25 16:00:58 +00:00
Jaap Keuter
ea3407dc59 From Andrew Jean: 
When dissecting an eDonkey "Request Parts" message, Wireshark incorrectly reads
3 offset start/end pairs when the actual number can be 1-3 pairs.

svn path=/trunk/; revision=31071
 2009-11-25 06:39:29 +00:00
Gerald Combs
eadf5e8448 Fix compilation problems. 
svn path=/trunk/; revision=31070
 2009-11-25 00:30:07 +00:00
Jaap Keuter
585e448083 From Juha Siltanen : 
This is a patch for a new dissector that decodes Nokia Siemens Networks'
proprietary Flow Layer Internal Protocol (Ethertype 0x8901).

svn path=/trunk/; revision=31069
 2009-11-24 23:11:11 +00:00
Gerasimos Dimitriadis
299d64d458 Use range_string for the decoding of the CN specific DRX 
cycle length coefficient; fixed the decoding of unknown 
values for Split PG Cycle Code; updated function for
Identity Type 2, now spare bit is explicitly shown; Reuse
the definition of the Switch-Measure-Switch values from
packet-gsm_a_common.c

svn path=/trunk/; revision=31060
 2009-11-23 23:02:02 +00:00
Anders Broman
4187652696 Add dissection of Source RNC to target RNC transparent information in BSSAP. 
Fix RRC container dissection in RANAP.

svn path=/trunk/; revision=31058
 2009-11-23 22:02:05 +00:00
Gerasimos Dimitriadis
029f3641ae Basic support for the DTAP User-User IE; print bitfields in a way more 
similar to proto_tree_add_bits_item(); Minor comment edits

svn path=/trunk/; revision=31057
 2009-11-23 20:23:30 +00:00
Gerasimos Dimitriadis
5664dac535 Analyze GPRS Timer in its two subfields, unit and value 
svn path=/trunk/; revision=31056
 2009-11-23 19:59:40 +00:00
Gerasimos Dimitriadis
518995a4d8 No need for decoding function for a Tag-only IE 
svn path=/trunk/; revision=31055
 2009-11-23 19:15:58 +00:00
Stig Bjørlykke
d577ca0fa7 Guard #include <sys/types.h> with HAVE_SYS_TYPES_H. 
svn path=/trunk/; revision=31053
 2009-11-23 18:47:52 +00:00
Stig Bjørlykke
2a6f8f21fc From Barry Miller via bug 4258: 
Include sys/types.h to make it compile on OpenBSD 4.5.

svn path=/trunk/; revision=31051
 2009-11-23 08:47:25 +00:00
Guy Harris
3bb1cd12a4 No non-ASCII characters, please. 
svn path=/trunk/; revision=31049
 2009-11-22 21:54:50 +00:00
Anders Broman
98c852386d Handle lenght restriction extension of restricted strings. 
Fixes 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4251

svn path=/trunk/; revision=31047
 2009-11-22 17:00:45 +00:00
Kovarththanan Rajaratnam
a8b7853536 ..but make sure we call tvb_get_guint8() at least once ;) 
svn path=/trunk/; revision=31043
 2009-11-21 11:21:23 +00:00
Kovarththanan Rajaratnam
ed5ff812fd Use gint when declaring a tree type variable 
svn path=/trunk/; revision=31040
 2009-11-21 10:45:27 +00:00
Kovarththanan Rajaratnam
d56779b966 Don't call tvb_get_guint8() twice 
svn path=/trunk/; revision=31039
 2009-11-21 10:45:19 +00:00
Anders Broman
9da838cb7e offset is in bits 
svn path=/trunk/; revision=31036
 2009-11-20 21:51:48 +00:00
Anders Broman
a3839c2a85 Dissect transportLayerAddress and rrc-context 
svn path=/trunk/; revision=31035
 2009-11-20 21:41:51 +00:00
Anders Broman
9aa6257dde Handle extended PER bitstrings. 
svn path=/trunk/; revision=31034
 2009-11-20 21:40:28 +00:00
Gerasimos Dimitriadis
d07a4dd389 When decoding a Cell Identifier, curr_offset is not increased after 
reading rnc-id

svn path=/trunk/; revision=31032
 2009-11-20 16:23:18 +00:00
Stig Bjørlykke
3734aaa330 Print adjusted length. 
svn path=/trunk/; revision=31031
 2009-11-20 14:12:15 +00:00
Stig Bjørlykke
e8bcb04ef4 Added nbss.length. 
svn path=/trunk/; revision=31030
 2009-11-20 13:57:26 +00:00
Gerald Combs
8533da1c94 Don't call tvb_new_subset on a NULL pointer. Fixes bug 4101. 
svn path=/trunk/; revision=31029
 2009-11-19 22:41:01 +00:00
Anders Broman
b1f6df534a From Michael Lum: 
The attached patch calls the tap to allow the number
of each type of message to be counted.

The patch does not fix the "size"/number of octets
column that is all zeroes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4253

svn path=/trunk/; revision=31027
 2009-11-19 21:44:28 +00:00
Jaap Keuter
6602c02f68 From Fabrizio Bertocci: 
I'm submitting an updated version of the RTPS & RTPS2 packet dissector.
While the RTPS packet dissector doesn't have too many changes (except for few
comments perhaps), the RTPS 2 packet dissector includes now dissecting of the
latest addition to the RTPS protocol (batched data, sessions, sparse data types).

svn path=/trunk/; revision=31026
 2009-11-19 21:30:25 +00:00
Anders Broman
4a2c426b34 From Michael Lum: 
MEID missing from some messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4252

svn path=/trunk/; revision=31025
 2009-11-19 21:12:58 +00:00
Gerasimos Dimitriadis
14689bd1ca - Remove if(tree) checks 
- Add masks so that PIM Version and Type nibbles are shown
- Show reserved byte in PIM header

svn path=/trunk/; revision=31022
 2009-11-19 20:19:12 +00:00
Martin Mathieson
51e240596d Dissect SRB2 as PDCP signalling too. 
svn path=/trunk/; revision=31021
 2009-11-19 18:23:53 +00:00
Martin Mathieson
2d2a1ef1cf Tweak expert info level/text. 
svn path=/trunk/; revision=31019
 2009-11-19 18:11:38 +00:00
Stig Bjørlykke
005049bebb Changed hf_ip_proto to use ipproto_val[]. 
Removed some unneeded includes.

svn path=/trunk/; revision=31017
 2009-11-19 15:30:06 +00:00
Anders Broman
7d6819f0bc ENBname is now a PrintableString. handling in .cnf no longer needed. 
svn path=/trunk/; revision=31014
 2009-11-19 09:56:18 +00:00
Anders Broman
cf5b1f4786 From Holger Freyther: 
RSL is on more than stream-id == 0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4245

svn path=/trunk/; revision=31013
 2009-11-19 07:06:59 +00:00
Gerald Combs
cf8126a808 Instead of initializing the Media Format name to NULL, set it to 
"Unknown".  This keeps us from crashing on some platforms if we have an
unknown media format ID.

svn path=/trunk/; revision=31011
 2009-11-19 01:50:44 +00:00
Jaap Keuter
53d17afd80 Get the offset right. 
svn path=/trunk/; revision=31010
 2009-11-18 23:50:05 +00:00
Gerasimos Dimitriadis
36b1cc8e77 Updated GPRS TMSI Status and Update Type IEs 
svn path=/trunk/; revision=31009
 2009-11-18 22:41:08 +00:00
Gerasimos Dimitriadis
bb3447c6b1 GPRS Attach Type IE updated according to 24.008 v8.6.0 
svn path=/trunk/; revision=31008
 2009-11-18 22:05:16 +00:00
Gerasimos Dimitriadis
55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in 
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
 2009-11-18 20:39:14 +00:00
Martin Mathieson
fa8e0f479f Trivial: comment update 
svn path=/trunk/; revision=31004
 2009-11-18 13:47:38 +00:00
Martin Mathieson
479fc76dc9 Expert warning about BSRs over a threshold configured in pref. 
svn path=/trunk/; revision=31003
 2009-11-18 13:47:08 +00:00
Anders Broman
e290921da1 From Aamer Akhter: 
Add fields for:
 cdp platform
 cdp device id
 cdp port id
From me:
Chnge ..add_uint to add_item in a couple of places, get rid of check_col.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4244

svn path=/trunk/; revision=30999
 2009-11-17 21:23:19 +00:00
Anders Broman
0d6239a976 Mobile On Channel carries no data. 
svn path=/trunk/; revision=30998
 2009-11-17 20:48:04 +00:00
Gerasimos Dimitriadis
bd124019a4 Fix for Bug 4248: 
Graft and GraftAck should get the same handling


svn path=/trunk/; revision=30997
 2009-11-17 20:38:02 +00:00
Gerasimos Dimitriadis
c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Martin Mathieson
7af44b2991 Resuse struct for PDCP info when redissecting. 
svn path=/trunk/; revision=30992
 2009-11-17 17:30:40 +00:00
Kovarththanan Rajaratnam
4e34e57739 From Benjamin Roch via. bug 4247: 
Fix type-field of protocol control frame

svn path=/trunk/; revision=30989
 2009-11-17 15:53:38 +00:00
Stig Bjørlykke
9c06ca976e Added format argument. 
svn path=/trunk/; revision=30986
 2009-11-17 08:47:27 +00:00
Anders Broman
44ee17f2d6 Herbert Lischka: 
Recipients as IPv4 and IPv6.

svn path=/trunk/; revision=30985
 2009-11-17 07:36:40 +00:00
Stig Bjørlykke
ebd71d6f84 Added more Peer ID Conventions. 
svn path=/trunk/; revision=30980
 2009-11-16 22:53:11 +00:00
Ronnie Sahlberg
6c05ca1051 dont print the window size for the initial SYN packet 
svn path=/trunk/; revision=30979
 2009-11-16 21:26:55 +00:00
Gerasimos Dimitriadis
e92c2e17da GPRS Attach Result IE updated according to 24.008 v8.6.0 
svn path=/trunk/; revision=30977
 2009-11-16 18:22:43 +00:00
Martin Mathieson
a6bc911e49 Show data-less PDUs are Error rather than warning. 
Only call PDCP for complete signalling PDUs.

svn path=/trunk/; revision=30976
 2009-11-16 18:18:07 +00:00
Gerald Combs
f075c30958 Don't let the session blob length go stomping all over the stack with 
muddy boots. Fixes bug 4239.

svn path=/trunk/; revision=30975
 2009-11-16 17:08:12 +00:00
Gerasimos Dimitriadis
79cf9b5f45 Erroneously ommitted from the patch of Bug 4219: 
bit_offset used instead of curr_bit_offset


svn path=/trunk/; revision=30974
 2009-11-16 16:20:49 +00:00
Martin Mathieson
1a46552674 Allow LTE RRC dissector to call PDCP/RRC dissectors as appropriate for signalling PDUs. 
svn path=/trunk/; revision=30971
 2009-11-16 15:35:56 +00:00
Anders Broman
8e07cb1a33 Update SIP headers. 
svn path=/trunk/; revision=30969
 2009-11-16 06:48:17 +00:00
Gerasimos Dimitriadis
18d299b758 - Replaced get_start_octet() with a right shift 
- Deleted function bssgp_tvb_get_bits8(), uses tvbuff counterpart now
- guint32 vars should be enough for bit offsets

svn path=/trunk/; revision=30963
 2009-11-14 21:15:38 +00:00
Gerasimos Dimitriadis
9b36fc784e From yy: 
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219


svn path=/trunk/; revision=30962
 2009-11-14 20:13:43 +00:00
Kovarththanan Rajaratnam
81fe22f0d1 Remove unused static variable 
svn path=/trunk/; revision=30961
 2009-11-14 07:28:46 +00:00
Jaap Keuter
2f2bfdddd9 From Ivan Sy: 
Patch for IPv6 dissector to support the ff:
- RFC 2460 sec 3, particularly Traffic Class field's 6-bit DSCP and 2-bit ECN 
- RFC 2474 sec 3, copied implementation of ip.c to determine DSCP codepoints
- RFC 3168 sec 5, for ECN's ECT and CE bits
- changed the comment

svn path=/trunk/; revision=30957
 2009-11-13 22:19:31 +00:00
Jaap Keuter
eeb2d89d92 From Herbert Lischka: 
- packet-bacapp.h eliminated and included in packet-bacapp.c
- dissection of recipient-list and client-cov-increment added

svn path=/trunk/; revision=30955
 2009-11-13 20:24:36 +00:00
Stig Bjørlykke
8b42b795e8 Use correct opcode table for error values and regular values. 
Removed check_col().

svn path=/trunk/; revision=30950
 2009-11-13 12:33:33 +00:00
Jaap Keuter
0e4e74ef3d From Michael Dishman: 
Fixed parser for DIS DataRequest PDU.
Added parser for DIS StartResume, StopFreeze, Acknowledge, ActionRequest,
ActionResponse, Comment, CreateEntity, DeleteEntity PDUs.
Added parser for "reliable" versions of the above DIS PDUs.
Added parser for DIS Application Control PDU.
Added parsers for DIS Persistent Object Family PDUs.

svn path=/trunk/; revision=30947
 2009-11-13 06:53:15 +00:00
Bill Meier
ec097d9981 (Trivial): check_col() guard not needed for col_set_str; #include <stdio.h> not req'd. 
svn path=/trunk/; revision=30946
 2009-11-13 00:02:48 +00:00
Jaap Keuter
aca15d236e From Thomas Dreibholz: 
NetPerfMeter is an Open Source TCP/UDP/SCTP/DCCP network performance metering
application for Linux, FreeBSD and MacOS X. It can be downloaded here:
http://www.exp-math.uni-essen.de/~dreibh/netperfmeter/ . The protocol used by
this application for the transport of control and data is called NetPerfMeter
protocol. The attached patch is a dissector to decode its packets.

svn path=/trunk/; revision=30943
 2009-11-12 22:35:27 +00:00
Jaap Keuter
bd92a72428 From Henning Rogge: 
This patch adds support for PacketBB (RFC 5444) to Wireshark. 
PacketBB is a generic message format for mesh networks. 
Both OLSR version 2 and DYMO will use packetbb.

svn path=/trunk/; revision=30942
 2009-11-12 18:18:15 +00:00
Gerald Combs
f218c18d00 Make the MCC length check a little more picky. 
svn path=/trunk/; revision=30937
 2009-11-12 02:03:10 +00:00
Gerald Combs
bc41dc6837 Check for an invalid MCC length. Fixes bug 4212. 
svn path=/trunk/; revision=30936
 2009-11-12 01:55:06 +00:00
Jaap Keuter
324b7484d9 Implement RFC 3514. 
svn path=/trunk/; revision=30926
 2009-11-10 21:46:14 +00:00
Jaap Keuter
d22d3bf804 From Hariharan Ananthakrishnan: 
Support ISIS local /remote identifier display for extended IS adjacency
(RFC 5307 section 1.1.)

svn path=/trunk/; revision=30924
 2009-11-10 20:13:10 +00:00
Jaap Keuter
be342f9e26 From Bernard Imbert: 
If the "Level Of Interest" referenced in the smb.trans2.FIND_FIRST/FIND_NEXT
requests is 262, wireshark is unable to decode properly (neither the request
nor the response).

svn path=/trunk/; revision=30923
 2009-11-10 19:24:50 +00:00
Anders Broman
9822e9f804 Align RRC-Container dissection with RANAP. 
svn path=/trunk/; revision=30911
 2009-11-09 21:47:21 +00:00
Balint Reczey
02c98c4517 Decode Circuit ID and Remote ID DSL Forum TR-101 PPPoE tags. 
Based on patch from Stefan Puiu <stefan.puiu@gmail.com>.
This fixes bug 3113.

svn path=/trunk/; revision=30908
 2009-11-09 15:55:01 +00:00
Stig Bjørlykke
edc6f0cd3b Put sndcp-xid elements in the sndcp-xid subtree. 
svn path=/trunk/; revision=30907
 2009-11-09 15:51:30 +00:00
Stig Bjørlykke
1743f6e76f Fixed a return statement. 
svn path=/trunk/; revision=30906
 2009-11-09 15:44:14 +00:00
Stig Bjørlykke
2c01893e72 Conversation is unused in dissect_rtmpt_tcp(). 
svn path=/trunk/; revision=30905
 2009-11-09 15:43:54 +00:00
Stig Bjørlykke
ab3e4adf8b Removed an unused variable. 
svn path=/trunk/; revision=30904
 2009-11-09 15:43:25 +00:00
Stig Bjørlykke
2d9135f98c Removed unused assignments. 
svn path=/trunk/; revision=30903
 2009-11-09 15:43:05 +00:00
Stig Bjørlykke
5fa0e7b607 Removed some unused variables. 
svn path=/trunk/; revision=30902
 2009-11-09 15:17:14 +00:00
Stig Bjørlykke
d7a3a9d99c Removed some unused variables. 
svn path=/trunk/; revision=30901
 2009-11-09 15:16:51 +00:00
Stig Bjørlykke
af45c9dd3e Removed some unused assignments. 
svn path=/trunk/; revision=30900
 2009-11-09 15:16:12 +00:00
Stig Bjørlykke
e089ab2789 Removed an unused assignment. 
svn path=/trunk/; revision=30899
 2009-11-09 15:15:54 +00:00
Stig Bjørlykke
10b4dd438e Removed an unused assignment. 
svn path=/trunk/; revision=30898
 2009-11-09 15:15:29 +00:00
Stig Bjørlykke
c8810bbc2a Put type/length elements in correct subtree. 
svn path=/trunk/; revision=30897
 2009-11-09 15:05:34 +00:00
Stig Bjørlykke
b3a5cf28a5 Removed unused variables. 
svn path=/trunk/; revision=30896
 2009-11-09 14:40:35 +00:00
Stig Bjørlykke
68939c0d8d Removed an unused assignment. 
svn path=/trunk/; revision=30895
 2009-11-09 14:36:35 +00:00
Stig Bjørlykke
f14b274ec2 Removed unused assignments. 
svn path=/trunk/; revision=30894
 2009-11-09 14:35:27 +00:00
Stig Bjørlykke
5b7e0dcd9e Put tree elements in the arcnet subtree. 
Some code cleanup.

svn path=/trunk/; revision=30890
 2009-11-09 14:20:44 +00:00
Stig Bjørlykke
8fe96a84e0 Removed an unused assignment. 
svn path=/trunk/; revision=30889
 2009-11-09 14:18:27 +00:00
Stig Bjørlykke
ea3b87288b Removed an unused assignment. 
svn path=/trunk/; revision=30888
 2009-11-09 14:18:08 +00:00
Stig Bjørlykke
2672f93988 Removed unused code. 
svn path=/trunk/; revision=30887
 2009-11-09 14:17:33 +00:00
Stig Bjørlykke
8288deee24 Put key_index values in correct tree. 
svn path=/trunk/; revision=30886
 2009-11-09 14:15:38 +00:00
Stig Bjørlykke
535e5317c2 Removed an unused variable. 
svn path=/trunk/; revision=30885
 2009-11-09 14:13:22 +00:00
Stig Bjørlykke
826595c5b5 Removed an unused variable. 
svn path=/trunk/; revision=30884
 2009-11-09 14:12:09 +00:00
Stig Bjørlykke
ccc3e2f4d9 Removed an unused assignment. 
svn path=/trunk/; revision=30883
 2009-11-09 14:10:19 +00:00
Stig Bjørlykke
cc229fada3 Removed an unused variable. 
svn path=/trunk/; revision=30882
 2009-11-09 14:09:40 +00:00
Stig Bjørlykke
ccba8cc3df Removed an unused assignment. 
svn path=/trunk/; revision=30881
 2009-11-09 14:09:19 +00:00
Stig Bjørlykke
e9977dda66 Removed an unused variable. 
svn path=/trunk/; revision=30880
 2009-11-09 14:08:54 +00:00
Stig Bjørlykke
a25ea02717 Put flags subtree under correct element. 
svn path=/trunk/; revision=30879
 2009-11-09 14:08:27 +00:00
Stig Bjørlykke
64c5b724e3 Removed an unused assignment. 
svn path=/trunk/; revision=30878
 2009-11-09 14:07:20 +00:00
Stig Bjørlykke
00d20e0384 Made enterprise_oid pointer const. 
svn path=/trunk/; revision=30877
 2009-11-09 13:03:15 +00:00
Stig Bjørlykke
169547006b Remove an unused variable. 
svn path=/trunk/; revision=30876
 2009-11-09 12:38:47 +00:00
Martin Mathieson
6634d939d4 Avoid a warning about signed/unsigned comparison. 
svn path=/trunk/; revision=30875
 2009-11-09 11:10:38 +00:00
Stig Bjørlykke
308f743247 Add the missing changes from r30869. 
svn path=/trunk/; revision=30871
 2009-11-08 22:04:46 +00:00
Stig Bjørlykke
10e98317c8 Fixed printing of BACnetTypeName in the Packet Details tree. 
svn path=/trunk/; revision=30870
 2009-11-08 22:00:16 +00:00
Stig Bjørlykke
46ccbb5bbf From Steve Karg and Herbert Lischka via bug 4190: 
Modified the open/close context tagging to include context tag number.
Modified the info column to show more specific information about certain
packets.

svn path=/trunk/; revision=30869
 2009-11-08 21:49:55 +00:00
Anders Broman
ff5758cdcb Dissect Handover "containers". 
svn path=/trunk/; revision=30866
 2009-11-08 19:59:21 +00:00
Guy Harris
43c946a6b1 Add packet-umts_mac.h to the release tarball. 
svn path=/trunk/; revision=30865
 2009-11-08 19:20:00 +00:00
Guy Harris
7aeb317c1d Squelch more warnings. 
svn path=/trunk/; revision=30860
 2009-11-08 07:28:39 +00:00
Martin Mathieson
04078dd997 Improve expert and info column strings reporting OOB events. 
svn path=/trunk/; revision=30859
 2009-11-08 00:39:22 +00:00
Guy Harris
be5c1a9e27 Squelch compiler warnings. 
svn path=/trunk/; revision=30858
 2009-11-07 19:56:13 +00:00
Jaap Keuter
71a48b6dbf From Alex Volinsky: 
This enhancement implements dissector for Downstream DOCSIS (Data over Cable)
frames, embedded into MPEG packets and encapsulated into L2TPv3 over IP
(DEPI/D-MPT encapsulation). This type of encapsulation is used in Modular Cable
Modem Termination System (M-CMTS) architecture for head-end components that
comply with DOCSIS.

DEPI, the Downstream External PHY Interface, is the interface between the
M-CMTS Core and the EQAM. More specifically, it is an IP Tunnel between the MAC
and PHY in a Modular CMTS system.

L2TPv3 is described in RFC3931.
DOCSIS DEPI data packet transport mechanism is described CM-SP-DEPI-I03-060728
(Downstream External PHY Interface - CableLabs specification) 
The format of MPEG packet carrying DOCSIS data is described in 
CM-SP-DRFI-I07-081209 (Data-Over-Cable Service Interface Specifications -
CableLabs specification).

svn path=/trunk/; revision=30857
 2009-11-07 19:41:58 +00:00
Jaap Keuter
03730e3bc1 From Filipe David Borba Manana: 
Since it was named Ethereal and up to today, Wireshark wrongly parses 
the IPv4 header flags field:
* it considers it as a 4 bits wide field - according to RFC 791 its a 3 bits
wide field (first 3 bits of the 6th octect of the IPv4 header).
* if for example the DF bit is set, Wireshark displays the flag value as 0x04
(0100) when it should be 0x02 (010), idem for the MF flag.
Attached to this bug report, you can find a patch to fix the issue.

svn path=/trunk/; revision=30855
 2009-11-07 11:24:05 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on) 
svn path=/trunk/; revision=30852
 2009-11-07 10:07:00 +00:00
Kovarththanan Rajaratnam
f6dfb9f323 Avoid possible NULL pointer dereference 
svn path=/trunk/; revision=30851
 2009-11-07 08:07:12 +00:00
Gerasimos Dimitriadis
4dbe3a5e3a Fix for bug 4209: 
After reading a SysID group, current_offset was off by 1 


svn path=/trunk/; revision=30847
 2009-11-06 21:20:17 +00:00
Kovarththanan Rajaratnam
f68d2fc933 Remove packet-umts_mac.c from DISSECTOR_INCLUDES 
svn path=/trunk/; revision=30845
 2009-11-06 14:56:28 +00:00
Anders Broman
b35647bb57 From Tobias Witek: 
Enables correct RRC decoding from RLC.

svn path=/trunk/; revision=30843
 2009-11-06 12:09:12 +00:00
Jaap Keuter
a1d82636c1 Add parentheses to satisfy the compiler. 
svn path=/trunk/; revision=30842
 2009-11-06 07:08:40 +00:00
Jörg Mayer
8ef22d4e08 Add a document reference 
svn path=/trunk/; revision=30841
 2009-11-06 06:14:19 +00:00
Jaap Keuter
e2246d08cd From Owen Kirby: 
We've discovered a number of bugs in the 6LoWPAN dissector, 
and have fixed them in the following patch. The fixed bugs include:
  - Incorrect UDP Checksum calculation.
  - Incorrect link-local prefix when decompressing IPHC headers.
  - Incorrect parsing of the UDP port numbers when not 8-byte aligned.
  - Overflow of the datagram offset field when reassembling fragmented packets.

svn path=/trunk/; revision=30840
 2009-11-05 22:39:00 +00:00
Anders Broman
54aa776069 From Tobias Witek: 
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30838
 2009-11-05 21:54:06 +00:00
Anders Broman
110a5be310 Dissect Source-ToTarget-TransparentContainer in the intra LTE case. 
svn path=/trunk/; revision=30837
 2009-11-05 20:34:56 +00:00
Kovarththanan Rajaratnam
d10ca62304 Fix value strings in packet boundary lookup table 
svn path=/trunk/; revision=30830
 2009-11-05 07:36:02 +00:00
Gerald Combs
b11e3a7ea3 From Jason Rusmisel via bug 4199: Increase the maximum number of 
template fields we handle from 20 to 30.

svn path=/trunk/; revision=30827
 2009-11-05 01:01:01 +00:00
Anders Broman
6300621b52 Check if we have a handle for "v110". 
svn path=/trunk/; revision=30823
 2009-11-04 16:40:52 +00:00
Anders Broman
a8986a995b Register by name. 
svn path=/trunk/; revision=30822
 2009-11-04 16:39:52 +00:00
Kovarththanan Rajaratnam
dc265696a1 tvb_format_text() always returns a non NULL pointer so don't check return value for NULL pointer 
svn path=/trunk/; revision=30821
 2009-11-04 16:08:47 +00:00
Anders Broman
83231fe94a From Pascal Quantin: 
[NAS EPS] Expert Info error triggered when decoding a Security Mode Complete message
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4203

svn path=/trunk/; revision=30820
 2009-11-04 13:49:19 +00:00
Kovarththanan Rajaratnam
9b1cbfea87 Fix a couple of value_stringS to match BT 2.1 
svn path=/trunk/; revision=30819
 2009-11-04 12:49:19 +00:00
Kovarththanan Rajaratnam
1fc06caf57 Also apply rev 30817 to command complete events 
svn path=/trunk/; revision=30818
 2009-11-04 12:31:39 +00:00
Kovarththanan Rajaratnam
167a30a6ef Append the opcode (that lead us to the command status) to the info column 
svn path=/trunk/; revision=30817
 2009-11-04 12:25:01 +00:00
Kovarththanan Rajaratnam
b5d8e71e1f Correct "Sniff Subrating" typo 
svn path=/trunk/; revision=30816
 2009-11-04 12:14:30 +00:00
Stig Bjørlykke
c60a5b284e Added offset fix from bug 4202, error introduced in r30770. 
svn path=/trunk/; revision=30815
 2009-11-04 11:41:05 +00:00
Jörg Mayer
ed5453d892 Fix printing of tuple values 
svn path=/trunk/; revision=30814
 2009-11-04 08:49:38 +00:00
Jaap Keuter
caeca294d6 From Robert Hogan: 
Not incrementing tvb offset in two places in tn3270 dissector.

svn path=/trunk/; revision=30813
 2009-11-04 06:58:42 +00:00
Jaap Keuter
8041e9732e From Jason Rusmisel: 
The netflow implementation has a bug where the code exists to extract four
fields from a packet, however, the decoder for these fields has not been
registered in proto_register_netflow in the hf_register_info array. 
The fix is to include decoders for the fields in the proto_register_netflow.

svn path=/trunk/; revision=30809
 2009-11-03 23:01:03 +00:00
Martin Mathieson
da15f9f5ff Show how many NACKs appeared in status message root. 
svn path=/trunk/; revision=30806
 2009-11-03 16:39:01 +00:00
Anders Broman
64416202c6 From Pascal Quantin: 
I just realized that I forgot to change one line to get a proper decoding of IMEI

svn path=/trunk/; revision=30805
 2009-11-03 12:44:17 +00:00
Anders Broman
242db04e6b From Pascal Quantin: 
Small fixes for Attach Request message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4198

svn path=/trunk/; revision=30803
 2009-11-03 12:16:25 +00:00
Anders Broman
62ae894451 From Pascal Quantin : 
[NAS EPS] Incorrect decoding of UE Network Capability IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4196

svn path=/trunk/; revision=30802
 2009-11-02 22:37:34 +00:00
Anders Broman
1a79f3ead4 Fix Layer 3 Message Contents(?) 
At least the trace at http://openbsc.gnumonks.org/trac/attachment/wiki/OpenBSCWithSCCP/bssmap_clean.pcap dissects correctly now.

svn path=/trunk/; revision=30799
 2009-11-01 20:00:08 +00:00
Stig Bjørlykke
bbc109d1b6 Added some type renames. 
svn path=/trunk/; revision=30798
 2009-11-01 19:16:57 +00:00
Anders Broman
3da9d8fc41 From Holger Freyther: 
GSM BSSMAP ChanType permitted indicator extension bit decoded wrongly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4185

svn path=/trunk/; revision=30797
 2009-11-01 19:11:13 +00:00
Stig Bjørlykke
5c62502644 Added a UAT table to describe enterprise specific-trap types. 
svn path=/trunk/; revision=30796
 2009-11-01 18:45:43 +00:00
Anders Broman
72e8e8dbee Update to 3GPP TS 25.331 V8.8.0 (2009-09) 
svn path=/trunk/; revision=30795
 2009-11-01 16:56:49 +00:00
Jaap Keuter
d3d53f1b1a From Markus Koetter: 
Wireshark fails dissecting dce rpc bind acks, if the bind request had more than 1 ctx.

svn path=/trunk/; revision=30790
 2009-11-01 11:52:32 +00:00
Jaap Keuter
d1c54017f3 From Jesper Dangaard Brouer: 
This patch set improves packet loss detection in for MPEG2 Transport Streams
(RFC 2250 / ISO/IEC 13818-1).
1. Improve loss detection by counting skipped TS frames (currently we only
detect a drop). (only store the info globally)
2. Introduce an analysis tree and record/count the info per TS frame.

svn path=/trunk/; revision=30789
 2009-11-01 11:00:00 +00:00
Anders Broman
bfb16c1bcb - Dissect Target-ToSource-TransparentContainer. 
- Update to 3GPP TS 25.413 V8.4.0 (2009-09).

svn path=/trunk/; revision=30788
 2009-11-01 10:52:17 +00:00