Commit Graph

17653 Commits

Author SHA1 Message Date
Ronnie Sahlberg cd7baad861 refactoring of the fcp response dissector
add missing flags to the dissection   and during refactoring fix several things that just can not have worked previously.




svn path=/trunk/; revision=17805
2006-04-04 22:21:48 +00:00
Ronnie Sahlberg 0283e3ab17 major refactoring of the ifcp dissector.
remove the port preference setting and replace it with strong heuristics instead
(attempt but fail to set a conversation dissector when the heuristics and the dissection match)

use tcp_dissect_pdus() for reassembly and pdu tracking and get rid of the try-to-step-through-the-pdu-to-find-where-the-next-pdu-starts thing.




svn path=/trunk/; revision=17804
2006-04-04 11:58:56 +00:00
Michael Tüxen 501a66109d From Irene: Make buttons unselecable when nothing would happen.
svn path=/trunk/; revision=17803
2006-04-04 09:04:08 +00:00
Ronnie Sahlberg 94f416ca62 fix for bug #856
dont try to lookup a NULL string since this string will be dereferenced
in the ghashtable   hash callback



svn path=/trunk/; revision=17802
2006-04-04 07:53:39 +00:00
Ronnie Sahlberg ab9b2e6836 dislay a flags field as "Flags" instead of "SCCS Flags"
svn path=/trunk/; revision=17801
2006-04-03 20:39:55 +00:00
Ronnie Sahlberg 54d8591809 use col_set_fence() after we have populated the info column with the SCSI details so that if there are other pdus followinf this scsi pdu in the packet they will not overwrite it
svn path=/trunk/; revision=17800
2006-04-03 20:29:53 +00:00
Ronnie Sahlberg 5ee1c8d1e4 add dissection of the inq sync flag
sort the entries in scsi_verdesc_val   so it is easier to add missing entries


svn path=/trunk/; revision=17799
2006-04-03 20:12:24 +00:00
Anders Broman e47e1c864d Fix bug http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=850 problems with tagged assignments.
Add som OID names. 

svn path=/trunk/; revision=17798
2006-04-03 19:07:52 +00:00
Gerald Combs 34335a2bc1 Add a null pointer check. Fixes the current Buildbot menagerie failure.
svn path=/trunk/; revision=17797
2006-04-03 14:44:56 +00:00
Ronnie Sahlberg 10a0fd2105 a krb_error pdu with the error_code ERR_CLIENT_REVOKED
issued by ms kdc contains a PA_DATA structure with a salt that contains an
nt_status code explaining why the client was not allowed to get a (tgt) ticket



svn path=/trunk/; revision=17796
2006-04-03 08:55:04 +00:00
Ronnie Sahlberg f886744b64 further prettification of the inq dissector.
further refactorinf of  the scsi  alloc_len macros



svn path=/trunk/; revision=17795
2006-04-03 08:20:54 +00:00
Ronnie Sahlberg 700a7f527a dissect byte 7 of the inq response
svn path=/trunk/; revision=17794
2006-04-03 03:19:52 +00:00
Guy Harris bd847a5617 Don't report the interface name unconditionally.
svn path=/trunk/; revision=17793
2006-04-03 03:15:29 +00:00
Guy Harris ef0c0e16a5 Set the right structure member.
svn path=/trunk/; revision=17792
2006-04-03 03:12:32 +00:00
Ronnie Sahlberg 0f1f0c8d8a add dissection of byte 6 of inq response
(except fopr 3 bits that only exist for pscsi)


svn path=/trunk/; revision=17791
2006-04-03 02:40:07 +00:00
Guy Harris 813af87c83 Clean up if CreateProcess() fails.
svn path=/trunk/; revision=17790
2006-04-03 01:58:43 +00:00
Guy Harris d260003026 Put the low-level sync routines into a common file so they can be shared
by dumpcap and Ethereal (so that, on UN*X, the child process can report
a detailed "can't exec dumpcap" error).

Rename most of the "sync_pipe_XXX_to_parent()" routines, as they're also
in Tethereal, which doesn't have a sync pipe.

svn path=/trunk/; revision=17789
2006-04-03 01:56:53 +00:00
Ronnie Sahlberg d5585760e7 add dissection of the flags in byte 5 of the inquiry response
svn path=/trunk/; revision=17788
2006-04-03 01:44:56 +00:00
Ronnie Sahlberg ae66a76a1a prettify dissection of the aca flags byte in the inq response data.
add dissection of two additional bits and the respdataformat bitvield

add booleans for the filter fields

make all the fields filterable



svn path=/trunk/; revision=17787
2006-04-03 00:55:21 +00:00
Guy Harris 2de9620eea In Tethereal, don't save to a temporary file if "-w" isn't specified,
even if doing a live capture; just print the packets without saving
them.

In dumpcap:

	default to the capturing the entire packet;

	don't do the "Press any key" stuff when debugging on UN*X;

	do console logging (to the standard error) even when we're
	running as the capture child (the sync pipe should only be the
	standard output, not the standard error).

svn path=/trunk/; revision=17786
2006-04-03 00:52:59 +00:00
Ronnie Sahlberg 2376539aab the hash,name,fullname of an nfs filehandle are all
generated items

mark them as generated items in the dissect pane


svn path=/trunk/; revision=17785
2006-04-02 23:24:00 +00:00
Ronnie Sahlberg 695b605cbb change TRY_SCSI_SHORT_TRANSFER to use the allocation length specified in the CDB
instead of the allocation length from the data pdu   since sometimes the datapdu will be completely empty and thus we cant extract it from the data pdu.
(unclear if this is really allowed by scsi   but anyway)
this should make the scsi transfer length checking more correct.


update mmc  getconfiguration   and spc  inquiry  to use these macros
and flag these packets that are short due to a too small alloc_len
as truncated due to scsi  and not being short/malformed packets.


at the same time,  get rid of a few horrible   offset+x   in the inquiry dissector and replace with proper offset incrementation instead.





svn path=/trunk/; revision=17784
2006-04-02 22:50:46 +00:00
Ronnie Sahlberg d9227587f0 prettify dissection of nfsv3 fattr3 structure
put useful info like type,mode,uid,gid on the expansion lines so we dont have to open the expansion to see these values.

allow it to push this info multiple expansion lines upward
and optionally (such as for GETATTR replies) put this info in the info column as well




svn path=/trunk/; revision=17783
2006-04-02 21:04:11 +00:00
Anders Broman 30ade25ed3 From Martin Mathieson:
Removes the use of the deprecated proto_tree_add_item_hidden() function

I was adding the 'msmms.command.unknown' field in lots of places (a 
habit of mine in my own dissectors), but this probably isn't useful.

svn path=/trunk/; revision=17782
2006-04-02 19:38:36 +00:00
Anders Broman 510b805e69 From Greg Morris:
Fixes bug 830
Adds a few more expert info details.
 

svn path=/trunk/; revision=17781
2006-04-02 19:37:12 +00:00
Anders Broman 89de25406b From Ming Zhang:
fix a minor error in mode_select, packet-scsi.c

svn path=/trunk/; revision=17780
2006-03-31 05:11:57 +00:00
Anders Broman 17d995edfa From Francesco Fondelli:
you find attached a patch for dissecting MPLS OAM pdus
as defind in Y.1711 ITU-T doc.

svn path=/trunk/; revision=17779
2006-03-31 05:09:37 +00:00
Michael Tüxen 3df55b78f6 From Irene: Fix problems with off screen drawings
Make rectangle clickable.

svn path=/trunk/; revision=17778
2006-03-30 22:17:42 +00:00
Luis Ontanon b3f862b7e5 fix for Bug 849
svn path=/trunk/; revision=17777
2006-03-30 20:29:36 +00:00
Luis Ontanon 3f22cb3cf7 remove some useless code.
svn path=/trunk/; revision=17776
2006-03-30 20:15:59 +00:00
Luis Ontanon 78c12304e1 Delete init.lua when asked to delete global settings.
svn path=/trunk/; revision=17775
2006-03-30 19:56:33 +00:00
Luis Ontanon ad4fe1ff8f Fix FieldInfo and add an attribute for the filter name.
svn path=/trunk/; revision=17774
2006-03-30 19:48:05 +00:00
Luis Ontanon 2e93b8b751 TextWindow:
- add buttons
  - make editable




svn path=/trunk/; revision=17773
2006-03-30 19:42:49 +00:00
Anders Broman 84fb70ef42 call OID subdissector for private extensiions, fix makefiles.
svn path=/trunk/; revision=17772
2006-03-30 16:46:36 +00:00
Gerald Combs f87b0f78ae Fix an off-by-one error.
svn path=/trunk/; revision=17771
2006-03-30 16:13:37 +00:00
Gerald Combs 4ea62e57b0 Continue to play whack-a-mole with null dereferences. Fixes CID 146.
svn path=/trunk/; revision=17770
2006-03-30 15:34:18 +00:00
Jaap Keuter d53b9d7205 Update status codes from RFC 2616 and RFC 2518
svn path=/trunk/; revision=17769
2006-03-30 10:16:35 +00:00
Jaap Keuter 95b974d6ba Undoing commit of private makefile in r17765
svn path=/trunk/; revision=17768
2006-03-30 09:33:39 +00:00
Jörg Mayer 9ba859bacf Update from samba tree revision 13374 to 14805
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============


svn path=/trunk/; revision=17767
2006-03-30 07:44:03 +00:00
Anders Broman e4f01d2051 From Martin Mathieson:
> > This patch adds a hidden 'sip.auth' field, that will be present 
> > whenever one of the authenticiation/authorization headers is 
> > present.
> >
> > I believe this is one place where hidden fields are justified:
> > - it is a substring of several sip.auth.* fields, so its reassuring 
> > to see the field turn green as you're typing in one of the visible 
> > fields
> > - it lets you quickly find all of the frames with any of these fields
> > (there are 4 different SIP headers that can contain the auth fields)

svn path=/trunk/; revision=17766
2006-03-30 05:02:06 +00:00
Anders Broman 901f07af60 From Martin Mathieson:
wiretap/README.developer
- the referenced default seek_read function doesn't exist now

wiretap/wtap.c
- a "hole" in encap_table was causing the wrong encap value for later 
types to be looked up (by name)

mergecap.c
- fix a couple of program name copy+paste errors from editcap.c

svn path=/trunk/; revision=17765
2006-03-30 04:58:06 +00:00
Guy Harris 015b486dc9 Get rid of an unused variable.
svn path=/trunk/; revision=17764
2006-03-29 22:11:42 +00:00
Guy Harris 01606f6114 Get rid of some unused variables.
svn path=/trunk/; revision=17763
2006-03-29 22:05:57 +00:00
Guy Harris 3ea3ee1fa2 Get rid of an unused function argument.
Clean up indentation.

svn path=/trunk/; revision=17762
2006-03-29 22:04:37 +00:00
Guy Harris 31e5e71b90 Close a comment to squelch a compiler warning.
svn path=/trunk/; revision=17761
2006-03-29 22:03:21 +00:00
Guy Harris 25ff28766f Squelch a compiler warning (for a problem that can't happen).
Fix up indentaton.

svn path=/trunk/; revision=17760
2006-03-29 21:57:58 +00:00
Guy Harris 16614b4ed1 Squelch a compiler warning.
svn path=/trunk/; revision=17759
2006-03-29 21:54:22 +00:00
Guy Harris 3b34a4f260 Squelch a compiler warning (for a problem that doesn't actually occur).
svn path=/trunk/; revision=17758
2006-03-29 21:53:26 +00:00
Anders Broman 9c5ac889e7 sccp - fix a typo
gre - fix a length error, and change the way to display 3GPP atributes.

svn path=/trunk/; revision=17757
2006-03-29 17:00:16 +00:00
Jaap Keuter 9daa63d451 The header will be there, just make sure the date is put in.
Coverity bug 148

svn path=/trunk/; revision=17756
2006-03-29 16:06:57 +00:00