Commit Graph

17653 Commits

Author SHA1 Message Date
Guy Harris 25e8c37489 Have the ring buffer routines take a pointer to a "bytes written" count
as an argument, rather than keeping the count to themselves, so the
count kept by the capturing program can be updated correctly - including
getting reset when files are switched.  Fixes bug 895.

svn path=/trunk/; revision=18032
2006-04-29 17:54:46 +00:00
Guy Harris f3d1963924 Clean up indentation; use 2-space indentation throughout.
Save the media encoding name in the transport_info_t structure rather
than in a global variable.  Allocate it with tvb_get_ephemeral_string()
so it's released after the packet is completely processed.  Do *NOT*
assume it's necessarily non-null in decode_sdp_fmtp(), as the code flow
doesn't guarantee that to be true.

proto_tree_add_string() now suffices for adding a particular SDP item -
strings are now displayed "safely", with escaping of non-printable
characters done.

Update a comment (we no longer have the Big Transfer Vector to allow
plugins to call dissector functions in Windows, we have those functions
in a DLL).

svn path=/trunk/; revision=18031
2006-04-29 17:31:20 +00:00
Jörg Mayer 8661cd1846 chrisaudley@yahoo.com:
Patch to fix:
[Bug 904] FIX protocol dissector missing some message types


svn path=/trunk/; revision=18030
2006-04-29 15:25:44 +00:00
Guy Harris e5d0659195 A dissector called from tcp_dissect_pdus() has to return void. (If you
want to have a dissector capable of rejecting packets, you need to
reject the packet before you call tcp_dissect_pdus() - once you're doing
reassembly, etc., it's too late to reject the packet.)

svn path=/trunk/; revision=18029
2006-04-29 09:30:09 +00:00
Anders Broman 13d178a3fc Check Payload type before dissecting fmtp parameters.
svn path=/trunk/; revision=18028
2006-04-28 21:42:18 +00:00
Anders Broman 039e39d8b4 Fix bug 896 by using tcp_dissect_pdus() .
svn path=/trunk/; revision=18027
2006-04-28 21:41:13 +00:00
Gerald Combs 9b59165a4d Fetch a combobox control handle before we try to use it. Add some needed
_T macros.  Remove some extraneous comments.

svn path=/trunk/; revision=18026
2006-04-28 18:43:33 +00:00
Gerald Combs e58dbf5e91 Fix logic used to test protection under Windows OT. Only initialize
our page size and OS version information once.

svn path=/trunk/; revision=18025
2006-04-28 16:40:39 +00:00
Ronnie Sahlberg 703869d3d6 tcp analysis updates to prepare for later tcp reassembly updates
now that we have se_tree_lookup32_le   we can do the tracking of pdu boundaries much more efficiently.

track pdu boundaries by a new  tcp_multisegment_pdu  structure that is indexed by sequence numbers and let this structure replace the older tcp_next_pdu structure.

with se_tree_lookup32_le  we no longer need to track segment by segment and can get rid of the two hash tables
tcp_pdu_tracking_table
tcp_pdu_skipping_table
Neither do we need the tree   tcp_pdu_time_table anymore so that one is gone as well.

remove various other functions that are no longer needed due to removing the structure and the tables/tree


this part of the code shoul;d be much more readable now   and also a bit faster



svn path=/trunk/; revision=18024
2006-04-28 09:44:02 +00:00
Tomas Kukosa fe88a09c26 - fix Bug 890
- remove c2asn() which did not work exactly

svn path=/trunk/; revision=18023
2006-04-28 06:47:51 +00:00
Guy Harris d44c620df0 Don't change rflags for any properties other than
IEEE80211_RADIOTAP_FLAGS.

svn path=/trunk/; revision=18022
2006-04-28 06:29:19 +00:00
Ulf Lamping 4674161ed0 add some higher packet length values
svn path=/trunk/; revision=18021
2006-04-27 22:13:29 +00:00
Guy Harris 4a84a894d9 This was completely broken, as the "length" variable actually reflected
the amount of data left in the radiotap header after the fields we've
processed so far, not the total length of the header, so it couldn't be
used to skip past the radiotap header and get a tvbuff of the packet
data.  Fix that.

svn path=/trunk/; revision=18020
2006-04-27 19:58:32 +00:00
Guy Harris 89ff9ef701 From Diego Petteno and Daniel Black: add more libraries to the list of
libraries with which we link libethereal, fixing the reopened bug 878.

svn path=/trunk/; revision=18019
2006-04-27 19:12:50 +00:00
Gerald Combs 784334b322 Add an extra null pointer check. Fixes Coverity CID 154.
svn path=/trunk/; revision=18018
2006-04-27 18:46:05 +00:00
Gerald Combs 36b80f1043 Properly grow our buffers for utf_8to16().
svn path=/trunk/; revision=18017
2006-04-27 14:58:46 +00:00
Anders Broman a345eab556 From Martin Mathieson:
Fix typo in menu item name

svn path=/trunk/; revision=18016
2006-04-27 05:02:57 +00:00
Jaap Keuter b1c230fb59 From Mark C. Brown:
The code was incorrectly bounds checking AndXOffset.  AndXOffset is only
relevant when AndXCommand is not 0xFF.  This patch corrects erroneous
"Malformed packet" exceptions.

svn path=/trunk/; revision=18015
2006-04-26 22:53:00 +00:00
Gerald Combs 056b3d977a Properly set our export file name before we try to use it. Fixes bug 894.
svn path=/trunk/; revision=18012
2006-04-26 21:15:51 +00:00
Gerald Combs 301a5f1e32 If we're running under Windows 95/98/Me, don't abort if we can't protect
our guard pages.

svn path=/trunk/; revision=18011
2006-04-26 21:06:52 +00:00
Anders Broman fd42a33307 Add dissection of MPEG4 fmtp parameter.
svn path=/trunk/; revision=18010
2006-04-26 20:16:57 +00:00
Ulf Lamping 4b4eba7993 minor enhancements
svn path=/trunk/; revision=18009
2006-04-26 20:13:33 +00:00
Gilbert Ramirez 1c57b51e9e Check for NULL return value from wtap_dump_open().
Fixes coverity bug 159.

svn path=/trunk/; revision=18005
2006-04-26 17:31:56 +00:00
Jörg Mayer dbbd8cd9a1 authesserre samuel <sauthess@gmail.com>:
The current ssl decryption code does not work for 3des session.
The attached patch fixes the problem.


svn path=/trunk/; revision=18004
2006-04-26 15:10:23 +00:00
Ronnie Sahlberg 1df4fecef5 add tracking of ndmp conversations and use this to track the version used if we have seen the CONNECT_OPEN request.
rename the preference to DEFAULT protocol version   to indicate it is only used for those conversation where we have not automatically detected the version used.




svn path=/trunk/; revision=18003
2006-04-26 09:40:49 +00:00
Ronnie Sahlberg 59f9aa6a8c NOTIFY_[DATA|MOVER]_HALTED requests no longer take an XDR string containing the reason for version 4 of ndmp and forward.
svn path=/trunk/; revision=18002
2006-04-26 07:58:45 +00:00
Jaap Keuter 7f5fc8b8d9 Workaround for bug 852. Force a line break so that the text view doesn't blow up on excessive long lines.
svn path=/trunk/; revision=18001
2006-04-26 06:37:46 +00:00
Anders Broman f9468fe33f Add some more ANSI Message types and Parameters dissect ANSI cause.
svn path=/trunk/; revision=18000
2006-04-25 19:12:08 +00:00
Guy Harris a6930fe4ae Add distclean and maintainerclean rules.
svn path=/trunk/; revision=17999
2006-04-25 18:45:08 +00:00
Guy Harris 09eeb3902c Add distclean and maintainerclean rules.
svn path=/trunk/; revision=17998
2006-04-25 18:35:15 +00:00
Guy Harris 2c091d5bba Add the usual Makefile.nmake comment.
Change "cd.." to "cd .." - I don't know whether they're equivalent, but,
if they're not, the former probably won't work.

svn path=/trunk/; revision=17997
2006-04-25 18:34:09 +00:00
Guy Harris 134c7734b3 Check several sets of additional libraries that libpcap might need
(-lcfg -lodm on AIX with the current tcpdump.org libpcap, -lpfring with
the ring buffer stuff on Linux).

svn path=/trunk/; revision=17996
2006-04-25 18:01:43 +00:00
Jörg Mayer 21ec14f314 Add a URL
svn path=/trunk/; revision=17995
2006-04-25 13:41:05 +00:00
Jörg Mayer 6b70d6d9f8 Update from samba tree revision 14805 to 15243
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============


svn path=/trunk/; revision=17994
2006-04-25 13:40:04 +00:00
Guy Harris e198ded297 Include non-dissector support files in the source.
svn path=/trunk/; revision=17992
2006-04-25 08:22:55 +00:00
Ronnie Sahlberg 2f08653337 rename some value_Strings from ..._val to ..._vals
svn path=/trunk/; revision=17991
2006-04-25 01:42:35 +00:00
Ulf Lamping 8ff5e909bb WinPcap 3.2 beta 1 (3, 2, 0, 29) seems to be working with the packet.dll, so don't warn the user about it
svn path=/trunk/; revision=17990
2006-04-25 01:22:05 +00:00
Ulf Lamping 333633806c fix win32 build:
scsi_mmc_val					DATA
scsi_sbc2_val					DATA
scsi_ssc2_val					DATA

BTW: these values should be renamed to ..._vals as in every other dissector I know!

svn path=/trunk/; revision=17989
2006-04-25 01:00:16 +00:00
Ulf Lamping 3333c5e35d various changes:
mention informational URLs at the beginning and not at each element
replace some // by /**/
start to decode the informational elements in the BSSID list
add a privacy tab to the BSSID list (None, WEP, WPA, WPA2)
various minor label changes

svn path=/trunk/; revision=17988
2006-04-25 00:25:41 +00:00
Ulf Lamping b02c428877 bugifx (should be copied to the 1.0 trunk): don't crash, if the interface hardware in question was removed since the list of interfaces was generated (NULL pointer returned from wpcap_packet_open() caused a crash)
svn path=/trunk/; revision=17987
2006-04-25 00:18:06 +00:00
Ulf Lamping c2d7e088f3 copy input data into the buffer given to PacketRequest(), so functions with input parameters will also work
svn path=/trunk/; revision=17986
2006-04-25 00:12:43 +00:00
Ronnie Sahlberg 480e7e2db1 remove a debugging printf
svn path=/trunk/; revision=17985
2006-04-24 23:24:27 +00:00
Ronnie Sahlberg c8cc76e2e2 SCSI Service Response Time Staistics
svn path=/trunk/; revision=17984
2006-04-24 23:09:34 +00:00
Jaap Keuter 5f7493586b Column list pointer became invalid when element was removed from list. Fixes bug 886.
svn path=/trunk/; revision=17983
2006-04-24 21:27:12 +00:00
Anders Broman 75b44d4de7 Preparations to include ANSI ISUP dissection.
svn path=/trunk/; revision=17981
2006-04-24 19:11:33 +00:00
Anders Broman 6b33d50f90 From Miha Jemec:
With the new feature we can: 
1. Measure how big the bursts are for a video streams (it uses sliding window algorithm) 2. Measure how big the output buffer should be that no packet drop will occur (it uses Leaky bucket algorithm) 
3. Detect if we have loses inside the MPEG2 video stream (if there are already MPEG2 packets missing) - this part of code is not added yet, see Limitations

The addition is called Multicast streams and works as follows:

- it uses the TAP system
- the main "stream" logic is taken from rtp_strems.* files
- the TAP system checks for UDP packets where the destination MAC address starts with "01:00:5E" (ethernet multicast address)
- it creates an entry for every new multicast stream
- based on sliding window and leaky bucket algorithm it calculates for every stream average BW, max BW, burst size, max buffer needed, some alarms if the limits are exceeded,...
- the same calculation is done for all streams together
- inside the window dialog you can specify the burst interval, the alarm limits and output speeds

To do & limitations:

- Currently the analysis can be done only for multicast streams, it means that VoD (Video on demand) or PayTV streams, which are normally unicast can not be analysed. 

- since the MPEG2 is patended I don't know if decoding of MPEG2 packets is allowed? Can we look inside this packets and calculate packets drops based on some counter information inside the payload? Can someone please answer this question? If we can do this, I will post this part of code too.

-  some more flexibility will be added

svn path=/trunk/; revision=17980
2006-04-24 19:10:36 +00:00
Anders Broman de3b8195c5 From Martin Mathieson:
This patch should hopefully remove any possible buffer overflows in 
parse_line() as reported by the current Coverity scan.  I'm not sure 
that the error it currently reports is valid (I think its confused by 
supposing that a condition that is being tested can be true, whereas it 
can't...), but this patch fixes a number of potential problems remaining 
in the function.

svn path=/trunk/; revision=17979
2006-04-24 19:08:52 +00:00
Jörg Mayer f1b4e85ee4 Make some /******...*/ lines less wide: They make svn-diffs on the web page
unreadable unless you have a 2000xsomething display.


svn path=/trunk/; revision=17978
2006-04-24 16:43:22 +00:00
Ronnie Sahlberg acbaf3fe1f change the signature for dissect_scsi_snsinfo() to take itlq and itl structures
update the comment in packet-scsi.c   to reflect that it is the transport now that is responsible to track itl and itlq data

make scsi tapable

svn path=/trunk/; revision=17974
2006-04-24 08:16:18 +00:00
Guy Harris 47bb33f1cb Use 2-space indentation.
Clean up the checks for STP vs. RSTP vs. MSTP.

Show the version 3 length field as a separate field, rather than as the
top-level item for the MSTP stuff.

"Trust" the version 3 length field, so that if it doesn't agree with the
packet length, we report a malformed frame (as we should).

svn path=/trunk/; revision=17973
2006-04-24 05:04:30 +00:00