Guy Harris
22ae89d766
colors_init() doesn't have anything to do with packet coloring, it's
...
just our initialization routine for low-level GTK+ stuff, such as
getting the system colormap and the "black" and "white" colors; we have
to call it before calling get_color().
svn path=/trunk/; revision=25090
2008-04-17 02:55:29 +00:00
Guy Harris
1b4b6462e8
Put a space between the number of bytes (for a file < 1024 bytes) and
...
"Bytes".
"Interface description" vs. "interface name" isn't Windows vs. UN*X,
it's "has a description" vs. "doesn't have a description" - the lack of
descriptions in UN*X is a result of
1) lack of a mechanism to supply descriptions in some UN*Xes
and
2) lack of code in libpcap to get those descriptions in some
other UN*Xes
and I need to work on fixing 2) (I think it can be dredged out of
FreeBSD 6 and 7, I seem to remember current OpenBSD supplying them, and
for OS X we might as well cheat the way the network preference pane does
and just call en0 the main Ethernet and en1 the AirPort interface).
Use an adverb rather than an adjective to modify a noun, as per Chris
Maynard's suggestion.
svn path=/trunk/; revision=25089
2008-04-17 02:38:21 +00:00
Guy Harris
04daff59de
Oh, what the heck, go for it - do the size calculations in 64 bits, just
...
in case a file has more than 2^32 megabytes of data :-); we already
require 64-bit support for calculations and formatting.
svn path=/trunk/; revision=25088
2008-04-17 02:29:43 +00:00
Ulf Lamping
fe630dbde0
... bring into alphabetical order
...
svn path=/trunk/; revision=25087
2008-04-17 02:17:55 +00:00
Ulf Lamping
85e14ceb86
rename REGISTER_xxx_GROUP_NONE to REGISTER_xxx_GROUP_UNSORTED, as NONE seems a bit misleading
...
svn path=/trunk/; revision=25086
2008-04-17 02:16:39 +00:00
Stephen Fisher
3ad27f2ff8
Mark a paramter as unused
...
svn path=/trunk/; revision=25085
2008-04-17 02:08:23 +00:00
Ulf Lamping
f7a6d27307
fix comments
...
svn path=/trunk/; revision=25084
2008-04-17 01:45:37 +00:00
Ulf Lamping
061df434cb
try to fix the buildbot
...
svn path=/trunk/; revision=25083
2008-04-17 01:13:06 +00:00
Ulf Lamping
8a6bd7e262
enable welcome page
...
add file size of recent files
tweak colors
code cleanup
svn path=/trunk/; revision=25082
2008-04-17 00:31:38 +00:00
Anders Broman
19b0132216
Handle:
...
SAEB-IE-ContainerList
SAEB-IE-ContainerPairList
and
ProtocolError-IE-ContainerList
svn path=/trunk/; revision=25081
2008-04-16 20:47:34 +00:00
Jeff Morriss
10a67c2028
sccp_ssn_table is not used so remove it. The handoff function does not need to be called after preference changes so stop doing that. Found this on the hunt for bug 2053's cause but it shouldn't (AFAICS) be related.
...
svn path=/trunk/; revision=25080
2008-04-16 14:28:22 +00:00
Jeff Morriss
1c4a7f8f30
Remove (no longer needed) forward declaration of handoff function
...
svn path=/trunk/; revision=25079
2008-04-16 14:15:04 +00:00
Stig Bjørlykke
f79f9c8504
Added missing comment closing.
...
svn path=/trunk/; revision=25078
2008-04-16 11:55:23 +00:00
Ulf Lamping
63acc87cf2
ups, missed one
...
svn path=/trunk/; revision=25077
2008-04-16 10:00:19 +00:00
Ulf Lamping
ed7018b6e4
flip the import and export button "sequence", that the import button comes first. So we have the same sequence as the usual open/save menu.
...
svn path=/trunk/; revision=25076
2008-04-16 09:57:21 +00:00
Ulf Lamping
be75f6fa16
remove the copied xpm stock icon files from SVN and use the "GTK built in" stock icons
...
this will also prevent us from showing different stock icons for "our" xpm stock icons and the "system defaults". GTK (for Windows?) changed the icon theme somewhere around V2.10 (or later?) and/or the user might use a different icon theme, so this isn't an esoteric case ;-)
svn path=/trunk/; revision=25075
2008-04-16 09:54:55 +00:00
Richard van der Hoff
bcfb45de67
fields passed into proto_tree_add_bits_* should have bits==0
...
svn path=/trunk/; revision=25074
2008-04-16 09:49:39 +00:00
Ulf Lamping
f3a40604dc
use a GTK_STOCK_CLEAR here
...
svn path=/trunk/; revision=25073
2008-04-16 08:54:50 +00:00
Ulf Lamping
45d5280ff1
add "Save As" and "Save All" buttons to the dialog / stock_icons utils
...
use them in the export object dialog
svn path=/trunk/; revision=25072
2008-04-16 08:47:12 +00:00
Ulf Lamping
a18fefb91f
a better spacing between the help and copy buttons
...
svn path=/trunk/; revision=25071
2008-04-16 08:06:55 +00:00
Guy Harris
b346a99d0b
tvb_get_ephemeral_string() is defined never to return null (currently,
...
it aborts - even if we don't make it abort, we should make it throw an
assertion, so we abort the dissection of the packet and let the user
know that we ran out of memory).
svn path=/trunk/; revision=25069
2008-04-16 07:23:56 +00:00
Guy Harris
266b212aad
The right length to use when scanning all the data in a packet is the
...
*reported* length, so that if the packet was cut short by a snapshot
length, we get an exception because we run past the end, and the packet
is marked as having been cut short.
Do not use DISSECTOR_ASSERT() to check for the validity of packet data;
dissectors should try to handle even malformed packets, they shouldn't
report malformed packets as dissector bugs (if DISSECTOR_ASSERT(), that
is *ipso facto* evidence of a dissector bug, *even if the packet is
malformed*).
Update the offset when scanning the packet even if we *aren't* building
the protocol tree.
svn path=/trunk/; revision=25068
2008-04-16 07:18:08 +00:00
Stig Bjørlykke
00f1fcf13c
From Chris:
...
The attached simple patch adds 2 missing help files to HELP and
alphabetizes all of them.
svn path=/trunk/; revision=25067
2008-04-16 06:28:26 +00:00
Ulf Lamping
561c514688
add packet-h263.h
...
svn path=/trunk/; revision=25066
2008-04-16 00:48:57 +00:00
Ulf Lamping
0f34f9fd6a
don't use a Close button for the preparation dialog, use a Cancel one instead
...
svn path=/trunk/; revision=25065
2008-04-16 00:46:16 +00:00
Ulf Lamping
80abf46094
fix button sequence, show filter... button left to Cancel button
...
svn path=/trunk/; revision=25064
2008-04-16 00:45:23 +00:00
Ulf Lamping
ac1dbb7c85
add #include <sys/types.h>
...
svn path=/trunk/; revision=25063
2008-04-16 00:17:51 +00:00
Ulf Lamping
4be30a0240
special handling for the dialog boxes Copy buttons, as the behaviour is more like an auxiliary button (like Help), than one of the "action" buttons as "Ok" (as e.g. Ok will close the dialog).
...
To make this more clear put the Copy button to the left of the button row ...
svn path=/trunk/; revision=25062
2008-04-16 00:14:01 +00:00
Ulf Lamping
2e125b32e2
use the standard dialog button mechanism for the firewall dialog
...
svn path=/trunk/; revision=25061
2008-04-16 00:10:47 +00:00
Ulf Lamping
8642844fef
add the firewall ACL dialog to the help topics (would be a good idea to better describe that dialog anyway...)
...
svn path=/trunk/; revision=25060
2008-04-16 00:09:15 +00:00
Ulf Lamping
769bd28a5d
use the "Clear" icon for the "Continue without saving" action, as the icon metapher seem to fit well here
...
svn path=/trunk/; revision=25059
2008-04-15 23:33:39 +00:00
Sake Blok
1984f23e28
Fix for the "Malformed packet: RPC" that is encountered in bug 1392:
...
Don't call a RPC subdissector if there is no more data in the packet.
svn path=/trunk/; revision=25058
2008-04-15 22:53:34 +00:00
Ulf Lamping
5a8e585962
further work on the yet to come welcome page ...
...
svn path=/trunk/; revision=25057
2008-04-15 22:46:35 +00:00
Gerald Combs
b65d445bf2
Fix a typo found by Don Arrowsmith.
...
svn path=/trunk/; revision=25056
2008-04-15 21:45:46 +00:00
Sake Blok
3751e74f67
From Didier (bug 1392):
...
Add port to conversation key so that RPC reassembly works when relative
sequence numbers are used.
svn path=/trunk/; revision=25055
2008-04-15 21:12:38 +00:00
Ulf Lamping
15b3bb93df
don't mark a used parameter as unused
...
svn path=/trunk/; revision=25054
2008-04-15 20:53:41 +00:00
Anders Broman
ce1abe9f3b
Fix some typos etc.
...
svn path=/trunk/; revision=25053
2008-04-15 20:40:06 +00:00
Anders Broman
a7144cf536
From Jonas Nilsson:
...
Add dissection of Measurement report and result and minor bugfixes.
svn path=/trunk/; revision=25052
2008-04-15 20:37:53 +00:00
Ulf Lamping
d1c7021840
try to fix adns build on MSVC2003 and alike
...
svn path=/trunk/; revision=25051
2008-04-15 20:26:51 +00:00
Richard van der Hoff
4a8ee5ed25
bitmasks are unnecessary with proto_tree_add_bits_*, and indeed break filtering.
...
svn path=/trunk/; revision=25050
2008-04-15 17:28:11 +00:00
Richard van der Hoff
30bd275138
i'm an idiot. we don't need to dissect data unless tree is non-NULL.
...
We *do* need to pass it through to h263data, however.
svn path=/trunk/; revision=25049
2008-04-15 17:26:29 +00:00
Richard van der Hoff
b1d400bb2d
rename protocol to h263
...
svn path=/trunk/; revision=25048
2008-04-15 16:03:38 +00:00
Richard van der Hoff
6f9dbbdae8
rename header fields so that they can be distinguished from the h.263 ones
...
svn path=/trunk/; revision=25047
2008-04-15 15:15:35 +00:00
Richard van der Hoff
5dcbfbf800
split the various bits of h263 dissector into separate files, so that we
...
can see which fields belong to which bit.
Also make sure that we can filter on the fields in the rfc2190 dissector
by actually parsing them even when tree=NULL.
svn path=/trunk/; revision=25046
2008-04-15 14:52:15 +00:00
Jeff Morriss
74a602085e
Ban strdup() and strndup().
...
svn path=/trunk/; revision=25045
2008-04-15 12:56:23 +00:00
Luis Ontanon
0fca04e6a0
attempt to fix init.lua construction in Windows.
...
more diagnostics to make-init-lua.pl
svn path=/trunk/; revision=25044
2008-04-15 12:22:25 +00:00
Luis Ontanon
1cbce0623f
It is useless in a Protocol Analyzer to avoid the user to have a password shorter than 8 chars.
...
svn path=/trunk/; revision=25043
2008-04-15 12:12:20 +00:00
Luis Ontanon
602de4d33c
Die stating why when a file could no be opened.
...
svn path=/trunk/; revision=25042
2008-04-15 10:22:39 +00:00
Stig Bjørlykke
0ce8d6c354
Added an option (-b) to specify directory containing binaries to use for
...
fuzz testing (tshark, editcap and capinfos).
svn path=/trunk/; revision=25041
2008-04-15 09:12:26 +00:00
Stig Bjørlykke
87a476645b
Call DISSECTOR_ASSERT instead of g_assert in dissector code.
...
svn path=/trunk/; revision=25040
2008-04-15 06:58:37 +00:00