Commit graph

33730 commits

Author SHA1 Message Date
Bill Meier
2276b10ddf Add a comment about not needing to g_free() the value returned from g_locale_to_utf8().
svn path=/trunk/; revision=35240
2010-12-21 21:01:01 +00:00
Chris Maynard
da1ae8731c Removed duplicate rawshark.html entry from DOC.
svn path=/trunk/; revision=35239
2010-12-21 19:45:16 +00:00
Stephen Fisher
0b8494fc2c Fix indentation: change from a mixture of 2 and 4 spaces to tabs (which
is what packet-smb.c uses) and add extra line breaks.  Both changes are
for improved readbility of the frequent complex and cryptic loops.


svn path=/trunk/; revision=35238
2010-12-21 17:51:35 +00:00
Martin Mathieson
1386eb8fa3 Be more consistent about how offset is updated while dissecting lte_rrc fields.
Show cell-id in info column (if don't manage to call RRC).

svn path=/trunk/; revision=35237
2010-12-21 17:46:25 +00:00
Jaap Keuter
dfb9193526 Set default graph file format to more appropriate Portable Network Graphics.
svn path=/trunk/; revision=35236
2010-12-21 08:08:28 +00:00
Jaap Keuter
015cd4a18d From Marc Giertzsch:
Dialog RTP Graph analysis is not showing forward and reverse delta.

svn path=/trunk/; revision=35235
2010-12-21 08:07:24 +00:00
Stephen Fisher
a7c89cdfd6 Fix bug #5509: CommView file format now uses reserved bytes and adds a
new use for the direction field per:

  http://www.tamos.com/htmlhelp/commview/logformat.htm

Add basic support for new fields and don't reject files that fit the new
format.


svn path=/trunk/; revision=35234
2010-12-20 23:34:14 +00:00
Jeff Morriss
08ba949594 Saying that patches will be reviewed in "a few days" may be a bit optimistic. Also point out that it's not necessary for patch submitters to mark the bug as ASSIGNED nor assign it to themselves.
svn path=/trunk/; revision=35233
2010-12-20 20:54:33 +00:00
Chris Maynard
f64b27c979 Fix warnings with format.
svn path=/trunk/; revision=35232
2010-12-20 18:16:12 +00:00
Chris Maynard
b9dd529e9c Some PIM enhancements, mostly to allow more fields to be filterable.
svn path=/trunk/; revision=35231
2010-12-20 17:48:26 +00:00
Bill Meier
8a4ae7cfa6 dissector_add() --> dissector_add_uint();
Rempve trailing blanks from lines.

svn path=/trunk/; revision=35230
2010-12-20 17:48:20 +00:00
Jeff Morriss
67aba31f94 Deprecate dissector_add(), dissector_change(), dissector_delete(),
dissector_get_port_handle(), dissector_reset(), dissector_try_port(),
dissector_try_port_new(), and next_tvb_add_port().

Re-tabify the file.

svn path=/trunk/; revision=35229
2010-12-20 16:39:09 +00:00
Martin Mathieson
c7c4850c38 From Papan Kumar Singh (bug 5504 & 5505):
Add missing break so that PDCP-LTE direction is set properly.

svn path=/trunk/; revision=35228
2010-12-20 11:26:50 +00:00
Jaap Keuter
720f40cd30 From Rob Casey:
Patch to add support for DNP3 protocol Binary Output Change object type.

svn path=/trunk/; revision=35227
2010-12-20 07:57:52 +00:00
Jaap Keuter
13a1233484 From Mathieu Parent:
* Support for XMLAlarmMessage (0x015A)
* every xml data is parsed using the XML dissector

svn path=/trunk/; revision=35226
2010-12-20 07:49:56 +00:00
Guy Harris
167ba84067 Another #define for old code.
svn path=/trunk/; revision=35225
2010-12-20 05:58:42 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jaap Keuter
7e16ec5b99 Prepare for handling DLT_IPV4 and DLT_IPV6.
svn path=/trunk/; revision=35223
2010-12-19 18:46:08 +00:00
Gerald Combs
9347f11d41 [Automatic manuf, services and enterprise-numbers update for 2010-12-19]
svn path=/trunk/; revision=35220
2010-12-19 16:03:24 +00:00
Bill Meier
70ce24ded5 Revert SVN #35213 based upon comments in the Wireshark-dev list.
http://www.wireshark.org/lists/wireshark-dev/201012/msg00206.html


svn path=/trunk/; revision=35219
2010-12-18 18:07:36 +00:00
Bill Meier
cd5544679a Revert SVN #35214 based upon comments in the Wireshark-dev list.
http://www.wireshark.org/lists/wireshark-dev/201012/msg00206.html

svn path=/trunk/; revision=35218
2010-12-18 17:55:06 +00:00
Jaap Keuter
9dd993d2f2 From Daniel Black:
Adds support for GOST algorithm as per RFC5933. This is used as an option
DNSSEC algorithm.

svn path=/trunk/; revision=35217
2010-12-18 14:29:21 +00:00
Sake Blok
c16ac675d9 Add support for the TLSv1.2 format of the CertificateRequest handshake message.
(see: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5485 )


svn path=/trunk/; revision=35216
2010-12-18 01:16:11 +00:00
Bill Meier
9fb850cf5b Convert indentation tabs within <programlisting> elements to 4 spaces.
As the book says:
 "Often a program listing will include tab characters to indent lines of code.
  When such a listing is imported to DocBook XML and formatted, the tab
  characters are not expanded as they are in the program editor.
  That's because in XSL-FO and HTML, tab stops and tab expansion are not
  described in either HTML or XSL-FO standards.
  By default, an XSL-FO processor treats a tab character as a single space,
  which leads to unsatisfactory results."

http://www.sagehill.net/docbookxsl/TabExpansion.html


svn path=/trunk/; revision=35215
2010-12-17 21:31:55 +00:00
Bill Meier
160bee8c16 The Styleguide section has been moved to the Wireshark Developer's Guide.
svn path=/trunk/; revision=35214
2010-12-17 20:55:45 +00:00
Bill Meier
8d27714f7e Integrate README.developer into the WSDG: Step 1: Styleguide;
Also: add list of README.developer contributors to the WSDG preface.

svn path=/trunk/; revision=35213
2010-12-17 20:30:26 +00:00
Martin Mathieson
e305c20212 Refactor EDCH-T2 function to also support the very similar EDCH-Common format.
N.B. EDCH-Common support itself not yet tested.

svn path=/trunk/; revision=35212
2010-12-17 17:40:42 +00:00
Stig Bjørlykke
bfc709b0d1 Use printf modifier %u for guint32 values.
svn path=/trunk/; revision=35211
2010-12-17 13:03:34 +00:00
Stig Bjørlykke
18e3850d24 Switched to bitwise & instead of logical && in bit operations.
This bug was found by clang.

svn path=/trunk/; revision=35210
2010-12-17 13:01:52 +00:00
Stig Bjørlykke
f7ac7ef37e Switched to bitwise | instead of logical || in bit operations.
This bug was found by clang.

svn path=/trunk/; revision=35209
2010-12-17 13:01:12 +00:00
Anders Broman
96659d0252 From Jouni Malinen:
Add support for dissecting TDLS (IEEE 802.11z) frames.
These are mostly used as Action frames that are encapsulated in Data frames (to go through any AP).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5493

svn path=/trunk/; revision=35208
2010-12-16 21:49:55 +00:00
Stephen Fisher
6892af9c0a Only call GetSystemMetrics(SM_REMOTESESSION) if running on MS Windows.
svn path=/trunk/; revision=35207
2010-12-16 20:38:06 +00:00
Gerald Combs
654835c197 Simplify our Remote Desktop session detection.
svn path=/trunk/; revision=35206
2010-12-16 19:52:59 +00:00
Bill Meier
7412810d89 Add comment that this file is apparently not referenced when building docs;
"AFAIK this file is *not* referenced on either Windows or *nix during the
  process of generating Wireshark documentation.
  (The catalogs referenced seem to be those in the "usual places": /etc/xml/...)"

svn path=/trunk/; revision=35205
2010-12-16 18:42:03 +00:00
Anders Broman
565b4d46b6 From Jouni Malinen:
Add dissecting for SA Query Action frames (IEEE 802.11w)
The patch hunks that were missed in r33436.

svn path=/trunk/; revision=35204
2010-12-16 18:06:32 +00:00
Balint Reczey
5dc1634248 Update filter for Windows-only symbols.
svn path=/trunk/; revision=35203
2010-12-16 17:22:17 +00:00
Balint Reczey
7f690fd086 Export only defined symbols from libwsutil.
Exported symbols are the symbols listed in libwsutil.def, but the
symbols defined in not used optional objects are filtered out.

svn path=/trunk/; revision=35202
2010-12-16 16:42:34 +00:00
Jeff Morriss
84aebe5af7 There is no exceptions.h file here, remove it from DISSECTOR_INCLUDES.
svn path=/trunk/; revision=35201
2010-12-16 14:39:33 +00:00
Anders Broman
86113c5a8c From Pascal Quantin:
When I coded the decoding of the feature group indicator, I decided to do not display the feature group content when it is not supported. After further thinking I find it more useful to always display the features of a given indicator whether it is supported or not.

svn path=/trunk/; revision=35200
2010-12-16 12:33:36 +00:00
Anders Broman
b124071369 From Vincent Helfre:
fixed the conversions for utran and eutran threshold which are used for Enhanced Measurement Report.

svn path=/trunk/; revision=35199
2010-12-16 12:26:49 +00:00
Anders Broman
7dd3704e0c Fix a comment.
svn path=/trunk/; revision=35198
2010-12-16 12:26:01 +00:00
Anders Broman
68fba79bed Dissect AVP Code: 606 User-Data if it's xml.
svn path=/trunk/; revision=35197
2010-12-16 10:04:00 +00:00
Jaap Keuter
a23223b145 From Harald Welte:
It seems that Hay Systems Limited (HSL) is using stream 0xDD to transport
human-readable debug messages from the BTS to the BSC.

svn path=/trunk/; revision=35196
2010-12-16 08:03:57 +00:00
Jaap Keuter
ede9bc5a0a From Harald Welte:
As it seems, there are systems that use an IPA multiplex layer but don't use
it on the standard ports that ip.access is using them for the A-bis interface.

This patch adds a user-configurable preference for the TCP and UDP ports the
IPA dissector should work on.

svn path=/trunk/; revision=35195
2010-12-16 07:55:35 +00:00
Jaap Keuter
fb1390652b Fix for bug 5475:
Track dissection properly of Packet Flow Identifier IE to 
avoid Extraneous Data reporting.

svn path=/trunk/; revision=35194
2010-12-16 07:25:01 +00:00
Jaap Keuter
a6b55e6530 From Guido Reismueller:
packet-mdd.c
- TLV 15 fixed

packet-tlv.c
- Added Support for DOCSIS 3.0 TLVs (38-66)

Added Support for the following DOCSIS 3.0 MAC Management Messages
- DBC-REQ (packet-dbcreq.c)
- DBC-RSP (packet-dbcrsp.c)
- DBC-ACK (packet-dbcack.c)
- CM-CTRL-REQ (packet-cmctrlreq.c)
- CM-CTRL-RSP (packet-cmctrlrsp.c)
- DPV-REQ (packet-dpvreq.c)
- DPV-RSP (packet-dpvrsp.c)

svn path=/trunk/; revision=35193
2010-12-16 07:01:22 +00:00
Jaap Keuter
5ae824fc8f From k barnard:
Flag when a packet has been dropped by the jitter buffer in the audio player,
by showing:
 D dropped packet
 W wrong timestamp
 S silence added by wireshark

To show when audio 'glitches' may have come from the processing the received
packets through the jitter buffer.

svn path=/trunk/; revision=35192
2010-12-15 18:38:17 +00:00
Martin Mathieson
3daaaf8a53 Use value_string for MAC-is descriptor lchid.
svn path=/trunk/; revision=35191
2010-12-15 12:07:41 +00:00
Martin Mathieson
126015ae33 From Tobias Witek:
Bug 5494 -  FP-Hint: Display correct DCH-ID value

In FP-Hint, DCH-IDs are stored as a 5-bit value. While a 5-bit value can 
hold values from 0..31, DCH-IDs in the NBAP, RNSAP and RRC protocols 
have values from 1..32.

This patch adds 1 to the DCH-ID in FP-Hint in order to display the 
correct DCH-ID value in the protcol tree.

svn path=/trunk/; revision=35190
2010-12-15 10:59:10 +00:00
Martin Mathieson
dea41913d5 Prettify the dissection of EDCH T2 data.
svn path=/trunk/; revision=35189
2010-12-15 10:53:35 +00:00