Commit Graph

15189 Commits

Author SHA1 Message Date
Guy Harris 1bd66768de Use the tap_dfilter_dlg mechanism.
svn path=/trunk/; revision=15504
2005-08-21 20:24:59 +00:00
Guy Harris 06a670ae9b Use the tap_dfilter_dlg code.
svn path=/trunk/; revision=15503
2005-08-21 20:16:12 +00:00
Jörg Mayer 547efe8ee3 - In the info summary, port# and slot# were exchanged
- In the Display element, the length of the display string
  was 4 too long
- Display the Vlan id in the packet summary, not just "Vlan"
- Remove trailing whitespace


svn path=/trunk/; revision=15502
2005-08-21 19:25:45 +00:00
Guy Harris 13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Anders Broman 78e0a2b458 From Mike Duigou:
A patch to the JXTA dissector. It's purpose is to improve 
the behaviour of the dissector when dissecting captures that do not 
include the whole conversation.

The dissector is now more capable of isolating a conversation without 
seeing the beginning of the conversation. It's still not always able to 
pick up all conversations (suggestions, patches and hints welcome).

improved some of the doxygen docs and comments.

svn path=/trunk/; revision=15500
2005-08-21 18:42:54 +00:00
Ulf Lamping 06c86303e7 The protocol item in the protocol tree will have a gray background now, which makes it much better visible.
Add some more optional flags to the protocol items, so more "special cases" can be marked in the protocol tree.

New flags:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR

svn path=/trunk/; revision=15499
2005-08-21 15:23:48 +00:00
Ulf Lamping 808b6d48d0 as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead
svn path=/trunk/; revision=15498
2005-08-21 15:13:47 +00:00
Anders Broman 929bd9dc39 remove sprintf from gsm_a
Do the update for the .cnf file too.

svn path=/trunk/; revision=15497
2005-08-21 13:52:33 +00:00
Guy Harris b3562ac040 "gtk_tap_dfilter_dlg_cb()" is no longer used outside
gtk/tap_dfilter_dlg.c; don't export it.

That means that gtk/tap_dfilter_dlg.h is no longer useful; get rid of
it.

Rename "gtk_tap_dfilter_dlg_cb()" to "tap_dfilter_dlg_cb()", as it's
inside GTK+-specific code, so there's no need to distinguish it from
non-GTK+ callbacks.

Update some comments to reflect the name change and the new API for
registering tap_dfilter_dlg stats.

Make the AFP and SMB stats use the gtk/tap_dfilter_dlg.c stuff.

svn path=/trunk/; revision=15496
2005-08-21 11:09:36 +00:00
Guy Harris 195c549d1a Have "register_dfilter_stat()" add "..." to the menu item, as all menu
items registered with it pop up a dialog box before displaying the stat.
Don't pass a name with "..." to it.

Put "..." into other menu items that pop up a dialog box before
displaying the stat; remove "..." from other menu items that don't.

svn path=/trunk/; revision=15495
2005-08-21 10:29:47 +00:00
Guy Harris 997601f754 Set properties.
svn path=/trunk/; revision=15494
2005-08-21 10:00:56 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Ronnie Sahlberg e88b3ccb32 remove sprintf from gsm_a
svn path=/trunk/; revision=15492
2005-08-21 01:52:09 +00:00
Ronnie Sahlberg bc3abb6ace remove gmalloc and sprintf
svn path=/trunk/; revision=15491
2005-08-21 01:14:43 +00:00
Ronnie Sahlberg 73d84924b5 remove sprintf
svn path=/trunk/; revision=15490
2005-08-21 00:55:46 +00:00
Guy Harris ce8ac34225 The routines registered with "register_stat_cmd_arg()" *are* called if
you use the "-z" command-line options for them; make them pop up the
appropriate windows.

Move the calls to "register_stat_cmd_arg()" after the code to register
the tap, just as the calls to "register_stat_menu_item()" are done after
registering the tap.

Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing that buffer.

svn path=/trunk/; revision=15489
2005-08-20 22:28:49 +00:00
Guy Harris 65064719d3 We already have a tap that registers as a command-line stat under the
name "rtp"; we don't need another one, especially given that
"rtp_stream.c" doesn't directly implement a stat (note that it doesn't
register a menu item).

svn path=/trunk/; revision=15488
2005-08-20 22:26:32 +00:00
Ulf Lamping cf3b9f23e5 capture_sync.c(290) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(290) : warning C4022: 'g_realloc' : pointer mismatch for actual parameter 1
capture_sync.c(431) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(431) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(442) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(442) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(549) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(549) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

svn path=/trunk/; revision=15487
2005-08-20 22:16:12 +00:00
Ronnie Sahlberg 91c1db961b remove sprintf
svn path=/trunk/; revision=15486
2005-08-20 22:15:39 +00:00
Ulf Lamping 03ea549ecc radius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(216) : warning C4022: 'g_hash_table_insert' : pointer mismatch for actual parameter 2
radius_dict.l(268) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(268) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

svn path=/trunk/; revision=15485
2005-08-20 22:08:35 +00:00
Ronnie Sahlberg b0476bbe19 removal of sprintf
svn path=/trunk/; revision=15484
2005-08-20 22:06:31 +00:00
Guy Harris 50d77b113c Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

svn path=/trunk/; revision=15483
2005-08-20 20:06:05 +00:00
Guy Harris b387fe837d Explain in more detail the split between the stuff in ui_util.h and in
gtk/gui_utils.h.

svn path=/trunk/; revision=15482
2005-08-20 19:49:22 +00:00
Guy Harris 6533b258e4 Explain in more detail what this file is for.
svn path=/trunk/; revision=15481
2005-08-20 19:45:53 +00:00
Guy Harris eadcfd642a There's no longer a need to individually remove items from
acse_ctx_oid_table - destroying the hash table will destroy the hash
table items, and the destroy function no longer has any work to do
because the OID strings are now allocated with se_strdup() (and thus get
freed when the capture is closed).

Regenerate packet-acse.c, which also regenerates acse-exp.cnf.

svn path=/trunk/; revision=15480
2005-08-20 18:17:36 +00:00
Guy Harris a749379d3c Flag the "add_string" parameter as unused if it is - and don't flag it
as such if it *is* used. Get rid of the "add_string" parameter to
"param_digits_basic", as that function *isn't* called through a pointer.

Don't flag arguments in declarations as unused; you only do that in
definitions.

Clean up indentation.

svn path=/trunk/; revision=15479
2005-08-20 18:01:07 +00:00
Guy Harris 07f44e2a7f "ascend-grammar.h" is generated by Bison with a copy of the definition
of the YYSTYPE structure in "ascend-grammar.c"; the intent is that other
files include "ascend-grammar.h" if they need that structure, but that
"ascend-grammar.c" not itself include "ascend-grammar.h".  If it *does*
include it, the compiler complains about YYSTYPE being redefined (even
though the two structures are identical).

svn path=/trunk/; revision=15478
2005-08-20 17:49:58 +00:00
Jörg Mayer bb5c2b1f7a And if we add a file, add it to Makefile.am as well
svn path=/trunk/; revision=15477
2005-08-20 16:30:23 +00:00
Jörg Mayer f296a84150 If we delete a file, don't forget to remove it from Makefile.common
svn path=/trunk/; revision=15476
2005-08-20 16:24:35 +00:00
Jörg Mayer 96adc5f4a1 - Include the .h files in their .c files.
- Remove epan/dissectors/packet-sna.h, it isn't used anywhere.

svn path=/trunk/; revision=15475
2005-08-20 16:19:22 +00:00
Ulf Lamping 925489be0b removed MSVC warnings:
packet-camel.c(6829) : warning C4101: 'version_str' : unreferenced local variable
packet-quakeworld.c(172) : warning C4090: 'return' : different 'const' qualifiers
packet-smb.c(10859) : warning C4101: 'target_name_len' : unreferenced local variable
packet-smb.c(10860) : warning C4101: 'fn_len' : unreferenced local variable
packet-smb.c(10858) : warning C4101: 'fn' : unreferenced local variable

svn path=/trunk/; revision=15474
2005-08-20 15:58:42 +00:00
Ulf Lamping c597abee57 Win32: exported DATA must be declared with ETH_VAR_IMPORT to be available from outside the lib
fixes current Win32 buildbot problem

svn path=/trunk/; revision=15473
2005-08-20 15:19:31 +00:00
Jörg Mayer b77737650f One file missed in last checkin
svn path=/trunk/; revision=15472
2005-08-20 14:08:53 +00:00
Jörg Mayer 0edcc8920e - Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

svn path=/trunk/; revision=15471
2005-08-20 14:02:00 +00:00
Jörg Mayer 4fd9fcc639 Add some comments on the originating files of the declarations
svn path=/trunk/; revision=15470
2005-08-20 13:21:09 +00:00
Ronnie Sahlberg e6dd3c8b22 more sprintf updates
svn path=/trunk/; revision=15469
2005-08-20 13:02:08 +00:00
Jörg Mayer b55266d3c0 - Include ../ui_util.h into files that implement functions declard in
ui_util.h
- Replace one instance of ui_util.h by gui_utils.h

svn path=/trunk/; revision=15468
2005-08-20 12:57:52 +00:00
Ronnie Sahlberg e1dad35f95 remove sprintf
svn path=/trunk/; revision=15467
2005-08-20 12:38:45 +00:00
Ronnie Sahlberg a51ba4011d get rid of a whole chunk of sprintfs
svn path=/trunk/; revision=15466
2005-08-20 12:28:16 +00:00
Ulf Lamping eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris 5adc2b6bf1 From Gisle Vanem: export get_timedelta() for use by AFP and SMB taps.
svn path=/trunk/; revision=15464
2005-08-20 10:03:07 +00:00
Guy Harris 393366d5dd The order in which arguments to a function are evaluated isn't defined
by C.  Do decrements of arguments before passing them to a function.

svn path=/trunk/; revision=15463
2005-08-20 09:35:55 +00:00
Guy Harris 0ec73a5eff Widen some variables so the code in question can handle large files if,
as, and when Wiretap can handle them.

svn path=/trunk/; revision=15462
2005-08-20 09:08:24 +00:00
Guy Harris c58cbeba92 Export AFP's CommandCode_vals for use by the AFP taps.
svn path=/trunk/; revision=15461
2005-08-20 08:15:21 +00:00
Ronnie Sahlberg 401c07b4dd sprintf elimination
svn path=/trunk/; revision=15460
2005-08-20 05:37:08 +00:00
Ronnie Sahlberg 54b6bc0e32 sprintf removals
svn path=/trunk/; revision=15459
2005-08-20 05:31:36 +00:00
Ronnie Sahlberg 6657ebb4c9 remove some more sprintf
svn path=/trunk/; revision=15458
2005-08-20 02:51:13 +00:00
Ronnie Sahlberg a34e7e3d03 removal of even more sprintf
svn path=/trunk/; revision=15457
2005-08-20 02:33:33 +00:00
Guy Harris 2028488827 For AFP requests, add in the frame with the (last part of the) reply, if
possible, and, for AFP replies, add in the frame with the request and
the time between those two frames.

Have AFP per-request-type RTT statistics, similar to SMB's statistics.

svn path=/trunk/; revision=15456
2005-08-20 02:19:37 +00:00
Guy Harris e5c09b21aa Use get_timedelta() to get the difference between two times.
svn path=/trunk/; revision=15455
2005-08-20 02:15:02 +00:00