Commit Graph

60359 Commits

Author SHA1 Message Date
Jeff Morriss 1ab019f409 Fix up documentation of RPM packages.
Specify which ./configure options are passed into the RPM.

Describe the 3 package RPM package names and their contents.

Describe how to enable parallel builds when making RPMs.

RPM now stands for "RPM Package Manager."

Fix some markup problems.

Change-Id: I1664aa0956719e872d302a4af2c092318f5eea6d
Reviewed-on: https://code.wireshark.org/review/11737
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-12 07:08:53 +00:00
Pascal Quantin c712d65e91 Qt: save preferences after creating a filter from expression frame
Bug: 11690
Change-Id: Ice6a2341d3f39c107a3c9d6a0e23fd98312b48a8
Reviewed-on: https://code.wireshark.org/review/11748
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-12 07:02:28 +00:00
Stig Bjørlykke 864872ed61 Qt: Added IO Graph save to clipboard button.
Also added save as CSV file.
Do not add double quotes for values as we do in GTK.

Change-Id: I8576a73e10b71cdba0c8c80db8b21927d19528da
Reviewed-on: https://code.wireshark.org/review/11732
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-12 07:00:33 +00:00
Martin Kaiser a67d426b1d dissector for ISO14443 protocols
This is a dissector for the ISO14443 protocols between a contactless
smartcard and a card reader.

The overall approach is similar to DVB-CI. We have a pseudo-header in
front of the captured data that has information about the type of the
captured data and the direction.

For now, the dissector registers itself by name so it can be linked to a
user-DLT. I am applying for an official DLT.

Change-Id: I9c4a28ef5b220f205baf58381bf1962996887a9d
Reviewed-on: https://code.wireshark.org/review/11663
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-12 06:59:24 +00:00
Guy Harris e240ad882b Use format_text() when displaying, not when handing to AirPDcap.
format_text() is specifically intended to handle strings when displaying
them to the user; code such as AirPDCap, which doesn't display strings
to the user, should be handed the raw SSID.

Put in a comment indicating what we probably *should* be doing here.

Bug: 11685

Change-Id: Ic30114c35d1d8f3d791ae904e33a4d81ddc215ec
Reviewed-on: https://code.wireshark.org/review/11757
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-12 06:30:40 +00:00
João Valverde 90d9710145 IPv6: Register extension header fields under the appropriate protocol
Fixes Qt GUI supported protocols display.

Change-Id: If51aae0f6cb2a7d182aa1c40bd827e09bbddbb09
Reviewed-on: https://code.wireshark.org/review/11536
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-12 03:36:22 +00:00
Alexis La Goutte 50e83c0e79 802.11: avoid multi return on SSID or MESHID
Bug:11685
Change-Id: Ibe7a2909f0aed33fa35685ac5c8e0e1a8a626742
Reviewed-on: https://code.wireshark.org/review/11652
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-12 03:34:51 +00:00
DiablosOffens bf2b578074 Make it possible to set an environment variable to do debug builds.
Change-Id: I236db01194803474d63fa3d5869f7e80585bce0e
Reviewed-on: https://code.wireshark.org/review/11730
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-12 03:33:10 +00:00
Jo Rueschel 09f43c196e Export functions str_to_ip() and str_to_ip6() to plugins
The functions str_to_ip() and str_to_ip6() are not yet exposed to plugins so
they cannot be used there.
Now they are added to the plugin API.

Change-Id: I9df267934ad43887a6326c8c9a1a666f263c08a2
Reviewed-on: https://code.wireshark.org/review/11728
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-12 03:31:01 +00:00
Guy Harris 412ab838d2 Plug file descriptor leak.
Change-Id: I882cc5c264fdf97452c84bd5cea0e5d56bd6eb45
Reviewed-on: https://code.wireshark.org/review/11753
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-12 01:49:25 +00:00
Guy Harris 75dc2051e8 Add wtap_dump_open_tempfile routines, to write to a temporary file.
It includes the temporary-file generation, so you don't have to do it
yourself.

Change-Id: I0798df95a5c5646224ec49612f50b423ed78547a
Reviewed-on: https://code.wireshark.org/review/11751
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-12 00:59:40 +00:00
Guy Harris af8c70cb7d Add $(randpkt_INCLUDES) to $(noinst_HEADERS) so they're distributed.
Change-Id: Ib81233c5292d5a81bca7fa6a382d4dad20997330
Reviewed-on: https://code.wireshark.org/review/11749
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-12 00:57:18 +00:00
Pascal Quantin ca2ecc1241 Qt: fix cursor position when editing coloring rules names or filters
A call to setText will set the cursor to the end of the box.
As far as I can tell, this call is useless so let's remove it.

Bug: 11689
Change-Id: I40aee48745a9107331a017070a715a075106974a
Reviewed-on: https://code.wireshark.org/review/11727
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-11 20:43:06 +00:00
Guy Harris b6fd85bd19 Put wtap_dump_open() right before wtap_dump_open_ng().
That matches what we do with the other two pairs of dump opening
routines.

Change-Id: I0e6e475573c3a8d4ab6cf991d0aadc14150af233
Reviewed-on: https://code.wireshark.org/review/11744
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-11 19:54:55 +00:00
Gerald Combs 4a9705774a Fixup a couple of stdout checks.
Change-Id: I942cd9010901d7b6c4f5b390fb23f79d72fb05d0
Reviewed-on: https://code.wireshark.org/review/11740
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-11 18:15:36 +00:00
Pascal Quantin 978d7a8f05 Update user guide for upcoming 2.0 release
Change-Id: Id27365d6bd7085f498edd78111d85de0fbd0abd3
Reviewed-on: https://code.wireshark.org/review/11738
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-11 18:00:31 +00:00
Pascal Quantin b20d5bbc0b CMake: set WinPcap version in top CMakeLists.txt file like for NMake
This allows displaying the WinPcap version in about dialog

Change-Id: Ic3f4256d81db68314a158fc55682dfd9dbf799a0
Reviewed-on: https://code.wireshark.org/review/11726
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-11-11 17:47:45 +00:00
Guy Harris ec289edf3e Put randpkt-core.h into the release tarball.
Change-Id: I9c887b3e683ecd035fb3d16d64c5ce1285b97865
Reviewed-on: https://code.wireshark.org/review/11736
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-11 17:46:52 +00:00
Jeff Morriss c4b4b9a59c Rename the wireshark-gnome RPM package wireshark-gtk.
This was mentioned a while ago in another change but I forgot about it until
seeing Gerald's recent release-notes change (which indicates that the RPM and
Debian package names for the old GUI are wireshark-gtk).

Change-Id: I2a39fce38086d3716c8ef2a07eb8f23bb91a25fa
Reviewed-on: https://code.wireshark.org/review/11709
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-11-11 17:43:34 +00:00
Pascal Quantin fb3d38225e Update user guide for development release
Change-Id: I9b4c5ab2e98ad6daa618bcda20b53a23467e16e0
Reviewed-on: https://code.wireshark.org/review/11734
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-11 17:31:31 +00:00
Dario Lombardo f1ff6d62c4 randpkt: split into a core and an app.
This will allow other apps to use the random packet generation
features.

Change-Id: I7e9af58cbe39da4908242b5fbb292f473e03b4f2
Reviewed-on: https://code.wireshark.org/review/11579
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-11 13:22:05 +00:00
Pascal Quantin 328fbc001e Qt: fix profile rename
Bug: 11658
Change-Id: I271863557d13137d168e12d3c393de49823f288a
Reviewed-on: https://code.wireshark.org/review/11708
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-11 08:17:26 +00:00
Pascal Quantin a4981a279a Qt: fixes to 'Edit Column' dialog
- set field name and occurrence when editing a custom column
- convert occurrence number to a QString
- disable OK button when syntax is incorrect or empty for a custom column
- update syntax state when opening the edit dialog or when switching between custom and normal column

Bug: 11433
Change-Id: Ia8424474dd250c78a0b503e0e9d89c322f4f86a9
Reviewed-on: https://code.wireshark.org/review/11705
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-11 08:16:25 +00:00
Guy Harris 5f4c9b2bb2 Make routines used only within wiretap/merge.c static.
We just export some UI helpers and the Big Merge Engine.

Change-Id: I60bc8ab167e7100189a9ce60d84c0e4db27b6bda
Reviewed-on: https://code.wireshark.org/review/11689
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-11 08:06:24 +00:00
Gerald Combs 757fe65474 Qt: Freeze+thaw the main window during nested operations.
As noted in main_window.cpp:

// Our event loop becomes nested whenever we call update_progress_dlg, which
// includes several places in file.c. The GTK+ UI stays out of trouble by
// showing a modal progress dialog. We attempt to do the equivalent below by
// disabling parts of the main window. At a minumum the ProgressFrame in the
// main status bar must remain accessible.

Move the freeze+thaw code from captureFileRetapStarted and
captureFileRetapFinished to its own set of member functions. Call them
when we {,un}mark and {,un}ignore packets and note that we should
probably call them elsewhere. Disable mark and ignore actions when we
freeze and restore their states when we thaw.

Bug: 11681
Change-Id: I6f015f7f5f6c98cd48ace2c87f43f48efe51a88b
Reviewed-on: https://code.wireshark.org/review/11690
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-11 05:28:10 +00:00
Balint Reczey 8930b0d5e0 debian: Make make dist know about moving wireshark.1 to wireshark-qt and removal of wireshark.menu
Change-Id: I81b95e43beae7ca85bff9b2d5b4a6f498252f2b3
Reviewed-on: https://code.wireshark.org/review/11720
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 05:26:37 +00:00
Balint Reczey f2ac2e477a debian: Move icon and mime info file to wireshark-common
Change-Id: I4d8660b36810baa95f8b300af9790778dcba83a8
Reviewed-on: https://code.wireshark.org/review/11697
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:47:30 +00:00
Balint Reczey b732f44d1e GTK: Add separate working desktop file for GTK+ Wireshark GUI
Change-Id: I52a749b7e2b9a4a5cb2968409e140b9d5f2002f6
Reviewed-on: https://code.wireshark.org/review/11696
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:45:48 +00:00
Balint Reczey 7d86cc9194 debian: Ship wireshark.desktop file in wireshark-qt
Change-Id: Idbf77e6a613c79e267f41d3e9d3c05617e9c6d99
Reviewed-on: https://code.wireshark.org/review/11695
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:45:14 +00:00
Balint Reczey 505529190a debian: Ship wireshark.1 in the package we ship /usr/bin/wireshark
Change-Id: I7935f412092d6dbb0f545803d82d9b42dfe5a638
Reviewed-on: https://code.wireshark.org/review/11694
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:44:15 +00:00
Balint Reczey 2d1bf738d7 debian: Finish postinst of wireshark-common even when wireshark group is a user group
Failing postinst has been reported several times under LP#1447893

Change-Id: I196f246b34aa3be9d53f02b4e0092c802effc42a
Reviewed-on: https://code.wireshark.org/review/11693
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:43:05 +00:00
Balint Reczey 927a55f914 debian: Add note to README.Debian to log in again to be able to capture packets
Change-Id: Ifae1223d34f7ae071484fe47d1c88de166ed84ca
Reviewed-on: https://code.wireshark.org/review/11692
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:41:59 +00:00
Balint Reczey 18a54fcaa4 debian: Drop menu support
Debian is migrating away from the Debian Menu system to adopt
Freedesktop Desktop Entry Specification instead. (.desktop files)
Packages providing .desktop files should not provide menu files.
https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html

Change-Id: I862deee870e9697c590a8323ba8ae2da892b7bb1
Reviewed-on: https://code.wireshark.org/review/11691
Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-11-11 04:40:42 +00:00
Alexis La Goutte 886de6b91f ISI: Add Modelines info
Change-Id: I758c39698847d65447e0a7490104a9369c85f6cd
Reviewed-on: https://code.wireshark.org/review/11684
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-11 00:25:16 +00:00
João Valverde 541f352b5e UDP: Don't throw malformed errors for empty UDP payload
Change-Id: I7f5724e263ab81d42421d0cfcb1fc4b63a55d79e
Reviewed-on: https://code.wireshark.org/review/11590
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-11 00:23:16 +00:00
Matthieu Coudron c2afc9edec Change prototype of callbacks passed to wmem_tree_foreach so that they
accept the node key as a first parameter.

wmem_tree accepts all sort of keys (strings, integers, soon ranges),
thus it is of interest for various purposes (testing, greedy search) to
know the key of the node.

Change-Id: Ie748b917bef91f0b1ba8cce15bd1b471922641dc
Reviewed-on: https://code.wireshark.org/review/11683
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-11 00:22:37 +00:00
Alexis La Goutte b9b74fcf57 ISI: fix code will never be executed [-Wunreachable-code]
Change-Id: I24185128e664a0f7cc2b59d5d653582cddd04df1
Reviewed-on: https://code.wireshark.org/review/11686
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-11 00:14:52 +00:00
Guy Harris 905314f259 Additional 2.1 symbols.
Change-Id: Icf5d218e3e0a3336c80e04ed51a1ef5262cc9f28
Reviewed-on: https://code.wireshark.org/review/11711
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-11 00:06:46 +00:00
Guy Harris 67a6342da5 New 2.0 symbols.
Change-Id: Ie85ac43891c5587b0998e26da683ef275b631657
Reviewed-on: https://code.wireshark.org/review/11706
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 21:54:05 +00:00
Gerald Combs ec303c13b3 Add CMakeLists.txt.user* to .gitignore.
Qt Creator uses CMakeLists.txt.user to store CMake build settings.

Change-Id: I600289183dcfbc03cd9b555c4b646e6cfb799b0e
Reviewed-on: https://code.wireshark.org/review/11700
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-10 21:48:23 +00:00
Guy Harris 0b05086754 Apple calls it just "OS X" these days.
Change-Id: I98905988ceb394d27307d1cbe883d8fe95ac23e4
Reviewed-on: https://code.wireshark.org/review/11703
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 21:08:45 +00:00
Gerald Combs 0d497e8125 Initial Sysdig syscall (event) support.
Add a dissector for reading Sysdig event blocks. It only handles plain
events but it's usable for reading trace files on hand here.

Use a script to generate various parts of the dissector. As an experiment,
update parts in-place instead of using a template.

Ultimately there should probably be a top-level "Syscall" or "Event"
dissector alongside the "Frame" dissector, which could then call this.
You could then directly compare an executable's system calls alongside
its network traffic.

For now leverage the pcapng_block dissector and keep everything under
"Frame".

Next steps:
- Items listed at the top of packet-sysdig-event.c.

Change-Id: I17077e8d7f40d10a946d61189ebc077d81c4da37
Reviewed-on: https://code.wireshark.org/review/11103
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-10 20:59:53 +00:00
AdrianSimionov 6a56224c18 [docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and subTLV 33
Change-Id: I63410d90e65a46aaeb534cca56e8797ebe00bf6f
Reviewed-on: https://code.wireshark.org/review/11685
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-10 19:37:28 +00:00
Guy Harris e2193fe6fd Fix typo.
Change-Id: I417de6124925dbfd9599ec7e90e287eb971457a3
Reviewed-on: https://code.wireshark.org/review/11687
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 18:10:17 +00:00
Guy Harris 6ae50ebf28 Call wtap_dump_open_check() in wtap_dump_init_dumper().
The callers of wtap_dump_init_dumper() always call
wtap_dump_open_check() first, with the same arguments in all cases; pull
the latter call into wtap_dump_init_dumper() itself.

Change-Id: I2b44dc3a018745e175b5c74ff1a346749fec2b71
Reviewed-on: https://code.wireshark.org/review/11681
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 11:29:05 +00:00
Guy Harris b3fa7e5d3d Add a comment for is_stdout.
Change-Id: I88abb5a37a00ebc1a2a742ff36c8d6be75420dbe
Reviewed-on: https://code.wireshark.org/review/11677
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 10:50:34 +00:00
Guy Harris 827b7dd756 Skip only the actual file descriptor close when writing to stdout.
Have a "this is stdout" flag for a wtap_dumper, and have "open the
standard output for dumping" routines that set that flag.  When closing
a wtap_dumper, do most of the work regardless of whether we're writing
to the standard output or not (so that everything gets written out) and
only skip the closing of the underlying file descriptor.

Change-Id: I9f7e4d142b3bd598055d806b7ded1cb4c378de8e
Reviewed-on: https://code.wireshark.org/review/11673
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-10 10:11:50 +00:00
Jeff Morriss 630ccbe2d7 Make the dfilter time tests work regardless of what time zone the tests are
being run in.

Do this by forcing the time zone to be UTC (by modifying the environment).

Change-Id: I13c47deada82b55a464006f9c3cc60115b2e4f20
Reviewed-on: https://code.wireshark.org/review/11378
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-10 09:04:48 +00:00
AndyL 0a993232bf GIOP dissector: Replies are not correctly associated with requests
Added IP address and port number to the comp_req_list_entry so
get_mfn_from_fn_and_reqid can check for matching IP and port number
when searching for the reply to a request.

Change-Id: Iad00bca5c1104cf8c335001f84264fe55d2e45fc
Reviewed-on: https://code.wireshark.org/review/11599
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-10 09:03:02 +00:00
Jeff Morriss 3e5b2537f7 RPC: call REPORT_DISSECTOR_BUG() rather than abort().
Checking WIRESHARK_ABORT_ON_DISSECTOR_BUG here looks somewhat redundant but it's not:
it's needed to prevent REPORT_DISSECTOR_BUG() from throwing an exception when
we're not dissecting (when nobody's going to catch the exception).

Change-Id: I4dfc484bdf13bca236bfff1388d4399e26880ad7
Reviewed-on: https://code.wireshark.org/review/11272
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-10 08:55:45 +00:00