Commit Graph

38226 Commits

Author SHA1 Message Date
Alexis La Goutte 90fc47b5a3 Fix a wrong copy/paste....
svn path=/trunk/; revision=40011
2011-11-26 16:32:20 +00:00
Alexis La Goutte d4050b9b0a From Kari Vatjus-Anttila via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5956
kNet (KristalliNet) dissector for Wireshark

kNet is a connection-oriented network protocol for transmitting arbitrary application-specific messages between network hosts. It is designed primarily for applications that require a method for rapid space-efficient real-time communication. kNet is an application-level protocol which can be ran either over UDP, TCP or SCTP transports.

From me :
* Add Modelines information and fix trailing whitespace
* Merge packet-knet.h in packet-knet.c
* Make Checkhf happy
* Fix Clang/GCC Warning about unused variable
* Add Authors info & CMakeList.txt

svn path=/trunk/; revision=40010
2011-11-26 16:23:37 +00:00
Jörg Mayer 296fade785 There is now an early (source only) Win32 version of GTK3 available.
svn path=/trunk/; revision=40009
2011-11-26 10:50:27 +00:00
Chris Maynard 5cfa297971 Don't pass 'len' to the dissect routine since we know there's only 1 byte present. This fixes the buildbot complaint about using 'len' uninitialized.
svn path=/trunk/; revision=40008
2011-11-26 04:45:49 +00:00
Chris Maynard 6dc3290d68 Add a few casts to try to make the buildbots happy.
svn path=/trunk/; revision=40007
2011-11-26 04:31:40 +00:00
Chris Maynard d51167076a IP option improvements. While fixing bug 6561, I noticed some deficiencies in the IP options dissection capabilities. Testing of these changes primarily used the capture file attached to that bug report as there were several IP options present. Packet 222 is an interesting packet that illustrates some of the new filters available. Further work is needed, but hopefully this is a good first step. Fuzz testing was performed using my own "menagerie".
svn path=/trunk/; revision=40006
2011-11-26 04:16:11 +00:00
Bill Meier 7ff8d2e622 Add missing '*/' to the end of a comment: Fixes gcc compile error.
svn path=/trunk/; revision=40005
2011-11-25 22:08:25 +00:00
Bill Meier 78af0d3f86 From Ivan Lawrow: Added IEEE 802.15.4-2003 AES-CCM security modes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4912

svn path=/trunk/; revision=40004
2011-11-25 22:02:25 +00:00
Stephen Fisher a4fedb2a86 Mark drep parameter as unused in the epm_dissect_tower_data function
since its use was removed in r40002.


svn path=/trunk/; revision=40003
2011-11-25 17:19:00 +00:00
Bill Meier 6ed4eee44f From Wido Kelling: EPM tower UUID must be interpreted always as little endian.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6368

svn path=/trunk/; revision=40002
2011-11-25 17:02:51 +00:00
Martin Mathieson 899155a563 Add the reason for a UL ReTx (PDCCH retx grant or PHICH NACK).
svn path=/trunk/; revision=40001
2011-11-25 11:19:03 +00:00
Alexis La Goutte a21d6f0a96 Remove unused code (Add in Revision 836)
Fix also some Clang/GCC Warning about unused variable

svn path=/trunk/; revision=40000
2011-11-25 10:41:11 +00:00
Tomas Kukosa 3c7926a2c6 Fix H.460.18 and H.460.19 integration into H.245
svn path=/trunk/; revision=39998
2011-11-24 15:18:11 +00:00
Martin Mathieson 20019f77ed Only add the priority level if it is set inside valid range.
svn path=/trunk/; revision=39997
2011-11-24 12:44:11 +00:00
Bill Meier d8027c4194 Fix gcc compile error
svn path=/trunk/; revision=39996
2011-11-24 03:33:29 +00:00
Bill Meier 6d9e776d34 Use a GHashTable to store templates instead of
using a home-grown hash table (which didn't handle collisions);
Include complete "connection info" (srcAddr,srcPort,dstAddr,dstPort) in "Template Name";
Rename various variables;
Re-indent & Re-format code.

svn path=/trunk/; revision=39995
2011-11-24 03:20:44 +00:00
Chris Maynard 1f513638e0 Display protocol ID consistently in decimal throughout. Append each IP option to top-level Options field. Whitespace cleanup - the majority of the dissector used 2-space indentation, so that's the format chosen. Added modelines to match.
svn path=/trunk/; revision=39994
2011-11-23 18:33:45 +00:00
Jaap Keuter f14c2c772b Move some comments around to make it more boilerplate like.
svn path=/trunk/; revision=39992
2011-11-22 21:51:24 +00:00
Bill Meier 6f23917193 Fix two compiler errors.
svn path=/trunk/; revision=39991
2011-11-22 20:48:49 +00:00
Bill Meier 0185b61ceb Handle 2 issues related to cacheing templates:
- Use a (slightly) less simplistic hashing algorithm to reduce collisions;
   Note: A GHashTable which handles collisions rather than
         a home-grown hash table (which does not) needs to be implemented.
 - Don't replace an existing template in the cache when a collision occurs;

Fixes Bug #6325
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6325

svn path=/trunk/; revision=39990
2011-11-22 20:42:25 +00:00
Guy Harris d892f00916 Show a "Capturing on ..." message similar to TShark.
svn path=/trunk/; revision=39989
2011-11-22 19:07:49 +00:00
Martin Mathieson 996dc0ad13 Add more packet highlights to the info column.
svn path=/trunk/; revision=39988
2011-11-22 17:57:25 +00:00
Anders Broman 932ea790e8 Fix bugs related to Nounce IE dissection.
svn path=/trunk/; revision=39987
2011-11-22 17:44:50 +00:00
Chris Maynard db39b3da06 For now, display the protocol in hexadecimal again so displaying it in decimal doesn't get backported to the 1.6 and 1.4 trunks at the request of Joerg.
svn path=/trunk/; revision=39986
2011-11-22 15:18:20 +00:00
Balint Reczey f15662eaa6 Unconditionally install idl2wrs
svn path=/trunk/; revision=39985
2011-11-22 13:53:17 +00:00
Balint Reczey f0642db264 hardcode /bin/sh to idl2wrs
svn path=/trunk/; revision=39984
2011-11-22 13:53:06 +00:00
Guy Harris 939feef06f If we're not running as a child process, report the interfaces on which
we're capturing.  (We do not require a -i flag; the message could be
useful if you don't specify the interface, as it lets you know which
interface was chosen, which might not be the interface you'd think it
would be.  Yes, that's arguably a libpcap bug, which I plan to look at;
it should probably try to figure out which interfaces are "active" if
possible, and prefer those.)

Use cmdarg_err() for invalid capture filters and other capture errors.

svn path=/trunk/; revision=39983
2011-11-22 10:08:26 +00:00
Balint Reczey aad9adc89d Add initial .gitignore files
svn path=/trunk/; revision=39982
2011-11-22 00:13:12 +00:00
Balint Reczey 333bc8f123 Don't hardcode 'python' for asn2wrs
svn path=/trunk/; revision=39981
2011-11-22 00:11:56 +00:00
Anders Broman 16be627c1a Get rid of Warnings.
svn path=/trunk/; revision=39980
2011-11-21 20:08:11 +00:00
Anders Broman a8ea39d6aa Typo
svn path=/trunk/; revision=39979
2011-11-21 20:06:26 +00:00
Anders Broman 7a6c01224d Get rid of Warnings.
svn path=/trunk/; revision=39978
2011-11-21 20:04:45 +00:00
Anders Broman 756113888a Get rid of Warnings.
svn path=/trunk/; revision=39977
2011-11-21 18:21:59 +00:00
Anders Broman 603173b64a From Vincent Helfre:
added the display of intermediate value used to decode ARFCN in 
range 1024/256 format.
So now the W(n) values can be displayed and localised in the tvb buffer.
The code was reworked a little to use the get_bit functions.

svn path=/trunk/; revision=39976
2011-11-21 18:16:19 +00:00
Bill Meier c60d239123 From Claudio: header value always computed twice
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6592

svn path=/trunk/; revision=39975
2011-11-21 17:58:47 +00:00
Guy Harris baa84e09f2 An SDNV length > 8 is also not dissectable. Should fix bug 6601.
svn path=/trunk/; revision=39974
2011-11-21 17:49:27 +00:00
Bill Meier 81a16331f8 'dissect_ImageLZ_JPEG()' is apparently not used; #if 0 the code for now.
svn path=/trunk/; revision=39973
2011-11-21 17:05:17 +00:00
Bill Meier 34c16b8c17 From Yaniv Kaul: Some enhancements, some fixes, to the Spice dissector:
- SASL authentication support - improved (and correct) state machine.
- indention, tab fixes
- macro to fetch PDU, simplifying the code (and improving its readability)
- properly show the length of agent messages and align them under the right tree.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6589

From me: Fix some indentation & remove some trailing whitespace.

svn path=/trunk/; revision=39972
2011-11-21 16:43:01 +00:00
Martin Mathieson ab9ede8e8f Add the system frame number (SFN) to the context fields logged along with LTE MAC frames.
svn path=/trunk/; revision=39971
2011-11-21 16:18:33 +00:00
Jörg Mayer ffd84cbf3c Linking against GTK3 stoped working because only libgtk3 was linked
against and no libs that gtk3 depended on. Fix this.

svn path=/trunk/; revision=39970
2011-11-21 15:39:25 +00:00
Jörg Mayer 4ea7f38015 More warnings "set but not used" fixed
svn path=/trunk/; revision=39969
2011-11-21 15:03:17 +00:00
Jörg Mayer c946b6c3a2 Move generated dissctors that are causing problems to DIRTY.
packet-x11.c: hundreds of:

/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h:27994:9: warning: variable ‘f_resource’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext_Reply’:

dissectors/packet-dcerpc-mapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_req’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8592:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_repl’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8617:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_RecipSMTP’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8848:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]


dissecots/packet-dcerpc-drsuapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c: In function ‘drsuapi_dissect_DsGetNCChangesCtr7’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c:2920:17: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]

Btw.: Does it really make sense to use an extra CMakefile for the dcerpc/ dir?
      I'd rather the the idl2wrs.c in tools/ and the generatorstuff in epan/CMake

More files with the same problem.

svn path=/trunk/; revision=39968
2011-11-21 13:52:35 +00:00
Jörg Mayer ffc843e501 Another case of written to only variable.
svn path=/trunk/; revision=39967
2011-11-21 12:13:36 +00:00
Jörg Mayer 80ec54b369 new_offset was was written to but never read.
svn path=/trunk/; revision=39966
2011-11-21 12:11:35 +00:00
Jörg Mayer 57969662c7 Move a generated file into file lists that do not treat warnings
as errors:

/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_req’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8592:14: error: variable ‘tree’ set but not used [-Werror=unused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_repl’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8617:14: error: variable ‘tree’ set but not used [-Werror=unused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_RecipSMTP’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8848:14: error: variable ‘tree’ set but not used [-Werror=unused-but-set-variable]


svn path=/trunk/; revision=39965
2011-11-21 12:08:10 +00:00
Guy Harris 272c011d19 On an I/O error, merge_read_packet() and merge_append_read_packet() need
to return a pointer to the merge_in_file_t that got the error.  Set *err
to 0 on success and an error code on an err, treat a null return as an
EOF indication, and if we don't get a null return check for a non-zero
error code and treat that as an I/O error.

svn path=/trunk/; revision=39964
2011-11-21 06:26:03 +00:00
Chris Maynard f2e8579ba3 Fix potential infinite loop introduced with r39961 and find by the buildbot. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6599
svn path=/trunk/; revision=39963
2011-11-21 02:01:59 +00:00
Chris Maynard 3c8e31e055 Fix bug 6561: IPv4 UDP/TCP Checksum incorrect if routing header present.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6561

svn path=/trunk/; revision=39961
2011-11-20 15:47:14 +00:00
Chris Maynard 1e6a19e48a Fix "'Closing File!' Dialog Hangs" bug 3046: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3046
svn path=/trunk/; revision=39959
2011-11-20 15:11:15 +00:00
Gerald Combs d1cdba1c13 [Automatic manuf, services and enterprise-numbers update for 2011-11-20]
svn path=/trunk/; revision=39958
2011-11-20 15:03:25 +00:00