Bill Meier
199da73e21
Prevent memory leakage of uncompress tvb and associated data buffer (step 1).
...
(tvb memory leak will actually remain until a bug in tvbuff.c is also fixed).
svn path=/trunk/; revision=40171
2011-12-13 02:56:44 +00:00
Guy Harris
c3da1f23d3
Add missing checks for a too-large packet, so we don't blow up trying to
...
allocate a huge buffer.
svn path=/trunk/; revision=40170
2011-12-13 02:42:42 +00:00
Guy Harris
dd92029afa
Check for a bogus record size. Fixes bug 6670.
...
svn path=/trunk/; revision=40169
2011-12-13 02:00:41 +00:00
Guy Harris
89303e99c4
Add an arbitrary limit on the maximum size of the frame table, so that
...
we don't crash. Fixes bug 6669.
svn path=/trunk/; revision=40168
2011-12-13 01:49:27 +00:00
Guy Harris
c8182253c8
Add missing checks for a too-large packet, so we don't blow up trying to
...
allocate a huge buffer; fixes bug 6668.
Also add some other checks for invalid records.
svn path=/trunk/; revision=40167
2011-12-13 01:24:12 +00:00
Guy Harris
73a808f9bc
Add missing check for a too-large packet, so we don't blow up trying to
...
allocate a huge buffer; fixes bug 6667.
svn path=/trunk/; revision=40166
2011-12-13 01:05:52 +00:00
Guy Harris
b669a11931
Add missing check for a too-large packet, so we don't blow up trying to
...
allocate a huge buffer; fixes bug 6666.
svn path=/trunk/; revision=40165
2011-12-13 00:57:09 +00:00
Guy Harris
c1f993eef5
Clamp the reported length of a packet at G_MAXINT for now, to avoid
...
crashes due to having no tvbuffs for an epan_dissect_t.
Fixes bug 6663 and its soon-to-be-duplicates.
svn path=/trunk/; revision=40164
2011-12-13 00:44:22 +00:00
Bill Meier
95977fcc8b
Fix a memory leak of a tvb.
...
svn path=/trunk/; revision=40163
2011-12-13 00:02:30 +00:00
Chris Maynard
c3a535a5bf
Add missing </field> for data tree. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3809
...
svn path=/trunk/; revision=40162
2011-12-12 19:24:49 +00:00
Chris Maynard
1153ff7b56
Fix incorrect "pos=0" pdml values. Resolves the issue reported in comment 4 of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2432 and closes the bug.
...
svn path=/trunk/; revision=40161
2011-12-12 18:35:49 +00:00
Anders Broman
ee9a02e12d
From Asmita:
...
Update to csg2 r7
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6661
svn path=/trunk/; revision=40160
2011-12-12 17:42:24 +00:00
Jaap Keuter
b6872d0a3b
From Roy Marples:
...
ICMPv6 DNSSL option can contain padding, which does not represent a malformed option.
svn path=/trunk/; revision=40159
2011-12-12 08:18:18 +00:00
Jaap Keuter
10ca01fb1b
Allow for true error reporing.
...
Move the comment to where it's intended.
svn path=/trunk/; revision=40158
2011-12-12 07:56:45 +00:00
Anders Broman
f5f746f54f
From Mike Morrin:
...
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.
There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.
The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658
svn path=/trunk/; revision=40157
2011-12-12 07:24:57 +00:00
Anders Broman
9d0fa5cfcb
- Change the tree layout to mimic packet-pdcp-lte.c
...
- Add IPv6 static chain dissectoin
- Part of IPv6 dynamic chain dissectoin
svn path=/trunk/; revision=40156
2011-12-12 06:58:37 +00:00
Chris Maynard
da449008f1
Well, until someone has the time to write ct2ext(), just return the content type, which is better than nothing.
...
svn path=/trunk/; revision=40155
2011-12-12 00:35:51 +00:00
Chris Maynard
cbb120e626
If no filename, include the packet number in the generic name. TODO: Implement the ct2ext() function.
...
svn path=/trunk/; revision=40154
2011-12-12 00:27:32 +00:00
Chris Maynard
89a747fb07
If the object to export doesn't have a filename, use a generic "object" name instead. This fixes the crash reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6250
...
svn path=/trunk/; revision=40153
2011-12-11 23:43:03 +00:00
Gerald Combs
371d25162e
[Automatic manuf, services and enterprise-numbers update for 2011-12-11]
...
svn path=/trunk/; revision=40150
2011-12-11 15:03:25 +00:00
Anders Broman
58221afc41
Fix a couple of warnings.
...
svn path=/trunk/; revision=40149
2011-12-10 13:18:45 +00:00
Anders Broman
86117b6a9f
607: warning: unused variable 'd'
...
svn path=/trunk/; revision=40148
2011-12-10 13:09:17 +00:00
Anders Broman
8f480def7c
Dissect the whole IR dyn packet in packet-rohc.c
...
svn path=/trunk/; revision=40147
2011-12-10 12:50:05 +00:00
Sake Blok
8d4e40559d
If we know there is a FCS present, don't hand it to the ethernet trailer dissectors, but dissect it on return
...
svn path=/trunk/; revision=40146
2011-12-10 12:28:28 +00:00
Michael Tüxen
08a00ee1da
Update some support libs to newer version.
...
svn path=/trunk/; revision=40145
2011-12-10 09:48:59 +00:00
Guy Harris
baa8f66c73
Clarify some stuff in a comment.
...
Don't call any of the heuristic trailer dissectors if there's no trailer
to dissect.
svn path=/trunk/; revision=40143
2011-12-10 05:33:48 +00:00
Guy Harris
3fc0968b02
Clean up indentation.
...
Do more length checks, so we reject trailers that have nothing to
dissect.
Test for the trailer length being >= 8, rather than for having the 0x08
bit set (they amount to the same thing, as the trailer length is <= 14,
and >= 8 is what we really want if we're checking whether there's a
timestamp).
svn path=/trunk/; revision=40142
2011-12-10 05:29:09 +00:00
Jaap Keuter
d2f9204568
From Tilghman Lesher:
...
Some commands and IEs from the current release of Asterisk are missing from the
IAX protocol dissector. This patch provides them.
svn path=/trunk/; revision=40141
2011-12-09 23:14:14 +00:00
Jaap Keuter
caa30d0c3d
From Thomas Dreibholz:
...
ASCONF and ASCONF_ACK chunks have a "Sequence Number" field (RFC 5061, 4.1.1
and 4.1.2). The dissector wrongly calls it "Serial number". The attached patch
fixes this issue.
svn path=/trunk/; revision=40140
2011-12-09 22:56:25 +00:00
Jaap Keuter
edcc7668ca
From Nikitha Malgi:
...
Implementing extensions to Wireshark to support TRILL payloads.
svn path=/trunk/; revision=40139
2011-12-09 22:05:04 +00:00
Guy Harris
e42d0d35d8
Referring to pcap_version[] doesn't do what you want on at least some
...
UN*Xes (Fedora 16 and probably other Linux distributions, probably at
least some if not all other ELF-based systems, and perhaps also Mac OS
X), and causes problems if pcap_version[] has a different length in the
libpcap with which the executable was built and the libpcap with which
it's run, so we avoid using it for now.
svn path=/trunk/; revision=40138
2011-12-09 21:15:48 +00:00
Guy Harris
f70480894c
Get rid of unused variable.
...
Fix a comparison.
svn path=/trunk/; revision=40137
2011-12-09 20:28:12 +00:00
Chris Maynard
36074c9828
Export all data sources of a frame to a C array. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4988
...
svn path=/trunk/; revision=40136
2011-12-09 19:44:28 +00:00
Anders Broman
08ca01b2a4
Dissect the whole IR packet in packet-rohc.c
...
svn path=/trunk/; revision=40135
2011-12-09 18:58:26 +00:00
Anders Broman
d5ebe40eaf
Update to 3GPP TS 36.413 V10.3.0 (2011-09)
...
svn path=/trunk/; revision=40134
2011-12-09 18:55:45 +00:00
Alexis La Goutte
da4a280a50
From report of Arasch Honarbacht via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6649
...
ZigBee ZCL Dissector reports invalid status
The status code 0x8d contained in an attriute status record in a configure reporting response frame is incorrectly displayed as "Write only" (where WRITE_ONLY = 0x8f). According to the ZigBee Cluster Library Specification, Document 075123r03ZB, April 26, 2010 a status of 0x8d should display as "INVALID_DATA_TYPE"
From me :
Fix this issue (Wrong value define) based on Specs available in ZigBee.org
svn path=/trunk/; revision=40133
2011-12-09 17:00:28 +00:00
Alexis La Goutte
9936838ce3
From beelzebutt via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6597
...
Mesh Peering Management reason code field interpreted as status code
The Mesh Peering Management tag displays a status code instead of a reason code
svn path=/trunk/; revision=40132
2011-12-09 16:49:06 +00:00
Alexis La Goutte
d5f64d59fb
From Juha Takala via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6654
...
ELCOM dissector needs small fixes for some protocol sub-field texts
svn path=/trunk/; revision=40131
2011-12-09 16:39:18 +00:00
Jaap Keuter
db1ea8f80d
From astramax57:
...
After r38723, some BGP AS_PATH packets were no longer dissected.
svn path=/trunk/; revision=40130
2011-12-09 16:34:02 +00:00
Graham Bloice
19895f31b5
Fixed wrong registration call causing compilation warnings.
...
svn path=/trunk/; revision=40129
2011-12-09 13:31:19 +00:00
Graham Bloice
9770256235
Added dissector registration for udp messages to permit use with a USER_DLT as per request from Chris Bontje
...
svn path=/trunk/; revision=40128
2011-12-09 13:08:50 +00:00
Graham Bloice
62ffea3b32
Added definition and handling for IIN Function Code Not Implemented bit.
...
svn path=/trunk/; revision=40127
2011-12-09 12:42:31 +00:00
Jaap Keuter
597058297e
From Johannes Berg
...
It's tedious to parse the blockack bitmap by hand, showing it in wireshark
directly is much nicer. Attached patch does so, only for compressed BA for now.
From me: made it filterable.
svn path=/trunk/; revision=40126
2011-12-09 08:41:38 +00:00
Anders Broman
1372c03cf3
Use correct offset.
...
svn path=/trunk/; revision=40125
2011-12-09 06:16:07 +00:00
Guy Harris
40efa29acc
Get rid of declarations of undefined routines and definitins of unused
...
routines.
svn path=/trunk/; revision=40124
2011-12-09 03:00:56 +00:00
Guy Harris
3f199f793a
Move the definition of enum rohc_mode into packet-rohc.h.
...
Have packet-pdcp-lte.h include packet-rohc.h to pick up that definition.
Get rid of now-no-longer-necessary includes.
svn path=/trunk/; revision=40123
2011-12-09 02:34:53 +00:00
Guy Harris
9242ce10c3
packet-pdcp-lte.h defines "enum rohc_mode", and packet-rohc.h uses it,
...
so include packet-pdcp-lte.h first.
Get rid of extra definition of "enum rohc_mode".
svn path=/trunk/; revision=40122
2011-12-09 00:59:47 +00:00
Guy Harris
f2f48a2b7e
packet-pdcp-lte.h defines "enum rohc_mode", and packet-rohc.h uses it,
...
so include packet-pdcp-lte.h first.
No extra tokens after #endif, please.
Fix indentation.
svn path=/trunk/; revision=40121
2011-12-09 00:56:48 +00:00
Anders Broman
f6dbd0863e
Start using functions from packet-rohc.c
...
svn path=/trunk/; revision=40120
2011-12-08 21:45:35 +00:00
Anders Broman
27f95726b3
Try to get the container stuff right...
...
svn path=/trunk/; revision=40119
2011-12-08 21:17:03 +00:00