Anders Broman
0e6aa74d54
From Pascal Quantin:
...
NAS EPS] Fix display of Authentication (Failure) Parameter IEs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5704
svn path=/trunk/; revision=36001
2011-02-18 18:40:29 +00:00
Jeff Morriss
34dc101fcb
#if out some (currently) unused functions.
...
svn path=/trunk/; revision=36000
2011-02-18 17:38:46 +00:00
Jaap Keuter
133cbe7581
From Ivan Lawrow:
...
The Final CAP Slot field "wpan.cap" in the Superframe Specification for a
beacon is always displayed as zero.
svn path=/trunk/; revision=35999
2011-02-18 08:02:53 +00:00
Anders Broman
29ddaec6a6
Add more MSG dissection.
...
svn path=/trunk/; revision=35998
2011-02-18 07:00:03 +00:00
Guy Harris
eef8820ab6
Nope, the __declspec(noreturn) didn't suffice - either abort() isn't
...
declared as a noreturn function or declaring except_throw() as a
noreturn function isn't good enough.
svn path=/trunk/; revision=35997
2011-02-18 02:49:46 +00:00
Guy Harris
ed86bc8023
Just for fun, see whether using __declspec(noreturn) on the exception
...
routines is sufficient to convince the Visual Studio code analyzer that
REPORT_DISSECTOR_BUG() never returns. (That would probably require that
abort() be tagged with __declspec(noreturn); let's hope Microsoft did
the right thing there.)
svn path=/trunk/; revision=35996
2011-02-18 01:28:18 +00:00
Gerald Combs
c223ebe718
Fix more Visual C++ analysis errors.
...
svn path=/trunk/; revision=35995
2011-02-18 01:18:44 +00:00
Gerald Combs
cb3aa2b633
Disable Code Analysis warning C6011 for now. Hopefully Clang can pick
...
up the slack.
svn path=/trunk/; revision=35994
2011-02-18 00:33:35 +00:00
Gerald Combs
d60527b94f
Put WS_MSVC_NORETURN back.
...
svn path=/trunk/; revision=35993
2011-02-18 00:08:03 +00:00
Guy Harris
e654a29b1c
config.h is now included, and it defines _WIN32_WINNT.
...
svn path=/trunk/; revision=35992
2011-02-17 23:36:39 +00:00
Gerald Combs
301a4ac9de
Fix compilation on Windows.
...
svn path=/trunk/; revision=35991
2011-02-17 23:35:46 +00:00
Gerald Combs
33819c43c8
Add a hint for Visual C++ to DISSECTOR_ASSERT. Hopefully this will
...
reduce some of the /analyze false positives.
svn path=/trunk/; revision=35990
2011-02-17 23:21:07 +00:00
Guy Harris
b4f663a29b
On Windows, try putting __declspec(noreturn) in front of declarations of
...
routines that don't return. (This requires that some files include
config.h to get WS_MSVC_NORETURN declared properly.)
svn path=/trunk/; revision=35989
2011-02-17 23:11:49 +00:00
Gerald Combs
dae5200002
Fix some Visual C++ analysis warnings.
...
svn path=/trunk/; revision=35988
2011-02-17 23:00:34 +00:00
Guy Harris
0bb81b40d5
Apparently, if the argument to the cd command in an nmake file contains
...
spaces, it needs to be quoted, the fact that, if the argument to a cd
command typed at cmd.exe contains spaces, it *doesn't* need to be quoted
nonwithstanding.
svn path=/trunk/; revision=35987
2011-02-17 21:21:40 +00:00
Gerald Combs
da198b3083
Fix gcc compilation errors.
...
svn path=/trunk/; revision=35986
2011-02-17 20:31:11 +00:00
Gerald Combs
1b0516a27e
Fix various Visual C++ analysis warnings.
...
svn path=/trunk/; revision=35985
2011-02-17 19:43:16 +00:00
Gerald Combs
51e5e75373
Don't allocate a bunch of memory on the stack for strings that will be
...
fed to col_append_fstr; columns have a maximum length of 240 characters
(ITEM_LABEL_LENGTH). Make sure our column text is properly formatted.
svn path=/trunk/; revision=35984
2011-02-17 19:28:30 +00:00
Stephen Fisher
56d74752d1
Fix dead initialization error found by clang:
...
"Value stored to 's' during its initialization is never read"
(it's assigned by a later g_hash_table_lookup call)
svn path=/trunk/; revision=35983
2011-02-17 18:53:35 +00:00
Stephen Fisher
f749439b71
Remove some of the many dead assignments found by clang
...
svn path=/trunk/; revision=35982
2011-02-17 18:45:45 +00:00
Guy Harris
b32b4d08bd
It wasn't complaining about that null pointer reference.
...
svn path=/trunk/; revision=35981
2011-02-17 18:43:38 +00:00
Stig Bjørlykke
17485dbd86
Fixed no_sua_assoc init.
...
svn path=/trunk/; revision=35980
2011-02-17 11:00:54 +00:00
Anders Broman
31f1c264fb
- Introduce association tracking(might not work well with multihoming).
...
- prefix hf variables with sua ( hf_sua...)
svn path=/trunk/; revision=35979
2011-02-17 10:13:05 +00:00
Guy Harris
0b229a4202
Is there an SAL tag that says "this function never returns"?
...
svn path=/trunk/; revision=35978
2011-02-17 09:13:38 +00:00
Guy Harris
d36684f364
Can we reassure Microsoft's static analyzer that 0 <= mask <= 48?
...
svn path=/trunk/; revision=35977
2011-02-17 09:08:11 +00:00
Guy Harris
71b71d920e
Oops, wrong pointer comparison.
...
svn path=/trunk/; revision=35976
2011-02-17 08:39:41 +00:00
Guy Harris
8eb8623b15
OK, let's try a couple more explicit checks against NULL, to see whether
...
that de-confuses Microsoft's code analyzer.
svn path=/trunk/; revision=35975
2011-02-17 08:15:05 +00:00
Jaap Keuter
3884e987b6
From Alexis La Goutte :
...
A patch to add Vendor ID of VIA Client & Remote AP (from Aruba Networks)
Also add ett_ value for rohc, ike & ike2.
svn path=/trunk/; revision=35974
2011-02-17 08:03:48 +00:00
Guy Harris
a12338b76a
Use "XXX != NULL" rather than "XXX" to test for a null pointer; either
...
I'm missing something or the MSVC++ code analyzer doesn't realize that
in
if (XXX)
dereference XXX
will not dereference XXX if it's null - maybe "if (XXX != NULL)" will do
the trick (if so, the code analyzer is buggy, because "if (XXX !=
NULL)", "if (XXX != 0)", and "if (XXX)" mean the exact same thing if XXX
is a pointer-valued expression, really, truly, even if a null pointer
isn't represented as all zero bits or if it's wider than an int).
Clean up indentation.
svn path=/trunk/; revision=35973
2011-02-17 04:35:12 +00:00
Guy Harris
6c6f3528f1
Squelch a warning from the MSVC++ static analyzer (it's worried that
...
GetModuleHandle() could return a null pointer, which is possible,
although if it returns one when handed "kernel32.dll", you have bigger
problems...).
Add some comments.
svn path=/trunk/; revision=35972
2011-02-17 03:02:18 +00:00
Gerald Combs
7b254f46fb
Fix some Visual C++ static analyzer complaints.
...
svn path=/trunk/; revision=35971
2011-02-17 01:11:05 +00:00
Gerald Combs
69901e8eba
Fix Visual C++ code analysis errors.
...
svn path=/trunk/; revision=35970
2011-02-16 22:57:36 +00:00
Stephen Fisher
64666812e9
Change protocol column from "IEEE 802.11" to "802.11" so it fits in
...
the default column width.
svn path=/trunk/; revision=35969
2011-02-16 21:56:28 +00:00
Guy Harris
ae86d3b411
Put the "MCS known information" field into the protocol tree; yes, it's
...
somewhat redundant, as items aren't displayed if they're not known, but
it can make it a little clearer to people who aren't familiar with the
gory details of radiotap (which people just looking at network traffic
might not be).
Clean up some capitalization of field names.
svn path=/trunk/; revision=35968
2011-02-16 21:08:40 +00:00
Gerald Combs
9bdecea98c
Fix compilation on Windows.
...
svn path=/trunk/; revision=35967
2011-02-16 19:26:08 +00:00
Stephen Fisher
82c78778ae
More cleanup toward being able to compile with GTK+ 3.0. Mostly replacing
...
deprecated GtkToolTips with new functions.
svn path=/trunk/; revision=35966
2011-02-16 18:27:00 +00:00
Stig Bjørlykke
d3051fa55d
Generate correct type (FT_OID) for "x420.compression_algorithm_id".
...
I suspect this should have been fixed in asn2wrs...
svn path=/trunk/; revision=35965
2011-02-16 11:04:28 +00:00
Jeff Morriss
edb9220dee
Make swap_mac_addr() take a pointer to a TVB and an offset rather than
...
(generally) a pointer into the TVB.
svn path=/trunk/; revision=35964
2011-02-16 03:36:49 +00:00
Jeff Morriss
45f7c05411
Use tvb_ether_to_str()
...
svn path=/trunk/; revision=35963
2011-02-16 03:30:59 +00:00
Jeff Morriss
feeafce765
Use tvb_ether_to_str().
...
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().
svn path=/trunk/; revision=35962
2011-02-16 03:26:57 +00:00
Jeff Morriss
66b6391c6b
Use tvb_ip_to_str() when it can eliminate a tvb_get_ptr() call.
...
svn path=/trunk/; revision=35961
2011-02-16 03:08:45 +00:00
Jeff Morriss
fb99707fa5
Use tvb_ether_to_str() when it can eliminate a tvb_get_ptr() call.
...
svn path=/trunk/; revision=35960
2011-02-16 03:05:13 +00:00
Jeff Morriss
deabd5ce3a
Use tvb_ether_to_str()
...
svn path=/trunk/; revision=35959
2011-02-16 03:01:19 +00:00
Jeff Morriss
76edd1b8f5
Rename the _to_str() functions in this dissector to tvb_*_to_str() and make
...
the functions take a pointer to a TVB and an offset rather than (generally)
a pointer into a TVB.
Use NULL as the value_ptr in proto_tree_add_bytes_format() since the bytes are
coming straight from the TVB anyway.
Remove unnecessary include file.
svn path=/trunk/; revision=35958
2011-02-16 02:55:58 +00:00
Guy Harris
965ecf3056
Return an error value for the new error return; it "can't happen" (but
...
either the VC++ analyzer can't determine that or it *can*, in fact,
happen). Pick an error code that's not too far off.
svn path=/trunk/; revision=35957
2011-02-16 02:21:31 +00:00
Guy Harris
59f65ab815
Check the index before storing into the array.
...
svn path=/trunk/; revision=35956
2011-02-16 02:16:12 +00:00
Gerald Combs
b2d28ce435
Fix checkapi.
...
svn path=/trunk/; revision=35955
2011-02-16 01:28:29 +00:00
Gerald Combs
8af7080001
Fix errors found by the Visual C++ analyzer.
...
svn path=/trunk/; revision=35954
2011-02-16 00:44:12 +00:00
Gerald Combs
f3bbbce5e3
Fix a buffer overflow found by the Visual C++ analyzer.
...
svn path=/trunk/; revision=35953
2011-02-16 00:42:06 +00:00
Bill Meier
4099dfa603
Update a few comments about the use of LOCAL_CFLAGS, STANDARD_CFLAGS and WARNING_ARE_ERRORS
...
svn path=/trunk/; revision=35952
2011-02-15 16:56:31 +00:00