31b969a4b5
Replace tvb_get_ipv4 / ip_to_str ... by tvb_ip_to_str
...
svn path=/trunk/; revision=47181
2013-01-20 18:32:56 +00:00
26df7b88e5
Fix indent (Replace tabs by space) and add Modelines info
...
svn path=/trunk/; revision=47180
2013-01-20 18:32:47 +00:00
56bddf989b
Use proto_tree_add_item for stun_att_reserved and use FT_BYTES type.
...
svn path=/trunk/; revision=47179
2013-01-20 18:32:37 +00:00
48cef7c61a
Enhance FIX generator
...
* Remove whitespace and tab
* Add information how to generate packet-fix.h (in top of packet-fix.h)
Regenerate packet-fix.h
svn path=/trunk/; revision=47178
2013-01-20 18:32:23 +00:00
1a182e2a79
Dissect ETWS and CMAS notifications
...
svn path=/trunk/; revision=47177
2013-01-20 17:14:24 +00:00
cf4fcaa8b6
snmp dissector did not correctly set length of pdu's of more than 127 bytes. The dissector assumed the ber identifier and length fields were always 2 bytes long, so a pdu length of more than 127 bytes, which requires more than 1 length octet, was incorrectly dissected.
...
svn path=/trunk/; revision=47173
2013-01-20 10:01:34 +00:00
518eee193b
Use epan-scoped memory to clean up another 1Kb+ of valgrind
...
sorta-false-positive leaks.
svn path=/trunk/; revision=47170
2013-01-19 20:14:42 +00:00
1390569a99
Use wmem epan-scoped memory when initializing dcerpc so that it gets freed when
...
we shut down. Cleans up 5Kb worth of valgrind sorta-false-positive leaks.
svn path=/trunk/; revision=47168
2013-01-19 19:36:20 +00:00
f177deead0
Fix for CID 280252.
...
We can be sure we've at least 0 bytes remaining in the TVB.
svn path=/trunk/; revision=47162
2013-01-19 13:06:26 +00:00
a43975ca82
Following r47157, this tries to suppress similar Coverity issues.
...
svn path=/trunk/; revision=47160
2013-01-19 10:54:09 +00:00
69489bc85a
Try and see if we can suppress about half of the Coverity issues.
...
svn path=/trunk/; revision=47157
2013-01-18 23:25:22 +00:00
2a1e61d582
From Kaushal Shah via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8021
...
Experimental and Reserved sub-TLVs from [RFC 3630]
From me: use consistent whitespace
svn path=/trunk/; revision=47155
2013-01-18 22:04:15 +00:00
02bc1028b5
Replace tvb_get_ipv4 / ip_to_str ... by tvb_ip_to_str
...
svn path=/trunk/; revision=47150
2013-01-18 15:52:15 +00:00
46452171c9
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47149
2013-01-18 15:52:05 +00:00
b4cdfdc5f1
Enhance MRCPv2 dissector * Fix indent (Tab => 4 Spaces) and add Modelines info * Replace by string_string * Replace if else if... by switch()
...
svn path=/trunk/; revision=47146
2013-01-18 15:51:33 +00:00
39b51c7c07
Dissect 3GPP PCO option.
...
svn path=/trunk/; revision=47145
2013-01-18 09:49:22 +00:00
d97b358e64
Fix for bug 8212.
...
Disable speed optimization which otherwise cause dissector asserts due to
appending text and setting lengths.
svn path=/trunk/; revision=47136
2013-01-17 22:06:22 +00:00
c6f702432e
Register in the UDP heuristic table rather than the internal one.
...
svn path=/trunk/; revision=47133
2013-01-17 16:10:22 +00:00
71dd7c2fe4
From Hendrik Uhlmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8227 :
...
Electromagnetic Emission Parser parses field Event Id as Entity Id
svn path=/trunk/; revision=47132
2013-01-17 13:20:45 +00:00
4bceaa501a
Remove forbidden C++ style comments
...
svn path=/trunk/; revision=47127
2013-01-16 22:38:42 +00:00
530de5ae97
no need for if (tree)
...
svn path=/trunk/; revision=47125
2013-01-16 21:57:34 +00:00
6ba6ea6533
don't attempt reassembly if more than 1000 consecutive fragments are
...
missing
this fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8222
svn path=/trunk/; revision=47123
2013-01-16 21:51:16 +00:00
e7d64a962f
From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8215 :
...
Several ERF types are incorrectly calling downstream dissectors under the erf_tree instead of under the top level tree
svn path=/trunk/; revision=47122
2013-01-16 21:47:28 +00:00
72a00dc259
Add a cast to shut up MSVC.
...
svn path=/trunk/; revision=47120
2013-01-16 18:33:34 +00:00
3a64f93a00
From Hendrik Uhlmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8185
...
Support for Underwater Acoustic PDUs in packet-dis.c
svn path=/trunk/; revision=47119
2013-01-16 17:27:03 +00:00
52699bd342
Bugfix version number in EtherIP dissector + general cleanup. Bug 8211 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8211 )
...
#BACKPORT
svn path=/trunk/; revision=47112
2013-01-16 13:27:23 +00:00
b1ac6585bc
Don't run past the end of a fragment array, either in the loop or by putting a
...
useless sentinel in.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8213
svn path=/trunk/; revision=47098
2013-01-15 16:51:55 +00:00
1a93ee3345
Based on http://ask.wireshark.org/questions/17661/tcap-decoding-bug :
...
Register the Camel dissector for SSN 146 instead of (GSM MAP's) SSN 6-9.
Looks like the 6-9 list was a carryover from when this dissector was created
based on the GSM MAP dissector.
svn path=/trunk/; revision=47097
2013-01-15 16:44:02 +00:00
e00af44a36
extend the iso7816 dissector
...
link request apdus to response apdus
dissect parameters p1 and p2 for some messages
svn path=/trunk/; revision=47096
2013-01-15 16:41:03 +00:00
5a74d61822
Add modelines.
...
svn path=/trunk/; revision=47095
2013-01-15 16:37:29 +00:00
ad78db491a
Fix Coverity CID 732304: Missing break in switch.
...
svn path=/trunk/; revision=47077
2013-01-14 19:23:26 +00:00
f2dd9bc0d2
Avoid any possibility of an infinte loop. Fixes Coverity CID 739883: Infinite loop. (Minor whitespace cleanup also.)
...
svn path=/trunk/; revision=47076
2013-01-14 19:14:51 +00:00
b3bc6cf28f
Fix Coverity CID 741992: Unused pointer value.
...
svn path=/trunk/; revision=47073
2013-01-14 18:31:04 +00:00
1891adc28e
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8208 :
...
Display ECI and LAC in decimal and fix highlighting of CGI, SAI, RAI, TAI, ECGI and LAI fields
svn path=/trunk/; revision=47071
2013-01-14 18:29:27 +00:00
110509a77f
Fixed Coverity CID 762008: Structurally dead code.
...
svn path=/trunk/; revision=47066
2013-01-14 15:49:30 +00:00
b89380dd74
Fix CID 966603: Unused pointer value.
...
svn path=/trunk/; revision=47062
2013-01-14 15:13:21 +00:00
c56910aa70
Fix CID 967205: Unused pointer value.
...
svn path=/trunk/; revision=47061
2013-01-14 15:09:12 +00:00
ccbff26e80
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8196 :
...
Add dissection of IPv4v6 type to End User Address IE
svn path=/trunk/; revision=47047
2013-01-13 11:04:46 +00:00
a9fb54c677
bugfix nested loop that wasn't breaking out of the main loop when subloop really wanted it to. Bug 8198 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8198 )
...
svn path=/trunk/; revision=47046
2013-01-13 02:58:42 +00:00
d3e4d6c972
Upgrade RRC dissector to v11.4.0
...
svn path=/trunk/; revision=47041
2013-01-11 23:25:30 +00:00
b8af5b44d1
#if 0 out some variables that are used only in now-#if 0'ed code.
...
svn path=/trunk/; revision=47040
2013-01-11 21:20:57 +00:00
9f387eddbb
Try to deduce NAS EPS Detach Request direction from message size
...
svn path=/trunk/; revision=47039
2013-01-11 20:54:04 +00:00
ef9384ff60
Fix uninitialized variable.
...
svn path=/trunk/; revision=47037
2013-01-11 20:25:05 +00:00
d4cf9ce69a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8193 :
...
Add dissection of Dual Address Bearer Flag bit in Common Flags IE
svn path=/trunk/; revision=47036
2013-01-11 20:18:32 +00:00
ebdc5f8d55
Get rid of unused variable.
...
svn path=/trunk/; revision=47035
2013-01-11 20:08:43 +00:00
1ca9d5c2b3
Upgrade LPP dissector to v11.1.0 and modify extract_asn1_from_spec.pl to automatically get ASN.1 from spec
...
svn path=/trunk/; revision=47034
2013-01-11 19:31:15 +00:00
660e028212
Add support for expanded Gigamon Trailer format
...
from Sandeep Dahiya, bug 8191 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8191 )
svn path=/trunk/; revision=47033
2013-01-11 19:20:39 +00:00
2d2198962a
replace g_warning with expert_add_info_format()
...
See bug 8155 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8155 )
svn path=/trunk/; revision=47031
2013-01-11 15:57:11 +00:00
8326a92942
Add RFC 5460 - DHCPv6 Bulk Leasequery
...
Bug 8172 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8172 )
svn path=/trunk/; revision=47028
2013-01-11 14:41:17 +00:00
614441f9e5
#if 0 out unused code
...
svn path=/trunk/; revision=47017
2013-01-10 12:42:07 +00:00
84a8c1d83a
From an.huang:
...
(1) support for optional attribute in Sample Value:
datSet (0x81),
refrTm (0x84),
smpRate (0x86),
smpMod (0x88). New attribute in 9-2 Ed2
(2) Data (0x87) decoded as PhsMeas in 9-2 LE(Lite Edition) recommemdation is removed, now the data is decoded as simply OctString, just as 9-2, further details should refer to the data set definition and Table 14 in Ed1 / Table 15 in Ed2 Encoding for the basic data types;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5696
svn path=/trunk/; revision=47016
2013-01-10 12:13:16 +00:00
2d44d2e05c
From Alton MacDonald:
...
A TLV can be larger that the MIH payload. In this case the packet should be fragmented and controlled with the help of two fields in the MIH header. The attached patch checks these fields and dissects the TLVs if the MIH payload is not fragmented.
Additionally, if a TLV is detected larger than the payload size it is marked as a fragmented TLV and not dissected. This would be the case if the previously mentioned fields were not set correctly as their use under this scenario is not explicitly defined in the 802.21 standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
svn path=/trunk/; revision=47014
2013-01-10 07:36:32 +00:00
84a94842a8
From "schlephorst":
...
BACnet dissect new tags in NotificationParameters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8181
svn path=/trunk/; revision=47011
2013-01-10 06:48:10 +00:00
c553ca5c5e
From "schlephorst":
...
BACnet dissect new tags in EventParameters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8181
svn path=/trunk/; revision=47010
2013-01-10 06:42:15 +00:00
4e9a407c6f
remove unnecessary NULL checks
...
svn path=/trunk/; revision=47006
2013-01-09 21:57:08 +00:00
9cdf3803a9
From David Bergeron:Added unknown attributes for STUN from RFC3489 that are now deprecated but does'nt appear with classicstun. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8179
...
svn path=/trunk/; revision=47002
2013-01-09 05:13:20 +00:00
c872b1258c
Dissect CDMA2000 system time
...
svn path=/trunk/; revision=47001
2013-01-08 22:29:38 +00:00
30fdbd6da6
revert r46739
...
call fragment_add() before fragment_set_tot_len()
(the latter has no effect if no fragments are present, so we don't set
the total length correctly when it's in the first fragment)
svn path=/trunk/; revision=47000
2013-01-08 22:24:42 +00:00
697514cd35
2012->2013
...
svn path=/trunk/; revision=46998
2013-01-08 21:51:01 +00:00
898dfde383
bring up a warning if an APDU's length field does not match the number
...
of payload bytes
svn path=/trunk/; revision=46997
2013-01-08 21:44:12 +00:00
433d9c198d
Only the private extension IE value part should go in the tvb.
...
svn path=/trunk/; revision=46996
2013-01-08 09:57:10 +00:00
ab9129add9
Small updates to the SEL Fast Message dissector.
...
From Chris Bontje via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8170
svn path=/trunk/; revision=46995
2013-01-07 23:53:56 +00:00
794183609d
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8164 :
...
Clarify content of StructureSize field
svn path=/trunk/; revision=46994
2013-01-07 23:08:25 +00:00
74e5c710cb
Re-fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8169 in a way that
...
is also (hopefully) valid for 32-bit platforms.
svn path=/trunk/; revision=46993
2013-01-07 22:12:38 +00:00
952ccb4b83
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8168 :
...
Detect properly the EMM Service Request message
svn path=/trunk/; revision=46991
2013-01-07 21:37:55 +00:00
aa6929d0cd
Fix potential (but very unlikely) overflow and infinite loop.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8169
svn path=/trunk/; revision=46989
2013-01-07 20:24:19 +00:00
28808df71b
Add mode-lines.
...
svn path=/trunk/; revision=46988
2013-01-07 20:00:38 +00:00
ab7f4395d7
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46967
2013-01-06 14:50:52 +00:00
b3db35e7a6
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46966
2013-01-06 14:50:44 +00:00
1cd2e3cd1b
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46965
2013-01-06 14:50:35 +00:00
4d353242e8
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46964
2013-01-06 14:50:27 +00:00
0c22e572c6
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46963
2013-01-06 14:50:18 +00:00
3bf44b5a27
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46962
2013-01-06 14:50:06 +00:00
2e3564d69e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46961
2013-01-06 14:49:58 +00:00
bfa7d1a3f1
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=46960
2013-01-06 14:49:48 +00:00
ca189246fe
Upgrade LTE RRC dissector to v11.2.0
...
svn path=/trunk/; revision=46959
2013-01-06 09:56:24 +00:00
33981700b5
From Guus Gerrits via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8148
...
Add some additional formatting to the mmhdr subtree (e.g. selecting 5
mmheaderbytes with mmver!=0, Added a subtree for the Fragmentation Info)
svn path=/trunk/; revision=46956
2013-01-05 23:14:50 +00:00
d131bc1077
From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8089
...
Dissector for the SEL (Schweitzer Engineering Labs) Fast Message protocol.
From me:
- use wmem instead of glib to not leak memory
- simplify port preference
- remove unneeded initializers
- modelines
- Id tag
svn path=/trunk/; revision=46949
2013-01-05 14:19:15 +00:00
b1143f60b3
Regenerate ANSI MAP dissector
...
svn path=/trunk/; revision=46948
2013-01-05 13:53:27 +00:00
5d6a6b4652
Fix regression from upgrade FIX 5.0 (Revision 46944)
...
../../../epan/dissectors/packet-fix.h:1450:10: error: multi-character character constant [-Werror=multichar]
../../../epan/dissectors/packet-fix.h:1451:10: error: multi-character character constant [-Werror=multichar]
[...]
When FIX field type is MULTIPLESTRINGVALUE use string_string (not value_string)
And regenerated packet-fix.h
svn path=/trunk/; revision=46947
2013-01-05 10:12:44 +00:00
bf8fce3a00
Upgrade to FIX 5.0 fields
...
Bug 7853 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7853 )
FIX.xml is now based on FIX50SP2.xml with some fill in from 4x xml files (as determined by diff between "old" and "new" packet-fix.h)
Included all FIX 5.0 field files from http://sourceforge.net/projects/quickfix/files/
svn path=/trunk/; revision=46944
2013-01-05 04:06:31 +00:00
7d8ab07431
Fix some errors found by fix-encoding-args.pl script
...
svn path=/trunk/; revision=46933
2013-01-04 17:35:46 +00:00
86d690880f
replace "unsigned" datatype with "guint". Some mpeg files needed "unsigned int" instead.
...
bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825 )
svn path=/trunk/; revision=46928
2013-01-04 05:22:43 +00:00
d36b4c8525
Fix a (false) could-be-used-uninitialized warning.
...
Fix up indentation (looks like "4 space tabs").
svn path=/trunk/; revision=46927
2013-01-04 02:28:46 +00:00
6ea36c51c3
Add casts to make it build on win64
...
svn path=/trunk/; revision=46925
2013-01-03 23:24:47 +00:00
6fd81d4994
From Zeljko Ancimer:
...
New dissector for Media Resource Control Protocol Version 2 (MRCPv2).
svn path=/trunk/; revision=46922
2013-01-03 21:42:59 +00:00
46935dbab4
USBHUB: Add useful details to INFO column, bug 8161 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8161 )
...
From Steve Magnani
svn path=/trunk/; revision=46919
2013-01-03 18:08:50 +00:00
69b38c579f
From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8157 USBHUB: Add dissection of GetPortStatus responses
...
Most USBHUB responses are not dissected. Add support for GetPortStatus.
svn path=/trunk/; revision=46913
2013-01-03 11:37:05 +00:00
0292371cf4
bitmask patch for MIH dissector that makes 64-bit bitmasks only use 32-bits since proto_tree_add_bitmask only supports 32 bits and there are no definitions in the MIH standard that require more than 32 bits. This addresses part of bug 8155 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8155 )
...
**
ERROR:proto.c:7240:proto_item_add_bitmask_tree: code should not be reached
svn path=/trunk/; revision=46895
2013-01-02 16:14:30 +00:00
37d19a1202
Add heuristic for USB MassStorage dissector to be dissected by USB. Bug 8131 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8131 )
...
svn path=/trunk/; revision=46877
2012-12-31 20:12:45 +00:00
58575f394f
From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8148 :
...
Fix dissection of HomePlug AV 1.1 frames with fragmentation information
From me: indentation fixes
svn path=/trunk/; revision=46871
2012-12-31 13:39:04 +00:00
54cb9e70ab
Use tvb_bcd_dig_to_ep_str
...
svn path=/trunk/; revision=46858
2012-12-30 11:10:35 +00:00
be1ff84f48
From Katrina Zhang:Pretify dissection if a dissector exists for the private extension
...
svn path=/trunk/; revision=46857
2012-12-30 09:35:27 +00:00
8b7f8d4c08
Move 3 ASN1 dissectors to 'clean' group; move 1 PIDL dissector to 'dirty' group.
...
svn path=/trunk/; revision=46855
2012-12-30 00:53:47 +00:00
45a77360ea
Rename tcp.data -> tcp.segment_data and add a description field.
...
Should clear up the confusion from
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8084
svn path=/trunk/; revision=46843
2012-12-29 18:08:11 +00:00
0b20f855f0
Upgrade NAS disssectors to v11.5.0
...
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
c7dd6480e4
Minor fix when building with VS2012 (VC11):
...
Prevents warning:
cl : Command line warning D9002 : ignoring unknown option '/Zd'
svn path=/trunk/; revision=46832
2012-12-28 22:13:05 +00:00
fee2b8b2b9
Tab => Spaces
...
svn path=/trunk/; revision=46826
2012-12-28 14:38:19 +00:00
c541aa4ab5
Add initial support for
...
http://tools.ietf.org/html/draft-jesup-rtcweb-data-protocol-03
I'll improve the dissector as the ID evolves...
svn path=/trunk/; revision=46809
2012-12-27 17:11:24 +00:00
93218a7c76
From Pawel Dziepak:dissect_rpc_array causes assertion fault when array is empty. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8145
...
svn path=/trunk/; revision=46805
2012-12-27 12:55:05 +00:00
Alexis La Goutte