(1) support for optional attribute in Sample Value:
datSet (0x81),
refrTm (0x84),
smpRate (0x86),
smpMod (0x88). New attribute in 9-2 Ed2
(2) Data (0x87) decoded as PhsMeas in 9-2 LE(Lite Edition) recommemdation is removed, now the data is decoded as simply OctString, just as 9-2, further details should refer to the data set definition and Table 14 in Ed1 / Table 15 in Ed2 Encoding for the basic data types;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5696
svn path=/trunk/; revision=47016
A TLV can be larger that the MIH payload. In this case the packet should be fragmented and controlled with the help of two fields in the MIH header. The attached patch checks these fields and dissects the TLVs if the MIH payload is not fragmented.
Additionally, if a TLV is detected larger than the payload size it is marked as a fragmented TLV and not dissected. This would be the case if the previously mentioned fields were not set correctly as their use under this scenario is not explicitly defined in the 802.21 standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
svn path=/trunk/; revision=47014
call fragment_add() before fragment_set_tot_len()
(the latter has no effect if no fragments are present, so we don't set
the total length correctly when it's in the first fragment)
svn path=/trunk/; revision=47000
Add some additional formatting to the mmhdr subtree (e.g. selecting 5
mmheaderbytes with mmver!=0, Added a subtree for the Fragmentation Info)
svn path=/trunk/; revision=46956
Dissector for the SEL (Schweitzer Engineering Labs) Fast Message protocol.
From me:
- use wmem instead of glib to not leak memory
- simplify port preference
- remove unneeded initializers
- modelines
- Id tag
svn path=/trunk/; revision=46949
../../../epan/dissectors/packet-fix.h:1450:10: error: multi-character character constant [-Werror=multichar]
../../../epan/dissectors/packet-fix.h:1451:10: error: multi-character character constant [-Werror=multichar]
[...]
When FIX field type is MULTIPLESTRINGVALUE use string_string (not value_string)
And regenerated packet-fix.h
svn path=/trunk/; revision=46947
64-bit value to 32 bits" warnings on 32-bit compilers. According to
6.1.3.3 "Enumeration constants" of C90, "An identifier declared as an
enumeration constant has type int", so there may be signed vs. unsigned
issues.
svn path=/trunk/; revision=46772
"const char *", as it is now expected to be. Regenerate the dissectors.
Update the URL for OmniOrb.
In README.parlay, use idl2wrs in the sample command.
svn path=/trunk/; revision=46765
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
must be filled in - even if we don't happen to have dissectors for
particular message types. Just put NULL in there, so we don't index
past the end of the array, grab a random location in memory's contents
as a function pointer, and crash when we call through that pointer.
svn path=/trunk/; revision=46747
Make a loop counter a full-width integer, just to be sure.
Do *NOT* assume that pinfo->private_data is non-null; I have at least
one capture where it is null when dissect_bthci_evt_command_complete()
is captured.
svn path=/trunk/; revision=46743
rather than as a single field. If bits other than the two defined bits
are set in the first byte of the packet, don't dissect UDP packets as
Vines FRP, so that other dissectors get a chance to look at the packet.
svn path=/trunk/; revision=46732
The structure of both the Config Methods and Selected Registrar Config Methods are the same.
Display filters such as "wps.config_methods.pushbutton", "wps.config_methods.display", etc are available for the different methods in the Config methods whereas the display filters for the elements in the Selected Registrar Config methods are found to be the same as the Config method Display filters.
From me :
add new filter for selected_registrar config method bitmask (and also permitted config method)
svn path=/trunk/; revision=46725
This patch provides
i) support for Shared Use of Experimental TCP Options (draft-ietf-tcpm-experimental-options-03)
ii) support for TCP Fast Open (draft-ietf-tcpm-fastopen-02).
A new 'TFO=R' string is appended at the column info in case a client sends a SYN packet with a Fast Open Cookie Request. Moreover, if the server responds with a SYN-ACK containing a Fast Open Cookie option a 'TFO=C' is shown (as well as in any subsequent client attempt to send SYN + DATA).
tcp.options.tfo display filter can be used in order to easily select the complete TFO three-way handshake.
Chrome (and I think also Firefox) has support for client-side TFO. Linux 3.7 got both client and server-side support.
svn path=/trunk/; revision=46723
now that tvb_get_ephemeral_unicode_string() throws an exception for
invalid length parameters, there's no point in doing an explicit check
beforehand
(when I added the check, there were many places that I missed)
svn path=/trunk/; revision=46707
Minor patch just adding the newer AR7400/INT7400 with dev_id==4 for decoding
in the Homeplug AV "Get Device/SW Version Confirm (A001)" response.
svn path=/trunk/; revision=46695
and a couple of SET_ADDRESS()s.
Use proto_tree_add_item() instead of proto_tree_add_ether() called with a
pointer into the TVB.
Leave a comment for a place where a bunch of code in several case statements
could probably be collapsed into much less code.
svn path=/trunk/; revision=46682
LLP64 environments such as Windows.
Cast the result of a modulus op that causes the result to fit into an
int to int, to suppress implicit 64-bit-to-32-bit conversion warnings.
svn path=/trunk/; revision=46661
so make the constants single-precision, so we don't end up with warnings
about double-precision values being assigned to single-precision
variables.
svn path=/trunk/; revision=46658
counts by trying to iterate all over the items (and, presumably, failing
when we go past the end of the packet).
When assigning to the loop count, cast the value down, to avoid implicit
64-bit-to-32-bit conversion warnings.
Write those loops as for loops - it makes it a bit clearer what's going
on.
svn path=/trunk/; revision=46657
Use SET_ADDRESS in some dissectors that weren't using it (so that the hf field
is correctly initialized).
Introduce a COPY_ADDRESS_SHALLOW (which copies an address without copying the
contents of the data field).
svn path=/trunk/; revision=46602
(or at least the complaints from Valgrind; I couldn't reproduce the crash).
What part of:
~~~
* If you're thinking of using tvb_get_ptr, STOP WHAT YOU ARE DOING
* IMMEDIATELY. Go take a break. Consider that tvb_get_ptr hands you
* a raw, unprotected pointer that you can easily use to create a
* security vulnerability or otherwise crash Wireshark. Then consider
* that you can probably find a function elsewhere in this file that
* does exactly what you want in a much more safe and robust manner.
~~~
did someone not read?
Use tvb_get_ephemeral_stringz() instead of adding (apparently not sufficiently
checked!) offsets to the result of tvb_get_ptr() and assuming that the result
is a) in bounds and b) a NULL-terminated string.
svn path=/trunk/; revision=46577
Add SSL segment data and SSL reassmebled data fields and improve readability of the hex/ASCII data blocks written to the SSL debug log
svn path=/trunk/; revision=46572
not going to put anything into it. And don't try to finalize the composite
if we didn't create it or put anything in it.
svn path=/trunk/; revision=46569
[MS-FSCC].pdf section 2.4.15 gives us the correct format of the structure currently know and file_info_0f.
The unknown byte is actually the second byte of the EA Value Len.
svn path=/trunk/; revision=46562
instead of storing the requests in an se_tree (keyed by hop-by-hop-id),
store an se_tree which is itself keyed by frame number. When looking for
a matching request, first find the tree of pdus (by hop-by-hop-id) and then
look for the largest frame number less than or equal to the answer's frame
number. Also verify that the end-to-end-id matches.
Move the conversation structure out of packet-diameter.h: it's only used in
packet-diameter.c
svn path=/trunk/; revision=46553
Allow Raw Data dissector to dissect TCP packets with Riverbed Transparency options if sport dissector (found only in Riverbed) is not found.
#BACKPORT
svn path=/trunk/; revision=46544
packet-h248_3gpp.c: In function ‘dissect_3gcsd_plmnbc’:
packet-h248_3gpp.c:168: error: cast to pointer from integer of different size
make[5]: *** [libdissectors_la-packet-h248_3gpp.lo] Error 1
I guess the last parameter of dissect_3gcsd_plmnbc() is a pointer to a
boolean variable. Call it implicit_param, not implicit, as there's
already a global variable 'implicit'.
Feel free to correct the fix if I got it wrong.
svn path=/trunk/; revision=46534
- Fix instance of offset changed under 'if (tree)' and used after 'if (tree)';
- Create/use some extended value strings;
- #if 0 an unused value_string array;
- Localize some variables & remove some uneeded initializers;
- Fix some whitespace & long lines.
svn path=/trunk/; revision=46516
Cause、RAB Context、PDU Numbers in packet-gtpv2.c are not dissected correctly. fixed in the patch.
The patch did not apply cleanly to trunk, applied by hand.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8079
svn path=/trunk/; revision=46497
Adds new values and fixes an incorrect value in the previous value_string array.
Note: names used as specified (with capitalization) in the document.
(Previously all the names in the value_string array were lower case).
Also: rename the value_string array to have a less generic name.
svn path=/trunk/; revision=46490