Many packages needed to build Wireshark are missing from pkg in
FreeBSD 11.4. They're only available in ports. That doesn't mean
that Wireshark is not compilable on FreeBSD 11.4, but that it
requires a long build from ports that is unlikely compatible with
Cirrus' CI (and its timeouts).
There is no need to remove the FCS at the end of the reassembled payload since FCS bytes have already been removed from the fragments. Also, the way it was removed in the code was wrong: it set the reported length of the reassembled payload to the reported length of the last fragment only.
Revert "ieee802.11: Make sure we do not include the FCS in the next_tvb."
This reverts commit 094297ec77.
In uninstall_autoconf, when running uninstall subfunctions, pass the
arguments to the subfunctions.
When uninstalling Ninja, remove the "we've finished installing this"
indicator file.
Get rid of a debugging "set +x".
Make sure NSView.wantsLayer is true by setting QT_MAC_WANTS_LAYER=1 at
startup if we're running on Big Sur and we were built with a version of
Qt susceptible to QTBUG-87014. Fixes#17075?
Two interlocking problems cause the dissection of FC to fail in some cases,
as shown in the capture of the related issue.
The FC dissector assumes that ETHERTYPE_UNK in the data structure passed
to it is coming from the MDS header dissector only, and thus that header
sizes have to be taken into account. This is not / no longer the case.
It always passes down ETHERTYPE_FCFT. Therefore the MDS header size
checking does not apply to ETHERTYP_UNK, so is removed as condition.
The other FC related dissectors were forced to setup a data structure to
pass to FC for it to handle that part of the frame. Because these weren't
related to ethernet, these lazily set the ethertype field in the data
structure to 0. This unfortunately matches ETHERTYPE_UNK, triggering the
MDS header size checking in FC, leading to this issue. With the first
problem resolved, now make it explicit that unknown ethertype is indicated
by ETHERTYPE_UNK, not '0'.
Addresses primary part of issue #17084
Improve display of Integer value (use standard, no alignement)
Reduce un-needed space in table display for Prm.
Use, where possible, 'xxx: Text (decimal)' display for Integer value
Every press of Play Stream or Prepare Filter caused incorrect increasing
of Packets count and added Comments.
The reason was that callinfo statistics were not clear before recap
therefore all new values were added to exiting ones.
Patch solves it.
In SCTP reassembly, dependent frames were only marked on the second pass,
but tshark requires them to be marked on the first pass in order to write
them with -w <FILE>. This fix marks the dependencies on the first pass.
Fixes#16773.
Dario Lombardo
Vadim Yanitskiy