Commit Graph

79173 Commits

Author SHA1 Message Date
Moshe Kaplan 0120c12c5d ringbuffer.c: avoid leaking gzFile handle
Avoid leaking the gzFile handle when g_malloc()
fails. This fixes coverity issue 1468698.
2020-11-27 14:58:29 +00:00
Stig Bjørlykke 7f4ae9a229 Qt: Load interfaces on profile change if settings have changed
Load interfaces on profile change if capture_no_interface_load or
capture_no_extcap preference have changed.
2020-11-27 11:34:24 +00:00
Huang Qiangxiong 4190ddfb7c Protobuf: add 'preload_protos' preference
If check the 'preload_protos' on, the .proto files will be loaded
on startup. That make tshark can use 'protobuf fields as wireshark
fields' feature by providing protobuf field name in display filter
(-Y option).

close #17036
2020-11-26 20:13:11 +00:00
John Thacker 358377bd43 gsm_sms: Get address string with tvb_get_string_enc
Get address fields in GSM 03.40 (GSM SMS TPDU) with tvb_get_string_enc()
using the new ENC_KEYPAD_ABC_TBCD encoding instead of a local implementation.
2020-11-26 19:50:15 +00:00
Pascal Quantin 98c21601f8 NAS 5GS: add a fence to info column before calling EAP dissector 2020-11-26 19:42:27 +01:00
Pascal Quantin dbb17b5233 JSON: fix a typo introduced in g2baaab6c 2020-11-26 15:14:24 +01:00
Anders Broman 2baaab6c01 json: Make it possible to filter and sub dissect json keys and data. 2020-11-26 13:10:08 +01:00
Anders Broman e782fb0200 GTPv2: Export dissect_gtpv2_ie_common() 2020-11-26 06:16:49 +00:00
Guy Harris 8e2815bfc0 Don't assume macOS version numbers are of the form 10.N.
Big Sur goes to 11, and it appears that next year's (San Juan Capistrano?)
will go to 12, and so on.

Split version numbers into major and minor, and do version-number
comparison (alas, whilst CMake has that built in, the Bourne shell
doesn't, and neither does the Bourne-again shell).

This should fix issue #17043.
2020-11-25 18:23:28 -08:00
Martin Mathieson de99214e43 DCT2000: misc changes
- For NR/LTE RRC messages, add cellGroup Id
- NRUP messages appearing as hex in comments passed to dissector
2020-11-26 00:56:36 +00:00
Alexis La Goutte c4343ed60b IPv6: fix clang warning 2020-11-25 22:31:46 +00:00
Anders Broman b26512e33a tvb: Add base64_tvb_to_new_tvb() 2020-11-25 22:09:06 +00:00
Guy Harris f1ab1f0b5b Put the XXX_pipe_open_live() calls after the file type determination.
That way, there's only one pcap_pipe_open_live() call, as was the case
in the past.
2020-11-25 12:43:00 -08:00
Guy Harris eb02336e28 Update a comment, and add some comments. 2020-11-25 11:58:26 -08:00
Guy Harris 884bae3317 Fix previous change to use WSAGetLastError() only on sockets.
On Windows, we do pipe I/O in a separate thread, as we can't do select()
- or even WaitForMultipleObjects() - on pipes, so
cap_pipe_read_data_bytes() is used only on sockets.

Update a comment.
2020-11-25 11:25:10 -08:00
Guy Harris 84bdd086cd Make sure a pcapng block's length is a multiple of 4.
We check for that when *writing* the block, but the error message for
that is not at all clear; check for it after we've read the block total
length, and report it with a better error message.

Clean up some other error messages while we're at it.
2020-11-25 10:41:05 -08:00
Jaap Keuter 7a12a663c3 Refine issue templates even more
Update the templates to help users even more to create first-time-right
issue reports.
2020-11-25 09:43:18 +00:00
Guy Harris b904fc69ab Have capture_loop_init_pcapng_output() report an error code.
It *can* get errors with error codes, so it should pass them to its
caller so it can report the error correctly.
2020-11-25 00:43:43 -08:00
Guy Harris 8c4d0bb131 Expand a comment to note that pcapng_read_shb() does a synchronous read. 2020-11-25 08:08:24 +00:00
Pascal Quantin fb2414ae6d Qt: fix some Qt 5.15.2 deprecation warnings 2020-11-25 07:23:21 +00:00
John Thacker 15d315c2ae GLib: Bump requirement 2.32 -> 2.36 2020-11-25 06:25:38 +00:00
Anders Broman 2999173126 GTPv2: Dissect the content of F-container type 3. 2020-11-24 16:41:50 +01:00
Đorđije Manojlović 8c4d420fb3 Extend IEC 61850 GOOSE dissector to support IEC 61850 R-GOOSE protocol
R-GOOSE (Routable GOOSE) protocol is GOOSE protocol embedded into
RFC 1240: OSI Connectionless Transport over UDP.
2020-11-24 13:43:53 +00:00
Pascal Quantin 74c0b2134b S1AP: fix decoding of inter eNB transparent container from NGAP 2020-11-24 14:05:21 +01:00
Pascal Quantin 063af96df7 NAS 5GS: add dissection of R16 UPDP messages 2020-11-23 23:55:04 +01:00
Pascal Quantin 9fdc3fb3ce NAS 5GS: request type field is 3 bits long 2020-11-23 22:11:13 +00:00
Alexis La Goutte f71458c601 proto(.h): fix -Wdocumentation
proto.h:2373:9: warning: parameter 'fi' not found in the function declaration [-Wdocumentation]
2020-11-23 20:06:49 +00:00
Pascal Quantin d75fef88fb NAS 5GS: upgrade remaining 5GSM IEs to v16.6.0
- IP header compression configuration
- DS-TT Ethernet port MAC address
- UE-DS-TT residence time
- Port management information container
- Ethernet header compression configuration
2020-11-23 19:22:58 +01:00
Pascal Quantin 533f21edfd NAS 5GS: upgrade some 5GSM IEs dissection to v16.6.0
- 5GSM capability
- 5GSM cause
- Integrity protection maximum data rate
- Mapped EPS bearer contexts
- PDU address
- Re-attempt indicator
- 5GSM network feature support
- Serving PLMN rate control
- 5GSM congestion re-attempt indicator
- ATSSS container
- Control plane only indication
2020-11-23 18:38:45 +01:00
Uli Heilmeier 0fad19b7d9 tshark: set cf values when quiet and tempfile
When there is no do_dissection cf is missing some variables
for cf_close() call. Therefore we have to set them explicitly.

Fixes: wireshark/wireshark#17021
2020-11-23 08:34:09 +00:00
Jorge Mora 753515f48f RPCoRDMA: fix RPC-over-RDMA message type info
Get value of message type from the buffer before displaying it
in the info column of the packet list pane. Also, make sure
there is enough bytes in the buffer to get the RPCoRDMA header.
2020-11-23 08:07:36 +00:00
Anders Broman 699f1f9041 BER: Fix debug statement 2020-11-23 08:42:50 +01:00
Pascal Quantin f22ed956f6 NAS 5GS: upgrade dissection of remaining 5GMM IEs to v16.6.0
- Ciphering key data
- Control plane service type
- MICO indication
- MA PDU session information
- Mapped NSSAI
- Mobile station classmark 2
- Supported codecs
- Payload container
- Payload container type
- Rejected NSSAI
- Release assistance indication
- Request type
- UE radio capability ID deletion indication
- Truncated 5G-S-TMSI configuration
- WUS assistance information
- NB-N1 mode DRX parameters
- Additional configuration indication
2020-11-22 19:19:14 +00:00
Gerald Combs 7d8dbd98b0 [Automatic update for 2020-11-22]
Update manuf, services enterprise numbers, translations, and other items.
2020-11-22 18:33:39 +00:00
Guy Harris 5fcedcf8f4 Various code and comment cleanups.
Doing a blocking read from a pipe on Windows is done in several places,
using similar sequences of code; put that sequence into a subroutine,
with the parts that differ in arguments to the routine.

Add some comments, and update some comments, to better clarify what the
code is doing in various places.

In the switch statement that tests the first 4 bytes read from a pipe or
socket, call pcap_pipe_open_live() at the end of all of the cases where
the file appears to be a pcap file; that makes the handling of pcap
files look a bit more like the handling of pcapng files.
2020-11-22 17:51:37 +00:00
Pascal Quantin 4212bea8f3 NAS 5GS: add dissection of 2 more r16 IEs
- CAG information list
- CIoT small data container
2020-11-22 13:42:58 +00:00
Martin Mathieson df651aca91 Spelling improvements
Improve script by ignoring common contractions, dealing with
e.g. \n within strings, and finding multiple concatenated words even
when no camelCase is used.

Also includes some actual spelling fixes.
2020-11-22 11:30:24 +00:00
Pascal Quantin 7d16b7b251 NAS 5GS: upgrade dissection of more 5GMM IEs to v16.6.0 2020-11-21 23:29:52 +01:00
Jaap Keuter 68313f4972 Avoid python deprecation warning
Fixes ad69ec2e11
2020-11-21 18:58:21 +00:00
Pascal Quantin 561c5607a8 NAS 5GS: upgrade dissection of a few 5GMM IEs to v16.6.0 2020-11-21 19:02:32 +01:00
Pascal Quantin 1f40b822e6 NAS 5GS: upgrade 5GMM and 5GSM messages description to v16.6.0 2020-11-21 17:18:20 +01:00
Joakim Andersson c586f71a5c bluetooth: Fix dissecting of packets received on LE Coded PHY
Fix dissecting of packets received on LE Coded PHY. These packets
will include the extra field "coding indicator" after the access
address.
The assignment of phy in the common bluetooth context was missing,
leading to this field being left out and the offset being wrong.
2020-11-21 11:08:50 +01:00
Guy Harris 58aea1de62 PacketListRecord: add an ensureColorized() method and use it.
Don't call the columnString() and discard the result in order to force
colorization; instead, add a separate method to force colorization and
use that.

This avoids the need to choose a column; we were using 1 as the column
number, but column numbers are zero-origin, so that's column 2, which
isn't guaranteed to exist (a crash ensued if it didn't).
2020-11-20 14:14:09 -08:00
Pascal Quantin aeebea1330 GSM A DTAP: fix hf_gsm_a_dtap_ue_received_rlc_sdu_counter_value length
The mistake was introduced while removing the proto_tree_add_text() calls
2020-11-20 11:36:34 +01:00
Alex Nik a6f8ea1143 SIP Flows window is discribed
minor correction
2020-11-20 08:20:02 +00:00
Martin Mathieson c1ff6b3675 Fix some more item lengths. 2020-11-19 21:18:21 +00:00
Alexis La Goutte b78abaf1be windows-common: fix Clang
Value stored to 'len' is never read
2020-11-19 19:01:53 +00:00
Jann Horn 785ef0f43d checkAPIs: Fix typo
Fix the typo'd header name in the error message.
2020-11-19 18:16:37 +00:00
Pascal Quantin 8c99f4de8d QUIC: fix compilation without HAVE_LIBGCRYPT_AEAD 2020-11-19 18:36:41 +01:00
John Thacker 91be8b6e60 SMPP: Support GSM 7 bit alphabet (3GPP TS 23.038)
Support the GSM 7 bit alphabet. This should be unpacked, according
to the spec and references online. Similarly, the IA5/ASCII support
should also be unpacked. GSM 7 Packed is supported as an option for
encoding 0, as reports of a small number of servers behaving that way
exist. Provide the byte representation for when encoding is performed
(but hidden), so that filters doesn't change depending on the preference
and encoding, and are backwards compatible with pre 3.2.0. Fixes #17015
2020-11-19 15:59:49 +00:00