forked from osmocom/wireshark
Fix: Execution Tracing High-Detail field selection highlighting seemingly wrong bytes in hex view pane.
Actual problem: A REAL_DATA tvbuff wasn't being added to the "data_sources" for a frame. When displaying the frame, when a field referencing the tvb was selected for display there was no 'hex bytes' tab for the field and so bytes ended up being highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane not related to the field). Consider: Add some code in field creation (proto_tree_add...) to at least warn if a field is being created using a tvb whose data_source is not in the data_sources list for the frame ? svn path=/trunk/; revision=40182
This commit is contained in:
parent
70e2a50ad1
commit
6d3f5ff143
1 changed files with 1 additions and 0 deletions
|
@ -752,6 +752,7 @@ dissect_sigcomp_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *sigcomp_tr
|
||||||
}
|
}
|
||||||
|
|
||||||
udvm_tvb = tvb_new_child_real_data(tvb, buff,state_length+state_address,state_length+state_address);
|
udvm_tvb = tvb_new_child_real_data(tvb, buff,state_length+state_address,state_length+state_address);
|
||||||
|
add_new_data_source(pinfo, udvm_tvb, "State/ExecutionTrace");
|
||||||
/* Arrange that the allocated packet data copy be freed when the
|
/* Arrange that the allocated packet data copy be freed when the
|
||||||
* tvbuff is freed.
|
* tvbuff is freed.
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in a new issue