From 6d3f5ff1433ee07e08d231079c536182949f29e6 Mon Sep 17 00:00:00 2001 From: Bill Meier Date: Tue, 13 Dec 2011 19:54:19 +0000 Subject: [PATCH] Fix: Execution Tracing High-Detail field selection highlighting seemingly wrong bytes in hex view pane. Actual problem: A REAL_DATA tvbuff wasn't being added to the "data_sources" for a frame. When displaying the frame, when a field referencing the tvb was selected for display there was no 'hex bytes' tab for the field and so bytes ended up being highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane not related to the field). Consider: Add some code in field creation (proto_tree_add...) to at least warn if a field is being created using a tvb whose data_source is not in the data_sources list for the frame ? svn path=/trunk/; revision=40182 --- epan/dissectors/packet-sigcomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/epan/dissectors/packet-sigcomp.c b/epan/dissectors/packet-sigcomp.c index 6356be2c5a..4d5b44406f 100644 --- a/epan/dissectors/packet-sigcomp.c +++ b/epan/dissectors/packet-sigcomp.c @@ -752,6 +752,7 @@ dissect_sigcomp_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *sigcomp_tr } udvm_tvb = tvb_new_child_real_data(tvb, buff,state_length+state_address,state_length+state_address); + add_new_data_source(pinfo, udvm_tvb, "State/ExecutionTrace"); /* Arrange that the allocated packet data copy be freed when the * tvbuff is freed. */