osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset 

I cannot find any mention in Q.933 that those two information elements
should not be present in CS0.  In fact, multiple real-world traces
I just recently took from Cisco and Ericsson equipment encodes
those IEs in normal codset 0.

This appears to have been broken since commit
bafebc7b80 in 2005, when the code was
first introduced.

Change-Id: I4c0ad080447d492b541cf7abd1e3f24a0e85084a
Reviewed-on: https://code.wireshark.org/review/38212
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Harald Welte 2020-08-20 21:59:13 +02:00 committed by Anders Broman
parent e7116cca75
commit 4dac9c2c53
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-q933.c
View File

@ -1998,6 +1998,7 @@ dissect_q933(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_
ie_tree);
break;
case CS0 | Q933_IE_LINK_INTEGRITY_VERF:
case CS5 | Q933_IE_LINK_INTEGRITY_VERF:
case CS5 | Q933_IE_ANSI_LINK_INTEGRITY_VERF:
dissect_q933_link_integrity_verf_ie(tvb,
@ -2005,6 +2006,7 @@ dissect_q933(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_
ie_tree);
break;
case CS0 | Q933_IE_PVC_STATUS:
case CS5 | Q933_IE_PVC_STATUS:
case CS5 | Q933_IE_ANSI_PVC_STATUS:
dissect_q933_pvc_status_ie(tvb,