From 4dac9c2c53d4fd1e3ea2c4a5018ad8f2c9d90410 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 20 Aug 2020 21:59:13 +0200 Subject: [PATCH] packet-q933: Decode LINK INTEGRITY + PVC STATUS IEs without codeset I cannot find any mention in Q.933 that those two information elements should not be present in CS0. In fact, multiple real-world traces I just recently took from Cisco and Ericsson equipment encodes those IEs in normal codset 0. This appears to have been broken since commit bafebc7b806e800741f8e982dd20e57ff69b1d28 in 2005, when the code was first introduced. Change-Id: I4c0ad080447d492b541cf7abd1e3f24a0e85084a Reviewed-on: https://code.wireshark.org/review/38212 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-q933.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/epan/dissectors/packet-q933.c b/epan/dissectors/packet-q933.c index 321c35fcd8..ec934714e2 100644 --- a/epan/dissectors/packet-q933.c +++ b/epan/dissectors/packet-q933.c @@ -1998,6 +1998,7 @@ dissect_q933(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_ ie_tree); break; + case CS0 | Q933_IE_LINK_INTEGRITY_VERF: case CS5 | Q933_IE_LINK_INTEGRITY_VERF: case CS5 | Q933_IE_ANSI_LINK_INTEGRITY_VERF: dissect_q933_link_integrity_verf_ie(tvb, @@ -2005,6 +2006,7 @@ dissect_q933(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_ ie_tree); break; + case CS0 | Q933_IE_PVC_STATUS: case CS5 | Q933_IE_PVC_STATUS: case CS5 | Q933_IE_ANSI_PVC_STATUS: dissect_q933_pvc_status_ie(tvb,