osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

androiddump: fix memory leaks reported by Coverity 

Change-Id: I55951d29c85f3e461b4028cfcadbc83745b1ebe7
Reviewed-on: https://code.wireshark.org/review/10506
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Pascal Quantin 2015-09-13 10:37:47 +02:00 committed by Alexis La Goutte
parent 7f191c721a
commit 2d466c0419
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
extcap/androiddump.c
View File

@ -2319,6 +2319,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo,
g_fprintf(stderr,
"ERROR: Error while setting adb transport for <%s>\n",
adb_transport);
closesocket(sock);
return 1;
}
} else {
@ -2332,6 +2333,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo,
g_fprintf(stderr,
"ERROR: Error while setting adb transport for <%s>\n",
helpful_packet);
closesocket(sock);
return 1;
}
}
@ -2343,6 +2345,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo,
g_fprintf(stderr,
"ERROR: Error while starting capture by sending command: %s\n",
adb_shell_tcpdump);
closesocket(sock);
return 1;
}