From 2d466c0419817f32b2428a8cc4bc99c760dfaadc Mon Sep 17 00:00:00 2001 From: Pascal Quantin Date: Sun, 13 Sep 2015 10:37:47 +0200 Subject: [PATCH] androiddump: fix memory leaks reported by Coverity Change-Id: I55951d29c85f3e461b4028cfcadbc83745b1ebe7 Reviewed-on: https://code.wireshark.org/review/10506 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michal Labedzki Reviewed-by: Alexis La Goutte --- extcap/androiddump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/extcap/androiddump.c b/extcap/androiddump.c index 5df1588321..1ae0dfdaaa 100644 --- a/extcap/androiddump.c +++ b/extcap/androiddump.c @@ -2319,6 +2319,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo, g_fprintf(stderr, "ERROR: Error while setting adb transport for <%s>\n", adb_transport); + closesocket(sock); return 1; } } else { @@ -2332,6 +2333,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo, g_fprintf(stderr, "ERROR: Error while setting adb transport for <%s>\n", helpful_packet); + closesocket(sock); return 1; } } @@ -2343,6 +2345,7 @@ static int capture_android_wifi_tcpdump(char *interface, char *fifo, g_fprintf(stderr, "ERROR: Error while starting capture by sending command: %s\n", adb_shell_tcpdump); + closesocket(sock); return 1; }