2006-08-29 22:12:40 +00:00
|
|
|
/*
|
|
|
|
* pata_artop.c - ARTOP ATA controller driver
|
|
|
|
*
|
|
|
|
* (C) 2006 Red Hat <alan@redhat.com>
|
2007-08-09 21:19:34 +00:00
|
|
|
* (C) 2007 Bartlomiej Zolnierkiewicz
|
2006-08-29 22:12:40 +00:00
|
|
|
*
|
|
|
|
* Based in part on drivers/ide/pci/aec62xx.c
|
|
|
|
* Copyright (C) 1999-2002 Andre Hedrick <andre@linux-ide.org>
|
|
|
|
* 865/865R fixes for Macintosh card version from a patch to the old
|
|
|
|
* driver by Thibaut VARENE <varenet@parisc-linux.org>
|
|
|
|
* When setting the PCI latency we must set 0x80 or higher for burst
|
|
|
|
* performance Alessandro Zummo <alessandro.zummo@towertech.it>
|
|
|
|
*
|
|
|
|
* TODO
|
|
|
|
* 850 serialization once the core supports it
|
|
|
|
* Investigate no_dsc on 850R
|
|
|
|
* Clock detect
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <scsi/scsi_host.h>
|
|
|
|
#include <linux/libata.h>
|
|
|
|
#include <linux/ata.h>
|
|
|
|
|
|
|
|
#define DRV_NAME "pata_artop"
|
2007-08-09 21:19:34 +00:00
|
|
|
#define DRV_VERSION "0.4.4"
|
2006-08-29 22:12:40 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The ARTOP has 33 Mhz and "over clocked" timing tables. Until we
|
|
|
|
* get PCI bus speed functionality we leave this as 0. Its a variable
|
|
|
|
* for when we get the functionality and also for folks wanting to
|
|
|
|
* test stuff.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int clock = 0;
|
|
|
|
|
2007-08-06 09:36:23 +00:00
|
|
|
static int artop6210_pre_reset(struct ata_link *link, unsigned long deadline)
|
2006-08-29 22:12:40 +00:00
|
|
|
{
|
2007-08-06 09:36:23 +00:00
|
|
|
struct ata_port *ap = link->ap;
|
2006-08-29 22:12:40 +00:00
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
const struct pci_bits artop_enable_bits[] = {
|
|
|
|
{ 0x4AU, 1U, 0x02UL, 0x02UL }, /* port 0 */
|
|
|
|
{ 0x4AU, 1U, 0x04UL, 0x04UL }, /* port 1 */
|
|
|
|
};
|
|
|
|
|
2006-09-26 16:53:38 +00:00
|
|
|
if (!pci_test_config_bits(pdev, &artop_enable_bits[ap->port_no]))
|
|
|
|
return -ENOENT;
|
libata: add deadline support to prereset and reset methods
Add @deadline to prereset and reset methods and make them honor it.
ata_wait_ready() which directly takes @deadline is implemented to be
used as the wait function. This patch is in preparation for EH timing
improvements.
* ata_wait_ready() never does busy sleep. It's only used from EH and
no wait in EH is that urgent. This function also prints 'be
patient' message automatically after 5 secs of waiting if more than
3 secs is remaining till deadline.
* ata_bus_post_reset() now fails with error code if any of its wait
fails. This is important because earlier reset tries will have
shorter timeout than the spec requires. If a device fails to
respond before the short timeout, reset should be retried with
longer timeout rather than silently ignoring the device.
There are three behavior differences.
1. Timeout is applied to both devices at once, not separately. This
is more consistent with what the spec says.
2. When a device passes devchk but fails to become ready before
deadline. Previouly, post_reset would just succeed and let
device classification remove the device. New code fails the
reset thus causing reset retry. After a few times, EH will give
up disabling the port.
3. When slave device passes devchk but fails to become accessible
(TF-wise) after reset. Original code disables dev1 after 30s
timeout and continues as if the device doesn't exist, while the
patched code fails reset. When this happens, new code fails
reset on whole port rather than proceeding with only the primary
device.
If the failing device is suffering transient problems, new code
retries reset which is a better behavior. If the failing device is
actually broken, the net effect is identical to it, but not to the
other device sharing the channel. In the previous code, reset would
have succeeded after 30s thus detecting the working one. In the new
code, reset fails and whole port gets disabled. IMO, it's a
pathological case anyway (broken device sharing bus with working
one) and doesn't really matter.
* ata_bus_softreset() is changed to return error code from
ata_bus_post_reset(). It used to return 0 unconditionally.
* Spin up waiting is to be removed and not converted to honor
deadline.
* To be on the safe side, deadline is set to 40s for the time being.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-02-02 07:50:52 +00:00
|
|
|
|
2007-08-06 09:36:23 +00:00
|
|
|
return ata_std_prereset(link, deadline);
|
2006-08-29 22:12:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6210_error_handler - Probe specified port on PATA host controller
|
|
|
|
* @ap: Port to probe
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6210_error_handler(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
ata_bmdma_drive_eh(ap, artop6210_pre_reset,
|
|
|
|
ata_std_softreset, NULL,
|
|
|
|
ata_std_postreset);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6260_pre_reset - check for 40/80 pin
|
2007-08-06 09:36:23 +00:00
|
|
|
* @link: link
|
libata: add deadline support to prereset and reset methods
Add @deadline to prereset and reset methods and make them honor it.
ata_wait_ready() which directly takes @deadline is implemented to be
used as the wait function. This patch is in preparation for EH timing
improvements.
* ata_wait_ready() never does busy sleep. It's only used from EH and
no wait in EH is that urgent. This function also prints 'be
patient' message automatically after 5 secs of waiting if more than
3 secs is remaining till deadline.
* ata_bus_post_reset() now fails with error code if any of its wait
fails. This is important because earlier reset tries will have
shorter timeout than the spec requires. If a device fails to
respond before the short timeout, reset should be retried with
longer timeout rather than silently ignoring the device.
There are three behavior differences.
1. Timeout is applied to both devices at once, not separately. This
is more consistent with what the spec says.
2. When a device passes devchk but fails to become ready before
deadline. Previouly, post_reset would just succeed and let
device classification remove the device. New code fails the
reset thus causing reset retry. After a few times, EH will give
up disabling the port.
3. When slave device passes devchk but fails to become accessible
(TF-wise) after reset. Original code disables dev1 after 30s
timeout and continues as if the device doesn't exist, while the
patched code fails reset. When this happens, new code fails
reset on whole port rather than proceeding with only the primary
device.
If the failing device is suffering transient problems, new code
retries reset which is a better behavior. If the failing device is
actually broken, the net effect is identical to it, but not to the
other device sharing the channel. In the previous code, reset would
have succeeded after 30s thus detecting the working one. In the new
code, reset fails and whole port gets disabled. IMO, it's a
pathological case anyway (broken device sharing bus with working
one) and doesn't really matter.
* ata_bus_softreset() is changed to return error code from
ata_bus_post_reset(). It used to return 0 unconditionally.
* Spin up waiting is to be removed and not converted to honor
deadline.
* To be on the safe side, deadline is set to 40s for the time being.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-02-02 07:50:52 +00:00
|
|
|
* @deadline: deadline jiffies for the operation
|
2006-08-29 22:12:40 +00:00
|
|
|
*
|
|
|
|
* The ARTOP hardware reports the cable detect bits in register 0x49.
|
|
|
|
* Nothing complicated needed here.
|
|
|
|
*/
|
|
|
|
|
2007-08-06 09:36:23 +00:00
|
|
|
static int artop6260_pre_reset(struct ata_link *link, unsigned long deadline)
|
2006-08-29 22:12:40 +00:00
|
|
|
{
|
|
|
|
static const struct pci_bits artop_enable_bits[] = {
|
|
|
|
{ 0x4AU, 1U, 0x02UL, 0x02UL }, /* port 0 */
|
|
|
|
{ 0x4AU, 1U, 0x04UL, 0x04UL }, /* port 1 */
|
|
|
|
};
|
|
|
|
|
2007-08-06 09:36:23 +00:00
|
|
|
struct ata_port *ap = link->ap;
|
2006-08-29 22:12:40 +00:00
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
|
|
|
|
/* Odd numbered device ids are the units with enable bits (the -R cards) */
|
2006-09-26 16:53:38 +00:00
|
|
|
if (pdev->device % 1 && !pci_test_config_bits(pdev, &artop_enable_bits[ap->port_no]))
|
|
|
|
return -ENOENT;
|
2007-03-09 14:41:19 +00:00
|
|
|
|
2007-08-06 09:36:23 +00:00
|
|
|
return ata_std_prereset(link, deadline);
|
2007-03-09 13:37:46 +00:00
|
|
|
}
|
2006-09-26 16:53:38 +00:00
|
|
|
|
2007-03-09 13:37:46 +00:00
|
|
|
/**
|
|
|
|
* artop6260_cable_detect - identify cable type
|
|
|
|
* @ap: Port
|
|
|
|
*
|
2007-05-25 19:39:30 +00:00
|
|
|
* Identify the cable type for the ARTOP interface in question
|
2007-03-09 13:37:46 +00:00
|
|
|
*/
|
2007-05-22 00:14:23 +00:00
|
|
|
|
2007-03-09 13:37:46 +00:00
|
|
|
static int artop6260_cable_detect(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
u8 tmp;
|
2006-08-29 22:12:40 +00:00
|
|
|
pci_read_config_byte(pdev, 0x49, &tmp);
|
2006-11-10 19:52:46 +00:00
|
|
|
if (tmp & (1 << ap->port_no))
|
2007-03-09 13:37:46 +00:00
|
|
|
return ATA_CBL_PATA40;
|
|
|
|
return ATA_CBL_PATA80;
|
2006-08-29 22:12:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6260_error_handler - Probe specified port on PATA host controller
|
|
|
|
* @ap: Port to probe
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6260_error_handler(struct ata_port *ap)
|
|
|
|
{
|
|
|
|
ata_bmdma_drive_eh(ap, artop6260_pre_reset,
|
|
|
|
ata_std_softreset, NULL,
|
|
|
|
ata_std_postreset);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6210_load_piomode - Load a set of PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
|
|
|
* @adev: Device
|
|
|
|
* @pio: PIO mode
|
|
|
|
*
|
|
|
|
* Set PIO mode for device, in host controller PCI config space. This
|
|
|
|
* is used both to set PIO timings in PIO mode and also to set the
|
|
|
|
* matching PIO clocking for UDMA, as well as the MWDMA timings.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6210_load_piomode(struct ata_port *ap, struct ata_device *adev, unsigned int pio)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
int dn = adev->devno + 2 * ap->port_no;
|
|
|
|
const u16 timing[2][5] = {
|
|
|
|
{ 0x0000, 0x000A, 0x0008, 0x0303, 0x0301 },
|
|
|
|
{ 0x0700, 0x070A, 0x0708, 0x0403, 0x0401 }
|
|
|
|
|
|
|
|
};
|
|
|
|
/* Load the PIO timing active/recovery bits */
|
|
|
|
pci_write_config_word(pdev, 0x40 + 2 * dn, timing[clock][pio]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6210_set_piomode - Initialize host controller PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
|
|
|
* @adev: Device we are configuring
|
|
|
|
*
|
|
|
|
* Set PIO mode for device, in host controller PCI config space. For
|
|
|
|
* ARTOP we must also clear the UDMA bits if we are not doing UDMA. In
|
|
|
|
* the event UDMA is used the later call to set_dmamode will set the
|
|
|
|
* bits as required.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6210_set_piomode(struct ata_port *ap, struct ata_device *adev)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
int dn = adev->devno + 2 * ap->port_no;
|
|
|
|
u8 ultra;
|
|
|
|
|
|
|
|
artop6210_load_piomode(ap, adev, adev->pio_mode - XFER_PIO_0);
|
|
|
|
|
|
|
|
/* Clear the UDMA mode bits (set_dmamode will redo this if needed) */
|
|
|
|
pci_read_config_byte(pdev, 0x54, &ultra);
|
|
|
|
ultra &= ~(3 << (2 * dn));
|
|
|
|
pci_write_config_byte(pdev, 0x54, ultra);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6260_load_piomode - Initialize host controller PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
|
|
|
* @adev: Device we are configuring
|
|
|
|
* @pio: PIO mode
|
|
|
|
*
|
|
|
|
* Set PIO mode for device, in host controller PCI config space. The
|
|
|
|
* ARTOP6260 and relatives store the timing data differently.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6260_load_piomode (struct ata_port *ap, struct ata_device *adev, unsigned int pio)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
int dn = adev->devno + 2 * ap->port_no;
|
|
|
|
const u8 timing[2][5] = {
|
|
|
|
{ 0x00, 0x0A, 0x08, 0x33, 0x31 },
|
|
|
|
{ 0x70, 0x7A, 0x78, 0x43, 0x41 }
|
|
|
|
|
|
|
|
};
|
|
|
|
/* Load the PIO timing active/recovery bits */
|
|
|
|
pci_write_config_byte(pdev, 0x40 + dn, timing[clock][pio]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6260_set_piomode - Initialize host controller PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
|
|
|
* @adev: Device we are configuring
|
|
|
|
*
|
|
|
|
* Set PIO mode for device, in host controller PCI config space. For
|
|
|
|
* ARTOP we must also clear the UDMA bits if we are not doing UDMA. In
|
|
|
|
* the event UDMA is used the later call to set_dmamode will set the
|
|
|
|
* bits as required.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6260_set_piomode(struct ata_port *ap, struct ata_device *adev)
|
|
|
|
{
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
u8 ultra;
|
|
|
|
|
|
|
|
artop6260_load_piomode(ap, adev, adev->pio_mode - XFER_PIO_0);
|
|
|
|
|
|
|
|
/* Clear the UDMA mode bits (set_dmamode will redo this if needed) */
|
|
|
|
pci_read_config_byte(pdev, 0x44 + ap->port_no, &ultra);
|
|
|
|
ultra &= ~(7 << (4 * adev->devno)); /* One nibble per drive */
|
|
|
|
pci_write_config_byte(pdev, 0x44 + ap->port_no, ultra);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6210_set_dmamode - Initialize host controller PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
2007-03-09 13:37:46 +00:00
|
|
|
* @adev: Device whose timings we are configuring
|
2006-08-29 22:12:40 +00:00
|
|
|
*
|
|
|
|
* Set DMA mode for device, in host controller PCI config space.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6210_set_dmamode (struct ata_port *ap, struct ata_device *adev)
|
|
|
|
{
|
|
|
|
unsigned int pio;
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
int dn = adev->devno + 2 * ap->port_no;
|
|
|
|
u8 ultra;
|
|
|
|
|
|
|
|
if (adev->dma_mode == XFER_MW_DMA_0)
|
|
|
|
pio = 1;
|
|
|
|
else
|
|
|
|
pio = 4;
|
|
|
|
|
|
|
|
/* Load the PIO timing active/recovery bits */
|
|
|
|
artop6210_load_piomode(ap, adev, pio);
|
|
|
|
|
|
|
|
pci_read_config_byte(pdev, 0x54, &ultra);
|
|
|
|
ultra &= ~(3 << (2 * dn));
|
|
|
|
|
|
|
|
/* Add ultra DMA bits if in UDMA mode */
|
|
|
|
if (adev->dma_mode >= XFER_UDMA_0) {
|
|
|
|
u8 mode = (adev->dma_mode - XFER_UDMA_0) + 1 - clock;
|
|
|
|
if (mode == 0)
|
|
|
|
mode = 1;
|
|
|
|
ultra |= (mode << (2 * dn));
|
|
|
|
}
|
|
|
|
pci_write_config_byte(pdev, 0x54, ultra);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop6260_set_dmamode - Initialize host controller PATA PIO timings
|
|
|
|
* @ap: Port whose timings we are configuring
|
|
|
|
* @adev: Device we are configuring
|
|
|
|
*
|
|
|
|
* Set DMA mode for device, in host controller PCI config space. The
|
|
|
|
* ARTOP6260 and relatives store the timing data differently.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* None (inherited from caller).
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void artop6260_set_dmamode (struct ata_port *ap, struct ata_device *adev)
|
|
|
|
{
|
|
|
|
unsigned int pio = adev->pio_mode - XFER_PIO_0;
|
|
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
u8 ultra;
|
|
|
|
|
|
|
|
if (adev->dma_mode == XFER_MW_DMA_0)
|
|
|
|
pio = 1;
|
|
|
|
else
|
|
|
|
pio = 4;
|
|
|
|
|
|
|
|
/* Load the PIO timing active/recovery bits */
|
|
|
|
artop6260_load_piomode(ap, adev, pio);
|
|
|
|
|
|
|
|
/* Add ultra DMA bits if in UDMA mode */
|
|
|
|
pci_read_config_byte(pdev, 0x44 + ap->port_no, &ultra);
|
|
|
|
ultra &= ~(7 << (4 * adev->devno)); /* One nibble per drive */
|
|
|
|
if (adev->dma_mode >= XFER_UDMA_0) {
|
|
|
|
u8 mode = adev->dma_mode - XFER_UDMA_0 + 1 - clock;
|
|
|
|
if (mode == 0)
|
|
|
|
mode = 1;
|
|
|
|
ultra |= (mode << (4 * adev->devno));
|
|
|
|
}
|
|
|
|
pci_write_config_byte(pdev, 0x44 + ap->port_no, ultra);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct scsi_host_template artop_sht = {
|
2008-03-25 03:22:49 +00:00
|
|
|
ATA_BMDMA_SHT(DRV_NAME),
|
2006-08-29 22:12:40 +00:00
|
|
|
};
|
|
|
|
|
libata: implement and use ops inheritance
libata lets low level drivers build ata_port_operations table and
register it with libata core layer. This allows low level drivers
high level of flexibility but also burdens them with lots of
boilerplate entries.
This becomes worse for drivers which support related similar
controllers which differ slightly. They share most of the operations
except for a few. However, the driver still needs to list all
operations for each variant. This results in large number of
duplicate entries, which is not only inefficient but also error-prone
as it becomes very difficult to tell what the actual differences are.
This duplicate boilerplates all over the low level drivers also make
updating the core layer exteremely difficult and error-prone. When
compounded with multi-branched development model, it ends up
accumulating inconsistencies over time. Some of those inconsistencies
cause immediate problems and fixed. Others just remain there dormant
making maintenance increasingly difficult.
To rectify the problem, this patch implements ata_port_operations
inheritance. To allow LLDs to easily re-use their own ops tables
overriding only specific methods, this patch implements poor man's
class inheritance. An ops table has ->inherits field which can be set
to any ops table as long as it doesn't create a loop. When the host
is started, the inheritance chain is followed and any operation which
isn't specified is taken from the nearest ancestor which has it
specified. This operation is called finalization and done only once
per an ops table and the LLD doesn't have to do anything special about
it other than making the ops table non-const such that libata can
update it.
libata provides four base ops tables lower drivers can inherit from -
base, sata, pmp, sff and bmdma. To avoid overriding these ops
accidentaly, these ops are declared const and LLDs should always
inherit these instead of using them directly.
After finalization, all the ops table are identical before and after
the patch except for setting .irq_handler to ata_interrupt in drivers
which didn't use to. The .irq_handler doesn't have any actual effect
and the field will soon be removed by later patch.
* sata_sx4 is still using old style EH and currently doesn't take
advantage of ops inheritance.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 03:22:49 +00:00
|
|
|
static struct ata_port_operations artop6210_ops = {
|
|
|
|
.inherits = &ata_bmdma_port_ops,
|
|
|
|
.cable_detect = ata_cable_40wire,
|
2006-08-29 22:12:40 +00:00
|
|
|
.set_piomode = artop6210_set_piomode,
|
|
|
|
.set_dmamode = artop6210_set_dmamode,
|
|
|
|
.error_handler = artop6210_error_handler,
|
|
|
|
};
|
|
|
|
|
libata: implement and use ops inheritance
libata lets low level drivers build ata_port_operations table and
register it with libata core layer. This allows low level drivers
high level of flexibility but also burdens them with lots of
boilerplate entries.
This becomes worse for drivers which support related similar
controllers which differ slightly. They share most of the operations
except for a few. However, the driver still needs to list all
operations for each variant. This results in large number of
duplicate entries, which is not only inefficient but also error-prone
as it becomes very difficult to tell what the actual differences are.
This duplicate boilerplates all over the low level drivers also make
updating the core layer exteremely difficult and error-prone. When
compounded with multi-branched development model, it ends up
accumulating inconsistencies over time. Some of those inconsistencies
cause immediate problems and fixed. Others just remain there dormant
making maintenance increasingly difficult.
To rectify the problem, this patch implements ata_port_operations
inheritance. To allow LLDs to easily re-use their own ops tables
overriding only specific methods, this patch implements poor man's
class inheritance. An ops table has ->inherits field which can be set
to any ops table as long as it doesn't create a loop. When the host
is started, the inheritance chain is followed and any operation which
isn't specified is taken from the nearest ancestor which has it
specified. This operation is called finalization and done only once
per an ops table and the LLD doesn't have to do anything special about
it other than making the ops table non-const such that libata can
update it.
libata provides four base ops tables lower drivers can inherit from -
base, sata, pmp, sff and bmdma. To avoid overriding these ops
accidentaly, these ops are declared const and LLDs should always
inherit these instead of using them directly.
After finalization, all the ops table are identical before and after
the patch except for setting .irq_handler to ata_interrupt in drivers
which didn't use to. The .irq_handler doesn't have any actual effect
and the field will soon be removed by later patch.
* sata_sx4 is still using old style EH and currently doesn't take
advantage of ops inheritance.
Signed-off-by: Tejun Heo <htejun@gmail.com>
2008-03-25 03:22:49 +00:00
|
|
|
static struct ata_port_operations artop6260_ops = {
|
|
|
|
.inherits = &ata_bmdma_port_ops,
|
|
|
|
.cable_detect = artop6260_cable_detect,
|
2006-08-29 22:12:40 +00:00
|
|
|
.set_piomode = artop6260_set_piomode,
|
|
|
|
.set_dmamode = artop6260_set_dmamode,
|
|
|
|
.error_handler = artop6260_error_handler,
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* artop_init_one - Register ARTOP ATA PCI device with kernel services
|
|
|
|
* @pdev: PCI device to register
|
|
|
|
* @ent: Entry in artop_pci_tbl matching with @pdev
|
|
|
|
*
|
|
|
|
* Called from kernel PCI layer.
|
|
|
|
*
|
|
|
|
* LOCKING:
|
|
|
|
* Inherited from PCI layer (may sleep).
|
|
|
|
*
|
|
|
|
* RETURNS:
|
|
|
|
* Zero on success, or -ERRNO value.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int artop_init_one (struct pci_dev *pdev, const struct pci_device_id *id)
|
|
|
|
{
|
|
|
|
static int printed_version;
|
2007-05-04 10:43:58 +00:00
|
|
|
static const struct ata_port_info info_6210 = {
|
2007-05-28 10:59:48 +00:00
|
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
2006-08-29 22:12:40 +00:00
|
|
|
.pio_mask = 0x1f, /* pio0-4 */
|
|
|
|
.mwdma_mask = 0x07, /* mwdma0-2 */
|
|
|
|
.udma_mask = ATA_UDMA2,
|
|
|
|
.port_ops = &artop6210_ops,
|
|
|
|
};
|
2007-05-04 10:43:58 +00:00
|
|
|
static const struct ata_port_info info_626x = {
|
2007-05-28 10:59:48 +00:00
|
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
2006-08-29 22:12:40 +00:00
|
|
|
.pio_mask = 0x1f, /* pio0-4 */
|
|
|
|
.mwdma_mask = 0x07, /* mwdma0-2 */
|
|
|
|
.udma_mask = ATA_UDMA4,
|
|
|
|
.port_ops = &artop6260_ops,
|
|
|
|
};
|
2007-08-09 21:19:34 +00:00
|
|
|
static const struct ata_port_info info_628x = {
|
2007-05-28 10:59:48 +00:00
|
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
2006-08-29 22:12:40 +00:00
|
|
|
.pio_mask = 0x1f, /* pio0-4 */
|
|
|
|
.mwdma_mask = 0x07, /* mwdma0-2 */
|
|
|
|
.udma_mask = ATA_UDMA5,
|
|
|
|
.port_ops = &artop6260_ops,
|
|
|
|
};
|
2007-08-09 21:19:34 +00:00
|
|
|
static const struct ata_port_info info_628x_fast = {
|
|
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
|
|
|
.pio_mask = 0x1f, /* pio0-4 */
|
|
|
|
.mwdma_mask = 0x07, /* mwdma0-2 */
|
|
|
|
.udma_mask = ATA_UDMA6,
|
|
|
|
.port_ops = &artop6260_ops,
|
|
|
|
};
|
2007-05-04 10:43:58 +00:00
|
|
|
const struct ata_port_info *ppi[] = { NULL, NULL };
|
2008-03-25 03:22:47 +00:00
|
|
|
int rc;
|
2006-08-29 22:12:40 +00:00
|
|
|
|
|
|
|
if (!printed_version++)
|
|
|
|
dev_printk(KERN_DEBUG, &pdev->dev,
|
|
|
|
"version " DRV_VERSION "\n");
|
|
|
|
|
2008-03-25 03:22:47 +00:00
|
|
|
rc = pcim_enable_device(pdev);
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
|
|
|
|
2006-08-29 22:12:40 +00:00
|
|
|
if (id->driver_data == 0) { /* 6210 variant */
|
2007-05-04 10:43:58 +00:00
|
|
|
ppi[0] = &info_6210;
|
|
|
|
ppi[1] = &ata_dummy_port_info;
|
2006-08-29 22:12:40 +00:00
|
|
|
/* BIOS may have left us in UDMA, clear it before libata probe */
|
|
|
|
pci_write_config_byte(pdev, 0x54, 0);
|
|
|
|
/* For the moment (also lacks dsc) */
|
|
|
|
printk(KERN_WARNING "ARTOP 6210 requires serialize functionality not yet supported by libata.\n");
|
|
|
|
printk(KERN_WARNING "Secondary ATA ports will not be activated.\n");
|
|
|
|
}
|
|
|
|
else if (id->driver_data == 1) /* 6260 */
|
2007-05-04 10:43:58 +00:00
|
|
|
ppi[0] = &info_626x;
|
2007-08-09 21:19:34 +00:00
|
|
|
else if (id->driver_data == 2) { /* 6280 or 6280 + fast */
|
2006-08-29 22:12:40 +00:00
|
|
|
unsigned long io = pci_resource_start(pdev, 4);
|
|
|
|
u8 reg;
|
|
|
|
|
2007-08-09 21:19:34 +00:00
|
|
|
ppi[0] = &info_628x;
|
2006-08-29 22:12:40 +00:00
|
|
|
if (inb(io) & 0x10)
|
2007-08-09 21:19:34 +00:00
|
|
|
ppi[0] = &info_628x_fast;
|
2006-08-29 22:12:40 +00:00
|
|
|
/* Mac systems come up with some registers not set as we
|
|
|
|
will need them */
|
|
|
|
|
|
|
|
/* Clear reset & test bits */
|
|
|
|
pci_read_config_byte(pdev, 0x49, ®);
|
|
|
|
pci_write_config_byte(pdev, 0x49, reg & ~ 0x30);
|
|
|
|
|
|
|
|
/* PCI latency must be > 0x80 for burst mode, tweak it
|
|
|
|
* if required.
|
|
|
|
*/
|
|
|
|
pci_read_config_byte(pdev, PCI_LATENCY_TIMER, ®);
|
|
|
|
if (reg <= 0x80)
|
|
|
|
pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x90);
|
|
|
|
|
|
|
|
/* Enable IRQ output and burst mode */
|
|
|
|
pci_read_config_byte(pdev, 0x4a, ®);
|
|
|
|
pci_write_config_byte(pdev, 0x4a, (reg & ~0x01) | 0x80);
|
|
|
|
|
|
|
|
}
|
2006-10-01 14:38:22 +00:00
|
|
|
|
2007-05-04 10:43:58 +00:00
|
|
|
BUG_ON(ppi[0] == NULL);
|
2006-10-01 14:38:22 +00:00
|
|
|
|
2008-03-25 03:22:49 +00:00
|
|
|
return ata_pci_init_one(pdev, ppi, &artop_sht, NULL);
|
2006-08-29 22:12:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pci_device_id artop_pci_tbl[] = {
|
2006-09-29 00:21:59 +00:00
|
|
|
{ PCI_VDEVICE(ARTOP, 0x0005), 0 },
|
|
|
|
{ PCI_VDEVICE(ARTOP, 0x0006), 1 },
|
|
|
|
{ PCI_VDEVICE(ARTOP, 0x0007), 1 },
|
|
|
|
{ PCI_VDEVICE(ARTOP, 0x0008), 2 },
|
|
|
|
{ PCI_VDEVICE(ARTOP, 0x0009), 2 },
|
|
|
|
|
2006-08-29 22:12:40 +00:00
|
|
|
{ } /* terminate list */
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct pci_driver artop_pci_driver = {
|
|
|
|
.name = DRV_NAME,
|
|
|
|
.id_table = artop_pci_tbl,
|
|
|
|
.probe = artop_init_one,
|
|
|
|
.remove = ata_pci_remove_one,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init artop_init(void)
|
|
|
|
{
|
|
|
|
return pci_register_driver(&artop_pci_driver);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit artop_exit(void)
|
|
|
|
{
|
|
|
|
pci_unregister_driver(&artop_pci_driver);
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(artop_init);
|
|
|
|
module_exit(artop_exit);
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Alan Cox");
|
|
|
|
MODULE_DESCRIPTION("SCSI low-level driver for ARTOP PATA");
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
MODULE_DEVICE_TABLE(pci, artop_pci_tbl);
|
|
|
|
MODULE_VERSION(DRV_VERSION);
|
|
|
|
|