Update patch set 4
Patch Set 4: (2 comments) And do we really need to test logging here? It's already being tested in libosmocore, so testing here for me seems useless... Patch-set: 4 Reviewer: Vadim Yanitskiy <1000010@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=0
This commit is contained in:
parent
1c694e88f7
commit
efa2275676
|
@ -16,6 +16,40 @@
|
|||
"revId": "c24f09cdfab4c2119f8c0350da78a34af9792aa6",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa81d914_e3f8a9e7",
|
||||
"filename": "CommonLibs/Makefile.am",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2018-02-21T18:39:06Z",
|
||||
"side": 1,
|
||||
"message": "We already have both VTY and CTRL cflags here,\nso do we really need to duplicate?",
|
||||
"revId": "c24f09cdfab4c2119f8c0350da78a34af9792aa6",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa81d914_03ddbd70",
|
||||
"filename": "tests/CommonLibs/Makefile.am",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2018-02-21T18:39:06Z",
|
||||
"side": 1,
|
||||
"message": "The same question here...",
|
||||
"revId": "c24f09cdfab4c2119f8c0350da78a34af9792aa6",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue