Update patch set 1

Browse Source

Patch Set 1:

> This is odd - if test output is always empty, how can we be sure
 > that the test was executed at all? I think it's better to log at
 > least what kind of test is executing. Even better would be to log
 > smth in case of error instead of using assert: if we hit assert
 > than we don't know what happens with the test code beyond assert
 > point. If we log error and continue, we might see several errors at
 > once and the test would still fail due to output difference.
 > Although it might be matter of personal preference.

AT_CHECK checks the return code of the program, so we catch if it fails or not.
I'll add a small print to the stdout to check against it, though, as it gives more confidence when checking if the test is run.
If the test fails with assert, then you can easily run it with gdb and get a backtrace and see what's going on, so no issue with it. Some tests also print extra information to stderr which is logged into testsuite.log if the test fails.

Patch-set: 1
Reviewer: Pau Espin Pedrol <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0

...

This commit is contained in:

Pau Espin Pedrol 2018-01-10 10:35:37 +00:00 committed by Gerrit Code Review

parent 928fae1ca0

commit a0f9e68bce

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available