cellular-infrastructure
/
osmo-trx
mirror of https://gerrit.osmocom.org/osmo-trx
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000161 \u003c1000161@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000161\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000161\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000161 2024-03-22 10:26:45 +00:00 committed by Gerrit Code Review
parent cae6531c7c
commit 62a8f4b19a
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
3d8598d4605d66a5b8181504b91e563ba69a4bd6
View File

@ -16,6 +16,24 @@
"message": "might be worth adding a reason in a comment here, not just in the commit log. This way a potential future reader of the file knows why it is disabled without having to go to git blame or git log.",
"revId": "3d8598d4605d66a5b8181504b91e563ba69a4bd6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ddb3addf_e18c010c",
"filename": "Transceiver52M/Makefile.am",
"patchSetId": 1
},
"lineNbr": 130,
"author": {
"id": 1000161
},
"writtenOn": "2024-03-22T10:26:45Z",
"side": 1,
"message": "I am not a fan of duplicating VCS information, modern IDEs will show the commit messages anyway, and multiple levels of blame are just one click away...",
"parentUuid": "90c673ee_969bd621",
"revId": "3d8598d4605d66a5b8181504b91e563ba69a4bd6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}