cellular-infrastructure
/
osmo-trx
mirror of https://gerrit.osmocom.org/osmo-trx
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000119 \u003c1000119@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
Attention: {"person_ident":"Gerrit User 1000022 \u003c1000022@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
This commit is contained in:
Gerrit User 1000004 2022-04-04 10:34:19 +00:00 committed by Gerrit Code Review
parent a1e8cf8034
commit 2f682f3be4
1 changed files with 23 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
dccaf6ce8e7ff5a79204cdaecac6b1145d570cde
View File

@ -1,6 +1,24 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bed75384_5fa1e54d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2022-04-04T10:34:19Z",
"side": 1,
"message": "related PR on the read-only github mirror at https://github.com/osmocom/osmo-trx/pull/4 - I pointed the developer to gerrit.",
"revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "2cf3f60d_aac084b8",
"filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -14,10 +32,10 @@
"side": 1,
"message": "Probably cleaner using /* */",
"revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "6f2e19ff_28fb9b58",
"filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -31,10 +49,10 @@
"side": 1,
"message": "Remove extra whitespace at the end.",
"revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "7a4bea7b_42dee340",
"filename": "contrib/systemd/Makefile.am",
@ -48,8 +66,7 @@
"side": 1,
"message": "You miss adding osmo-trx-xtrx.service here.",
"revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}