75 lines
2.2 KiB
Plaintext
75 lines
2.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8c6b2b2b_aef97943",
|
|
"filename": "src/mncc.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1059,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-12-11T06:19:56Z",
|
|
"side": 1,
|
|
"message": "Given that this whole new code chunk is only for `LOGL_DEBUG` logging, I think it can be moved into a separate function and called conditionally `if (log_check_level(DMNCC, LOGL_DEBUG))`?",
|
|
"range": {
|
|
"startLine": 1059,
|
|
"startChar": 4,
|
|
"endLine": 1059,
|
|
"endChar": 39
|
|
},
|
|
"revId": "7d95dfde98c11f8d3bf396d0afc08bbee456caff",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "842e8832_c071c076",
|
|
"filename": "src/mncc.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1059,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-12-11T10:17:48Z",
|
|
"side": 1,
|
|
"message": "the cost of calling log_check_level() and the conditional is probably bigger than going through the switch statement, so I see no benefit.",
|
|
"parentUuid": "8c6b2b2b_aef97943",
|
|
"range": {
|
|
"startLine": 1059,
|
|
"startChar": 4,
|
|
"endLine": 1059,
|
|
"endChar": 39
|
|
},
|
|
"revId": "7d95dfde98c11f8d3bf396d0afc08bbee456caff",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6cdfe9e2_740d1f8d",
|
|
"filename": "src/mncc.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1059,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-12-11T10:20:16Z",
|
|
"side": 1,
|
|
"message": "A static function used by only one function would most likely be inlined anyway...\nIn any case, not a merge blocker. Just an idea.",
|
|
"parentUuid": "842e8832_c071c076",
|
|
"range": {
|
|
"startLine": 1059,
|
|
"startChar": 4,
|
|
"endLine": 1059,
|
|
"endChar": 39
|
|
},
|
|
"revId": "7d95dfde98c11f8d3bf396d0afc08bbee456caff",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |