cellular-infrastructure
/
osmo-sip-connector
mirror of https://gerrit.osmocom.org/osmo-sip-connector
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, fce447de8a96c157c08614ae1c5677a46d1a5600
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000074 2023-12-11 10:17:48 +00:00 committed by Gerrit Code Review
parent c8a1dfbdb7
commit eb16a6e8c3
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
7d95dfde98c11f8d3bf396d0afc08bbee456caff
View File

@ -22,6 +22,30 @@
},
"revId": "7d95dfde98c11f8d3bf396d0afc08bbee456caff",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "842e8832_c071c076",
"filename": "src/mncc.c",
"patchSetId": 2
},
"lineNbr": 1059,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-11T10:17:48Z",
"side": 1,
"message": "the cost of calling log_check_level() and the conditional is probably bigger than going through the switch statement, so I see no benefit.",
"parentUuid": "8c6b2b2b_aef97943",
"range": {
"startLine": 1059,
"startChar": 4,
"endLine": 1059,
"endChar": 39
},
"revId": "7d95dfde98c11f8d3bf396d0afc08bbee456caff",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}