Update patch set 1

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000057 <1000057@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, c8ec453a49d9eb17f3afae9c3b0b2c10bacdd9d8
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000057\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000057 2023-09-14 02:56:18 +00:00 committed by Gerrit Code Review
parent b42ba155c8
commit 503a221ee1
1 changed files with 18 additions and 0 deletions

View File

@ -34,6 +34,24 @@
"parentUuid": "dc896dc9_e8c710af",
"revId": "da2c2207b2964be213f960aa32f7fd314f3ceeb8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "b2c53898_85cd4a81",
"filename": "src/sdp.c",
"patchSetId": 1
},
"lineNbr": 68,
"author": {
"id": 1000057
},
"writtenOn": "2023-09-14T02:56:18Z",
"side": 0,
"message": "I guess I was probably confused between updating passed pointers like it says on the tin and returning a bool to imply failure - and not paying attention to returned types and such things. Or maybe there was some copy/paste involved. \nI was an even worse C programmer back in July 2019 than I am today. \nHmm, compiler does not complain though. 😊",
"parentUuid": "4decfd5c_690fb7e1",
"revId": "da2c2207b2964be213f960aa32f7fd314f3ceeb8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}